[baremetal] reclass: Fix class order for common 87/45387/4
authorAlexandru Avadanii <Alexandru.Avadanii@enea.com>
Tue, 17 Oct 2017 19:39:20 +0000 (21:39 +0200)
committerAlexandru Avadanii <Alexandru.Avadanii@enea.com>
Tue, 17 Oct 2017 23:01:53 +0000 (01:01 +0200)
Inheriting classes in the wrong order led to params being silently
overriden by defaults in the system reclass classes, leaving
some mismatched values between the controller nova config and the
compute conunterpart (e.g. metadata_password had different values).

Always inherit the common class first, so scenario-specific config
is applied on top.

NOTE: {dhcp,single}_nic are not used for mas|kvm|cmp nodes, but they
are referenced in inherited classes, so keep them for now.

Change-Id: I6cb90d5c832ffc8ab731bd9e3cd38ede858dba5c
Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
Signed-off-by: Michael Polenchuk <mpolenchuk@mirantis.com>
44 files changed:
mcp/reclass/classes/cluster/baremetal-mcp-ocata-common/infra/init.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-common/infra/kvm.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-common/infra/maas.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-common/openstack_compute.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-common/openstack_control.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-common/openstack_dashboard.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-common/openstack_database.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-common/openstack_message_queue.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-common/openstack_proxy.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-common/openstack_telemetry.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-odl-ha/infra/config.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-odl-ha/infra/init.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-odl-ha/infra/kvm.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-odl-ha/infra/maas.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-odl-ha/opendaylight/control.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-odl-ha/openstack/benchmark.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-odl-ha/openstack/control.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-odl-ha/openstack/dashboard.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-odl-ha/openstack/database.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-odl-ha/openstack/message_queue.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-odl-ha/openstack/proxy.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-odl-ha/openstack/telemetry.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-ovs-dpdk-ha/infra/config.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-ovs-dpdk-ha/infra/init.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-ovs-dpdk-ha/infra/kvm.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-ovs-dpdk-ha/infra/maas.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-ovs-dpdk-ha/openstack/benchmark.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-ovs-dpdk-ha/openstack/control.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-ovs-dpdk-ha/openstack/dashboard.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-ovs-dpdk-ha/openstack/database.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-ovs-dpdk-ha/openstack/message_queue.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-ovs-dpdk-ha/openstack/proxy.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-ovs-dpdk-ha/openstack/telemetry.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-ovs-ha/infra/config.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-ovs-ha/infra/init.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-ovs-ha/infra/kvm.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-ovs-ha/infra/maas.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-ovs-ha/openstack/benchmark.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-ovs-ha/openstack/control.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-ovs-ha/openstack/dashboard.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-ovs-ha/openstack/database.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-ovs-ha/openstack/message_queue.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-ovs-ha/openstack/proxy.yml
mcp/reclass/classes/cluster/baremetal-mcp-ocata-ovs-ha/openstack/telemetry.yml

index 467a45c..a96e254 100644 (file)
@@ -50,8 +50,6 @@ parameters:
       storage:
         node:
           name: default
-    dhcp_nic: ${_param:opnfv_vcp_vm_primary_interface}
-    single_nic: ${_param:opnfv_vcp_vm_secondary_interface}
     linux_dhcp_interface:
       enabled: true
       type: eth
index ce81f42..3bd705c 100644 (file)
@@ -32,6 +32,9 @@ parameters:
     keepalived_vip_interface: br-ctl
     keepalived_vip_virtual_router_id: 69
     deploy_nic: ${_param:opnfv_baremetal_primary_nic}
+    # {dhcp,single}_nic are not used, but referenced
+    dhcp_nic: ${_param:opnfv_vcp_vm_primary_interface}
+    single_nic: ${_param:opnfv_vcp_vm_secondary_interface}
   salt:
     control:
       size:  # RAM 4096,8192,16384,32768,65536
index fb5d1cf..e8c2965 100644 (file)
@@ -23,6 +23,9 @@ parameters:
     maas_db_password: opnfv_secret
     dns_server01: ${_param:opnfv_dns_server01}
     single_address: ${_param:infra_maas_node01_deploy_address}
+    # {dhcp,single}_nic are not used, but referenced
+    dhcp_nic: ${_param:opnfv_vcp_vm_primary_interface}
+    single_nic: ${_param:opnfv_vcp_vm_secondary_interface}
   maas:
     region:
       salt_master_ip: ${_param:infra_config_deploy_address}
index 1540133..43b0830 100644 (file)
@@ -36,6 +36,9 @@ parameters:
     keepalived_vip_virtual_router_id: 69
     loopback_device_size: 20
     linux_system_codename: xenial
+    # {dhcp,single}_nic are not used, but referenced
+    dhcp_nic: ${_param:opnfv_vcp_vm_primary_interface}
+    single_nic: ${_param:opnfv_vcp_vm_secondary_interface}
   glusterfs:
     client:
       volumes:
index 0684bd8..2aa05f0 100644 (file)
@@ -39,6 +39,8 @@ parameters:
     cluster_node03_hostname: ctl03
     cluster_node03_address: ${_param:openstack_control_node03_address}
     nova_vncproxy_url: https://${_param:cluster_public_host}:6080
+    dhcp_nic: ${_param:opnfv_vcp_vm_primary_interface}
+    single_nic: ${_param:opnfv_vcp_vm_secondary_interface}
   linux:
     network:
       interface:
index f6143e8..e082d26 100644 (file)
@@ -11,6 +11,8 @@ classes:
 parameters:
   _param:
     horizon_site_branding: OpenStack Dashboard
+    dhcp_nic: ${_param:opnfv_vcp_vm_primary_interface}
+    single_nic: ${_param:opnfv_vcp_vm_secondary_interface}
   linux:
     network:
       interface:
index 2a25eab..7ed588d 100644 (file)
@@ -35,6 +35,8 @@ parameters:
     cluster_node02_address: ${_param:openstack_database_node02_address}
     cluster_node03_hostname: dbs03
     cluster_node03_address: ${_param:openstack_database_node03_address}
+    dhcp_nic: ${_param:opnfv_vcp_vm_primary_interface}
+    single_nic: ${_param:opnfv_vcp_vm_secondary_interface}
   linux:
     network:
       interface:
index 04e45e8..88affb8 100644 (file)
@@ -23,6 +23,8 @@ parameters:
     cluster_node02_address: ${_param:openstack_message_queue_node02_address}
     cluster_node03_hostname: msg03
     cluster_node03_address: ${_param:openstack_message_queue_node03_address}
+    dhcp_nic: ${_param:opnfv_vcp_vm_primary_interface}
+    single_nic: ${_param:opnfv_vcp_vm_secondary_interface}
   linux:
     network:
       interface:
index 3439371..da31908 100644 (file)
@@ -30,6 +30,8 @@ parameters:
       mode: secure
     cluster_vip_address: ${_param:openstack_proxy_address}
     salt_minion_ca_host: cfg01.${_param:cluster_domain}
+    dhcp_nic: ${_param:opnfv_vcp_vm_primary_interface}
+    single_nic: ${_param:opnfv_vcp_vm_secondary_interface}
   linux:
     network:
       interface:
index cffe04c..c52b5ed 100644 (file)
@@ -28,6 +28,8 @@ parameters:
     cluster_node02_address: ${_param:openstack_telemetry_node02_address}
     cluster_node03_hostname: mdb03
     cluster_node03_address: ${_param:openstack_telemetry_node03_address}
+    dhcp_nic: ${_param:opnfv_vcp_vm_primary_interface}
+    single_nic: ${_param:opnfv_vcp_vm_secondary_interface}
   linux:
     network:
       interface:
index 991e3f9..0d2c5a3 100644 (file)
@@ -8,8 +8,8 @@
 ---
 classes:
   - system.reclass.storage.system.opendaylight_control_single
-  - cluster.baremetal-mcp-ocata-odl-ha.infra
   - cluster.baremetal-mcp-ocata-common.infra.config
+  - cluster.baremetal-mcp-ocata-odl-ha.infra
 parameters:
   reclass:
     storage:
index 2017aa4..efcf1a4 100644 (file)
@@ -7,8 +7,8 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-odl-ha.openstack
   - cluster.baremetal-mcp-ocata-common.infra
+  - cluster.baremetal-mcp-ocata-odl-ha.openstack
 parameters:
   _param:
     cluster_name: baremetal-mcp-ocata-odl-ha
index 344b190..d7bbadd 100644 (file)
@@ -7,8 +7,8 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-odl-ha.infra
   - cluster.baremetal-mcp-ocata-common.infra.kvm
+  - cluster.baremetal-mcp-ocata-odl-ha.infra
 parameters:
   salt:
     control:
index 17e1e02..5b842bb 100644 (file)
@@ -7,5 +7,5 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-odl-ha.infra
   - cluster.baremetal-mcp-ocata-common.infra.maas
+  - cluster.baremetal-mcp-ocata-odl-ha.infra
index 225c785..edb1a33 100644 (file)
@@ -14,6 +14,8 @@ classes:
 parameters:
   _param:
     linux_system_codename: xenial
+    dhcp_nic: ${_param:opnfv_vcp_vm_primary_interface}
+    single_nic: ${_param:opnfv_vcp_vm_secondary_interface}
   linux:
     network:
       interface:
index d9b1541..5ae972d 100644 (file)
@@ -7,5 +7,5 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-odl-ha
   - cluster.baremetal-mcp-ocata-common.openstack_benchmark
+  - cluster.baremetal-mcp-ocata-odl-ha
index 5bc423e..210da2a 100644 (file)
@@ -8,8 +8,8 @@
 ---
 classes:
   - system.neutron.control.opendaylight.cluster
-  - cluster.baremetal-mcp-ocata-odl-ha.infra
   - cluster.baremetal-mcp-ocata-common.openstack_control
+  - cluster.baremetal-mcp-ocata-odl-ha.infra
 parameters:
   neutron:
     server:
index 1d2cf4f..c60d7c4 100644 (file)
@@ -7,5 +7,5 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-odl-ha
   - cluster.baremetal-mcp-ocata-common.openstack_dashboard
+  - cluster.baremetal-mcp-ocata-odl-ha
index d85bbef..fc38aad 100644 (file)
@@ -7,5 +7,5 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-odl-ha
   - cluster.baremetal-mcp-ocata-common.openstack_database
+  - cluster.baremetal-mcp-ocata-odl-ha
index 76c3def..5757db3 100644 (file)
@@ -7,5 +7,5 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-odl-ha
   - cluster.baremetal-mcp-ocata-common.openstack_message_queue
+  - cluster.baremetal-mcp-ocata-odl-ha
index 08d0fe1..7cb1c10 100644 (file)
@@ -7,9 +7,9 @@
 ##############################################################################
 ---
 classes:
+  - cluster.baremetal-mcp-ocata-common.openstack_proxy
   - cluster.baremetal-mcp-ocata-odl-ha.infra
   - cluster.baremetal-mcp-ocata-odl-ha.openstack.dashboard
-  - cluster.baremetal-mcp-ocata-common.openstack_proxy
 parameters:
   nginx:
     server:
index 58552ef..fd4f7e8 100644 (file)
@@ -7,5 +7,5 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-odl-ha.infra
   - cluster.baremetal-mcp-ocata-common.openstack_telemetry
+  - cluster.baremetal-mcp-ocata-odl-ha.infra
index ce5d9ca..7bd8c37 100644 (file)
@@ -7,8 +7,8 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-ovs-dpdk-ha.infra
   - cluster.baremetal-mcp-ocata-common.infra.config
+  - cluster.baremetal-mcp-ocata-ovs-dpdk-ha.infra
 parameters:
   reclass:
     storage:
index c034ced..60278a5 100644 (file)
@@ -7,8 +7,8 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-ovs-dpdk-ha.openstack
   - cluster.baremetal-mcp-ocata-common.infra
+  - cluster.baremetal-mcp-ocata-ovs-dpdk-ha.openstack
 parameters:
   _param:
     cluster_name: baremetal-mcp-ocata-ovs-dpdk-ha
index 4889812..f7a8fe3 100644 (file)
@@ -7,5 +7,5 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-ovs-dpdk-ha.infra
   - cluster.baremetal-mcp-ocata-common.infra.kvm
+  - cluster.baremetal-mcp-ocata-ovs-dpdk-ha.infra
index 9d7dab6..3ec33c3 100644 (file)
@@ -7,5 +7,5 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-ovs-dpdk-ha.infra
   - cluster.baremetal-mcp-ocata-common.infra.maas
+  - cluster.baremetal-mcp-ocata-ovs-dpdk-ha.infra
index b193457..1c02ae4 100644 (file)
@@ -7,5 +7,5 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-ovs-dpdk-ha
   - cluster.baremetal-mcp-ocata-common.openstack_benchmark
+  - cluster.baremetal-mcp-ocata-ovs-dpdk-ha
index 01e723f..dddae33 100644 (file)
@@ -8,8 +8,8 @@
 ---
 classes:
   - system.neutron.control.openvswitch.cluster
-  - cluster.baremetal-mcp-ocata-ovs-dpdk-ha.infra
   - cluster.baremetal-mcp-ocata-common.openstack_control
+  - cluster.baremetal-mcp-ocata-ovs-dpdk-ha.infra
 parameters:
   neutron:
     server:
index 62c30b2..278bf14 100644 (file)
@@ -7,5 +7,5 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-ovs-dpdk-ha
   - cluster.baremetal-mcp-ocata-common.openstack_dashboard
+  - cluster.baremetal-mcp-ocata-ovs-dpdk-ha
index 861129a..e76b20a 100644 (file)
@@ -7,5 +7,5 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-ovs-dpdk-ha
   - cluster.baremetal-mcp-ocata-common.openstack_database
+  - cluster.baremetal-mcp-ocata-ovs-dpdk-ha
index 0895094..a01eda9 100644 (file)
@@ -7,5 +7,5 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-ovs-dpdk-ha
   - cluster.baremetal-mcp-ocata-common.openstack_message_queue
+  - cluster.baremetal-mcp-ocata-ovs-dpdk-ha
index 07f7971..07da7eb 100644 (file)
@@ -7,6 +7,6 @@
 ##############################################################################
 ---
 classes:
+  - cluster.baremetal-mcp-ocata-common.openstack_proxy
   - cluster.baremetal-mcp-ocata-ovs-dpdk-ha.infra
   - cluster.baremetal-mcp-ocata-ovs-dpdk-ha.openstack.dashboard
-  - cluster.baremetal-mcp-ocata-common.openstack_proxy
index 17a324f..d38cc0d 100644 (file)
@@ -7,5 +7,5 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-ovs-dpdk-ha.infra
   - cluster.baremetal-mcp-ocata-common.openstack_telemetry
+  - cluster.baremetal-mcp-ocata-ovs-dpdk-ha.infra
index 5f5601f..c325246 100644 (file)
@@ -7,5 +7,5 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-ovs-ha.infra
   - cluster.baremetal-mcp-ocata-common.infra.config
+  - cluster.baremetal-mcp-ocata-ovs-ha.infra
index cdfde5b..a15355b 100644 (file)
@@ -7,8 +7,8 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-ovs-ha.openstack
   - cluster.baremetal-mcp-ocata-common.infra
+  - cluster.baremetal-mcp-ocata-ovs-ha.openstack
 parameters:
   _param:
     cluster_name: baremetal-mcp-ocata-ovs-ha
index ebe1317..51bf6ae 100644 (file)
@@ -7,5 +7,5 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-ovs-ha.infra
   - cluster.baremetal-mcp-ocata-common.infra.kvm
+  - cluster.baremetal-mcp-ocata-ovs-ha.infra
index ec078ed..9121299 100644 (file)
@@ -7,5 +7,5 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-ovs-ha.infra
   - cluster.baremetal-mcp-ocata-common.infra.maas
+  - cluster.baremetal-mcp-ocata-ovs-ha.infra
index b8bf1c7..783561a 100644 (file)
@@ -7,5 +7,5 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-ovs-ha
   - cluster.baremetal-mcp-ocata-common.openstack_benchmark
+  - cluster.baremetal-mcp-ocata-ovs-ha
index 549cb52..790c6d9 100644 (file)
@@ -8,5 +8,5 @@
 ---
 classes:
   - system.neutron.control.openvswitch.cluster
-  - cluster.baremetal-mcp-ocata-ovs-ha.infra
   - cluster.baremetal-mcp-ocata-common.openstack_control
+  - cluster.baremetal-mcp-ocata-ovs-ha.infra
index 24218f0..8dec9ed 100644 (file)
@@ -7,5 +7,5 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-ovs-ha
   - cluster.baremetal-mcp-ocata-common.openstack_dashboard
+  - cluster.baremetal-mcp-ocata-ovs-ha
index 545980a..fae7c5b 100644 (file)
@@ -7,5 +7,5 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-ovs-ha
   - cluster.baremetal-mcp-ocata-common.openstack_database
+  - cluster.baremetal-mcp-ocata-ovs-ha
index 762e2ed..986422b 100644 (file)
@@ -7,5 +7,5 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-ovs-ha
   - cluster.baremetal-mcp-ocata-common.openstack_message_queue
+  - cluster.baremetal-mcp-ocata-ovs-ha
index aaefc61..f2a9d89 100644 (file)
@@ -7,6 +7,6 @@
 ##############################################################################
 ---
 classes:
+  - cluster.baremetal-mcp-ocata-common.openstack_proxy
   - cluster.baremetal-mcp-ocata-ovs-ha.infra
   - cluster.baremetal-mcp-ocata-ovs-ha.openstack.dashboard
-  - cluster.baremetal-mcp-ocata-common.openstack_proxy
index 744d40f..6b2349e 100644 (file)
@@ -7,5 +7,5 @@
 ##############################################################################
 ---
 classes:
-  - cluster.baremetal-mcp-ocata-ovs-ha.infra
   - cluster.baremetal-mcp-ocata-common.openstack_telemetry
+  - cluster.baremetal-mcp-ocata-ovs-ha.infra