Stop verifying ResultWriter.write_results exit codes

ResultWriter.write_results() returns false if one test fails.
It's skipped by run() because the report is correctly generated.

[1] https://robot-framework.readthedocs.io/en/2.9.2/_modules/robot/reporting/resultwriter.html

Change-Id: If29059b272679ed89a1189e0bb52997c83401b94
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>

diff --git a/xtesting/core/robotframework.py b/xtesting/core/robotframework.py
index 9865a26..2791b55 100644 (file)
--- a/xtesting/core/robotframework.py
+++ b/xtesting/core/robotframework.py
@@ -127,7 +127,7 @@ class RobotFramework(testcase.TestCase):
         try:
             self.parse_results()
             self.__logger.info("Results were successfully parsed")
-            assert self.generate_report() == 0
+            self.generate_report()
             self.__logger.info("Results were successfully generated")
         except RobotError as ex:
             self.__logger.error("Run suites before publishing: %s", ex.message)

diff --git a/xtesting/tests/unit/core/test_robotframework.py b/xtesting/tests/unit/core/test_robotframework.py
index 4cda171..398cf87 100644 (file)
--- a/xtesting/tests/unit/core/test_robotframework.py
+++ b/xtesting/tests/unit/core/test_robotframework.py
@@ -283,7 +283,7 @@ class RunTesting(unittest.TestCase):
     def test_generate_report_err(self):
         with mock.patch.object(self.test, 'generate_report',
                                return_value=1) as mmethod:
-            self._test_generate_report(self.test.EX_RUN_ERROR)
+            self._test_generate_report(self.test.EX_OK)
             mmethod.assert_called_once_with()
 
     def test_generate_report(self):