Fix dict conversion in tempest.conf 05/62005/1
authorCédric Ollivier <cedric.ollivier@orange.com>
Sat, 8 Sep 2018 07:36:28 +0000 (09:36 +0200)
committerCédric Ollivier <cedric.ollivier@orange.com>
Sat, 8 Sep 2018 07:38:27 +0000 (09:38 +0200)
https://github.com/openstack/oslo.config/blob/master/oslo_config/types.py#L600
https://build.opnfv.org/ci/view/fuel/job/functest-fuel-virtual-daily-master/817/consoleFull

Change-Id: Icde9938bb9f6c0c37d2504317f31b0af4ef9ee8e
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
functest/opnfv_tests/openstack/tempest/conf_utils.py
functest/tests/unit/openstack/tempest/test_conf_utils.py

index 80f78e9..e0b2a8e 100644 (file)
@@ -270,7 +270,7 @@ def configure_verifier(deployment_dir):
 def convert_dict_to_ini(value):
     "Convert dict to oslo.conf input"
     assert isinstance(value, dict)
-    return ",".join("{}={}".format(
+    return ",".join("{}:{}".format(
         key, val) for (key, val) in six.iteritems(value))
 
 
index 7c49337..3f4af3d 100644 (file)
@@ -186,9 +186,9 @@ class OSTempestConfUtilsTesting(unittest.TestCase):
         self.assertEqual(
             conf_utils.convert_dict_to_ini({}), "")
         self.assertEqual(
-            conf_utils.convert_dict_to_ini({"a": "b"}), "a=b")
+            conf_utils.convert_dict_to_ini({"a": "b"}), "a:b")
         value = conf_utils.convert_dict_to_ini({"a": "b", "c": "d"})
-        self.assertTrue(value == "a=b,c=d" or value == "c=d,a=b")
+        self.assertTrue(value == "a:b,c:d" or value == "c:d,a:b")
         with self.assertRaises(AssertionError):
             conf_utils.convert_list_to_ini("")