Merge "Ensure that only ASCII characters make it into the jobs JIRA:OCTO-105"

diff --git a/jjb/releng-jobs.yaml b/jjb/releng-jobs.yaml
index 19c6bab..3d52678 100644 (file)
--- a/jjb/releng-jobs.yaml
+++ b/jjb/releng-jobs.yaml
@@ -60,9 +60,8 @@
 
 
     builders:
-        - shell: |
-            source /opt/virtualenv/jenkins-job-builder/bin/activate
-            jenkins-jobs test jjb/
+        - shell:
+            !include-raw verify-releng
 
 - job-template:
     name: 'builder-merge'

diff --git a/jjb/verify-releng b/jjb/verify-releng
new file mode 100755 (executable)
index 0000000..6e980e7
--- /dev/null
+++ b/jjb/verify-releng
@@ -0,0 +1,17 @@
+#!/bin/bash
+
+source /opt/virtualenv/jenkins-job-builder/bin/activate
+jenkins-jobs test jjb/
+
+
+#test for non-ascii characters, these can pass the test and end up breaking things in production
+for x in $(find . -name *\.yml); do
+
+  if LC_ALL=C grep -q '[^[:print:][:space:]]' "$x"; then
+    echo "file "$x" contains non-ascii characters"
+    exit 1
+  fi
+
+done
+
+echo "all .yml files are ASCII only"