ci: Support for negative pylint rating 03/59203/1
authorMartin Klozik <martin.klozik@tieto.com>
Thu, 28 Jun 2018 13:30:47 +0000 (15:30 +0200)
committerMartin Klozik <martin.klozik@tieto.com>
Thu, 28 Jun 2018 13:55:33 +0000 (15:55 +0200)
Script ./check was updated to correctly parse and process negative pylint
ratings. Also awk expression was fixed to get rid of error messages
during parsing of pylint output.

JIRA: VSPERF-587

Change-Id: I72c5bd85f38274f308fce881517e5b6fa4a123dc
Signed-off-by: Martin Klozik <martin.klozik@tieto.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Reviewed-by: Richard Elias <richard.elias@tieto.com>
check

diff --git a/check b/check
index 3c8c292..b1c79ac 100755 (executable)
--- a/check
+++ b/check
@@ -159,7 +159,7 @@ if [ -s $FILE_LIST ] ; then
         fi
         # run pylint and extract final rating
         output=`$PYLINT --rcfile $PYLINT_RC $pyfile 2>/dev/null`
-        rating=`echo -e $output | tail -n3 | grep rated | sed -e 's/^.*rated at \([0-9.]*\).*$/\1/'`
+        rating=`echo -e $output | tail -n3 | grep rated | sed -e 's/^.*rated at \(-\?[0-9.]*\).*$/\1/'`
         # evaluate and display aquired rating
         if [ "x$rating" == "x" ] ; then
             # rating is not available for files without python statements
@@ -167,7 +167,7 @@ if [ -s $FILE_LIST ] ; then
         elif rating_is_ok $rating ; then
             printf "    %-70s ${GREEN}%-6s${BLACK}\n" $pyfile "OK"
         else
-            echo -e "$output" | awk '/^*+ Module|^[A-Z]\:/'
+            echo -e "$output" | awk '/^\*+ Module|^[A-Z]\:/'
             printf "    %-70s ${RED}%-6s${BLACK}\n" $pyfile $rating
         fi
     done