model: pylint fixes 21/30621/2
authorRoss Brattain <ross.b.brattain@intel.com>
Thu, 16 Mar 2017 02:47:24 +0000 (19:47 -0700)
committerRoss Brattain <ross.b.brattain@intel.com>
Thu, 23 Mar 2017 21:54:12 +0000 (14:54 -0700)
remove redundnant parens
replace type with isinstance
fix import order

Change-Id: I0407cbbf6993290f392f17c398827603b5bc1ebd
Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
tests/unit/benchmark/contexts/test_model.py
yardstick/benchmark/contexts/model.py

index a4b7d81..6ae4e6d 100644 (file)
@@ -12,8 +12,8 @@
 # Unittest for yardstick.benchmark.contexts.model
 
 from __future__ import absolute_import
-import mock
 import unittest
+import mock
 
 from yardstick.benchmark.contexts import model
 
index 8cf3b62..4873afd 100644 (file)
@@ -154,7 +154,7 @@ class Server(Object):     # pragma: no cover
 
         self.placement_groups = []
         placement = attrs.get("placement", [])
-        placement = placement if type(placement) is list else [placement]
+        placement = placement if isinstance(placement, list) else [placement]
         for p in placement:
             pg = PlacementGroup.get(p)
             if not pg:
@@ -166,7 +166,7 @@ class Server(Object):     # pragma: no cover
         # support servergroup attr
         self.server_group = None
         sg = attrs.get("server_group")
-        if (sg):
+        if sg:
             server_group = ServerGroup.get(sg)
             if not server_group:
                 raise ValueError("server '%s', server_group '%s' is invalid" %