xci: scripts: start-new-vm.sh: Make DEFAULT_XCI_TEST stricter

The DEFAULT_XCI_TEST value wasn't checked and it could actually contain
anything leading to all sort of failures so we need to check it against
well known values.

Change-Id: Ib12c944adebfbcb3097b42af98d2bacefbd8374c
Signed-off-by: Markos Chandras <mchandras@suse.de>

diff --git a/xci/scripts/vm/start-new-vm.sh b/xci/scripts/vm/start-new-vm.sh
index bb2b335..6e5c819 100755 (executable)
--- a/xci/scripts/vm/start-new-vm.sh
+++ b/xci/scripts/vm/start-new-vm.sh
@@ -357,7 +357,7 @@ echo "Verifying test script exists..."
 $vm_ssh ${VM_NAME} "bash -c 'stat ~/releng-xci/run_jenkins_test.sh'"
 if [[ $? != 0 ]]; then
        echo "Failed to find a 'run_jenkins_test.sh' script..."
-       if ${DEFAULT_XCI_TEST}; then
+       if [[ ${DEFAULT_XCI_TEST} == true ]]; then
                echo "Creating a default test case to run xci-deploy.sh"
                cat > ${BASE_PATH}/run_jenkins_test.sh <<EOF
 #!/bin/bash