Upgrades: fix up the rabbitmq HA mode like in new ocata deployments

In ocata we changed the rabbitmq ha policy to "ha-exactly" via the
following changes:
- tht: Iace6daf27a76cb8ef1050ada0de7ff1f530916c6
- puppet-tripleo: Ib62001c03e1e08f58cf0c6e0ba07a8879a584084

We took care of the upgrade path via I3a97505d2ae1ae27f3080ffe74c33fdabffd2420

With the move to the ansible-based composable upgrades we left this change out.
And now an upgraded environment has the following policy:
- Upgraded environment
Attributes: set_policy="ha-all ^(?!amq\.).* {"ha-mode":"all"}"

- New environment
Attributes: set_policy="ha-all ^(?!amq\.).* {"ha-mode":"exactly","ha-params":2}"

We need to add this pcs resource change to the our upgrade scripts.

Change-Id: I3c4113c207e9d0c45be43df7c2379ac26cb60692
Closes-Bug: #1668600
(cherry picked from commit 41514d0cd603194fecb327f96995c60a9fe6e67a)

diff --git a/puppet/services/pacemaker/rabbitmq.yaml b/puppet/services/pacemaker/rabbitmq.yaml
index 03c2c83..b018df3 100644 (file)
--- a/puppet/services/pacemaker/rabbitmq.yaml
+++ b/puppet/services/pacemaker/rabbitmq.yaml
@@ -39,3 +39,32 @@ outputs:
           - rabbitmq::service_manage: false
       step_config: |
         include ::tripleo::profile::pacemaker::rabbitmq
+      upgrade_tasks:
+        - name: get bootstrap nodeid
+          tags: common
+          command: hiera bootstrap_nodeid
+          register: bootstrap_node
+        - name: set is_bootstrap_node fact
+          tags: common
+          set_fact: is_bootstrap_node={{bootstrap_node.stdout == ansible_hostname}}
+        - name: get rabbitmq policy
+          tags: common
+          shell: pcs resource show rabbitmq | grep -q -E "Attributes:.*\"ha-mode\":\"all\""
+          register: rabbit_ha_mode
+          when: is_bootstrap_node
+          ignore_errors: true
+        - name: set migrate_rabbit_ha_mode fact
+          tags: common
+          set_fact: migrate_rabbit_ha_mode={{rabbit_ha_mode.rc == 0}}
+          when: is_bootstrap_node
+        - name: Fixup for rabbitmq ha-queues LP#1668600
+          tags: step0,pre-upgrade
+          shell: |
+            nr_controllers=$(($(hiera controller_node_names | grep -o "," |wc -l) + 1))
+            nr_queues=$(($nr_controllers / 2 + ($nr_controllers % 2)))
+            if ! [ $nr_queues -gt 0 -a $nr_queues -le $nr_controllers ]; then
+                echo "ERROR: The nr. of HA queues during the rabbit upgrade is out of range: $nr_queues"
+                exit 1
+            fi
+            pcs resource update rabbitmq set_policy='ha-all ^(?!amq\\.).* {"ha-mode":"exactly","ha-params":'"$nr_queues}" --wait=600
+          when: is_bootstrap_node and migrate_rabbit_ha_mode