Merge "Apex: enable ha for os-odl_l3-fdio"
authorTim Rozet <trozet@redhat.com>
Tue, 2 May 2017 19:31:34 +0000 (19:31 +0000)
committerGerrit Code Review <gerrit@opnfv.org>
Tue, 2 May 2017 19:31:34 +0000 (19:31 +0000)
18 files changed:
jjb/armband/armband-ci-jobs.yml
jjb/armband/armband-deploy.sh
jjb/daisy4nfv/daisy4nfv-build.sh
jjb/functest/functest-daily-jobs.yml
jjb/global/slave-params.yml
jjb/releng/opnfv-docker-arm.yml
jjb/securedlab/check-jinja2.sh [new file with mode: 0755]
jjb/securedlab/check-jinja2.yml [new file with mode: 0644]
utils/test/testapi/opnfv_testapi/tests/unit/executor.py [new file with mode: 0644]
utils/test/testapi/opnfv_testapi/tests/unit/test_base.py
utils/test/testapi/opnfv_testapi/tests/unit/test_fake_pymongo.py
utils/test/testapi/opnfv_testapi/tests/unit/test_pod.py
utils/test/testapi/opnfv_testapi/tests/unit/test_project.py
utils/test/testapi/opnfv_testapi/tests/unit/test_result.py
utils/test/testapi/opnfv_testapi/tests/unit/test_scenario.py
utils/test/testapi/opnfv_testapi/tests/unit/test_testcase.py
utils/test/testapi/opnfv_testapi/tests/unit/test_token.py
utils/test/testapi/opnfv_testapi/tests/unit/test_version.py

index ff855c1..17d5204 100644 (file)
@@ -56,8 +56,8 @@
             slave-label: arm-pod3
             installer: fuel
             <<: *danube
-        - arm-pod3-2:
-            slave-label: arm-pod3-2
+        - arm-pod4:
+            slave-label: arm-pod4
             installer: fuel
             <<: *danube
         - arm-virtual1:
@@ -75,8 +75,8 @@
             slave-label: arm-pod3
             installer: fuel
             <<: *master
-        - arm-pod3-2:
-            slave-label: arm-pod3-2
+        - arm-pod4:
+            slave-label: arm-pod4
             installer: fuel
             <<: *master
         - arm-virtual1:
 # Enea Armband POD 3 Triggers running against master branch (aarch64 slave)
 #--------------------------------------------------------------------------
 - trigger:
-    name: 'fuel-os-odl_l2-nofeature-ha-arm-pod3-2-master-trigger'
+    name: 'fuel-os-odl_l2-nofeature-ha-arm-pod4-master-trigger'
     triggers:
         - timed: ''
 - trigger:
-    name: 'fuel-os-nosdn-nofeature-ha-arm-pod3-2-master-trigger'
+    name: 'fuel-os-nosdn-nofeature-ha-arm-pod4-master-trigger'
     triggers:
         - timed: ''
 - trigger:
-    name: 'fuel-os-odl_l3-nofeature-ha-arm-pod3-2-master-trigger'
+    name: 'fuel-os-odl_l3-nofeature-ha-arm-pod4-master-trigger'
     triggers:
         - timed: ''
 - trigger:
-    name: 'fuel-os-odl_l2-bgpvpn-ha-arm-pod3-2-master-trigger'
+    name: 'fuel-os-odl_l2-bgpvpn-ha-arm-pod4-master-trigger'
     triggers:
         - timed: ''
 - trigger:
-    name: 'fuel-os-odl_l2-nofeature-noha-arm-pod3-2-master-trigger'
+    name: 'fuel-os-odl_l2-nofeature-noha-arm-pod4-master-trigger'
     triggers:
         - timed: ''
 - trigger:
-    name: 'fuel-os-odl_l2-sfc-ha-arm-pod3-2-master-trigger'
+    name: 'fuel-os-odl_l2-sfc-ha-arm-pod4-master-trigger'
     triggers:
         - timed: ''
 - trigger:
-    name: 'fuel-os-odl_l2-sfc-noha-arm-pod3-2-master-trigger'
+    name: 'fuel-os-odl_l2-sfc-noha-arm-pod4-master-trigger'
     triggers:
         - timed: ''
 #--------------------------------------------------------------------------
 # Enea Armband POD 3 Triggers running against danube branch (aarch64 slave)
 #--------------------------------------------------------------------------
 - trigger:
-    name: 'fuel-os-odl_l2-nofeature-ha-arm-pod3-2-danube-trigger'
+    name: 'fuel-os-odl_l2-nofeature-ha-arm-pod4-danube-trigger'
     triggers:
         - timed: ''
 - trigger:
-    name: 'fuel-os-nosdn-nofeature-ha-arm-pod3-2-danube-trigger'
+    name: 'fuel-os-nosdn-nofeature-ha-arm-pod4-danube-trigger'
     triggers:
         - timed: ''
 - trigger:
-    name: 'fuel-os-odl_l3-nofeature-ha-arm-pod3-2-danube-trigger'
+    name: 'fuel-os-odl_l3-nofeature-ha-arm-pod4-danube-trigger'
     triggers:
         - timed: ''
 - trigger:
-    name: 'fuel-os-odl_l2-bgpvpn-ha-arm-pod3-2-danube-trigger'
+    name: 'fuel-os-odl_l2-bgpvpn-ha-arm-pod4-danube-trigger'
     triggers:
         - timed: ''
 - trigger:
-    name: 'fuel-os-odl_l2-nofeature-noha-arm-pod3-2-danube-trigger'
+    name: 'fuel-os-odl_l2-nofeature-noha-arm-pod4-danube-trigger'
     triggers:
         - timed: ''
 - trigger:
-    name: 'fuel-os-odl_l2-sfc-ha-arm-pod3-2-danube-trigger'
+    name: 'fuel-os-odl_l2-sfc-ha-arm-pod4-danube-trigger'
     triggers:
         - timed: ''
 - trigger:
-    name: 'fuel-os-odl_l2-sfc-noha-arm-pod3-2-danube-trigger'
+    name: 'fuel-os-odl_l2-sfc-noha-arm-pod4-danube-trigger'
     triggers:
         - timed: ''
index 2e5aa39..e445e08 100755 (executable)
@@ -33,10 +33,10 @@ fi
 # set deployment parameters
 export TMPDIR=${WORKSPACE}/tmpdir
 
-# arm-pod3-2 is an aarch64 jenkins slave for the same POD as the
+# arm-pod4 is an aarch64 jenkins slave for the same POD as the
 # x86 jenkins slave arm-pod3; therefore we use the same pod name
 # to deploy the pod from both jenkins slaves
-if [[ "${NODE_NAME}" == "arm-pod3-2" ]]; then
+if [[ "${NODE_NAME}" == "arm-pod4" ]]; then
     NODE_NAME="arm-pod3"
 fi
 
index 375d807..925f68e 100755 (executable)
@@ -1,5 +1,9 @@
 #!/bin/bash
 
+set -o errexit
+set -o nounset
+set -o pipefail
+
 echo "--------------------------------------------------------"
 echo "This is diasy4nfv build job!"
 echo "--------------------------------------------------------"
index 80ca44b..9e2cdd4 100644 (file)
             slave-label: '{pod}'
             installer: fuel
             <<: *master
-        - arm-pod3-2:
+        - arm-pod4:
             slave-label: '{pod}'
             installer: fuel
             <<: *master
             slave-label: '{pod}'
             installer: fuel
             <<: *danube
-        - arm-pod3-2:
+        - arm-pod4:
             slave-label: '{pod}'
             installer: fuel
             <<: *danube
index fc89f14..fad06b0 100644 (file)
             default: ssh://jenkins-enea@gerrit.opnfv.org:29418/securedlab
             description: 'Base URI to the configuration directory'
 - parameter:
-    name: 'arm-pod3-2-defaults'
+    name: 'arm-pod4-defaults'
     parameters:
         - node:
             name: SLAVE_NAME
             description: 'Slave name on Jenkins'
             allowed-slaves:
-                - arm-pod3-2
+                - arm-pod4
             default-slaves:
-                - arm-pod3-2
+                - arm-pod4
         - string:
             name: GIT_BASE
             default: https://gerrit.opnfv.org/gerrit/$PROJECT
index ba540ed..417fc70 100644 (file)
         receivers: >
             cristina.pauna@enea.com
             alexandru.avadanii@enea.com
+    dovetail-arm-receivers: &dovetail-arm-receivers
+        receivers: >
+            cristina.pauna@enea.com
+            alexandru.avadanii@enea.com
+            alexandru.nemes@enea.com
     other-receivers: &other-receivers
         receivers: ''
 
@@ -26,6 +31,9 @@
         - 'functest':
             <<: *master
             <<: *functest-arm-receivers
+        - 'dovetail':
+            <<: *master
+            <<: *dovetail-arm-receivers
         # projects with jobs for stable
 
     jobs:
diff --git a/jjb/securedlab/check-jinja2.sh b/jjb/securedlab/check-jinja2.sh
new file mode 100755 (executable)
index 0000000..be4d951
--- /dev/null
@@ -0,0 +1,9 @@
+#!/bin/bash
+set +x
+set -o errexit
+for lab_configs in $(find labs/ -name 'pod.yaml' | grep -v zte); do
+        while IFS= read -r jinja_templates; do
+          echo "./utils/generate_config.py -y $lab_configs -j $jinja_templates"
+          ./utils/generate_config.py -y $lab_configs -j $jinja_templates
+        done < <(find installers/ -name '*.jinja2')
+done
diff --git a/jjb/securedlab/check-jinja2.yml b/jjb/securedlab/check-jinja2.yml
new file mode 100644 (file)
index 0000000..1e85536
--- /dev/null
@@ -0,0 +1,80 @@
+########################
+# Job configuration to validate jninja2 files
+########################
+- project:
+
+    name: validate-templates
+
+    project: 'securedlab'
+
+    jobs:
+        - 'validate-jinja2-templates-{stream}'
+
+    stream:
+        - master:
+            branch: '{stream}'
+            disabled: false
+        - danube:
+            branch: 'stable/{stream}'
+            disabled: false
+
+########################
+# job templates
+########################
+
+- job-template:
+    name: 'validate-jinja2-templates-{stream}'
+
+    disabled: '{obj:disabled}'
+
+    concurrent: true
+
+    parameters:
+        - project-parameter:
+            project: $GERRIT_PROJECT
+            branch: '{branch}'
+        - node:
+            name: SLAVE_NAME
+            description: Slave to execute jnija template test
+            default-slaves:
+                - lf-build1
+            allowed-multiselect: true
+            ignore-offline-nodes: true
+
+    scm:
+        - git-scm-gerrit
+
+    triggers:
+        - gerrit:
+            server-name: 'gerrit.opnfv.org'
+            trigger-on:
+                - patchset-created-event:
+                    exclude-drafts: 'false'
+                    exclude-trivial-rebase: 'false'
+                    exclude-no-code-change: 'false'
+                - draft-published-event
+                - comment-added-contains-event:
+                    comment-contains-value: 'recheck'
+                - comment-added-contains-event:
+                    comment-contains-value: 'reverify'
+            projects:
+              - project-compare-type: 'REG_EXP'
+                project-pattern: '{project}'
+                branches:
+                  - branch-compare-type: 'ANT'
+                    branch-pattern: '**/{branch}'
+                file-paths:
+                  - compare-type: ANT
+                    pattern: 'utils/generate_config.yml'
+                  - compare-type: ANT
+                    pattern: '**/*.jinja2'
+                  - compare-type: ANT
+                    pattern: '**/*.yaml'
+    builders:
+        - check-jinja
+
+- builder:
+    name: check-jinja
+    builders:
+        - shell:
+            !include-raw-escape: ./check-jinja2.sh
diff --git a/utils/test/testapi/opnfv_testapi/tests/unit/executor.py b/utils/test/testapi/opnfv_testapi/tests/unit/executor.py
new file mode 100644 (file)
index 0000000..b30c325
--- /dev/null
@@ -0,0 +1,83 @@
+##############################################################################
+# Copyright (c) 2017 ZTE Corp
+# feng.xiaowei@zte.com.cn
+# All rights reserved. This program and the accompanying materials
+# are made available under the terms of the Apache License, Version 2.0
+# which accompanies this distribution, and is available at
+# http://www.apache.org/licenses/LICENSE-2.0
+##############################################################################
+import functools
+import httplib
+
+
+def create(excepted_status, excepted_response):
+    def _create(create_request):
+        @functools.wraps(create_request)
+        def wrap(self):
+            request = create_request(self)
+            status, body = self.create(request)
+            if excepted_status == httplib.OK:
+                getattr(self, excepted_response)(body)
+            else:
+                self.assertIn(excepted_response, body)
+        return wrap
+    return _create
+
+
+def get(excepted_status, excepted_response):
+    def _get(get_request):
+        @functools.wraps(get_request)
+        def wrap(self):
+            request = get_request(self)
+            status, body = self.get(request)
+            if excepted_status == httplib.OK:
+                getattr(self, excepted_response)(body)
+            else:
+                self.assertIn(excepted_response, body)
+        return wrap
+    return _get
+
+
+def update(excepted_status, excepted_response):
+    def _update(update_request):
+        @functools.wraps(update_request)
+        def wrap(self):
+            request, resource = update_request(self)
+            status, body = self.update(request, resource)
+            if excepted_status == httplib.OK:
+                getattr(self, excepted_response)(request, body)
+            else:
+                self.assertIn(excepted_response, body)
+        return wrap
+    return _update
+
+
+def delete(excepted_status, excepted_response):
+    def _delete(delete_request):
+        @functools.wraps(delete_request)
+        def wrap(self):
+            request = delete_request(self)
+            if isinstance(request, tuple):
+                status, body = self.delete(request[0], *(request[1]))
+            else:
+                status, body = self.delete(request)
+            if excepted_status == httplib.OK:
+                getattr(self, excepted_response)(body)
+            else:
+                self.assertIn(excepted_response, body)
+        return wrap
+    return _delete
+
+
+def query(excepted_status, excepted_response, number=0):
+    def _query(get_request):
+        @functools.wraps(get_request)
+        def wrap(self):
+            request = get_request(self)
+            status, body = self.query(request)
+            if excepted_status == httplib.OK:
+                getattr(self, excepted_response)(body, number)
+            else:
+                self.assertIn(excepted_response, body)
+        return wrap
+    return _query
index b955f4a..a6e7339 100644 (file)
@@ -12,9 +12,9 @@ from os import path
 import mock
 from tornado import testing
 
-import fake_pymongo
 from opnfv_testapi.cmd import server
 from opnfv_testapi.resources import models
+from opnfv_testapi.tests.unit import fake_pymongo
 
 
 class TestBase(testing.AsyncHTTPTestCase):
index 7c43fca..1ebc96f 100644 (file)
@@ -12,7 +12,7 @@ from tornado import gen
 from tornado import testing
 from tornado import web
 
-import fake_pymongo
+from opnfv_testapi.tests.unit import fake_pymongo
 
 
 class MyTest(testing.AsyncHTTPTestCase):
index cae86e8..0ed348d 100644 (file)
@@ -11,7 +11,8 @@ import unittest
 
 from opnfv_testapi.common import message
 from opnfv_testapi.resources import pod_models
-import test_base as base
+from opnfv_testapi.tests.unit import executor
+from opnfv_testapi.tests.unit import test_base as base
 
 
 class TestPodBase(base.TestBase):
@@ -36,48 +37,47 @@ class TestPodBase(base.TestBase):
 
 
 class TestPodCreate(TestPodBase):
+    @executor.create(httplib.BAD_REQUEST, message.no_body())
     def test_withoutBody(self):
-        (code, body) = self.create()
-        self.assertEqual(code, httplib.BAD_REQUEST)
+        return None
 
+    @executor.create(httplib.BAD_REQUEST, message.missing('name'))
     def test_emptyName(self):
-        req_empty = pod_models.PodCreateRequest('')
-        (code, body) = self.create(req_empty)
-        self.assertEqual(code, httplib.BAD_REQUEST)
-        self.assertIn(message.missing('name'), body)
+        return pod_models.PodCreateRequest('')
 
+    @executor.create(httplib.BAD_REQUEST, message.missing('name'))
     def test_noneName(self):
-        req_none = pod_models.PodCreateRequest(None)
-        (code, body) = self.create(req_none)
-        self.assertEqual(code, httplib.BAD_REQUEST)
-        self.assertIn(message.missing('name'), body)
+        return pod_models.PodCreateRequest(None)
 
+    @executor.create(httplib.OK, 'assert_create_body')
     def test_success(self):
-        code, body = self.create_d()
-        self.assertEqual(code, httplib.OK)
-        self.assert_create_body(body)
+        return self.req_d
 
+    @executor.create(httplib.FORBIDDEN, message.exist_base)
     def test_alreadyExist(self):
         self.create_d()
-        code, body = self.create_d()
-        self.assertEqual(code, httplib.FORBIDDEN)
-        self.assertIn(message.exist_base, body)
+        return self.req_d
 
 
 class TestPodGet(TestPodBase):
+    def setUp(self):
+        super(TestPodGet, self).setUp()
+        self.create_d()
+        self.create_e()
+
+    @executor.get(httplib.NOT_FOUND, message.not_found_base)
     def test_notExist(self):
-        code, body = self.get('notExist')
-        self.assertEqual(code, httplib.NOT_FOUND)
+        return 'notExist'
 
+    @executor.get(httplib.OK, 'assert_get_body')
     def test_getOne(self):
-        self.create_d()
-        code, body = self.get(self.req_d.name)
-        self.assert_get_body(body)
+        return self.req_d.name
 
+    @executor.get(httplib.OK, '_assert_list')
     def test_list(self):
-        self.create_d()
-        self.create_e()
-        code, body = self.get()
+        return None
+
+    def _assert_list(self, body):
         self.assertEqual(len(body.pods), 2)
         for pod in body.pods:
             if self.req_d.name == pod.name:
index 74cefd7..9143f8a 100644 (file)
@@ -11,7 +11,7 @@ import unittest
 
 from opnfv_testapi.common import message
 from opnfv_testapi.resources import project_models
-import test_base as base
+from opnfv_testapi.tests.unit import test_base as base
 
 
 class TestProjectBase(base.TestBase):
index 2e0aa36..940279c 100644 (file)
@@ -16,7 +16,7 @@ from opnfv_testapi.resources import pod_models
 from opnfv_testapi.resources import project_models
 from opnfv_testapi.resources import result_models
 from opnfv_testapi.resources import testcase_models
-import test_base as base
+from opnfv_testapi.tests.unit import test_base as base
 
 
 class Details(object):
index f2291a5..b232bc1 100644 (file)
@@ -7,7 +7,7 @@ import os
 
 from opnfv_testapi.common import message
 import opnfv_testapi.resources.scenario_models as models
-import test_base as base
+from opnfv_testapi.tests.unit import test_base as base
 
 
 class TestScenarioBase(base.TestBase):
index 62d0fa0..73c4819 100644 (file)
@@ -13,7 +13,7 @@ import unittest
 from opnfv_testapi.common import message
 from opnfv_testapi.resources import project_models
 from opnfv_testapi.resources import testcase_models
-import test_base as base
+from opnfv_testapi.tests.unit import test_base as base
 
 
 class TestCaseBase(base.TestBase):
index ed3eda0..ca247a3 100644 (file)
@@ -8,11 +8,12 @@ import unittest
 
 from tornado import web
 
-import fake_pymongo
 from opnfv_testapi.common import message
 from opnfv_testapi.resources import project_models
 from opnfv_testapi.router import url_mappings
-import test_base as base
+from opnfv_testapi.tests.unit import executor
+from opnfv_testapi.tests.unit import fake_pymongo
+from opnfv_testapi.tests.unit import test_base as base
 
 
 class TestToken(base.TestBase):
@@ -32,22 +33,24 @@ class TestTokenCreateProject(TestToken):
         fake_pymongo.tokens.insert({"access_token": "12345"})
         self.basePath = '/api/v1/projects'
 
+    @executor.create(httplib.FORBIDDEN, message.invalid_token())
     def test_projectCreateTokenInvalid(self):
         self.headers['X-Auth-Token'] = '1234'
-        code, body = self.create_d()
-        self.assertEqual(code, httplib.FORBIDDEN)
-        self.assertIn(message.invalid_token(), body)
+        return self.req_d
 
+    @executor.create(httplib.UNAUTHORIZED, message.unauthorized())
     def test_projectCreateTokenUnauthorized(self):
-        self.headers.pop('X-Auth-Token')
-        code, body = self.create_d()
-        self.assertEqual(code, httplib.UNAUTHORIZED)
-        self.assertIn(message.unauthorized(), body)
+        if 'X-Auth-Token' in self.headers:
+            self.headers.pop('X-Auth-Token')
+        return self.req_d
 
+    @executor.create(httplib.OK, '_create_success')
     def test_projectCreateTokenSuccess(self):
         self.headers['X-Auth-Token'] = '12345'
-        code, body = self.create_d()
-        self.assertEqual(code, httplib.OK)
+        return self.req_d
+
+    def _create_success(self, body):
+        self.assertIn('CreateResponse', str(type(body)))
 
 
 class TestTokenDeleteProject(TestToken):
@@ -56,28 +59,25 @@ class TestTokenDeleteProject(TestToken):
         self.req_d = project_models.ProjectCreateRequest('vping')
         fake_pymongo.tokens.insert({"access_token": "12345"})
         self.basePath = '/api/v1/projects'
-
-    def test_projectDeleteTokenIvalid(self):
         self.headers['X-Auth-Token'] = '12345'
         self.create_d()
+
+    @executor.delete(httplib.FORBIDDEN, message.invalid_token())
+    def test_projectDeleteTokenIvalid(self):
         self.headers['X-Auth-Token'] = '1234'
-        code, body = self.delete(self.req_d.name)
-        self.assertEqual(code, httplib.FORBIDDEN)
-        self.assertIn(message.invalid_token(), body)
+        return self.req_d.name
 
+    @executor.delete(httplib.UNAUTHORIZED, message.unauthorized())
     def test_projectDeleteTokenUnauthorized(self):
-        self.headers['X-Auth-Token'] = '12345'
-        self.create_d()
         self.headers.pop('X-Auth-Token')
-        code, body = self.delete(self.req_d.name)
-        self.assertEqual(code, httplib.UNAUTHORIZED)
-        self.assertIn(message.unauthorized(), body)
+        return self.req_d.name
 
+    @executor.delete(httplib.OK, '_delete_success')
     def test_projectDeleteTokenSuccess(self):
-        self.headers['X-Auth-Token'] = '12345'
-        self.create_d()
-        code, body = self.delete(self.req_d.name)
-        self.assertEqual(code, httplib.OK)
+        return self.req_d.name
+
+    def _delete_success(self, body):
+        self.assertEqual('', body)
 
 
 class TestTokenUpdateProject(TestToken):
@@ -86,34 +86,28 @@ class TestTokenUpdateProject(TestToken):
         self.req_d = project_models.ProjectCreateRequest('vping')
         fake_pymongo.tokens.insert({"access_token": "12345"})
         self.basePath = '/api/v1/projects'
-
-    def test_projectUpdateTokenIvalid(self):
         self.headers['X-Auth-Token'] = '12345'
         self.create_d()
-        code, body = self.get(self.req_d.name)
+
+    @executor.update(httplib.FORBIDDEN, message.invalid_token())
+    def test_projectUpdateTokenIvalid(self):
         self.headers['X-Auth-Token'] = '1234'
         req = project_models.ProjectUpdateRequest('newName', 'new description')
-        code, body = self.update(req, self.req_d.name)
-        self.assertEqual(code, httplib.FORBIDDEN)
-        self.assertIn(message.invalid_token(), body)
+        return req, self.req_d.name
 
+    @executor.update(httplib.UNAUTHORIZED, message.unauthorized())
     def test_projectUpdateTokenUnauthorized(self):
-        self.headers['X-Auth-Token'] = '12345'
-        self.create_d()
-        code, body = self.get(self.req_d.name)
         self.headers.pop('X-Auth-Token')
         req = project_models.ProjectUpdateRequest('newName', 'new description')
-        code, body = self.update(req, self.req_d.name)
-        self.assertEqual(code, httplib.UNAUTHORIZED)
-        self.assertIn(message.unauthorized(), body)
+        return req, self.req_d.name
 
+    @executor.update(httplib.OK, '_update_success')
     def test_projectUpdateTokenSuccess(self):
-        self.headers['X-Auth-Token'] = '12345'
-        self.create_d()
-        code, body = self.get(self.req_d.name)
         req = project_models.ProjectUpdateRequest('newName', 'new description')
-        code, body = self.update(req, self.req_d.name)
-        self.assertEqual(code, httplib.OK)
+        return req, self.req_d.name
+
+    def _update_success(self, request, body):
+        self.assertIn(request.name, body)
 
 if __name__ == '__main__':
     unittest.main()
index c8f3f50..fff802a 100644 (file)
@@ -6,10 +6,12 @@
 # which accompanies this distribution, and is available at
 # http://www.apache.org/licenses/LICENSE-2.0
 ##############################################################################
+import httplib
 import unittest
 
 from opnfv_testapi.resources import models
-import test_base as base
+from opnfv_testapi.tests.unit import executor
+from opnfv_testapi.tests.unit import test_base as base
 
 
 class TestVersionBase(base.TestBase):
@@ -20,12 +22,15 @@ class TestVersionBase(base.TestBase):
 
 
 class TestVersion(TestVersionBase):
+    @executor.get(httplib.OK, '_get_success')
     def test_success(self):
-        code, body = self.get()
-        self.assertEqual(200, code)
+        return None
+
+    def _get_success(self, body):
         self.assertEqual(len(body.versions), 1)
         self.assertEqual(body.versions[0].version, 'v1.0')
         self.assertEqual(body.versions[0].description, 'basics')
 
+
 if __name__ == '__main__':
     unittest.main()