Separate out test_parse_to_value_exception()

Separate out test_parse_to_value_exception(self)
into 3 different methods:
    test_parse_scanner(self)
    test_parse_parser(self)
    test_parse_reader(self)

This ensures that each side effect is tested, even if one fails.

JIRA: YARDSTICK-940

Change-Id: Ifdc84284c633fe1ddc1acf9cd985c5144030b430
Signed-off-by: John O Loughlin <john.oloughlin@intel.com>

diff --git a/yardstick/tests/unit/common/test_template_format.py b/yardstick/tests/unit/common/test_template_format.py
index 56253ef..6e4827e 100644 (file)
--- a/yardstick/tests/unit/common/test_template_format.py
+++ b/yardstick/tests/unit/common/test_template_format.py
@@ -22,16 +22,21 @@ from yardstick.common import template_format
 
 class TemplateFormatTestCase(unittest.TestCase):
 
-    def test_parse_to_value_exception(self):
+    def test_parse_scanner(self):
 
-        # TODO(elfoley): Don't hide the error that occurs in
-        # template_format.parse
-        # TODO(elfoley): Separate these tests; one per error type
         with mock.patch.object(yaml, 'load') as yaml_loader:
             yaml_loader.side_effect = yaml.scanner.ScannerError()
             self.assertRaises(ValueError, template_format.parse, 'FOOBAR')
+
+    def test_parse_parser(self):
+
+        with mock.patch.object(yaml, 'load') as yaml_loader:
             yaml_loader.side_effect = yaml.parser.ParserError()
             self.assertRaises(ValueError, template_format.parse, 'FOOBAR')
+
+    def test_parse_reader(self):
+
+        with mock.patch.object(yaml, 'load') as yaml_loader:
             yaml_loader.side_effect = \
                 yaml.reader.ReaderError('', '', '', '', '')
             self.assertRaises(ValueError, template_format.parse, 'FOOBAR')