lib.sh: Fix locals override in nested invocations 95/45895/1
authorAlexandru Avadanii <Alexandru.Avadanii@enea.com>
Thu, 19 Oct 2017 21:58:05 +0000 (23:58 +0200)
committerAlexandru Avadanii <Alexandru.Avadanii@enea.com>
Thu, 19 Oct 2017 22:19:12 +0000 (22:19 +0000)
commita05761b9a0cafa01fc837798e030cf01f46026c3
tree6a91d2f1685bb4dbbc6472dca43c798437ef7e53
parent80fa21c1cf4eea0f41438bc0f7509af7ee237dc1
lib.sh: Fix locals override in nested invocations

'wait_for' bash function is nested in another 'wait_for' call in some
places, which leads to inner calls interfering with outer calls by
overriding the locally scoped variables, including the 'attempt'
internal counter. In some cases, the outer 'wait_for' would exit
after a single attempt.

Fix that by running all contents of `wait_for` inside a subshell,
which inherits outer calls variables, but does not override them
when the inner call is finished.

Change-Id: I450eda3d023af2380c61ee930071fbfc393a5645
Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
(cherry picked from commit 2776ab9d850e764a92c30c858befc48e474f6dd4)
mcp/scripts/lib.sh