Better way to ensure keepalived before haproxy.
authorSofer Athlan-Guyot <sathlang@redhat.com>
Tue, 8 Nov 2016 09:16:53 +0000 (10:16 +0100)
committerSofer Athlan-Guyot <sathlang@redhat.com>
Tue, 8 Nov 2016 17:35:11 +0000 (18:35 +0100)
commitb11d048e55fc20a90bcf11eed0f4cea5e1b45f7c
tree083e1890ea5fff6a3c2505a2d04461c7620b3300
parent8a4fc9c18e8ebfccc7f5bd0c4820c87bebd61d31
Better way to ensure keepalived before haproxy.

The lastest patchset of https://review.openstack.org/393361 was actually
not working.

The `if defined` idiom depends on *evaluation* order.

At the time it's red in the haproxy.pp class, the line that loads the
class 'haproxy' has still not yet been reached and thus the `defined`
result is false. The constraint is not added.

For this reason, the use of `defined` in module is not advised by
puppetlabs[1].

[1] https://docs.puppet.com/puppet/latest/reference/function.html#defined

Change-Id: Ibd352cb313f8863d62db8987419378bed5b87256
Relates-To: #1638029
manifests/haproxy.pp
manifests/keepalived.pp