Move deprecated SchedulerHints logic to overcloud.j2.yaml
The changes in puppet/role.role.j2.yaml should have been made
to overcloud.j2.yaml, because we don't want the hard-coded reference
to the deprecated name in the parent template. Note we need to
pass this value from the parent template so the %index% substitution
works, which is required for predictable placement via *SchedulerHints
Partial-Bug: #
1711656
Change-Id: Ided1802daac48d737f53caa7093df814ba101dd0
(cherry picked from commit
c6207379db07544240b699ba000537b58d9fb68f)