get_param calls with multiple arguments need brackets around them
authorMichele Baldessari <michele@acksyn.org>
Fri, 23 Sep 2016 15:31:19 +0000 (17:31 +0200)
committerMichele Baldessari <michele@acksyn.org>
Sun, 25 Sep 2016 20:05:00 +0000 (22:05 +0200)
commit9393a3e2a57d293eabe1fcfb702b0cecdf5e60ff
tree85ae1a597cbeff45560b7d4f7b26cd419be08997
parent5d49b75b6e8c608ede6fc7bd63b06055ce5f6317
get_param calls with multiple arguments need brackets around them

This issue was spotted during major upgrade where we had calls like
this:

   servers: {get_param: servers, Controller}

These get_param calls are hanging indefinitely and make the whole
upgrade end in a timeout. We need to put brackets around the get_param
function when there are multiple arguments:
http://docs.openstack.org/developer/heat/template_guide/hot_spec.html#get-param

This is already done in most of the tree, and the few places where this
was not happening were parts not under CI. After this change the
following grep returns only one false positive:

   grep -ir get_param: |grep -v -- '\[' |grep ','

Change-Id: I65b23bb44f37b93e017dd15a5212939ffac76614
Closes-Bug: #1626628
extraconfig/all_nodes/mac_hostname.j2.yaml
extraconfig/all_nodes/random_string.j2.yaml
extraconfig/all_nodes/swap-partition.j2.yaml
extraconfig/all_nodes/swap.j2.yaml
extraconfig/tasks/major_upgrade_pacemaker.yaml
extraconfig/tasks/mitaka_to_newton_aodh_data_migration.yaml
puppet/extraconfig/all_nodes/neutron-midonet-all-nodes.yaml
puppet/extraconfig/all_nodes/neutron-ml2-cisco-nexus-ucsm.yaml