X-Git-Url: https://gerrit.opnfv.org/gerrit/gitweb?a=blobdiff_plain;f=snaps%2Fopenstack%2Futils%2Fnova_utils.py;h=0820289e3efc1e6cb1673f68e7b213930103a51a;hb=4cad4f7d1f53189900f9024fa5478e98a64d3760;hp=9d0f70fa74e9b52a55aa45c1acebcea0bef3f699;hpb=1a0967b4e23c2d985b8c02dc9f23bd6c3afa86a3;p=snaps.git diff --git a/snaps/openstack/utils/nova_utils.py b/snaps/openstack/utils/nova_utils.py index 9d0f70f..0820289 100644 --- a/snaps/openstack/utils/nova_utils.py +++ b/snaps/openstack/utils/nova_utils.py @@ -1,4 +1,4 @@ -# Copyright (c) 2016 Cable Television Laboratories, Inc. ("CableLabs") +# Copyright (c) 2017 Cable Television Laboratories, Inc. ("CableLabs") # and others. All rights reserved. # # Licensed under the Apache License, Version 2.0 (the "License"); @@ -12,13 +12,24 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. -import os + import logging -import keystone_utils +import os +import time +from cryptography.hazmat.backends import default_backend +from cryptography.hazmat.primitives import serialization +from cryptography.hazmat.primitives.asymmetric import rsa from novaclient.client import Client from novaclient.exceptions import NotFound +from snaps import file_utils +from snaps.domain.flavor import Flavor +from snaps.domain.keypair import Keypair +from snaps.domain.project import ComputeQuotas +from snaps.domain.vm_inst import VmInst +from snaps.openstack.utils import keystone_utils, glance_utils, neutron_utils + __author__ = 'spisarski' logger = logging.getLogger('nova_utils') @@ -30,22 +41,196 @@ Utilities for basic OpenStack Nova API calls def nova_client(os_creds): """ - Instantiates and returns a client for communications with OpenStack's Nova server + Instantiates and returns a client for communications with OpenStack's Nova + server :param os_creds: The connection credentials to the OpenStack API :return: the client object """ logger.debug('Retrieving Nova Client') - return Client(os_creds.compute_api_version, session=keystone_utils.keystone_session(os_creds)) + return Client(os_creds.compute_api_version, + session=keystone_utils.keystone_session(os_creds), + region_name=os_creds.region_name) + + +def create_server(nova, neutron, glance, instance_settings, image_settings, + keypair_settings=None): + """ + Creates a VM instance + :param nova: the nova client (required) + :param neutron: the neutron client for retrieving ports (required) + :param glance: the glance client (required) + :param instance_settings: the VM instance settings object (required) + :param image_settings: the VM's image settings object (required) + :param keypair_settings: the VM's keypair settings object (optional) + :return: a snaps.domain.VmInst object + """ + + ports = list() + + for port_setting in instance_settings.port_settings: + ports.append(neutron_utils.get_port( + neutron, port_settings=port_setting)) + nics = [] + for port in ports: + kv = dict() + kv['port-id'] = port.id + nics.append(kv) + + logger.info('Creating VM with name - ' + instance_settings.name) + keypair_name = None + if keypair_settings: + keypair_name = keypair_settings.name + + flavor = get_flavor_by_name(nova, instance_settings.flavor) + if not flavor: + raise NovaException( + 'Flavor not found with name - %s', instance_settings.flavor) + + image = glance_utils.get_image(glance, image_settings=image_settings) + if image: + userdata = None + if instance_settings.userdata: + if isinstance(instance_settings.userdata, str): + userdata = instance_settings.userdata + '\n' + elif (isinstance(instance_settings.userdata, dict) and + 'script_file' in instance_settings.userdata): + try: + userdata = file_utils.read_file( + instance_settings.userdata['script_file']) + except Exception as e: + logger.warn('error reading userdata file %s - %s', + instance_settings.userdata, e) + args = {'name': instance_settings.name, + 'flavor': flavor, + 'image': image, + 'nics': nics, + 'key_name': keypair_name, + 'security_groups': + instance_settings.security_group_names, + 'userdata': userdata} + + if instance_settings.availability_zone: + args['availability_zone'] = instance_settings.availability_zone + + server = nova.servers.create(**args) + + return __map_os_server_obj_to_vm_inst(server) + else: + raise NovaException( + 'Cannot create instance, image cannot be located with name %s', + image_settings.name) + + +def get_server(nova, vm_inst_settings=None, server_name=None): + """ + Returns a VmInst object for the first server instance found. + :param nova: the Nova client + :param vm_inst_settings: the VmInstanceSettings object from which to build + the query if not None + :param server_name: the server with this name to return if vm_inst_settings + is not None + :return: a snaps.domain.VmInst object or None if not found + """ + search_opts = dict() + if vm_inst_settings: + search_opts['name'] = vm_inst_settings.name + elif server_name: + search_opts['name'] = server_name + servers = nova.servers.list(search_opts=search_opts) + for server in servers: + return __map_os_server_obj_to_vm_inst(server) -def get_servers_by_name(nova, name): + +def get_server_connection(nova, vm_inst_settings=None, server_name=None): """ - Returns a list of servers with a given name + Returns a VmInst object for the first server instance found. :param nova: the Nova client - :param name: the server name - :return: the list of servers + :param vm_inst_settings: the VmInstanceSettings object from which to build + the query if not None + :param server_name: the server with this name to return if vm_inst_settings + is not None + :return: a snaps.domain.VmInst object or None if not found + """ + search_opts = dict() + if vm_inst_settings: + search_opts['name'] = vm_inst_settings.name + elif server_name: + search_opts['name'] = server_name + + servers = nova.servers.list(search_opts=search_opts) + for server in servers: + return server.links[0] + + +def __map_os_server_obj_to_vm_inst(os_server): + """ + Returns a VmInst object for an OpenStack Server object + :param os_server: the OpenStack server object + :return: an equivalent SNAPS-OO VmInst domain object + """ + sec_grp_names = list() + # VM must be active for 'security_groups' attr to be initialized + if hasattr(os_server, 'security_groups'): + for sec_group in os_server.security_groups: + if sec_group.get('name'): + sec_grp_names.append(sec_group.get('name')) + + volumes = None + if hasattr(os_server, 'os-extended-volumes:volumes_attached'): + volumes = getattr(os_server, 'os-extended-volumes:volumes_attached') + + return VmInst( + name=os_server.name, inst_id=os_server.id, + image_id=os_server.image['id'], flavor_id=os_server.flavor['id'], + networks=os_server.networks, keypair_name=os_server.key_name, + sec_grp_names=sec_grp_names, volume_ids=volumes) + + +def __get_latest_server_os_object(nova, server): + """ + Returns a server with a given id + :param nova: the Nova client + :param server: the domain VmInst object + :return: the list of servers or None if not found """ - return nova.servers.list(search_opts={'name': name}) + return __get_latest_server_os_object_by_id(nova, server.id) + + +def __get_latest_server_os_object_by_id(nova, server_id): + """ + Returns a server with a given id + :param nova: the Nova client + :param server_id: the server's ID + :return: the list of servers or None if not found + """ + return nova.servers.get(server_id) + + +def get_server_status(nova, server): + """ + Returns the a VM instance's status from OpenStack + :param nova: the Nova client + :param server: the domain VmInst object + :return: the VM's string status or None if not founc + """ + server = __get_latest_server_os_object(nova, server) + if server: + return server.status + return None + + +def get_server_console_output(nova, server): + """ + Returns the console object for parsing VM activity + :param nova: the Nova client + :param server: the domain VmInst object + :return: the console output object or None if server object is not found + """ + server = __get_latest_server_os_object(nova, server) + if server: + return server.get_console_output() + return None def get_latest_server_object(nova, server): @@ -55,36 +240,119 @@ def get_latest_server_object(nova, server): :param server: the old server object :return: the list of servers or None if not found """ - return nova.servers.get(server) + server = __get_latest_server_os_object(nova, server) + return __map_os_server_obj_to_vm_inst(server) + + +def get_server_object_by_id(nova, server_id): + """ + Returns a server with a given id + :param nova: the Nova client + :param server_id: the server's id + :return: an SNAPS-OO VmInst object or None if not found + """ + server = __get_latest_server_os_object_by_id(nova, server_id) + return __map_os_server_obj_to_vm_inst(server) + + +def get_server_security_group_names(nova, server): + """ + Returns a server with a given id + :param nova: the Nova client + :param server: the old server object + :return: the list of security groups associated with a VM + """ + out = list() + os_vm_inst = __get_latest_server_os_object(nova, server) + for sec_grp_dict in os_vm_inst.security_groups: + out.append(sec_grp_dict['name']) + return out + + +def get_server_info(nova, server): + """ + Returns a dictionary of a VMs info as returned by OpenStack + :param nova: the Nova client + :param server: the old server object + :return: a dict of the info if VM exists else None + """ + vm = __get_latest_server_os_object(nova, server) + if vm: + return vm._info + return None + + +def create_keys(key_size=2048): + """ + Generates public and private keys + :param key_size: the number of bytes for the key size + :return: the cryptography keys + """ + return rsa.generate_private_key(backend=default_backend(), + public_exponent=65537, + key_size=key_size) + + +def public_key_openssh(keys): + """ + Returns the public key for OpenSSH + :param keys: the keys generated by create_keys() from cryptography + :return: the OpenSSH public key + """ + return keys.public_key().public_bytes(serialization.Encoding.OpenSSH, + serialization.PublicFormat.OpenSSH) def save_keys_to_files(keys=None, pub_file_path=None, priv_file_path=None): """ Saves the generated RSA generated keys to the filesystem - :param keys: the keys to save + :param keys: the keys to save generated by cryptography :param pub_file_path: the path to the public keys :param priv_file_path: the path to the private keys - :return: None """ if keys: if pub_file_path: - pub_dir = os.path.dirname(pub_file_path) + # To support '~' + pub_expand_file = os.path.expanduser(pub_file_path) + pub_dir = os.path.dirname(pub_expand_file) + if not os.path.isdir(pub_dir): os.mkdir(pub_dir) - public_handle = open(pub_file_path, 'wb') - public_handle.write(keys.publickey().exportKey('OpenSSH')) - public_handle.close() - os.chmod(pub_file_path, 0o400) - logger.info("Saved public key to - " + pub_file_path) + + public_handle = None + try: + public_handle = open(pub_expand_file, 'wb') + public_bytes = keys.public_key().public_bytes( + serialization.Encoding.OpenSSH, + serialization.PublicFormat.OpenSSH) + public_handle.write(public_bytes) + finally: + if public_handle: + public_handle.close() + + os.chmod(pub_expand_file, 0o600) + logger.info("Saved public key to - " + pub_expand_file) if priv_file_path: - priv_dir = os.path.dirname(priv_file_path) + # To support '~' + priv_expand_file = os.path.expanduser(priv_file_path) + priv_dir = os.path.dirname(priv_expand_file) if not os.path.isdir(priv_dir): os.mkdir(priv_dir) - private_handle = open(priv_file_path, 'wb') - private_handle.write(keys.exportKey()) - private_handle.close() - os.chmod(priv_file_path, 0o400) - logger.info("Saved private key to - " + priv_file_path) + + private_handle = None + try: + private_handle = open(priv_expand_file, 'wb') + private_handle.write( + keys.private_bytes( + encoding=serialization.Encoding.PEM, + format=serialization.PrivateFormat.TraditionalOpenSSL, + encryption_algorithm=serialization.NoEncryption())) + finally: + if private_handle: + private_handle.close() + + os.chmod(priv_expand_file, 0o600) + logger.info("Saved private key to - " + priv_expand_file) def upload_keypair_file(nova, name, file_path): @@ -95,9 +363,14 @@ def upload_keypair_file(nova, name, file_path): :param file_path: the path to the public key file :return: the keypair object """ - with open(os.path.expanduser(file_path)) as fpubkey: - logger.info('Saving keypair to - ' + file_path) - return upload_keypair(nova, name, fpubkey.read()) + fpubkey = None + try: + with open(os.path.expanduser(file_path), 'rb') as fpubkey: + logger.info('Saving keypair to - ' + file_path) + return upload_keypair(nova, name, fpubkey.read()) + finally: + if fpubkey: + fpubkey.close() def upload_keypair(nova, name, key): @@ -109,7 +382,9 @@ def upload_keypair(nova, name, key): :return: the keypair object """ logger.info('Creating keypair with name - ' + name) - return nova.keypairs.create(name=name, public_key=key) + os_kp = nova.keypairs.create(name=name, public_key=key.decode('utf-8')) + return Keypair(name=os_kp.name, kp_id=os_kp.id, + public_key=os_kp.public_key, fingerprint=os_kp.fingerprint) def keypair_exists(nova, keypair_obj): @@ -120,7 +395,9 @@ def keypair_exists(nova, keypair_obj): :return: the keypair object or None if not found """ try: - return nova.keypairs.get(keypair_obj) + os_kp = nova.keypairs.get(keypair_obj) + return Keypair(name=os_kp.name, kp_id=os_kp.id, + public_key=os_kp.public_key) except: return None @@ -136,95 +413,121 @@ def get_keypair_by_name(nova, name): for keypair in keypairs: if keypair.name == name: - return keypair + return Keypair(name=keypair.name, kp_id=keypair.id, + public_key=keypair.public_key) return None -def delete_keypair(nova, key): +def get_keypair_by_id(nova, kp_id): """ - Deletes a keypair object from OpenStack + Returns a list of all available keypairs :param nova: the Nova client - :param key: the keypair object to delete + :param kp_id: the ID of the keypair to return + :return: the keypair object """ - logger.debug('Deleting keypair - ' + key.name) - nova.keypairs.delete(key) + keypair = nova.keypairs.get(kp_id) + return Keypair(name=keypair.name, kp_id=keypair.id, + public_key=keypair.public_key) -def get_floating_ip_pools(nova): +def delete_keypair(nova, key): """ - Returns all of the available floating IP pools + Deletes a keypair object from OpenStack :param nova: the Nova client - :return: a list of pools + :param key: the SNAPS-OO keypair domain object to delete """ - return nova.floating_ip_pools.list() + logger.debug('Deleting keypair - ' + key.name) + nova.keypairs.delete(key.id) -def get_floating_ips(nova): +def get_availability_zone_hosts(nova, zone_name='nova'): """ - Returns all of the floating IPs + Returns the names of all nova active compute servers :param nova: the Nova client - :return: a list of floating IPs + :param zone_name: the Nova client + :return: a list of compute server names """ - return nova.floating_ips.list() + out = list() + zones = nova.availability_zones.list() + for zone in zones: + if zone.zoneName == zone_name and zone.hosts: + for key, host in zone.hosts.items(): + if host['nova-compute']['available']: + out.append(zone.zoneName + ':' + key) + return out -def create_floating_ip(nova, ext_net_name): + +def delete_vm_instance(nova, vm_inst): """ - Returns the floating IP object that was created with this call - :param nova: the Nova client - :param ext_net_name: the name of the external network on which to apply the floating IP address - :return: the floating IP object + Deletes a VM instance + :param nova: the nova client + :param vm_inst: the snaps.domain.VmInst object """ - logger.info('Creating floating ip to external network - ' + ext_net_name) - return nova.floating_ips.create(ext_net_name) + nova.servers.delete(vm_inst.id) -def get_floating_ip(nova, floating_ip): +def __get_os_flavor(nova, flavor_id): """ - Returns a floating IP object that should be identical to the floating_ip parameter + Returns to OpenStack flavor object by name :param nova: the Nova client - :param floating_ip: the floating IP object to lookup - :return: hopefully the same floating IP object input + :param flavor_id: the flavor's ID value + :return: the OpenStack Flavor object """ - logger.debug('Attempting to retrieve existing floating ip with IP - ' + floating_ip.ip) - return nova.floating_ips.get(floating_ip) + try: + return nova.flavors.get(flavor_id) + except NotFound: + return None -def delete_floating_ip(nova, floating_ip): +def get_flavor(nova, flavor): """ - Responsible for deleting a floating IP + Returns to OpenStack flavor object by name :param nova: the Nova client - :param floating_ip: the floating IP object to delete - :return: - """ - logger.debug('Attempting to delete existing floating ip with IP - ' + floating_ip.ip) - return nova.floating_ips.delete(floating_ip) + :param flavor: the SNAPS flavor domain object + :return: the SNAPS Flavor domain object + """ + os_flavor = __get_os_flavor(nova, flavor.id) + if os_flavor: + return Flavor( + name=os_flavor.name, id=os_flavor.id, ram=os_flavor.ram, + disk=os_flavor.disk, vcpus=os_flavor.vcpus, + ephemeral=os_flavor.ephemeral, swap=os_flavor.swap, + rxtx_factor=os_flavor.rxtx_factor, is_public=os_flavor.is_public) + try: + return nova.flavors.get(flavor.id) + except NotFound: + return None -def get_nova_availability_zones(nova): +def get_flavor_by_id(nova, flavor_id): """ - Returns the names of all nova compute servers + Returns to OpenStack flavor object by name :param nova: the Nova client - :return: a list of compute server names + :param flavor_id: the flavor ID value + :return: the SNAPS Flavor domain object """ - out = list() - zones = nova.availability_zones.list() - for zone in zones: - if zone.zoneName == 'nova': - for key, host in zone.hosts.iteritems(): - out.append(zone.zoneName + ':' + key) + os_flavor = __get_os_flavor(nova, flavor_id) + if os_flavor: + return Flavor( + name=os_flavor.name, id=os_flavor.id, ram=os_flavor.ram, + disk=os_flavor.disk, vcpus=os_flavor.vcpus, + ephemeral=os_flavor.ephemeral, swap=os_flavor.swap, + rxtx_factor=os_flavor.rxtx_factor, is_public=os_flavor.is_public) - return out - -def delete_vm_instance(nova, vm_inst): +def __get_os_flavor_by_name(nova, name): """ - Deletes a VM instance - :param nova: the nova client - :param vm_inst: the OpenStack instance object to delete + Returns to OpenStack flavor object by name + :param nova: the Nova client + :param name: the name of the flavor to query + :return: OpenStack flavor object """ - nova.servers.delete(vm_inst) + try: + return nova.flavors.find(name=name) + except NotFound: + return None def get_flavor_by_name(nova, name): @@ -232,12 +535,15 @@ def get_flavor_by_name(nova, name): Returns a flavor by name :param nova: the Nova client :param name: the flavor name to return - :return: the OpenStack flavor object or None if not exists + :return: the SNAPS flavor domain object or None if not exists """ - try: - return nova.flavors.find(name=name) - except NotFound: - return None + os_flavor = __get_os_flavor_by_name(nova, name) + if os_flavor: + return Flavor( + name=os_flavor.name, id=os_flavor.id, ram=os_flavor.ram, + disk=os_flavor.disk, vcpus=os_flavor.vcpus, + ephemeral=os_flavor.ephemeral, swap=os_flavor.swap, + rxtx_factor=os_flavor.rxtx_factor, is_public=os_flavor.is_public) def create_flavor(nova, flavor_settings): @@ -245,21 +551,51 @@ def create_flavor(nova, flavor_settings): Creates and returns and OpenStack flavor object :param nova: the Nova client :param flavor_settings: the flavor settings - :return: the Flavor + :return: the SNAPS flavor domain object """ - return nova.flavors.create(name=flavor_settings.name, flavorid=flavor_settings.flavor_id, ram=flavor_settings.ram, - vcpus=flavor_settings.vcpus, disk=flavor_settings.disk, - ephemeral=flavor_settings.ephemeral, swap=flavor_settings.swap, - rxtx_factor=flavor_settings.rxtx_factor, is_public=flavor_settings.is_public) + os_flavor = nova.flavors.create( + name=flavor_settings.name, flavorid=flavor_settings.flavor_id, + ram=flavor_settings.ram, vcpus=flavor_settings.vcpus, + disk=flavor_settings.disk, ephemeral=flavor_settings.ephemeral, + swap=flavor_settings.swap, rxtx_factor=flavor_settings.rxtx_factor, + is_public=flavor_settings.is_public) + return Flavor( + name=os_flavor.name, id=os_flavor.id, ram=os_flavor.ram, + disk=os_flavor.disk, vcpus=os_flavor.vcpus, + ephemeral=os_flavor.ephemeral, swap=os_flavor.swap, + rxtx_factor=os_flavor.rxtx_factor, is_public=os_flavor.is_public) def delete_flavor(nova, flavor): """ Deletes a flavor :param nova: the Nova client - :param flavor: the OpenStack flavor object + :param flavor: the SNAPS flavor domain object """ - nova.flavors.delete(flavor) + nova.flavors.delete(flavor.id) + + +def set_flavor_keys(nova, flavor, metadata): + """ + Sets metadata on the flavor + :param nova: the Nova client + :param flavor: the SNAPS flavor domain object + :param metadata: the metadata to set + """ + os_flavor = __get_os_flavor(nova, flavor.id) + if os_flavor: + os_flavor.set_keys(metadata) + + +def get_flavor_keys(nova, flavor): + """ + Sets metadata on the flavor + :param nova: the Nova client + :param flavor: the SNAPS flavor domain object + """ + os_flavor = __get_os_flavor(nova, flavor.id) + if os_flavor: + return os_flavor.get_keys() def add_security_group(nova, vm, security_group_name): @@ -269,7 +605,7 @@ def add_security_group(nova, vm, security_group_name): :param vm: the OpenStack server object (VM) to alter :param security_group_name: the name of the security group to add """ - nova.servers.add_security_group(vm.id, security_group_name) + nova.servers.add_security_group(str(vm.id), security_group_name) def remove_security_group(nova, vm, security_group): @@ -277,6 +613,113 @@ def remove_security_group(nova, vm, security_group): Removes a security group from an existing VM :param nova: the nova client :param vm: the OpenStack server object (VM) to alter - :param security_group: the OpenStack security group object to add + :param security_group: the SNAPS SecurityGroup domain object to add + """ + nova.servers.remove_security_group(str(vm.id), security_group.name) + + +def add_floating_ip_to_server(nova, vm, floating_ip, ip_addr): + """ + Adds a floating IP to a server instance + :param nova: the nova client + :param vm: VmInst domain object + :param floating_ip: FloatingIp domain object + :param ip_addr: the IP to which to bind the floating IP to + """ + vm = __get_latest_server_os_object(nova, vm) + vm.add_floating_ip(floating_ip.ip, ip_addr) + + +def get_compute_quotas(nova, project_id): + """ + Returns a list of all available keypairs + :param nova: the Nova client + :param project_id: the project's ID of the quotas to lookup + :return: an object of type ComputeQuotas or None if not found + """ + quotas = nova.quotas.get(tenant_id=project_id) + if quotas: + return ComputeQuotas(quotas) + + +def update_quotas(nova, project_id, compute_quotas): + """ + Updates the compute quotas for a given project + :param nova: the Nova client + :param project_id: the project's ID that requires quota updates + :param compute_quotas: an object of type ComputeQuotas containing the + values to update + :return: + """ + update_values = dict() + update_values['metadata_items'] = compute_quotas.metadata_items + update_values['cores'] = compute_quotas.cores + update_values['instances'] = compute_quotas.instances + update_values['injected_files'] = compute_quotas.injected_files + update_values['injected_file_content_bytes'] = ( + compute_quotas.injected_file_content_bytes) + update_values['ram'] = compute_quotas.ram + update_values['fixed_ips'] = compute_quotas.fixed_ips + update_values['key_pairs'] = compute_quotas.key_pairs + + return nova.quotas.update(project_id, **update_values) + + +def attach_volume(nova, server, volume, timeout=None): + """ + Attaches a volume to a server + :param nova: the nova client + :param server: the VMInst domain object + :param volume: the Volume domain object + :param timeout: denotes the amount of time to block to determine if the + has been properly attached. When None, do not wait. + :return: the value from the nova call + """ + nova.volumes.create_server_volume(server.id, volume.id) + + if timeout: + start_time = time.time() + while time.time() < start_time + timeout: + vm = get_server_object_by_id(nova, server.id) + for vol_dict in vm.volume_ids: + if volume.id == vol_dict['id']: + return vm + + return None + else: + return get_server_object_by_id(nova, server.id) + + +def detach_volume(nova, server, volume, timeout=None): + """ + Attaches a volume to a server + :param nova: the nova client + :param server: the VMInst domain object + :param volume: the Volume domain object + :param timeout: denotes the amount of time to block to determine if the + has been properly detached. When None, do not wait. + :return: the value from the nova call + """ + nova.volumes.delete_server_volume(server.id, volume.id) + + if timeout: + start_time = time.time() + while time.time() < start_time + timeout: + vm = get_server_object_by_id(nova, server.id) + found = False + for vol_dict in vm.volume_ids: + if volume.id == vol_dict['id']: + found = True + + if not found: + return vm + + return None + else: + return get_server_object_by_id(nova, server.id) + + +class NovaException(Exception): + """ + Exception when calls to the Keystone client cannot be served properly """ - nova.servers.remove_security_group(vm.id, security_group)