X-Git-Url: https://gerrit.opnfv.org/gerrit/gitweb?a=blobdiff_plain;f=kernel%2Fdrivers%2Fvideo%2Ffbdev%2Fbroadsheetfb.c;fp=kernel%2Fdrivers%2Fvideo%2Ffbdev%2Fbroadsheetfb.c;h=9f9a7bef1ff6d46d80fe8cb6dcfeea5a3e26729d;hb=e09b41010ba33a20a87472ee821fa407a5b8da36;hp=0e5fde1d3ffbe5a152035f33063afa98bf84f33e;hpb=f93b97fd65072de626c074dbe099a1fff05ce060;p=kvmfornfv.git

diff --git a/kernel/drivers/video/fbdev/broadsheetfb.c b/kernel/drivers/video/fbdev/broadsheetfb.c
index 0e5fde1d3..9f9a7bef1 100644
--- a/kernel/drivers/video/fbdev/broadsheetfb.c
+++ b/kernel/drivers/video/fbdev/broadsheetfb.c
@@ -752,7 +752,7 @@ static ssize_t broadsheet_loadstore_waveform(struct device *dev,
 	if ((fw_entry->size < 8*1024) || (fw_entry->size > 64*1024)) {
 		dev_err(dev, "Invalid waveform\n");
 		err = -EINVAL;
-		goto err_failed;
+		goto err_fw;
 	}
 
 	mutex_lock(&(par->io_lock));
@@ -762,13 +762,15 @@ static ssize_t broadsheet_loadstore_waveform(struct device *dev,
 	mutex_unlock(&(par->io_lock));
 	if (err < 0) {
 		dev_err(dev, "Failed to store broadsheet waveform\n");
-		goto err_failed;
+		goto err_fw;
 	}
 
 	dev_info(dev, "Stored broadsheet waveform, size %zd\n", fw_entry->size);
 
-	return len;
+	err = len;
 
+err_fw:
+	release_firmware(fw_entry);
 err_failed:
 	return err;
 }