X-Git-Url: https://gerrit.opnfv.org/gerrit/gitweb?a=blobdiff_plain;f=functest%2Ftests%2Funit%2Fopenstack%2Ftempest%2Ftest_tempest.py;h=060a8a010c87f9e4730c1e0839c0db905a6a98bd;hb=d589e4e5345ed82c68d9a011ac89f8cdbefe2ca3;hp=54d7d49bbdd688201a7a101a9beb568255abc61d;hpb=1b7322ab8290b55b1869ac913442070ebe6df2a5;p=functest.git diff --git a/functest/tests/unit/openstack/tempest/test_tempest.py b/functest/tests/unit/openstack/tempest/test_tempest.py index 54d7d49bb..060a8a010 100644 --- a/functest/tests/unit/openstack/tempest/test_tempest.py +++ b/functest/tests/unit/openstack/tempest/test_tempest.py @@ -5,7 +5,10 @@ # which accompanies this distribution, and is available at # http://www.apache.org/licenses/LICENSE-2.0 +# pylint: disable=missing-docstring + import logging +import os import unittest import mock @@ -13,7 +16,6 @@ import mock from functest.core import testcase from functest.opnfv_tests.openstack.tempest import tempest from functest.opnfv_tests.openstack.tempest import conf_utils -from functest.utils.constants import CONST from snaps.openstack.os_credentials import OSCreds @@ -37,7 +39,8 @@ class OSTempestTesting(unittest.TestCase): mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' 'conf_utils.get_verifier_deployment_dir', return_value='test_verifier_deploy_dir'), \ - mock.patch('snaps.openstack.tests.openstack_tests.get_credentials', + mock.patch('functest.opnfv_tests.openstack.snaps.snaps_utils.' + 'get_credentials', return_value=os_creds): self.tempestcommon = tempest.TempestCommon() self.tempestsmoke_serial = tempest.TempestSmokeSerial() @@ -46,20 +49,21 @@ class OSTempestTesting(unittest.TestCase): self.tempestcustom = tempest.TempestCustom() self.tempestdefcore = tempest.TempestDefcore() - @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.logger.debug') - def test_generate_test_list_defcore_mode(self, mock_logger_debug): - self.tempestcommon.MODE = 'defcore' + @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.LOGGER.debug') + def test_gen_tl_defcore_mode(self, mock_logger_debug): + # pylint: disable=unused-argument + self.tempestcommon.mode = 'defcore' with mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' - 'shutil.copyfile') as m: + 'shutil.copyfile') as mock_copyfile: self.tempestcommon.generate_test_list('test_verifier_repo_dir') - self.assertTrue(m.called) - - @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.logger.error') - @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.logger.debug') - def test_generate_test_list_custom_mode_missing_file(self, - mock_logger_debug, - mock_logger_error): - self.tempestcommon.MODE = 'custom' + self.assertTrue(mock_copyfile.called) + + @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.LOGGER.error') + @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.LOGGER.debug') + def test_gen_tl_cm_missing_file(self, mock_logger_debug, + mock_logger_error): + # pylint: disable=unused-argument + self.tempestcommon.mode = 'custom' with mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' 'os.path.isfile', return_value=False), \ self.assertRaises(Exception) as context: @@ -67,93 +71,92 @@ class OSTempestTesting(unittest.TestCase): self.tempestcommon.generate_test_list('test_verifier_repo_dir') self.assertTrue((msg % conf_utils.TEMPEST_CUSTOM) in context) - def test_generate_test_list_custom_mode_default(self): - self.tempestcommon.MODE = 'custom' + def test_gen_tl_cm_default(self): + self.tempestcommon.mode = 'custom' with mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' - 'shutil.copyfile') as m, \ + 'shutil.copyfile') as mock_copyfile, \ mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' 'os.path.isfile', return_value=True): self.tempestcommon.generate_test_list('test_verifier_repo_dir') - self.assertTrue(m.called) + self.assertTrue(mock_copyfile.called) - def _test_generate_test_list_mode_default(self, mode): - self.tempestcommon.MODE = mode - if self.tempestcommon.MODE == 'smoke': + def _test_gen_tl_mode_default(self, mode): + self.tempestcommon.mode = mode + if self.tempestcommon.mode == 'smoke': testr_mode = "smoke" - elif self.tempestcommon.MODE == 'full': + elif self.tempestcommon.mode == 'full': testr_mode = "" else: - testr_mode = 'tempest.api.' + self.tempestcommon.MODE + testr_mode = 'tempest.api.' + self.tempestcommon.mode conf_utils.TEMPEST_RAW_LIST = 'raw_list' verifier_repo_dir = 'test_verifier_repo_dir' with mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' - 'ft_utils.execute_command') as m: + 'ft_utils.execute_command') as mock_exec: cmd = ("cd {0};" "testr list-tests {1} > {2};" - "cd -;".format(verifier_repo_dir, - testr_mode, + "cd -;".format(verifier_repo_dir, testr_mode, conf_utils.TEMPEST_RAW_LIST)) self.tempestcommon.generate_test_list('test_verifier_repo_dir') - m.assert_any_call(cmd) + mock_exec.assert_any_call(cmd) - def test_generate_test_list_smoke_mode(self): - self._test_generate_test_list_mode_default('smoke') + def test_gen_tl_smoke_mode(self): + self._test_gen_tl_mode_default('smoke') - def test_generate_test_list_full_mode(self): - self._test_generate_test_list_mode_default('full') + def test_gen_tl_full_mode(self): + self._test_gen_tl_mode_default('full') - def test_parse_verifier_result_missing_verification_uuid(self): - self.tempestcommon.VERIFICATION_ID = None + def test_verif_res_missing_verif_id(self): + self.tempestcommon.verification_id = None with self.assertRaises(Exception): self.tempestcommon.parse_verifier_result() - def test_apply_tempest_blacklist_no_blacklist(self): - with mock.patch('__builtin__.open', mock.mock_open()) as m, \ + def test_apply_missing_blacklist(self): + with mock.patch('__builtin__.open', mock.mock_open()) as mock_open, \ mock.patch.object(self.tempestcommon, 'read_file', return_value=['test1', 'test2']): conf_utils.TEMPEST_BLACKLIST = Exception - CONST.__setattr__('INSTALLER_TYPE', 'installer_type') - CONST.__setattr__('DEPLOY_SCENARIO', 'deploy_scenario') + os.environ['INSTALLER_TYPE'] = 'installer_type' + os.environ['DEPLOY_SCENARIO'] = 'deploy_scenario' self.tempestcommon.apply_tempest_blacklist() - obj = m() + obj = mock_open() obj.write.assert_any_call('test1\n') obj.write.assert_any_call('test2\n') - def test_apply_tempest_blacklist_default(self): + def test_apply_blacklist_default(self): item_dict = {'scenarios': ['deploy_scenario'], 'installers': ['installer_type'], 'tests': ['test2']} - with mock.patch('__builtin__.open', mock.mock_open()) as m, \ + with mock.patch('__builtin__.open', mock.mock_open()) as mock_open, \ mock.patch.object(self.tempestcommon, 'read_file', return_value=['test1', 'test2']), \ mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' 'yaml.safe_load', return_value=item_dict): - CONST.__setattr__('INSTALLER_TYPE', 'installer_type') - CONST.__setattr__('DEPLOY_SCENARIO', 'deploy_scenario') + os.environ['INSTALLER_TYPE'] = 'installer_type' + os.environ['DEPLOY_SCENARIO'] = 'deploy_scenario' self.tempestcommon.apply_tempest_blacklist() - obj = m() + obj = mock_open() obj.write.assert_any_call('test1\n') self.assertFalse(obj.write.assert_any_call('test2\n')) - @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.logger.info') + @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.LOGGER.info') def test_run_verifier_tests_default(self, mock_logger_info): with mock.patch('__builtin__.open', mock.mock_open()), \ - mock.patch('__builtin__.iter', return_value=['\} tempest\.']), \ + mock.patch('__builtin__.iter', return_value=[r'\} tempest\.']), \ mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' 'subprocess.Popen'): conf_utils.TEMPEST_LIST = 'test_tempest_list' - cmd_line = ("rally verify start --load-list " - "test_tempest_list --detailed") + cmd = ["rally", "verify", "start", "--load-list", + conf_utils.TEMPEST_LIST] self.tempestcommon.run_verifier_tests() mock_logger_info. \ - assert_any_call("Starting Tempest test suite: '%s'." - % cmd_line) + assert_any_call("Starting Tempest test suite: '%s'.", cmd) @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' 'os.path.exists', return_value=False) @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.os.makedirs', side_effect=Exception) def test_run_makedirs_ko(self, *args): + # pylint: disable=unused-argument self.assertEqual(self.tempestcommon.run(), testcase.TestCase.EX_RUN_ERROR) @@ -162,7 +165,20 @@ class OSTempestTesting(unittest.TestCase): @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.os.makedirs') @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' 'TempestResourcesManager.create', side_effect=Exception) - def test_run_tempest_create_resources_ko(self, *args): + def test_run_create_resources_ko(self, *args): + # pylint: disable=unused-argument + self.assertEqual(self.tempestcommon.run(), + testcase.TestCase.EX_RUN_ERROR) + + @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os.path.exists', return_value=False) + @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.os.makedirs') + @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'TempestResourcesManager.create', return_value={}) + @mock.patch('functest.opnfv_tests.openstack.snaps.snaps_utils.' + 'get_active_compute_cnt', side_effect=Exception) + def test_run_get_active_comp_cnt_ko(self, *args): + # pylint: disable=unused-argument self.assertEqual(self.tempestcommon.run(), testcase.TestCase.EX_RUN_ERROR) @@ -171,9 +187,12 @@ class OSTempestTesting(unittest.TestCase): @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.os.makedirs') @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' 'TempestResourcesManager.create', return_value={}) + @mock.patch('functest.opnfv_tests.openstack.snaps.snaps_utils.' + 'get_active_compute_cnt', return_value=2) @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' 'conf_utils.configure_tempest', side_effect=Exception) def test_run_configure_tempest_ko(self, *args): + # pylint: disable=unused-argument self.assertEqual(self.tempestcommon.run(), testcase.TestCase.EX_RUN_ERROR) @@ -182,24 +201,27 @@ class OSTempestTesting(unittest.TestCase): @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.os.makedirs') @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' 'TempestResourcesManager.create', return_value={}) + @mock.patch('functest.opnfv_tests.openstack.snaps.snaps_utils.' + 'get_active_compute_cnt', return_value=2) @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' 'conf_utils.configure_tempest') def _test_run(self, status, *args): + # pylint: disable=unused-argument self.assertEqual(self.tempestcommon.run(), status) - def test_run_missing_generate_test_list(self): + def test_run_missing_gen_test_list(self): with mock.patch.object(self.tempestcommon, 'generate_test_list', side_effect=Exception): self._test_run(testcase.TestCase.EX_RUN_ERROR) - def test_run_apply_tempest_blacklist_ko(self): + def test_run_apply_blacklist_ko(self): with mock.patch.object(self.tempestcommon, 'generate_test_list'), \ mock.patch.object(self.tempestcommon, 'apply_tempest_blacklist', side_effect=Exception()): self._test_run(testcase.TestCase.EX_RUN_ERROR) - def test_run_verifier_tests_ko(self, *args): + def test_run_verifier_tests_ko(self): with mock.patch.object(self.tempestcommon, 'generate_test_list'), \ mock.patch.object(self.tempestcommon, 'apply_tempest_blacklist'), \ @@ -209,7 +231,7 @@ class OSTempestTesting(unittest.TestCase): side_effect=Exception): self._test_run(testcase.TestCase.EX_RUN_ERROR) - def test_run_parse_verifier_result_ko(self, *args): + def test_run_verif_result_ko(self): with mock.patch.object(self.tempestcommon, 'generate_test_list'), \ mock.patch.object(self.tempestcommon, 'apply_tempest_blacklist'), \ @@ -218,7 +240,7 @@ class OSTempestTesting(unittest.TestCase): side_effect=Exception): self._test_run(testcase.TestCase.EX_RUN_ERROR) - def test_run(self, *args): + def test_run(self): with mock.patch.object(self.tempestcommon, 'generate_test_list'), \ mock.patch.object(self.tempestcommon, 'apply_tempest_blacklist'), \