X-Git-Url: https://gerrit.opnfv.org/gerrit/gitweb?a=blobdiff_plain;f=functest%2Fci%2Ftier_builder.py;h=370ab94d9becf504f0f44f5edc6f38634772ce33;hb=3009b15820e4eede5d52090146581c8aaf1eb0bc;hp=d2722dc224b639ff226fd26b9c90f00d41ab6ba1;hpb=16b9a69410fd0aaa9a55b023997bb3872ee5907d;p=functest.git

diff --git a/functest/ci/tier_builder.py b/functest/ci/tier_builder.py
index d2722dc22..370ab94d9 100644
--- a/functest/ci/tier_builder.py
+++ b/functest/ci/tier_builder.py
@@ -7,11 +7,15 @@
 # which accompanies this distribution, and is available at
 # http://www.apache.org/licenses/LICENSE-2.0
 
-import tier_handler as th
+"""TierBuilder class to parse testcases config file"""
+
 import yaml
 
+import functest.ci.tier_handler as th
+
 
 class TierBuilder(object):
+    # pylint: disable=missing-docstring
 
     def __init__(self, ci_installer, ci_scenario, testcases_file):
         self.ci_installer = ci_installer
@@ -23,8 +27,8 @@ class TierBuilder(object):
         self.generate_tiers()
 
     def read_test_yaml(self):
-        with open(self.testcases_file) as f:
-            self.testcases_yaml = yaml.safe_load(f)
+        with open(self.testcases_file) as tc_file:
+            self.testcases_yaml = yaml.safe_load(tc_file)
 
         self.dic_tier_array = []
         for tier in self.testcases_yaml.get("tiers"):
@@ -36,24 +40,23 @@ class TierBuilder(object):
 
         del self.tier_objects[:]
         for dic_tier in self.dic_tier_array:
-            tier = th.Tier(name=dic_tier['name'],
-                           order=dic_tier['order'],
-                           ci_loop=dic_tier['ci_loop'],
-                           description=dic_tier['description'])
+            tier = th.Tier(
+                name=dic_tier['name'], order=dic_tier['order'],
+                ci_loop=dic_tier['ci_loop'],
+                description=dic_tier['description'])
 
             for dic_testcase in dic_tier['testcases']:
                 installer = dic_testcase['dependencies']['installer']
                 scenario = dic_testcase['dependencies']['scenario']
                 dep = th.Dependency(installer, scenario)
 
-                testcase = th.TestCase(name=dic_testcase['case_name'],
-                                       enabled=dic_testcase.get(
-                                           'enabled', True),
-                                       dependency=dep,
-                                       criteria=dic_testcase['criteria'],
-                                       blocking=dic_testcase['blocking'],
-                                       description=dic_testcase['description'],
-                                       project=dic_testcase['project_name'])
+                testcase = th.TestCase(
+                    name=dic_testcase['case_name'],
+                    enabled=dic_testcase.get('enabled', True),
+                    dependency=dep, criteria=dic_testcase['criteria'],
+                    blocking=dic_testcase['blocking'],
+                    description=dic_testcase['description'],
+                    project=dic_testcase['project_name'])
                 if (testcase.is_compatible(self.ci_installer,
                                            self.ci_scenario) and
                         testcase.is_enabled()):