Adapt SDNVPN Functest test according to new framework
[sdnvpn.git] / sdnvpn / test / functest / testcase_3.py
index 8a8aa30..44e7366 100644 (file)
@@ -1,4 +1,3 @@
-#
 # Copyright (c) 2017 All rights reserved
 # This program and the accompanying materials
 # are made available under the terms of the Apache License, Version 2.0
 #   - Start a BGP router with OpenDaylight
 #   - Add the functest Quagga as a neighbor
 #   - Verify that the OpenDaylight and gateway Quagga peer
+
+import logging
 import os
-import argparse
+import sys
 
+from functest.utils import functest_utils as ft_utils
+from functest.utils import openstack_utils as os_utils
 from sdnvpn.lib import quagga
-import sdnvpn.lib.utils as test_utils
-import sdnvpn.lib.config as sdnvpn_config
+from sdnvpn.lib import utils as test_utils
+from sdnvpn.lib import config as sdnvpn_config
+from sdnvpn.lib.results import Results
 
-import functest.utils.openstack_utils as os_utils
-import functest.utils.functest_utils as ft_utils
-import functest.utils.functest_logger as ft_logger
 
-from sdnvpn.lib.results import Results
+logger = logging.getLogger(__name__)
 
 COMMON_CONFIG = sdnvpn_config.CommonConfig()
 TESTCASE_CONFIG = sdnvpn_config.TestcaseConfig("testcase_3")
 
-logger = ft_logger.Logger("sdnvpn-testcase-3").getLogger()
-
-parser = argparse.ArgumentParser()
-
-parser.add_argument("-r", "--report",
-                    help="Create json result file",
-                    action="store_true")
-
-args = parser.parse_args()
-
 
 def main():
     results = Results(COMMON_CONFIG.line_length)
@@ -47,9 +38,13 @@ def main():
 
     openstack_nodes = test_utils.get_nodes()
 
+    # node.is_odl() doesn't work in Apex
+    # https://jira.opnfv.org/browse/RELENG-192
     controllers = [node for node in openstack_nodes
-                   if node.is_odl()]
+                   if "running" in
+                   node.run_cmd("sudo systemctl status opendaylight")]
     computes = [node for node in openstack_nodes if node.is_compute()]
+
     msg = ("Verify that OpenDaylight can start/communicate with zrpcd/Quagga")
     results.record_action(msg)
     results.add_to_summary(0, "-")
@@ -64,14 +59,17 @@ def main():
         results.add_success(msg)
 
     controller = controllers[0]  # We don't handle HA well
-    get_ext_ip_cmd = "ip a | grep br-ex | grep inet | awk '{print $2}'"
-    controller_ext_ip = controller.run_cmd(get_ext_ip_cmd).split("/")[0]
+    get_ext_ip_cmd = "sudo ip a | grep br-ex | grep inet | awk '{print $2}'"
+    ext_net_cidr = controller.run_cmd(get_ext_ip_cmd).strip().split('\n')
+    ext_net_mask = ext_net_cidr[0].split('/')[1]
+    controller_ext_ip = ext_net_cidr[0].split('/')[0]
+
     logger.info("Starting bgp speaker of controller at IP %s "
                 % controller_ext_ip)
     logger.info("Checking if zrpcd is "
                 "running on the controller node")
 
-    cmd = "systemctl status zrpcd"
+    cmd = "systemctl status zrpcd |grep -i running"
     output = controller.run_cmd(cmd)
     msg = ("zrpcd is running")
 
@@ -133,8 +131,8 @@ def main():
     if not os.path.isfile(COMMON_CONFIG.ubuntu_image_path):
         logger.info("Downloading image")
         ft_utils.download_url(
-            "https://cloud-images.ubuntu.com/releases/16.04/"
-            "release/ubuntu-16.04-server-cloudimg-amd64-disk1.img",
+            "http://artifacts.opnfv.org/sdnvpn/"
+            "ubuntu-16.04-server-cloudimg-amd64-disk1.img",
             "/home/opnfv/functest/data/")
     else:
         logger.info("Using old image")
@@ -143,32 +141,55 @@ def main():
     nova_client = os_utils.get_nova_client()
     neutron_client = os_utils.get_neutron_client()
 
+    (floatingip_ids, instance_ids, router_ids, network_ids, image_ids,
+     subnet_ids, interfaces, bgpvpn_ids) = ([] for i in range(8))
+
     sg_id = os_utils.create_security_group_full(neutron_client,
                                                 TESTCASE_CONFIG.secgroup_name,
                                                 TESTCASE_CONFIG.secgroup_descr)
-    test_utils.open_icmp_ssh(neutron_client, sg_id)
-    test_utils.open_bgp_port(neutron_client, sg_id)
-    net_id, _, _ = test_utils.create_network(neutron_client,
-                                             TESTCASE_CONFIG.net_1_name,
-                                             TESTCASE_CONFIG.subnet_1_name,
-                                             TESTCASE_CONFIG.subnet_1_cidr,
-                                             TESTCASE_CONFIG.router_1_name)
+    test_utils.open_icmp(neutron_client, sg_id)
+    test_utils.open_http_port(neutron_client, sg_id)
 
-    quagga_net_id, _, _ = test_utils.create_network(
+    test_utils.open_bgp_port(neutron_client, sg_id)
+    net_id, subnet_1_id, router_1_id = test_utils.create_network(
         neutron_client,
-        TESTCASE_CONFIG.quagga_net_name,
-        TESTCASE_CONFIG.quagga_subnet_name,
-        TESTCASE_CONFIG.quagga_subnet_cidr,
-        TESTCASE_CONFIG.quagga_router_name)
+        TESTCASE_CONFIG.net_1_name,
+        TESTCASE_CONFIG.subnet_1_name,
+        TESTCASE_CONFIG.subnet_1_cidr,
+        TESTCASE_CONFIG.router_1_name)
+
+    quagga_net_id, subnet_quagga_id, \
+        router_quagga_id = test_utils.create_network(
+            neutron_client,
+            TESTCASE_CONFIG.quagga_net_name,
+            TESTCASE_CONFIG.quagga_subnet_name,
+            TESTCASE_CONFIG.quagga_subnet_cidr,
+            TESTCASE_CONFIG.quagga_router_name)
+
+    interfaces.append(tuple((router_1_id, subnet_1_id)))
+    interfaces.append(tuple((router_quagga_id, subnet_quagga_id)))
+    network_ids.extend([net_id, quagga_net_id])
+    router_ids.extend([router_1_id, router_quagga_id])
+    subnet_ids.extend([subnet_1_id, subnet_quagga_id])
+
+    installer_type = str(os.environ['INSTALLER_TYPE'].lower())
+    if installer_type == "fuel":
+        disk = 'raw'
+    elif installer_type == "apex":
+        disk = 'qcow2'
+    else:
+        logger.error("Incompatible installer type")
 
     ubuntu_image_id = os_utils.create_glance_image(
         glance_client,
         COMMON_CONFIG.ubuntu_image_name,
         COMMON_CONFIG.ubuntu_image_path,
-        disk="raw",
+        disk,
         container="bare",
         public="public")
 
+    image_ids.append(ubuntu_image_id)
+
     # NOTE(rski) The order of this seems a bit weird but
     # there is a reason for this, namely
     # https://jira.opnfv.org/projects/SDNVPN/issues/SDNVPN-99
@@ -182,23 +203,24 @@ def main():
     # fake_fip is needed to bypass NAT
     # see below for the reason why.
     fake_fip = os_utils.create_floating_ip(neutron_client)
+
+    floatingip_ids.extend([fip['fip_id'], fake_fip['fip_id']])
     # pin quagga to some compute
     compute_node = nova_client.hypervisors.list()[0]
     quagga_compute_node = "nova:" + compute_node.hypervisor_hostname
     # Map the hypervisor used above to a compute handle
     # returned by releng's manager
     for comp in computes:
-        if compute_node.host_ip in comp.run_cmd("ip a"):
+        if compute_node.host_ip in comp.run_cmd("sudo ip a"):
             compute = comp
             break
-    # Get the mask of ext net of the compute where quagga is running
-    # TODO check this works on apex
-    ext_cidr = compute.run_cmd(get_ext_ip_cmd).split("/")
-    ext_net_mask = ext_cidr[1]
     quagga_bootstrap_script = quagga.gen_quagga_setup_script(
         controller_ext_ip,
         fake_fip['fip_addr'],
         ext_net_mask)
+
+    test_utils.create_custom_flavor()
+
     quagga_vm = test_utils.create_instance(
         nova_client,
         TESTCASE_CONFIG.quagga_instance_name,
@@ -206,10 +228,12 @@ def main():
         quagga_net_id,
         sg_id,
         fixed_ip=TESTCASE_CONFIG.quagga_instance_ip,
-        flavor=TESTCASE_CONFIG.quagga_instance_flavor,
+        flavor=COMMON_CONFIG.custom_flavor_name,
         userdata=quagga_bootstrap_script,
         compute_node=quagga_compute_node)
 
+    instance_ids.append(quagga_vm)
+
     fip_added = os_utils.add_floating_ip(nova_client,
                                          quagga_vm.id,
                                          fip['fip_addr'])
@@ -219,40 +243,40 @@ def main():
         results.add_success(msg)
     else:
         results.add_failure(msg)
+    test_utils.attach_instance_to_ext_br(quagga_vm, compute)
 
-    # This part works around NAT
-    # What we do is attach the instance directly to the OpenStack
-    # external network. This way is is directly accessible from the
-    # controller without NAT. We assign a floating IP for this
-    # to make sure no overlaps happen.
-    libvirt_instance_name = getattr(quagga_vm, "OS-EXT-SRV-ATTR:instance_name")
-    compute.run_cmd("virsh attach-interface %s"
-                    " bridge br-ex" % libvirt_instance_name)
-
-    testcase = "Bootstrap quagga inside an OpenStack instance"
-    cloud_init_success = test_utils.wait_for_cloud_init(quagga_vm)
-    if cloud_init_success:
-        results.add_success(testcase)
-    else:
-        results.add_failure(testcase)
-    results.add_to_summary(0, "=")
+    try:
+        testcase = "Bootstrap quagga inside an OpenStack instance"
+        cloud_init_success = test_utils.wait_for_cloud_init(quagga_vm)
+        if cloud_init_success:
+            results.add_success(testcase)
+        else:
+            results.add_failure(testcase)
+        results.add_to_summary(0, "=")
 
-    results.add_to_summary(0, '-')
-    results.add_to_summary(1, "Peer Quagga with OpenDaylight")
-    results.add_to_summary(0, '-')
+        results.add_to_summary(0, '-')
+        results.add_to_summary(1, "Peer Quagga with OpenDaylight")
+        results.add_to_summary(0, '-')
 
-    neighbor = quagga.odl_add_neighbor(fake_fip['fip_addr'],
-                                       controller_ext_ip,
-                                       controller)
-    peer = quagga.check_for_peering(controller)
+        neighbor = quagga.odl_add_neighbor(fake_fip['fip_addr'],
+                                           controller_ext_ip,
+                                           controller)
+        peer = quagga.check_for_peering(controller)
+
+    finally:
+        test_utils.detach_instance_from_ext_br(quagga_vm, compute)
 
     if neighbor and peer:
         results.add_success("Peering with quagga")
     else:
         results.add_failure("Peering with quagga")
 
+    test_utils.cleanup_nova(nova_client, instance_ids, image_ids)
+    test_utils.cleanup_neutron(neutron_client, floatingip_ids, bgpvpn_ids,
+                               interfaces, subnet_ids, router_ids,
+                               network_ids)
     return results.compile_summary()
 
-
 if __name__ == '__main__':
-    main()
+    logging.basicConfig(level=logging.INFO)
+    sys.exit(main())