Adapt the floating ip handling in functest
[sdnvpn.git] / sdnvpn / test / functest / testcase_3.py
index 41f8f70..24d413c 100644 (file)
@@ -11,6 +11,7 @@
 #   - Start a BGP router with OpenDaylight
 #   - Add the functest Quagga as a neighbor
 #   - Verify that the OpenDaylight and gateway Quagga peer
+import logging
 import os
 import argparse
 
@@ -20,14 +21,13 @@ import sdnvpn.lib.config as sdnvpn_config
 
 import functest.utils.openstack_utils as os_utils
 import functest.utils.functest_utils as ft_utils
-import functest.utils.functest_logger as ft_logger
 
 from sdnvpn.lib.results import Results
 
 COMMON_CONFIG = sdnvpn_config.CommonConfig()
 TESTCASE_CONFIG = sdnvpn_config.TestcaseConfig("testcase_3")
 
-logger = ft_logger.Logger("sdnvpn-testcase-3").getLogger()
+logger = logging.getLogger('sdnvpn-testcase-3')
 
 parser = argparse.ArgumentParser()
 
@@ -52,6 +52,7 @@ def main():
                    if "running" in
                    node.run_cmd("sudo systemctl status opendaylight")]
     computes = [node for node in openstack_nodes if node.is_compute()]
+
     msg = ("Verify that OpenDaylight can start/communicate with zrpcd/Quagga")
     results.record_action(msg)
     results.add_to_summary(0, "-")
@@ -71,24 +72,12 @@ def main():
     ext_net_mask = ext_net_cidr[0].split('/')[1]
     controller_ext_ip = ext_net_cidr[0].split('/')[0]
 
-    # TODO This code has to be adapted into Apex quagga rpm spec
-    installer_type = str(os.environ['INSTALLER_TYPE'].lower())
-    if installer_type == "apex":
-        add_quagga_user = 'sudo usermod -a -G quaggavt quagga'
-        test_utils.run_odl_cmd(controller, add_quagga_user)
-
-        create_quagga_run_folder = "sudo mkdir -p /var/run/quagga/"
-        test_utils.run_odl_cmd(controller, create_quagga_run_folder)
-
-        chown_quagga_folder = 'sudo chown quagga:quagga -R /var/run/quagga/'
-        test_utils.run_odl_cmd(controller, chown_quagga_folder)
-
     logger.info("Starting bgp speaker of controller at IP %s "
                 % controller_ext_ip)
     logger.info("Checking if zrpcd is "
                 "running on the controller node")
 
-    cmd = "systemctl status zrpcd"
+    cmd = "systemctl status zrpcd |grep -i running"
     output = controller.run_cmd(cmd)
     msg = ("zrpcd is running")
 
@@ -150,8 +139,8 @@ def main():
     if not os.path.isfile(COMMON_CONFIG.ubuntu_image_path):
         logger.info("Downloading image")
         ft_utils.download_url(
-            "https://cloud-images.ubuntu.com/releases/16.04/"
-            "release/ubuntu-16.04-server-cloudimg-amd64-disk1.img",
+            "http://artifacts.opnfv.org/sdnvpn/"
+            "ubuntu-16.04-server-cloudimg-amd64-disk1.img",
             "/home/opnfv/functest/data/")
     else:
         logger.info("Using old image")
@@ -160,24 +149,38 @@ def main():
     nova_client = os_utils.get_nova_client()
     neutron_client = os_utils.get_neutron_client()
 
+    (floatingip_ids, instance_ids, router_ids, network_ids, image_ids,
+     subnet_ids, interfaces, bgpvpn_ids) = ([] for i in range(8))
+
     sg_id = os_utils.create_security_group_full(neutron_client,
                                                 TESTCASE_CONFIG.secgroup_name,
                                                 TESTCASE_CONFIG.secgroup_descr)
-    test_utils.open_icmp_ssh(neutron_client, sg_id)
-    test_utils.open_bgp_port(neutron_client, sg_id)
-    net_id, _, _ = test_utils.create_network(neutron_client,
-                                             TESTCASE_CONFIG.net_1_name,
-                                             TESTCASE_CONFIG.subnet_1_name,
-                                             TESTCASE_CONFIG.subnet_1_cidr,
-                                             TESTCASE_CONFIG.router_1_name)
+    test_utils.open_icmp(neutron_client, sg_id)
+    test_utils.open_http_port(neutron_client, sg_id)
 
-    quagga_net_id, _, _ = test_utils.create_network(
+    test_utils.open_bgp_port(neutron_client, sg_id)
+    net_id, subnet_1_id, router_1_id = test_utils.create_network(
         neutron_client,
-        TESTCASE_CONFIG.quagga_net_name,
-        TESTCASE_CONFIG.quagga_subnet_name,
-        TESTCASE_CONFIG.quagga_subnet_cidr,
-        TESTCASE_CONFIG.quagga_router_name)
+        TESTCASE_CONFIG.net_1_name,
+        TESTCASE_CONFIG.subnet_1_name,
+        TESTCASE_CONFIG.subnet_1_cidr,
+        TESTCASE_CONFIG.router_1_name)
+
+    quagga_net_id, subnet_quagga_id, \
+        router_quagga_id = test_utils.create_network(
+            neutron_client,
+            TESTCASE_CONFIG.quagga_net_name,
+            TESTCASE_CONFIG.quagga_subnet_name,
+            TESTCASE_CONFIG.quagga_subnet_cidr,
+            TESTCASE_CONFIG.quagga_router_name)
+
+    interfaces.append(tuple((router_1_id, subnet_1_id)))
+    interfaces.append(tuple((router_quagga_id, subnet_quagga_id)))
+    network_ids.extend([net_id, quagga_net_id])
+    router_ids.extend([router_1_id, router_quagga_id])
+    subnet_ids.extend([subnet_1_id, subnet_quagga_id])
 
+    installer_type = str(os.environ['INSTALLER_TYPE'].lower())
     if installer_type == "fuel":
         disk = 'raw'
     elif installer_type == "apex":
@@ -193,6 +196,8 @@ def main():
         container="bare",
         public="public")
 
+    image_ids.append(ubuntu_image_id)
+
     # NOTE(rski) The order of this seems a bit weird but
     # there is a reason for this, namely
     # https://jira.opnfv.org/projects/SDNVPN/issues/SDNVPN-99
@@ -206,6 +211,8 @@ def main():
     # fake_fip is needed to bypass NAT
     # see below for the reason why.
     fake_fip = os_utils.create_floating_ip(neutron_client)
+
+    floatingip_ids.extend([fip['fip_id'], fake_fip['fip_id']])
     # pin quagga to some compute
     compute_node = nova_client.hypervisors.list()[0]
     quagga_compute_node = "nova:" + compute_node.hypervisor_hostname
@@ -233,6 +240,8 @@ def main():
         userdata=quagga_bootstrap_script,
         compute_node=quagga_compute_node)
 
+    instance_ids.append(quagga_vm)
+
     fip_added = os_utils.add_floating_ip(nova_client,
                                          quagga_vm.id,
                                          fip['fip_addr'])
@@ -242,33 +251,40 @@ def main():
         results.add_success(msg)
     else:
         results.add_failure(msg)
-
     test_utils.attach_instance_to_ext_br(quagga_vm, compute)
 
-    testcase = "Bootstrap quagga inside an OpenStack instance"
-    cloud_init_success = test_utils.wait_for_cloud_init(quagga_vm)
-    if cloud_init_success:
-        results.add_success(testcase)
-    else:
-        results.add_failure(testcase)
-    results.add_to_summary(0, "=")
+    try:
+        testcase = "Bootstrap quagga inside an OpenStack instance"
+        cloud_init_success = test_utils.wait_for_cloud_init(quagga_vm)
+        if cloud_init_success:
+            results.add_success(testcase)
+        else:
+            results.add_failure(testcase)
+        results.add_to_summary(0, "=")
 
-    results.add_to_summary(0, '-')
-    results.add_to_summary(1, "Peer Quagga with OpenDaylight")
-    results.add_to_summary(0, '-')
+        results.add_to_summary(0, '-')
+        results.add_to_summary(1, "Peer Quagga with OpenDaylight")
+        results.add_to_summary(0, '-')
 
-    neighbor = quagga.odl_add_neighbor(fake_fip['fip_addr'],
-                                       controller_ext_ip,
-                                       controller)
-    peer = quagga.check_for_peering(controller)
+        neighbor = quagga.odl_add_neighbor(fake_fip['fip_addr'],
+                                           controller_ext_ip,
+                                           controller)
+        peer = quagga.check_for_peering(controller)
+
+    finally:
+        test_utils.detach_instance_from_ext_br(quagga_vm, compute)
 
     if neighbor and peer:
         results.add_success("Peering with quagga")
     else:
         results.add_failure("Peering with quagga")
 
+    test_utils.cleanup_nova(nova_client, instance_ids, image_ids)
+    test_utils.cleanup_neutron(neutron_client, floatingip_ids, bgpvpn_ids,
+                               interfaces, subnet_ids, router_ids,
+                               network_ids)
     return results.compile_summary()
 
-
 if __name__ == '__main__':
+    logging.basicConfig(level=logging.INFO)
     main()