Add the rt linux 4.1.3-rt3 as base
[kvmfornfv.git] / kernel / drivers / net / ethernet / sfc / mcdi_port.c
diff --git a/kernel/drivers/net/ethernet/sfc/mcdi_port.c b/kernel/drivers/net/ethernet/sfc/mcdi_port.c
new file mode 100644 (file)
index 0000000..fb19b70
--- /dev/null
@@ -0,0 +1,1035 @@
+/****************************************************************************
+ * Driver for Solarflare network controllers and boards
+ * Copyright 2009-2013 Solarflare Communications Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 as published
+ * by the Free Software Foundation, incorporated herein by reference.
+ */
+
+/*
+ * Driver for PHY related operations via MCDI.
+ */
+
+#include <linux/slab.h>
+#include "efx.h"
+#include "phy.h"
+#include "mcdi.h"
+#include "mcdi_pcol.h"
+#include "nic.h"
+#include "selftest.h"
+
+struct efx_mcdi_phy_data {
+       u32 flags;
+       u32 type;
+       u32 supported_cap;
+       u32 channel;
+       u32 port;
+       u32 stats_mask;
+       u8 name[20];
+       u32 media;
+       u32 mmd_mask;
+       u8 revision[20];
+       u32 forced_cap;
+};
+
+static int
+efx_mcdi_get_phy_cfg(struct efx_nic *efx, struct efx_mcdi_phy_data *cfg)
+{
+       MCDI_DECLARE_BUF(outbuf, MC_CMD_GET_PHY_CFG_OUT_LEN);
+       size_t outlen;
+       int rc;
+
+       BUILD_BUG_ON(MC_CMD_GET_PHY_CFG_IN_LEN != 0);
+       BUILD_BUG_ON(MC_CMD_GET_PHY_CFG_OUT_NAME_LEN != sizeof(cfg->name));
+
+       rc = efx_mcdi_rpc(efx, MC_CMD_GET_PHY_CFG, NULL, 0,
+                         outbuf, sizeof(outbuf), &outlen);
+       if (rc)
+               goto fail;
+
+       if (outlen < MC_CMD_GET_PHY_CFG_OUT_LEN) {
+               rc = -EIO;
+               goto fail;
+       }
+
+       cfg->flags = MCDI_DWORD(outbuf, GET_PHY_CFG_OUT_FLAGS);
+       cfg->type = MCDI_DWORD(outbuf, GET_PHY_CFG_OUT_TYPE);
+       cfg->supported_cap =
+               MCDI_DWORD(outbuf, GET_PHY_CFG_OUT_SUPPORTED_CAP);
+       cfg->channel = MCDI_DWORD(outbuf, GET_PHY_CFG_OUT_CHANNEL);
+       cfg->port = MCDI_DWORD(outbuf, GET_PHY_CFG_OUT_PRT);
+       cfg->stats_mask = MCDI_DWORD(outbuf, GET_PHY_CFG_OUT_STATS_MASK);
+       memcpy(cfg->name, MCDI_PTR(outbuf, GET_PHY_CFG_OUT_NAME),
+              sizeof(cfg->name));
+       cfg->media = MCDI_DWORD(outbuf, GET_PHY_CFG_OUT_MEDIA_TYPE);
+       cfg->mmd_mask = MCDI_DWORD(outbuf, GET_PHY_CFG_OUT_MMD_MASK);
+       memcpy(cfg->revision, MCDI_PTR(outbuf, GET_PHY_CFG_OUT_REVISION),
+              sizeof(cfg->revision));
+
+       return 0;
+
+fail:
+       netif_err(efx, hw, efx->net_dev, "%s: failed rc=%d\n", __func__, rc);
+       return rc;
+}
+
+static int efx_mcdi_set_link(struct efx_nic *efx, u32 capabilities,
+                            u32 flags, u32 loopback_mode,
+                            u32 loopback_speed)
+{
+       MCDI_DECLARE_BUF(inbuf, MC_CMD_SET_LINK_IN_LEN);
+       int rc;
+
+       BUILD_BUG_ON(MC_CMD_SET_LINK_OUT_LEN != 0);
+
+       MCDI_SET_DWORD(inbuf, SET_LINK_IN_CAP, capabilities);
+       MCDI_SET_DWORD(inbuf, SET_LINK_IN_FLAGS, flags);
+       MCDI_SET_DWORD(inbuf, SET_LINK_IN_LOOPBACK_MODE, loopback_mode);
+       MCDI_SET_DWORD(inbuf, SET_LINK_IN_LOOPBACK_SPEED, loopback_speed);
+
+       rc = efx_mcdi_rpc(efx, MC_CMD_SET_LINK, inbuf, sizeof(inbuf),
+                         NULL, 0, NULL);
+       return rc;
+}
+
+static int efx_mcdi_loopback_modes(struct efx_nic *efx, u64 *loopback_modes)
+{
+       MCDI_DECLARE_BUF(outbuf, MC_CMD_GET_LOOPBACK_MODES_OUT_LEN);
+       size_t outlen;
+       int rc;
+
+       rc = efx_mcdi_rpc(efx, MC_CMD_GET_LOOPBACK_MODES, NULL, 0,
+                         outbuf, sizeof(outbuf), &outlen);
+       if (rc)
+               goto fail;
+
+       if (outlen < (MC_CMD_GET_LOOPBACK_MODES_OUT_SUGGESTED_OFST +
+                     MC_CMD_GET_LOOPBACK_MODES_OUT_SUGGESTED_LEN)) {
+               rc = -EIO;
+               goto fail;
+       }
+
+       *loopback_modes = MCDI_QWORD(outbuf, GET_LOOPBACK_MODES_OUT_SUGGESTED);
+
+       return 0;
+
+fail:
+       netif_err(efx, hw, efx->net_dev, "%s: failed rc=%d\n", __func__, rc);
+       return rc;
+}
+
+static int efx_mcdi_mdio_read(struct net_device *net_dev,
+                             int prtad, int devad, u16 addr)
+{
+       struct efx_nic *efx = netdev_priv(net_dev);
+       MCDI_DECLARE_BUF(inbuf, MC_CMD_MDIO_READ_IN_LEN);
+       MCDI_DECLARE_BUF(outbuf, MC_CMD_MDIO_READ_OUT_LEN);
+       size_t outlen;
+       int rc;
+
+       MCDI_SET_DWORD(inbuf, MDIO_READ_IN_BUS, efx->mdio_bus);
+       MCDI_SET_DWORD(inbuf, MDIO_READ_IN_PRTAD, prtad);
+       MCDI_SET_DWORD(inbuf, MDIO_READ_IN_DEVAD, devad);
+       MCDI_SET_DWORD(inbuf, MDIO_READ_IN_ADDR, addr);
+
+       rc = efx_mcdi_rpc(efx, MC_CMD_MDIO_READ, inbuf, sizeof(inbuf),
+                         outbuf, sizeof(outbuf), &outlen);
+       if (rc)
+               return rc;
+
+       if (MCDI_DWORD(outbuf, MDIO_READ_OUT_STATUS) !=
+           MC_CMD_MDIO_STATUS_GOOD)
+               return -EIO;
+
+       return (u16)MCDI_DWORD(outbuf, MDIO_READ_OUT_VALUE);
+}
+
+static int efx_mcdi_mdio_write(struct net_device *net_dev,
+                              int prtad, int devad, u16 addr, u16 value)
+{
+       struct efx_nic *efx = netdev_priv(net_dev);
+       MCDI_DECLARE_BUF(inbuf, MC_CMD_MDIO_WRITE_IN_LEN);
+       MCDI_DECLARE_BUF(outbuf, MC_CMD_MDIO_WRITE_OUT_LEN);
+       size_t outlen;
+       int rc;
+
+       MCDI_SET_DWORD(inbuf, MDIO_WRITE_IN_BUS, efx->mdio_bus);
+       MCDI_SET_DWORD(inbuf, MDIO_WRITE_IN_PRTAD, prtad);
+       MCDI_SET_DWORD(inbuf, MDIO_WRITE_IN_DEVAD, devad);
+       MCDI_SET_DWORD(inbuf, MDIO_WRITE_IN_ADDR, addr);
+       MCDI_SET_DWORD(inbuf, MDIO_WRITE_IN_VALUE, value);
+
+       rc = efx_mcdi_rpc(efx, MC_CMD_MDIO_WRITE, inbuf, sizeof(inbuf),
+                         outbuf, sizeof(outbuf), &outlen);
+       if (rc)
+               return rc;
+
+       if (MCDI_DWORD(outbuf, MDIO_WRITE_OUT_STATUS) !=
+           MC_CMD_MDIO_STATUS_GOOD)
+               return -EIO;
+
+       return 0;
+}
+
+static u32 mcdi_to_ethtool_cap(u32 media, u32 cap)
+{
+       u32 result = 0;
+
+       switch (media) {
+       case MC_CMD_MEDIA_KX4:
+               result |= SUPPORTED_Backplane;
+               if (cap & (1 << MC_CMD_PHY_CAP_1000FDX_LBN))
+                       result |= SUPPORTED_1000baseKX_Full;
+               if (cap & (1 << MC_CMD_PHY_CAP_10000FDX_LBN))
+                       result |= SUPPORTED_10000baseKX4_Full;
+               if (cap & (1 << MC_CMD_PHY_CAP_40000FDX_LBN))
+                       result |= SUPPORTED_40000baseKR4_Full;
+               break;
+
+       case MC_CMD_MEDIA_XFP:
+       case MC_CMD_MEDIA_SFP_PLUS:
+               result |= SUPPORTED_FIBRE;
+               break;
+
+       case MC_CMD_MEDIA_QSFP_PLUS:
+               result |= SUPPORTED_FIBRE;
+               if (cap & (1 << MC_CMD_PHY_CAP_40000FDX_LBN))
+                       result |= SUPPORTED_40000baseCR4_Full;
+               break;
+
+       case MC_CMD_MEDIA_BASE_T:
+               result |= SUPPORTED_TP;
+               if (cap & (1 << MC_CMD_PHY_CAP_10HDX_LBN))
+                       result |= SUPPORTED_10baseT_Half;
+               if (cap & (1 << MC_CMD_PHY_CAP_10FDX_LBN))
+                       result |= SUPPORTED_10baseT_Full;
+               if (cap & (1 << MC_CMD_PHY_CAP_100HDX_LBN))
+                       result |= SUPPORTED_100baseT_Half;
+               if (cap & (1 << MC_CMD_PHY_CAP_100FDX_LBN))
+                       result |= SUPPORTED_100baseT_Full;
+               if (cap & (1 << MC_CMD_PHY_CAP_1000HDX_LBN))
+                       result |= SUPPORTED_1000baseT_Half;
+               if (cap & (1 << MC_CMD_PHY_CAP_1000FDX_LBN))
+                       result |= SUPPORTED_1000baseT_Full;
+               if (cap & (1 << MC_CMD_PHY_CAP_10000FDX_LBN))
+                       result |= SUPPORTED_10000baseT_Full;
+               break;
+       }
+
+       if (cap & (1 << MC_CMD_PHY_CAP_PAUSE_LBN))
+               result |= SUPPORTED_Pause;
+       if (cap & (1 << MC_CMD_PHY_CAP_ASYM_LBN))
+               result |= SUPPORTED_Asym_Pause;
+       if (cap & (1 << MC_CMD_PHY_CAP_AN_LBN))
+               result |= SUPPORTED_Autoneg;
+
+       return result;
+}
+
+static u32 ethtool_to_mcdi_cap(u32 cap)
+{
+       u32 result = 0;
+
+       if (cap & SUPPORTED_10baseT_Half)
+               result |= (1 << MC_CMD_PHY_CAP_10HDX_LBN);
+       if (cap & SUPPORTED_10baseT_Full)
+               result |= (1 << MC_CMD_PHY_CAP_10FDX_LBN);
+       if (cap & SUPPORTED_100baseT_Half)
+               result |= (1 << MC_CMD_PHY_CAP_100HDX_LBN);
+       if (cap & SUPPORTED_100baseT_Full)
+               result |= (1 << MC_CMD_PHY_CAP_100FDX_LBN);
+       if (cap & SUPPORTED_1000baseT_Half)
+               result |= (1 << MC_CMD_PHY_CAP_1000HDX_LBN);
+       if (cap & (SUPPORTED_1000baseT_Full | SUPPORTED_1000baseKX_Full))
+               result |= (1 << MC_CMD_PHY_CAP_1000FDX_LBN);
+       if (cap & (SUPPORTED_10000baseT_Full | SUPPORTED_10000baseKX4_Full))
+               result |= (1 << MC_CMD_PHY_CAP_10000FDX_LBN);
+       if (cap & (SUPPORTED_40000baseCR4_Full | SUPPORTED_40000baseKR4_Full))
+               result |= (1 << MC_CMD_PHY_CAP_40000FDX_LBN);
+       if (cap & SUPPORTED_Pause)
+               result |= (1 << MC_CMD_PHY_CAP_PAUSE_LBN);
+       if (cap & SUPPORTED_Asym_Pause)
+               result |= (1 << MC_CMD_PHY_CAP_ASYM_LBN);
+       if (cap & SUPPORTED_Autoneg)
+               result |= (1 << MC_CMD_PHY_CAP_AN_LBN);
+
+       return result;
+}
+
+static u32 efx_get_mcdi_phy_flags(struct efx_nic *efx)
+{
+       struct efx_mcdi_phy_data *phy_cfg = efx->phy_data;
+       enum efx_phy_mode mode, supported;
+       u32 flags;
+
+       /* TODO: Advertise the capabilities supported by this PHY */
+       supported = 0;
+       if (phy_cfg->flags & (1 << MC_CMD_GET_PHY_CFG_OUT_TXDIS_LBN))
+               supported |= PHY_MODE_TX_DISABLED;
+       if (phy_cfg->flags & (1 << MC_CMD_GET_PHY_CFG_OUT_LOWPOWER_LBN))
+               supported |= PHY_MODE_LOW_POWER;
+       if (phy_cfg->flags & (1 << MC_CMD_GET_PHY_CFG_OUT_POWEROFF_LBN))
+               supported |= PHY_MODE_OFF;
+
+       mode = efx->phy_mode & supported;
+
+       flags = 0;
+       if (mode & PHY_MODE_TX_DISABLED)
+               flags |= (1 << MC_CMD_SET_LINK_IN_TXDIS_LBN);
+       if (mode & PHY_MODE_LOW_POWER)
+               flags |= (1 << MC_CMD_SET_LINK_IN_LOWPOWER_LBN);
+       if (mode & PHY_MODE_OFF)
+               flags |= (1 << MC_CMD_SET_LINK_IN_POWEROFF_LBN);
+
+       return flags;
+}
+
+static u32 mcdi_to_ethtool_media(u32 media)
+{
+       switch (media) {
+       case MC_CMD_MEDIA_XAUI:
+       case MC_CMD_MEDIA_CX4:
+       case MC_CMD_MEDIA_KX4:
+               return PORT_OTHER;
+
+       case MC_CMD_MEDIA_XFP:
+       case MC_CMD_MEDIA_SFP_PLUS:
+       case MC_CMD_MEDIA_QSFP_PLUS:
+               return PORT_FIBRE;
+
+       case MC_CMD_MEDIA_BASE_T:
+               return PORT_TP;
+
+       default:
+               return PORT_OTHER;
+       }
+}
+
+static void efx_mcdi_phy_decode_link(struct efx_nic *efx,
+                             struct efx_link_state *link_state,
+                             u32 speed, u32 flags, u32 fcntl)
+{
+       switch (fcntl) {
+       case MC_CMD_FCNTL_AUTO:
+               WARN_ON(1);     /* This is not a link mode */
+               link_state->fc = EFX_FC_AUTO | EFX_FC_TX | EFX_FC_RX;
+               break;
+       case MC_CMD_FCNTL_BIDIR:
+               link_state->fc = EFX_FC_TX | EFX_FC_RX;
+               break;
+       case MC_CMD_FCNTL_RESPOND:
+               link_state->fc = EFX_FC_RX;
+               break;
+       default:
+               WARN_ON(1);
+       case MC_CMD_FCNTL_OFF:
+               link_state->fc = 0;
+               break;
+       }
+
+       link_state->up = !!(flags & (1 << MC_CMD_GET_LINK_OUT_LINK_UP_LBN));
+       link_state->fd = !!(flags & (1 << MC_CMD_GET_LINK_OUT_FULL_DUPLEX_LBN));
+       link_state->speed = speed;
+}
+
+static int efx_mcdi_phy_probe(struct efx_nic *efx)
+{
+       struct efx_mcdi_phy_data *phy_data;
+       MCDI_DECLARE_BUF(outbuf, MC_CMD_GET_LINK_OUT_LEN);
+       u32 caps;
+       int rc;
+
+       /* Initialise and populate phy_data */
+       phy_data = kzalloc(sizeof(*phy_data), GFP_KERNEL);
+       if (phy_data == NULL)
+               return -ENOMEM;
+
+       rc = efx_mcdi_get_phy_cfg(efx, phy_data);
+       if (rc != 0)
+               goto fail;
+
+       /* Read initial link advertisement */
+       BUILD_BUG_ON(MC_CMD_GET_LINK_IN_LEN != 0);
+       rc = efx_mcdi_rpc(efx, MC_CMD_GET_LINK, NULL, 0,
+                         outbuf, sizeof(outbuf), NULL);
+       if (rc)
+               goto fail;
+
+       /* Fill out nic state */
+       efx->phy_data = phy_data;
+       efx->phy_type = phy_data->type;
+
+       efx->mdio_bus = phy_data->channel;
+       efx->mdio.prtad = phy_data->port;
+       efx->mdio.mmds = phy_data->mmd_mask & ~(1 << MC_CMD_MMD_CLAUSE22);
+       efx->mdio.mode_support = 0;
+       if (phy_data->mmd_mask & (1 << MC_CMD_MMD_CLAUSE22))
+               efx->mdio.mode_support |= MDIO_SUPPORTS_C22;
+       if (phy_data->mmd_mask & ~(1 << MC_CMD_MMD_CLAUSE22))
+               efx->mdio.mode_support |= MDIO_SUPPORTS_C45 | MDIO_EMULATE_C22;
+
+       caps = MCDI_DWORD(outbuf, GET_LINK_OUT_CAP);
+       if (caps & (1 << MC_CMD_PHY_CAP_AN_LBN))
+               efx->link_advertising =
+                       mcdi_to_ethtool_cap(phy_data->media, caps);
+       else
+               phy_data->forced_cap = caps;
+
+       /* Assert that we can map efx -> mcdi loopback modes */
+       BUILD_BUG_ON(LOOPBACK_NONE != MC_CMD_LOOPBACK_NONE);
+       BUILD_BUG_ON(LOOPBACK_DATA != MC_CMD_LOOPBACK_DATA);
+       BUILD_BUG_ON(LOOPBACK_GMAC != MC_CMD_LOOPBACK_GMAC);
+       BUILD_BUG_ON(LOOPBACK_XGMII != MC_CMD_LOOPBACK_XGMII);
+       BUILD_BUG_ON(LOOPBACK_XGXS != MC_CMD_LOOPBACK_XGXS);
+       BUILD_BUG_ON(LOOPBACK_XAUI != MC_CMD_LOOPBACK_XAUI);
+       BUILD_BUG_ON(LOOPBACK_GMII != MC_CMD_LOOPBACK_GMII);
+       BUILD_BUG_ON(LOOPBACK_SGMII != MC_CMD_LOOPBACK_SGMII);
+       BUILD_BUG_ON(LOOPBACK_XGBR != MC_CMD_LOOPBACK_XGBR);
+       BUILD_BUG_ON(LOOPBACK_XFI != MC_CMD_LOOPBACK_XFI);
+       BUILD_BUG_ON(LOOPBACK_XAUI_FAR != MC_CMD_LOOPBACK_XAUI_FAR);
+       BUILD_BUG_ON(LOOPBACK_GMII_FAR != MC_CMD_LOOPBACK_GMII_FAR);
+       BUILD_BUG_ON(LOOPBACK_SGMII_FAR != MC_CMD_LOOPBACK_SGMII_FAR);
+       BUILD_BUG_ON(LOOPBACK_XFI_FAR != MC_CMD_LOOPBACK_XFI_FAR);
+       BUILD_BUG_ON(LOOPBACK_GPHY != MC_CMD_LOOPBACK_GPHY);
+       BUILD_BUG_ON(LOOPBACK_PHYXS != MC_CMD_LOOPBACK_PHYXS);
+       BUILD_BUG_ON(LOOPBACK_PCS != MC_CMD_LOOPBACK_PCS);
+       BUILD_BUG_ON(LOOPBACK_PMAPMD != MC_CMD_LOOPBACK_PMAPMD);
+       BUILD_BUG_ON(LOOPBACK_XPORT != MC_CMD_LOOPBACK_XPORT);
+       BUILD_BUG_ON(LOOPBACK_XGMII_WS != MC_CMD_LOOPBACK_XGMII_WS);
+       BUILD_BUG_ON(LOOPBACK_XAUI_WS != MC_CMD_LOOPBACK_XAUI_WS);
+       BUILD_BUG_ON(LOOPBACK_XAUI_WS_FAR != MC_CMD_LOOPBACK_XAUI_WS_FAR);
+       BUILD_BUG_ON(LOOPBACK_XAUI_WS_NEAR != MC_CMD_LOOPBACK_XAUI_WS_NEAR);
+       BUILD_BUG_ON(LOOPBACK_GMII_WS != MC_CMD_LOOPBACK_GMII_WS);
+       BUILD_BUG_ON(LOOPBACK_XFI_WS != MC_CMD_LOOPBACK_XFI_WS);
+       BUILD_BUG_ON(LOOPBACK_XFI_WS_FAR != MC_CMD_LOOPBACK_XFI_WS_FAR);
+       BUILD_BUG_ON(LOOPBACK_PHYXS_WS != MC_CMD_LOOPBACK_PHYXS_WS);
+
+       rc = efx_mcdi_loopback_modes(efx, &efx->loopback_modes);
+       if (rc != 0)
+               goto fail;
+       /* The MC indicates that LOOPBACK_NONE is a valid loopback mode,
+        * but by convention we don't */
+       efx->loopback_modes &= ~(1 << LOOPBACK_NONE);
+
+       /* Set the initial link mode */
+       efx_mcdi_phy_decode_link(
+               efx, &efx->link_state,
+               MCDI_DWORD(outbuf, GET_LINK_OUT_LINK_SPEED),
+               MCDI_DWORD(outbuf, GET_LINK_OUT_FLAGS),
+               MCDI_DWORD(outbuf, GET_LINK_OUT_FCNTL));
+
+       /* Default to Autonegotiated flow control if the PHY supports it */
+       efx->wanted_fc = EFX_FC_RX | EFX_FC_TX;
+       if (phy_data->supported_cap & (1 << MC_CMD_PHY_CAP_AN_LBN))
+               efx->wanted_fc |= EFX_FC_AUTO;
+       efx_link_set_wanted_fc(efx, efx->wanted_fc);
+
+       return 0;
+
+fail:
+       kfree(phy_data);
+       return rc;
+}
+
+int efx_mcdi_port_reconfigure(struct efx_nic *efx)
+{
+       struct efx_mcdi_phy_data *phy_cfg = efx->phy_data;
+       u32 caps = (efx->link_advertising ?
+                   ethtool_to_mcdi_cap(efx->link_advertising) :
+                   phy_cfg->forced_cap);
+
+       return efx_mcdi_set_link(efx, caps, efx_get_mcdi_phy_flags(efx),
+                                efx->loopback_mode, 0);
+}
+
+/* Verify that the forced flow control settings (!EFX_FC_AUTO) are
+ * supported by the link partner. Warn the user if this isn't the case
+ */
+static void efx_mcdi_phy_check_fcntl(struct efx_nic *efx, u32 lpa)
+{
+       struct efx_mcdi_phy_data *phy_cfg = efx->phy_data;
+       u32 rmtadv;
+
+       /* The link partner capabilities are only relevant if the
+        * link supports flow control autonegotiation */
+       if (~phy_cfg->supported_cap & (1 << MC_CMD_PHY_CAP_AN_LBN))
+               return;
+
+       /* If flow control autoneg is supported and enabled, then fine */
+       if (efx->wanted_fc & EFX_FC_AUTO)
+               return;
+
+       rmtadv = 0;
+       if (lpa & (1 << MC_CMD_PHY_CAP_PAUSE_LBN))
+               rmtadv |= ADVERTISED_Pause;
+       if (lpa & (1 << MC_CMD_PHY_CAP_ASYM_LBN))
+               rmtadv |=  ADVERTISED_Asym_Pause;
+
+       if ((efx->wanted_fc & EFX_FC_TX) && rmtadv == ADVERTISED_Asym_Pause)
+               netif_err(efx, link, efx->net_dev,
+                         "warning: link partner doesn't support pause frames");
+}
+
+static bool efx_mcdi_phy_poll(struct efx_nic *efx)
+{
+       struct efx_link_state old_state = efx->link_state;
+       MCDI_DECLARE_BUF(outbuf, MC_CMD_GET_LINK_OUT_LEN);
+       int rc;
+
+       WARN_ON(!mutex_is_locked(&efx->mac_lock));
+
+       BUILD_BUG_ON(MC_CMD_GET_LINK_IN_LEN != 0);
+
+       rc = efx_mcdi_rpc(efx, MC_CMD_GET_LINK, NULL, 0,
+                         outbuf, sizeof(outbuf), NULL);
+       if (rc)
+               efx->link_state.up = false;
+       else
+               efx_mcdi_phy_decode_link(
+                       efx, &efx->link_state,
+                       MCDI_DWORD(outbuf, GET_LINK_OUT_LINK_SPEED),
+                       MCDI_DWORD(outbuf, GET_LINK_OUT_FLAGS),
+                       MCDI_DWORD(outbuf, GET_LINK_OUT_FCNTL));
+
+       return !efx_link_state_equal(&efx->link_state, &old_state);
+}
+
+static void efx_mcdi_phy_remove(struct efx_nic *efx)
+{
+       struct efx_mcdi_phy_data *phy_data = efx->phy_data;
+
+       efx->phy_data = NULL;
+       kfree(phy_data);
+}
+
+static void efx_mcdi_phy_get_settings(struct efx_nic *efx, struct ethtool_cmd *ecmd)
+{
+       struct efx_mcdi_phy_data *phy_cfg = efx->phy_data;
+       MCDI_DECLARE_BUF(outbuf, MC_CMD_GET_LINK_OUT_LEN);
+       int rc;
+
+       ecmd->supported =
+               mcdi_to_ethtool_cap(phy_cfg->media, phy_cfg->supported_cap);
+       ecmd->advertising = efx->link_advertising;
+       ethtool_cmd_speed_set(ecmd, efx->link_state.speed);
+       ecmd->duplex = efx->link_state.fd;
+       ecmd->port = mcdi_to_ethtool_media(phy_cfg->media);
+       ecmd->phy_address = phy_cfg->port;
+       ecmd->transceiver = XCVR_INTERNAL;
+       ecmd->autoneg = !!(efx->link_advertising & ADVERTISED_Autoneg);
+       ecmd->mdio_support = (efx->mdio.mode_support &
+                             (MDIO_SUPPORTS_C45 | MDIO_SUPPORTS_C22));
+
+       BUILD_BUG_ON(MC_CMD_GET_LINK_IN_LEN != 0);
+       rc = efx_mcdi_rpc(efx, MC_CMD_GET_LINK, NULL, 0,
+                         outbuf, sizeof(outbuf), NULL);
+       if (rc)
+               return;
+       ecmd->lp_advertising =
+               mcdi_to_ethtool_cap(phy_cfg->media,
+                                   MCDI_DWORD(outbuf, GET_LINK_OUT_LP_CAP));
+}
+
+static int efx_mcdi_phy_set_settings(struct efx_nic *efx, struct ethtool_cmd *ecmd)
+{
+       struct efx_mcdi_phy_data *phy_cfg = efx->phy_data;
+       u32 caps;
+       int rc;
+
+       if (ecmd->autoneg) {
+               caps = (ethtool_to_mcdi_cap(ecmd->advertising) |
+                        1 << MC_CMD_PHY_CAP_AN_LBN);
+       } else if (ecmd->duplex) {
+               switch (ethtool_cmd_speed(ecmd)) {
+               case 10:    caps = 1 << MC_CMD_PHY_CAP_10FDX_LBN;    break;
+               case 100:   caps = 1 << MC_CMD_PHY_CAP_100FDX_LBN;   break;
+               case 1000:  caps = 1 << MC_CMD_PHY_CAP_1000FDX_LBN;  break;
+               case 10000: caps = 1 << MC_CMD_PHY_CAP_10000FDX_LBN; break;
+               case 40000: caps = 1 << MC_CMD_PHY_CAP_40000FDX_LBN; break;
+               default:    return -EINVAL;
+               }
+       } else {
+               switch (ethtool_cmd_speed(ecmd)) {
+               case 10:    caps = 1 << MC_CMD_PHY_CAP_10HDX_LBN;    break;
+               case 100:   caps = 1 << MC_CMD_PHY_CAP_100HDX_LBN;   break;
+               case 1000:  caps = 1 << MC_CMD_PHY_CAP_1000HDX_LBN;  break;
+               default:    return -EINVAL;
+               }
+       }
+
+       rc = efx_mcdi_set_link(efx, caps, efx_get_mcdi_phy_flags(efx),
+                              efx->loopback_mode, 0);
+       if (rc)
+               return rc;
+
+       if (ecmd->autoneg) {
+               efx_link_set_advertising(
+                       efx, ecmd->advertising | ADVERTISED_Autoneg);
+               phy_cfg->forced_cap = 0;
+       } else {
+               efx_link_set_advertising(efx, 0);
+               phy_cfg->forced_cap = caps;
+       }
+       return 0;
+}
+
+static int efx_mcdi_phy_test_alive(struct efx_nic *efx)
+{
+       MCDI_DECLARE_BUF(outbuf, MC_CMD_GET_PHY_STATE_OUT_LEN);
+       size_t outlen;
+       int rc;
+
+       BUILD_BUG_ON(MC_CMD_GET_PHY_STATE_IN_LEN != 0);
+
+       rc = efx_mcdi_rpc(efx, MC_CMD_GET_PHY_STATE, NULL, 0,
+                         outbuf, sizeof(outbuf), &outlen);
+       if (rc)
+               return rc;
+
+       if (outlen < MC_CMD_GET_PHY_STATE_OUT_LEN)
+               return -EIO;
+       if (MCDI_DWORD(outbuf, GET_PHY_STATE_OUT_STATE) != MC_CMD_PHY_STATE_OK)
+               return -EINVAL;
+
+       return 0;
+}
+
+static const char *const mcdi_sft9001_cable_diag_names[] = {
+       "cable.pairA.length",
+       "cable.pairB.length",
+       "cable.pairC.length",
+       "cable.pairD.length",
+       "cable.pairA.status",
+       "cable.pairB.status",
+       "cable.pairC.status",
+       "cable.pairD.status",
+};
+
+static int efx_mcdi_bist(struct efx_nic *efx, unsigned int bist_mode,
+                        int *results)
+{
+       unsigned int retry, i, count = 0;
+       size_t outlen;
+       u32 status;
+       MCDI_DECLARE_BUF(inbuf, MC_CMD_START_BIST_IN_LEN);
+       MCDI_DECLARE_BUF(outbuf, MC_CMD_POLL_BIST_OUT_SFT9001_LEN);
+       u8 *ptr;
+       int rc;
+
+       BUILD_BUG_ON(MC_CMD_START_BIST_OUT_LEN != 0);
+       MCDI_SET_DWORD(inbuf, START_BIST_IN_TYPE, bist_mode);
+       rc = efx_mcdi_rpc(efx, MC_CMD_START_BIST,
+                         inbuf, MC_CMD_START_BIST_IN_LEN, NULL, 0, NULL);
+       if (rc)
+               goto out;
+
+       /* Wait up to 10s for BIST to finish */
+       for (retry = 0; retry < 100; ++retry) {
+               BUILD_BUG_ON(MC_CMD_POLL_BIST_IN_LEN != 0);
+               rc = efx_mcdi_rpc(efx, MC_CMD_POLL_BIST, NULL, 0,
+                                 outbuf, sizeof(outbuf), &outlen);
+               if (rc)
+                       goto out;
+
+               status = MCDI_DWORD(outbuf, POLL_BIST_OUT_RESULT);
+               if (status != MC_CMD_POLL_BIST_RUNNING)
+                       goto finished;
+
+               msleep(100);
+       }
+
+       rc = -ETIMEDOUT;
+       goto out;
+
+finished:
+       results[count++] = (status == MC_CMD_POLL_BIST_PASSED) ? 1 : -1;
+
+       /* SFT9001 specific cable diagnostics output */
+       if (efx->phy_type == PHY_TYPE_SFT9001B &&
+           (bist_mode == MC_CMD_PHY_BIST_CABLE_SHORT ||
+            bist_mode == MC_CMD_PHY_BIST_CABLE_LONG)) {
+               ptr = MCDI_PTR(outbuf, POLL_BIST_OUT_SFT9001_CABLE_LENGTH_A);
+               if (status == MC_CMD_POLL_BIST_PASSED &&
+                   outlen >= MC_CMD_POLL_BIST_OUT_SFT9001_LEN) {
+                       for (i = 0; i < 8; i++) {
+                               results[count + i] =
+                                       EFX_DWORD_FIELD(((efx_dword_t *)ptr)[i],
+                                                       EFX_DWORD_0);
+                       }
+               }
+               count += 8;
+       }
+       rc = count;
+
+out:
+       return rc;
+}
+
+static int efx_mcdi_phy_run_tests(struct efx_nic *efx, int *results,
+                                 unsigned flags)
+{
+       struct efx_mcdi_phy_data *phy_cfg = efx->phy_data;
+       u32 mode;
+       int rc;
+
+       if (phy_cfg->flags & (1 << MC_CMD_GET_PHY_CFG_OUT_BIST_LBN)) {
+               rc = efx_mcdi_bist(efx, MC_CMD_PHY_BIST, results);
+               if (rc < 0)
+                       return rc;
+
+               results += rc;
+       }
+
+       /* If we support both LONG and SHORT, then run each in response to
+        * break or not. Otherwise, run the one we support */
+       mode = 0;
+       if (phy_cfg->flags & (1 << MC_CMD_GET_PHY_CFG_OUT_BIST_CABLE_SHORT_LBN)) {
+               if ((flags & ETH_TEST_FL_OFFLINE) &&
+                   (phy_cfg->flags &
+                    (1 << MC_CMD_GET_PHY_CFG_OUT_BIST_CABLE_LONG_LBN)))
+                       mode = MC_CMD_PHY_BIST_CABLE_LONG;
+               else
+                       mode = MC_CMD_PHY_BIST_CABLE_SHORT;
+       } else if (phy_cfg->flags &
+                  (1 << MC_CMD_GET_PHY_CFG_OUT_BIST_CABLE_LONG_LBN))
+               mode = MC_CMD_PHY_BIST_CABLE_LONG;
+
+       if (mode != 0) {
+               rc = efx_mcdi_bist(efx, mode, results);
+               if (rc < 0)
+                       return rc;
+               results += rc;
+       }
+
+       return 0;
+}
+
+static const char *efx_mcdi_phy_test_name(struct efx_nic *efx,
+                                         unsigned int index)
+{
+       struct efx_mcdi_phy_data *phy_cfg = efx->phy_data;
+
+       if (phy_cfg->flags & (1 << MC_CMD_GET_PHY_CFG_OUT_BIST_LBN)) {
+               if (index == 0)
+                       return "bist";
+               --index;
+       }
+
+       if (phy_cfg->flags & ((1 << MC_CMD_GET_PHY_CFG_OUT_BIST_CABLE_SHORT_LBN) |
+                             (1 << MC_CMD_GET_PHY_CFG_OUT_BIST_CABLE_LONG_LBN))) {
+               if (index == 0)
+                       return "cable";
+               --index;
+
+               if (efx->phy_type == PHY_TYPE_SFT9001B) {
+                       if (index < ARRAY_SIZE(mcdi_sft9001_cable_diag_names))
+                               return mcdi_sft9001_cable_diag_names[index];
+                       index -= ARRAY_SIZE(mcdi_sft9001_cable_diag_names);
+               }
+       }
+
+       return NULL;
+}
+
+#define SFP_PAGE_SIZE  128
+#define SFP_NUM_PAGES  2
+static int efx_mcdi_phy_get_module_eeprom(struct efx_nic *efx,
+                                         struct ethtool_eeprom *ee, u8 *data)
+{
+       MCDI_DECLARE_BUF(outbuf, MC_CMD_GET_PHY_MEDIA_INFO_OUT_LENMAX);
+       MCDI_DECLARE_BUF(inbuf, MC_CMD_GET_PHY_MEDIA_INFO_IN_LEN);
+       size_t outlen;
+       int rc;
+       unsigned int payload_len;
+       unsigned int space_remaining = ee->len;
+       unsigned int page;
+       unsigned int page_off;
+       unsigned int to_copy;
+       u8 *user_data = data;
+
+       BUILD_BUG_ON(SFP_PAGE_SIZE * SFP_NUM_PAGES != ETH_MODULE_SFF_8079_LEN);
+
+       page_off = ee->offset % SFP_PAGE_SIZE;
+       page = ee->offset / SFP_PAGE_SIZE;
+
+       while (space_remaining && (page < SFP_NUM_PAGES)) {
+               MCDI_SET_DWORD(inbuf, GET_PHY_MEDIA_INFO_IN_PAGE, page);
+
+               rc = efx_mcdi_rpc(efx, MC_CMD_GET_PHY_MEDIA_INFO,
+                                 inbuf, sizeof(inbuf),
+                                 outbuf, sizeof(outbuf),
+                                 &outlen);
+               if (rc)
+                       return rc;
+
+               if (outlen < (MC_CMD_GET_PHY_MEDIA_INFO_OUT_DATA_OFST +
+                             SFP_PAGE_SIZE))
+                       return -EIO;
+
+               payload_len = MCDI_DWORD(outbuf,
+                                        GET_PHY_MEDIA_INFO_OUT_DATALEN);
+               if (payload_len != SFP_PAGE_SIZE)
+                       return -EIO;
+
+               /* Copy as much as we can into data */
+               payload_len -= page_off;
+               to_copy = (space_remaining < payload_len) ?
+                       space_remaining : payload_len;
+
+               memcpy(user_data,
+                      MCDI_PTR(outbuf, GET_PHY_MEDIA_INFO_OUT_DATA) + page_off,
+                      to_copy);
+
+               space_remaining -= to_copy;
+               user_data += to_copy;
+               page_off = 0;
+               page++;
+       }
+
+       return 0;
+}
+
+static int efx_mcdi_phy_get_module_info(struct efx_nic *efx,
+                                       struct ethtool_modinfo *modinfo)
+{
+       struct efx_mcdi_phy_data *phy_cfg = efx->phy_data;
+
+       switch (phy_cfg->media) {
+       case MC_CMD_MEDIA_SFP_PLUS:
+               modinfo->type = ETH_MODULE_SFF_8079;
+               modinfo->eeprom_len = ETH_MODULE_SFF_8079_LEN;
+               return 0;
+       default:
+               return -EOPNOTSUPP;
+       }
+}
+
+static const struct efx_phy_operations efx_mcdi_phy_ops = {
+       .probe          = efx_mcdi_phy_probe,
+       .init           = efx_port_dummy_op_int,
+       .reconfigure    = efx_mcdi_port_reconfigure,
+       .poll           = efx_mcdi_phy_poll,
+       .fini           = efx_port_dummy_op_void,
+       .remove         = efx_mcdi_phy_remove,
+       .get_settings   = efx_mcdi_phy_get_settings,
+       .set_settings   = efx_mcdi_phy_set_settings,
+       .test_alive     = efx_mcdi_phy_test_alive,
+       .run_tests      = efx_mcdi_phy_run_tests,
+       .test_name      = efx_mcdi_phy_test_name,
+       .get_module_eeprom = efx_mcdi_phy_get_module_eeprom,
+       .get_module_info = efx_mcdi_phy_get_module_info,
+};
+
+u32 efx_mcdi_phy_get_caps(struct efx_nic *efx)
+{
+       struct efx_mcdi_phy_data *phy_data = efx->phy_data;
+
+       return phy_data->supported_cap;
+}
+
+static unsigned int efx_mcdi_event_link_speed[] = {
+       [MCDI_EVENT_LINKCHANGE_SPEED_100M] = 100,
+       [MCDI_EVENT_LINKCHANGE_SPEED_1G] = 1000,
+       [MCDI_EVENT_LINKCHANGE_SPEED_10G] = 10000,
+       [MCDI_EVENT_LINKCHANGE_SPEED_40G] = 40000,
+};
+
+void efx_mcdi_process_link_change(struct efx_nic *efx, efx_qword_t *ev)
+{
+       u32 flags, fcntl, speed, lpa;
+
+       speed = EFX_QWORD_FIELD(*ev, MCDI_EVENT_LINKCHANGE_SPEED);
+       EFX_BUG_ON_PARANOID(speed >= ARRAY_SIZE(efx_mcdi_event_link_speed));
+       speed = efx_mcdi_event_link_speed[speed];
+
+       flags = EFX_QWORD_FIELD(*ev, MCDI_EVENT_LINKCHANGE_LINK_FLAGS);
+       fcntl = EFX_QWORD_FIELD(*ev, MCDI_EVENT_LINKCHANGE_FCNTL);
+       lpa = EFX_QWORD_FIELD(*ev, MCDI_EVENT_LINKCHANGE_LP_CAP);
+
+       /* efx->link_state is only modified by efx_mcdi_phy_get_link(),
+        * which is only run after flushing the event queues. Therefore, it
+        * is safe to modify the link state outside of the mac_lock here.
+        */
+       efx_mcdi_phy_decode_link(efx, &efx->link_state, speed, flags, fcntl);
+
+       efx_mcdi_phy_check_fcntl(efx, lpa);
+
+       efx_link_status_changed(efx);
+}
+
+int efx_mcdi_set_mac(struct efx_nic *efx)
+{
+       u32 fcntl;
+       MCDI_DECLARE_BUF(cmdbytes, MC_CMD_SET_MAC_IN_LEN);
+
+       BUILD_BUG_ON(MC_CMD_SET_MAC_OUT_LEN != 0);
+
+       ether_addr_copy(MCDI_PTR(cmdbytes, SET_MAC_IN_ADDR),
+                       efx->net_dev->dev_addr);
+
+       MCDI_SET_DWORD(cmdbytes, SET_MAC_IN_MTU,
+                       EFX_MAX_FRAME_LEN(efx->net_dev->mtu));
+       MCDI_SET_DWORD(cmdbytes, SET_MAC_IN_DRAIN, 0);
+
+       /* Set simple MAC filter for Siena */
+       MCDI_POPULATE_DWORD_1(cmdbytes, SET_MAC_IN_REJECT,
+                             SET_MAC_IN_REJECT_UNCST, efx->unicast_filter);
+
+       switch (efx->wanted_fc) {
+       case EFX_FC_RX | EFX_FC_TX:
+               fcntl = MC_CMD_FCNTL_BIDIR;
+               break;
+       case EFX_FC_RX:
+               fcntl = MC_CMD_FCNTL_RESPOND;
+               break;
+       default:
+               fcntl = MC_CMD_FCNTL_OFF;
+               break;
+       }
+       if (efx->wanted_fc & EFX_FC_AUTO)
+               fcntl = MC_CMD_FCNTL_AUTO;
+       if (efx->fc_disable)
+               fcntl = MC_CMD_FCNTL_OFF;
+
+       MCDI_SET_DWORD(cmdbytes, SET_MAC_IN_FCNTL, fcntl);
+
+       return efx_mcdi_rpc(efx, MC_CMD_SET_MAC, cmdbytes, sizeof(cmdbytes),
+                           NULL, 0, NULL);
+}
+
+bool efx_mcdi_mac_check_fault(struct efx_nic *efx)
+{
+       MCDI_DECLARE_BUF(outbuf, MC_CMD_GET_LINK_OUT_LEN);
+       size_t outlength;
+       int rc;
+
+       BUILD_BUG_ON(MC_CMD_GET_LINK_IN_LEN != 0);
+
+       rc = efx_mcdi_rpc(efx, MC_CMD_GET_LINK, NULL, 0,
+                         outbuf, sizeof(outbuf), &outlength);
+       if (rc)
+               return true;
+
+       return MCDI_DWORD(outbuf, GET_LINK_OUT_MAC_FAULT) != 0;
+}
+
+enum efx_stats_action {
+       EFX_STATS_ENABLE,
+       EFX_STATS_DISABLE,
+       EFX_STATS_PULL,
+};
+
+static int efx_mcdi_mac_stats(struct efx_nic *efx,
+                             enum efx_stats_action action, int clear)
+{
+       MCDI_DECLARE_BUF(inbuf, MC_CMD_MAC_STATS_IN_LEN);
+       int rc;
+       int change = action == EFX_STATS_PULL ? 0 : 1;
+       int enable = action == EFX_STATS_ENABLE ? 1 : 0;
+       int period = action == EFX_STATS_ENABLE ? 1000 : 0;
+       dma_addr_t dma_addr = efx->stats_buffer.dma_addr;
+       u32 dma_len = action != EFX_STATS_DISABLE ?
+               MC_CMD_MAC_NSTATS * sizeof(u64) : 0;
+
+       BUILD_BUG_ON(MC_CMD_MAC_STATS_OUT_DMA_LEN != 0);
+
+       MCDI_SET_QWORD(inbuf, MAC_STATS_IN_DMA_ADDR, dma_addr);
+       MCDI_POPULATE_DWORD_7(inbuf, MAC_STATS_IN_CMD,
+                             MAC_STATS_IN_DMA, !!enable,
+                             MAC_STATS_IN_CLEAR, clear,
+                             MAC_STATS_IN_PERIODIC_CHANGE, change,
+                             MAC_STATS_IN_PERIODIC_ENABLE, enable,
+                             MAC_STATS_IN_PERIODIC_CLEAR, 0,
+                             MAC_STATS_IN_PERIODIC_NOEVENT, 1,
+                             MAC_STATS_IN_PERIOD_MS, period);
+       MCDI_SET_DWORD(inbuf, MAC_STATS_IN_DMA_LEN, dma_len);
+
+       rc = efx_mcdi_rpc(efx, MC_CMD_MAC_STATS, inbuf, sizeof(inbuf),
+                         NULL, 0, NULL);
+       return rc;
+}
+
+void efx_mcdi_mac_start_stats(struct efx_nic *efx)
+{
+       __le64 *dma_stats = efx->stats_buffer.addr;
+
+       dma_stats[MC_CMD_MAC_GENERATION_END] = EFX_MC_STATS_GENERATION_INVALID;
+
+       efx_mcdi_mac_stats(efx, EFX_STATS_ENABLE, 0);
+}
+
+void efx_mcdi_mac_stop_stats(struct efx_nic *efx)
+{
+       efx_mcdi_mac_stats(efx, EFX_STATS_DISABLE, 0);
+}
+
+#define EFX_MAC_STATS_WAIT_US 100
+#define EFX_MAC_STATS_WAIT_ATTEMPTS 10
+
+void efx_mcdi_mac_pull_stats(struct efx_nic *efx)
+{
+       __le64 *dma_stats = efx->stats_buffer.addr;
+       int attempts = EFX_MAC_STATS_WAIT_ATTEMPTS;
+
+       dma_stats[MC_CMD_MAC_GENERATION_END] = EFX_MC_STATS_GENERATION_INVALID;
+       efx_mcdi_mac_stats(efx, EFX_STATS_PULL, 0);
+
+       while (dma_stats[MC_CMD_MAC_GENERATION_END] ==
+                               EFX_MC_STATS_GENERATION_INVALID &&
+                       attempts-- != 0)
+               udelay(EFX_MAC_STATS_WAIT_US);
+}
+
+int efx_mcdi_port_probe(struct efx_nic *efx)
+{
+       int rc;
+
+       /* Hook in PHY operations table */
+       efx->phy_op = &efx_mcdi_phy_ops;
+
+       /* Set up MDIO structure for PHY */
+       efx->mdio.mode_support = MDIO_SUPPORTS_C45 | MDIO_EMULATE_C22;
+       efx->mdio.mdio_read = efx_mcdi_mdio_read;
+       efx->mdio.mdio_write = efx_mcdi_mdio_write;
+
+       /* Fill out MDIO structure, loopback modes, and initial link state */
+       rc = efx->phy_op->probe(efx);
+       if (rc != 0)
+               return rc;
+
+       /* Allocate buffer for stats */
+       rc = efx_nic_alloc_buffer(efx, &efx->stats_buffer,
+                                 MC_CMD_MAC_NSTATS * sizeof(u64), GFP_KERNEL);
+       if (rc)
+               return rc;
+       netif_dbg(efx, probe, efx->net_dev,
+                 "stats buffer at %llx (virt %p phys %llx)\n",
+                 (u64)efx->stats_buffer.dma_addr,
+                 efx->stats_buffer.addr,
+                 (u64)virt_to_phys(efx->stats_buffer.addr));
+
+       efx_mcdi_mac_stats(efx, EFX_STATS_DISABLE, 1);
+
+       return 0;
+}
+
+void efx_mcdi_port_remove(struct efx_nic *efx)
+{
+       efx->phy_op->remove(efx);
+       efx_nic_free_buffer(efx, &efx->stats_buffer);
+}
+
+/* Get physical port number (EF10 only; on Siena it is same as PF number) */
+int efx_mcdi_port_get_number(struct efx_nic *efx)
+{
+       MCDI_DECLARE_BUF(outbuf, MC_CMD_GET_PORT_ASSIGNMENT_OUT_LEN);
+       int rc;
+
+       rc = efx_mcdi_rpc(efx, MC_CMD_GET_PORT_ASSIGNMENT, NULL, 0,
+                         outbuf, sizeof(outbuf), NULL);
+       if (rc)
+               return rc;
+
+       return MCDI_DWORD(outbuf, GET_PORT_ASSIGNMENT_OUT_PORT);
+}