Fix pylint errors in test_refstack_client
[functest-xtesting.git] / functest / tests / unit / openstack / refstack_client / test_refstack_client.py
index c560107..61e950a 100644 (file)
@@ -1,22 +1,33 @@
 #!/usr/bin/env python
+
 # Copyright (c) 2017 Huawei Technologies Co.,Ltd and others.
-# matthew.lijun@huawei.com wangwulin@huawei.com
+#
 # All rights reserved. This program and the accompanying materials
 # are made available under the terms of the Apache License, Version 2.0
 # which accompanies this distribution, and is available at
 # http://www.apache.org/licenses/LICENSE-2.0
 
+# pylint: disable=missing-docstring
+
 import logging
 import mock
 import pkg_resources
 import unittest
 
 from functest.core import testcase
-from functest.opnfv_tests.openstack.refstack_client import refstack_client
+from functest.opnfv_tests.openstack.refstack_client.refstack_client import \
+    RefstackClient, RefstackClientParser
 from functest.utils.constants import CONST
 
+from snaps.openstack.os_credentials import OSCreds
+
+__author__ = ("Matthew Li <matthew.lijun@huawei.com>,"
+              "Linda Wang <wangwulin@huawei.com>")
+
 
 class OSRefstackClientTesting(unittest.TestCase):
+    """The class testing RefstackClient """
+    # pylint: disable=missing-docstring, too-many-public-methods
 
     _config = pkg_resources.resource_filename(
         'functest',
@@ -25,49 +36,63 @@ class OSRefstackClientTesting(unittest.TestCase):
         'functest', 'opnfv_tests/openstack/refstack_client/defcore.txt')
 
     def setUp(self):
-        self.defaultargs = {'config': self._config,
-                            'testlist': self._testlist}
+        self.default_args = {'config': self._config,
+                             'testlist': self._testlist}
         CONST.__setattr__('OS_AUTH_URL', 'https://ip:5000/v3')
         CONST.__setattr__('OS_INSECURE', 'true')
-        self.refstackclient = refstack_client.RefstackClient()
+        self.case_name = 'refstack_defcore'
+        self.result = 0
+        self.os_creds = OSCreds(
+            username='user', password='pass',
+            auth_url='http://foo.com:5000/v3', project_name='bar')
+        self.details = {"tests": 3,
+                        "failures": 1,
+                        "success": ['tempest.api.compute [18.464988s]'],
+                        "errors": ['tempest.api.volume [0.230334s]'],
+                        "skipped": ['tempest.api.network [1.265828s]']}
+
+    @mock.patch('functest.opnfv_tests.openstack.refstack_client.tempest_conf.'
+                'TempestConf', return_value=mock.Mock())
+    def _create_client(self, *args):
+        with mock.patch('snaps.openstack.tests.openstack_tests.'
+                        'get_credentials', return_value=self.os_creds):
+            return RefstackClient()
 
     def test_run_defcore_insecure(self):
         insecure = '-k'
         config = 'tempest.conf'
         testlist = 'testlist'
+        client = self._create_client()
         with mock.patch('functest.opnfv_tests.openstack.refstack_client.'
-                        'refstack_client.ft_utils.execute_command') as m:
+                        'refstack_client.ft_utils.execute_command') as m_cmd:
             cmd = ("refstack-client test {0} -c {1} -v --test-list {2}"
                    .format(insecure, config, testlist))
-            self.refstackclient.run_defcore(config, testlist)
-            m.assert_any_call(cmd)
+            client.run_defcore(config, testlist)
+            m_cmd.assert_any_call(cmd)
 
     def test_run_defcore(self):
         CONST.__setattr__('OS_AUTH_URL', 'http://ip:5000/v3')
-        refstackclient = refstack_client.RefstackClient()
         insecure = ''
         config = 'tempest.conf'
         testlist = 'testlist'
+        client = self._create_client()
         with mock.patch('functest.opnfv_tests.openstack.refstack_client.'
-                        'refstack_client.ft_utils.execute_command') as m:
+                        'refstack_client.ft_utils.execute_command') as m_cmd:
             cmd = ("refstack-client test {0} -c {1} -v --test-list {2}"
                    .format(insecure, config, testlist))
-            refstackclient.run_defcore(config, testlist)
-            m.assert_any_call(cmd)
+            client.run_defcore(config, testlist)
+            m_cmd.assert_any_call(cmd)
 
     @mock.patch('functest.opnfv_tests.openstack.refstack_client.'
                 'refstack_client.LOGGER.info')
     @mock.patch('__builtin__.open', side_effect=Exception)
-    def test_parse_refstack_result_missing_log_file(self, mock_open,
-                                                    mock_logger_info):
-        self.case_name = 'refstack_defcore'
-        self.result = 0
-        self.refstackclient.parse_refstack_result()
-        mock_logger_info.assert_called_once_with(
+    def test_parse_refstack_result_fail(self, *args):
+        self._create_client().parse_refstack_result()
+        args[1].assert_called_once_with(
             "Testcase %s success_rate is %s%%",
             self.case_name, self.result)
 
-    def test_parse_refstack_result_default(self):
+    def test_parse_refstack_result_ok(self):
         log_file = ('''
                     {0} tempest.api.compute [18.464988s] ... ok
                     {0} tempest.api.volume [0.230334s] ... FAILED
@@ -77,15 +102,11 @@ class OSRefstackClientTesting(unittest.TestCase):
                     - Skipped: 1
                     - Failed: 1
                    ''')
-        self.details = {"tests": 3,
-                        "failures": 1,
-                        "success": ['tempest.api.compute [18.464988s]'],
-                        "errors": ['tempest.api.volume [0.230334s]'],
-                        "skipped": ['tempest.api.network [1.265828s]']}
+        client = self._create_client()
         with mock.patch('__builtin__.open',
                         mock.mock_open(read_data=log_file)):
-            self.refstackclient.parse_refstack_result()
-            self.assertEqual(self.refstackclient.details, self.details)
+            client.parse_refstack_result()
+            self.assertEqual(client.details, self.details)
 
     def _get_main_kwargs(self, key=None):
         kwargs = {'config': self._config,
@@ -94,18 +115,10 @@ class OSRefstackClientTesting(unittest.TestCase):
             del kwargs[key]
         return kwargs
 
-    def _test_main(self, status, *args):
-        kwargs = self._get_main_kwargs()
-        self.assertEqual(self.refstackclient.main(**kwargs), status)
-        if len(args) > 0:
-            args[0].assert_called_once_with(
-                refstack_client.RefstackClient.result_dir)
-        if len(args) > 1:
-            args
-
     def _test_main_missing_keyword(self, key):
         kwargs = self._get_main_kwargs(key)
-        self.assertEqual(self.refstackclient.main(**kwargs),
+        client = self._create_client()
+        self.assertEqual(client.main(**kwargs),
                          testcase.TestCase.EX_RUN_ERROR)
 
     def test_main_missing_conf(self):
@@ -115,10 +128,10 @@ class OSRefstackClientTesting(unittest.TestCase):
         self._test_main_missing_keyword('testlist')
 
     def _test_argparser(self, arg, value):
-        self.defaultargs[arg] = value
-        parser = refstack_client.RefstackClientParser()
+        self.default_args[arg] = value
+        parser = RefstackClientParser()
         self.assertEqual(parser.parse_args(["--{}={}".format(arg, value)]),
-                         self.defaultargs)
+                         self.default_args)
 
     def test_argparser_conf(self):
         self._test_argparser('config', self._config)
@@ -127,13 +140,13 @@ class OSRefstackClientTesting(unittest.TestCase):
         self._test_argparser('testlist', self._testlist)
 
     def test_argparser_multiple_args(self):
-        self.defaultargs['config'] = self._config
-        self.defaultargs['testlist'] = self._testlist
-        parser = refstack_client.RefstackClientParser()
+        self.default_args['config'] = self._config
+        self.default_args['testlist'] = self._testlist
+        parser = RefstackClientParser()
         self.assertEqual(parser.parse_args(
             ["--config={}".format(self._config),
              "--testlist={}".format(self._testlist)
-             ]), self.defaultargs)
+             ]), self.default_args)
 
 
 if __name__ == "__main__":