Switch to Shade in rally
[functest.git] / functest / tests / unit / openstack / rally / test_rally.py
index 92177f3..970e5c4 100644 (file)
@@ -5,7 +5,7 @@
 # which accompanies this distribution, and is available at
 # http://www.apache.org/licenses/LICENSE-2.0
 
-# pylint: disable=missing-docstring
+# pylint: disable=missing-docstring,protected-access,invalid-name
 
 import json
 import logging
@@ -13,32 +13,26 @@ import os
 import unittest
 
 import mock
+from xtesting.core import testcase
 
-from functest.core import testcase
 from functest.opnfv_tests.openstack.rally import rally
-from functest.utils.constants import CONST
-
-from snaps.openstack.os_credentials import OSCreds
 
 
 class OSRallyTesting(unittest.TestCase):
+    # pylint: disable=too-many-public-methods
     def setUp(self):
-        os_creds = OSCreds(
-            username='user', password='pass',
-            auth_url='http://foo.com:5000/v3', project_name='bar')
-        with mock.patch('functest.opnfv_tests.openstack.snaps.snaps_utils.'
-                        'get_credentials', return_value=os_creds) as m:
+        with mock.patch('os_client_config.make_shade') as mock_make_shade:
             self.rally_base = rally.RallyBase()
-        self.assertTrue(m.called)
+        self.assertTrue(mock_make_shade.called)
 
     def test_build_task_args_missing_floating_network(self):
-        CONST.__setattr__('OS_AUTH_URL', None)
+        os.environ['OS_AUTH_URL'] = ''
         self.rally_base.ext_net_name = ''
         task_args = self.rally_base._build_task_args('test_file_name')
         self.assertEqual(task_args['floating_network'], '')
 
     def test_build_task_args_missing_net_id(self):
-        CONST.__setattr__('OS_AUTH_URL', None)
+        os.environ['OS_AUTH_URL'] = ''
         self.rally_base.priv_net_id = ''
         task_args = self.rally_base._build_task_args('test_file_name')
         self.assertEqual(task_args['netid'], '')
@@ -119,8 +113,8 @@ class OSRallyTesting(unittest.TestCase):
                      'installers': ['test_installer'],
                      'tests': ['other_test']}]})
     def test_excl_scenario_default(self, mock_func):
-        CONST.__setattr__('INSTALLER_TYPE', 'test_installer')
-        CONST.__setattr__('DEPLOY_SCENARIO', 'test_scenario')
+        os.environ['INSTALLER_TYPE'] = 'test_installer'
+        os.environ['DEPLOY_SCENARIO'] = 'test_scenario'
         self.assertEqual(self.rally_base.excl_scenario(), ['test'])
         mock_func.assert_called()
 
@@ -146,8 +140,8 @@ class OSRallyTesting(unittest.TestCase):
                      'installers': ['test_installer'],
                      'tests': ['test0b']}]})
     def test_excl_scenario_regex(self, mock_func):
-        CONST.__setattr__('INSTALLER_TYPE', 'test_installer')
-        CONST.__setattr__('DEPLOY_SCENARIO', 'os-ctrlT-featT-modeT')
+        os.environ['INSTALLER_TYPE'] = 'test_installer'
+        os.environ['DEPLOY_SCENARIO'] = 'os-ctrlT-featT-modeT'
         self.assertEqual(self.rally_base.excl_scenario(),
                          ['test1', 'test2', 'test3', 'test4'])
         mock_func.assert_called()
@@ -164,8 +158,8 @@ class OSRallyTesting(unittest.TestCase):
     @mock.patch('functest.opnfv_tests.openstack.rally.rally.RallyBase.'
                 '_migration_supported', return_value=False)
     def test_excl_func_default(self, mock_func, mock_yaml_load):
-        CONST.__setattr__('INSTALLER_TYPE', 'test_installer')
-        CONST.__setattr__('DEPLOY_SCENARIO', 'test_scenario')
+        os.environ['INSTALLER_TYPE'] = 'test_installer'
+        os.environ['DEPLOY_SCENARIO'] = 'test_scenario'
         self.assertEqual(self.rally_base.excl_func(), ['test'])
         mock_func.assert_called()
         mock_yaml_load.assert_called()
@@ -230,6 +224,7 @@ class OSRallyTesting(unittest.TestCase):
     @mock.patch('functest.opnfv_tests.openstack.rally.rally.subprocess.Popen')
     @mock.patch('functest.opnfv_tests.openstack.rally.rally.LOGGER.error')
     def test_run_task_taskid_missing(self, mock_logger_error, *args):
+        # pylint: disable=unused-argument
         self.rally_base._run_task('test_name')
         text = 'Failed to retrieve task_id, validating task...'
         mock_logger_error.assert_any_call(text)
@@ -257,6 +252,7 @@ class OSRallyTesting(unittest.TestCase):
     @mock.patch('functest.opnfv_tests.openstack.rally.rally.LOGGER.error')
     def test_run_task_default(self, mock_logger_error, mock_logger_info,
                               *args):
+        # pylint: disable=unused-argument
         self.rally_base._run_task('test_name')
         text = 'Test scenario: "test_name" OK.\n'
         mock_logger_info.assert_any_call(text)
@@ -268,107 +264,138 @@ class OSRallyTesting(unittest.TestCase):
         with self.assertRaises(Exception):
             self.rally_base._prepare_env()
 
-    @mock.patch('functest.opnfv_tests.openstack.snaps.snaps_utils.'
-                'get_active_compute_cnt')
-    @mock.patch('functest.opnfv_tests.openstack.snaps.snaps_utils.'
-                'get_ext_net_name', return_value='test_net_name')
-    @mock.patch('snaps.openstack.utils.deploy_utils.create_image',
-                return_value=None)
-    def test_prepare_env_image_missing(
-            self, mock_get_img, mock_get_net, mock_get_comp_cnt):
+    @mock.patch('functest.utils.functest_utils.get_external_network')
+    def test_prepare_env_image_missing(self, *args):
+        # pylint: disable=unused-argument
         self.rally_base.TESTS = ['test1', 'test2']
         self.rally_base.test_name = 'test1'
-        with self.assertRaises(Exception):
-            self.rally_base._prepare_env()
-        mock_get_img.assert_called()
-        mock_get_net.assert_called()
-        mock_get_comp_cnt.assert_called()
-
-    @mock.patch('functest.opnfv_tests.openstack.snaps.snaps_utils.'
-                'get_active_compute_cnt')
-    @mock.patch('functest.opnfv_tests.openstack.snaps.snaps_utils.'
-                'get_ext_net_name', return_value='test_net_name')
-    @mock.patch('snaps.openstack.utils.deploy_utils.create_image')
-    @mock.patch('snaps.openstack.utils.deploy_utils.create_network',
-                return_value=None)
-    def test_prepare_env_network_creation_failed(
-            self, mock_create_net, mock_get_img, mock_get_net,
-            mock_get_comp_cnt):
+        with mock.patch.object(self.rally_base.cloud, 'list_hypervisors'), \
+            mock.patch.object(self.rally_base.cloud, 'create_image',
+                              return_value=None):
+            with self.assertRaises(Exception):
+                self.rally_base._prepare_env()
+
+    @mock.patch('functest.utils.functest_utils.get_external_network')
+    def test_prepare_env_network_creation_failed(self, *args):
+        # pylint: disable=unused-argument
         self.rally_base.TESTS = ['test1', 'test2']
         self.rally_base.test_name = 'test1'
-        with self.assertRaises(Exception):
-            self.rally_base._prepare_env()
-        mock_create_net.assert_called()
-        mock_get_img.assert_called()
-        mock_get_net.assert_called()
-        mock_get_comp_cnt.assert_called()
-
-    @mock.patch('functest.opnfv_tests.openstack.snaps.snaps_utils.'
-                'get_active_compute_cnt')
-    @mock.patch('functest.opnfv_tests.openstack.snaps.snaps_utils.'
-                'get_ext_net_name', return_value='test_net_name')
-    @mock.patch('snaps.openstack.utils.deploy_utils.create_image')
-    @mock.patch('snaps.openstack.utils.deploy_utils.create_network')
-    @mock.patch('snaps.openstack.utils.deploy_utils.create_router',
-                return_value=None)
-    def test_prepare_env_router_creation_failed(
-            self, mock_create_router, mock_create_net, mock_get_img,
-            mock_get_net, mock_get_comp_cnt):
+        with mock.patch.object(self.rally_base.cloud,
+                               'list_hypervisors') as mock_list_hyperv, \
+            mock.patch.object(self.rally_base.cloud,
+                              'create_image') as mock_create_img, \
+            mock.patch.object(self.rally_base.cloud, 'create_network',
+                              return_value=None) as mock_create_net:
+            with self.assertRaises(Exception):
+                self.rally_base._prepare_env()
+            mock_create_net.assert_called()
+            mock_create_img.assert_called()
+            mock_list_hyperv.assert_called()
+
+    @mock.patch('functest.utils.functest_utils.get_external_network')
+    def test_prepare_env_subnet_creation_failed(self, *args):
+        # pylint: disable=unused-argument
         self.rally_base.TESTS = ['test1', 'test2']
         self.rally_base.test_name = 'test1'
-        with self.assertRaises(Exception):
-            self.rally_base._prepare_env()
-        mock_create_net.assert_called()
-        mock_get_img.assert_called()
-        mock_get_net.assert_called()
-        mock_create_router.assert_called()
-        mock_get_comp_cnt.assert_called()
-
-    @mock.patch('functest.opnfv_tests.openstack.snaps.snaps_utils.'
-                'get_active_compute_cnt')
-    @mock.patch('functest.opnfv_tests.openstack.snaps.snaps_utils.'
-                'get_ext_net_name', return_value='test_net_name')
-    @mock.patch('snaps.openstack.utils.deploy_utils.create_image')
-    @mock.patch('snaps.openstack.utils.deploy_utils.create_network')
-    @mock.patch('snaps.openstack.utils.deploy_utils.create_router')
-    @mock.patch('snaps.openstack.create_flavor.OpenStackFlavor.create',
-                return_value=None)
-    def test_prepare_env_flavor_creation_failed(
-            self, mock_create_flavor, mock_create_router, mock_create_net,
-            mock_get_img, mock_get_net, mock_get_comp_cnt):
+        with mock.patch.object(self.rally_base.cloud,
+                               'list_hypervisors') as mock_list_hyperv, \
+            mock.patch.object(self.rally_base.cloud,
+                              'create_image') as mock_create_img, \
+            mock.patch.object(self.rally_base.cloud,
+                              'create_network') as mock_create_net, \
+            mock.patch.object(self.rally_base.cloud, 'create_subnet',
+                              return_value=None) as mock_create_subnet:
+            with self.assertRaises(Exception):
+                self.rally_base._prepare_env()
+            mock_create_subnet.assert_called()
+            mock_create_net.assert_called()
+            mock_create_img.assert_called()
+            mock_list_hyperv.assert_called()
+
+    @mock.patch('functest.utils.functest_utils.get_external_network')
+    def test_prepare_env_router_creation_failed(self, *args):
+        # pylint: disable=unused-argument
         self.rally_base.TESTS = ['test1', 'test2']
         self.rally_base.test_name = 'test1'
-        with self.assertRaises(Exception):
-            self.rally_base._prepare_env()
-        mock_create_net.assert_called()
-        mock_get_img.assert_called()
-        mock_get_net.assert_called()
-        mock_create_router.assert_called()
-        mock_get_comp_cnt.assert_called()
-        mock_create_flavor.assert_called_once()
-
-    @mock.patch('functest.opnfv_tests.openstack.snaps.snaps_utils.'
-                'get_active_compute_cnt')
-    @mock.patch('functest.opnfv_tests.openstack.snaps.snaps_utils.'
-                'get_ext_net_name', return_value='test_net_name')
-    @mock.patch('snaps.openstack.utils.deploy_utils.create_image')
-    @mock.patch('snaps.openstack.utils.deploy_utils.create_network')
-    @mock.patch('snaps.openstack.utils.deploy_utils.create_router')
-    @mock.patch('snaps.openstack.create_flavor.OpenStackFlavor.create',
-                side_effect=[mock.Mock, None])
-    def test_prepare_env_flavor_alt_creation_failed(
-            self, mock_create_flavor, mock_create_router, mock_create_net,
-            mock_get_img, mock_get_net, mock_get_comp_cnt):
+        with mock.patch.object(self.rally_base.cloud,
+                               'list_hypervisors') as mock_list_hyperv, \
+            mock.patch.object(self.rally_base.cloud,
+                              'create_image') as mock_create_img, \
+            mock.patch.object(self.rally_base.cloud,
+                              'create_network') as mock_create_net, \
+            mock.patch.object(self.rally_base.cloud,
+                              'create_subnet') as mock_create_subnet, \
+            mock.patch.object(self.rally_base.cloud, 'create_router',
+                              return_value=None) as mock_create_router:
+            with self.assertRaises(Exception):
+                self.rally_base._prepare_env()
+            mock_create_router.assert_called()
+            mock_create_subnet.assert_called()
+            mock_create_net.assert_called()
+            mock_create_img.assert_called()
+            mock_list_hyperv.assert_called()
+
+    @mock.patch('functest.utils.functest_utils.get_external_network')
+    def test_prepare_env_flavor_creation_failed(self, *args):
+        # pylint: disable=unused-argument
         self.rally_base.TESTS = ['test1', 'test2']
         self.rally_base.test_name = 'test1'
-        with self.assertRaises(Exception):
-            self.rally_base._prepare_env()
-        mock_create_net.assert_called()
-        mock_get_img.assert_called()
-        mock_get_net.assert_called()
-        mock_create_router.assert_called()
-        mock_get_comp_cnt.assert_called()
-        self.assertEqual(mock_create_flavor.call_count, 2)
+        with mock.patch.object(self.rally_base.cloud,
+                               'list_hypervisors') as mock_list_hyperv, \
+            mock.patch.object(self.rally_base.cloud,
+                              'create_image') as mock_create_img, \
+            mock.patch.object(self.rally_base.cloud,
+                              'create_network') as mock_create_net, \
+            mock.patch.object(self.rally_base.cloud,
+                              'create_subnet') as mock_create_subnet, \
+            mock.patch.object(self.rally_base.cloud,
+                              'add_router_interface') as mock_add_router_if, \
+            mock.patch.object(self.rally_base.cloud,
+                              'create_router') as mock_create_router, \
+            mock.patch.object(self.rally_base.cloud, 'create_flavor',
+                              return_value=None) as mock_create_flavor:
+            with self.assertRaises(Exception):
+                self.rally_base._prepare_env()
+            mock_create_flavor.assert_called_once()
+            mock_add_router_if.assert_called()
+            mock_create_router.assert_called()
+            mock_create_subnet.assert_called()
+            mock_create_net.assert_called()
+            mock_create_img.assert_called()
+            mock_list_hyperv.assert_called()
+
+    @mock.patch('functest.utils.functest_utils.get_external_network')
+    def test_prepare_env_flavor_alt_creation_failed(self, *args):
+        # pylint: disable=unused-argument
+        self.rally_base.TESTS = ['test1', 'test2']
+        self.rally_base.test_name = 'test1'
+        with mock.patch.object(self.rally_base.cloud,
+                               'list_hypervisors') as mock_list_hyperv, \
+            mock.patch.object(self.rally_base.cloud,
+                              'create_image') as mock_create_img, \
+            mock.patch.object(self.rally_base.cloud,
+                              'create_network') as mock_create_net, \
+            mock.patch.object(self.rally_base.cloud,
+                              'create_subnet') as mock_create_subnet, \
+            mock.patch.object(self.rally_base.cloud,
+                              'add_router_interface') as mock_add_router_if, \
+            mock.patch.object(self.rally_base.cloud,
+                              'create_router') as mock_create_router, \
+            mock.patch.object(self.rally_base.cloud,
+                              'set_flavor_specs') as mock_set_flavor_specs, \
+            mock.patch.object(self.rally_base.cloud, 'create_flavor',
+                              side_effect=[mock.Mock(), None]) \
+                as mock_create_flavor:
+            with self.assertRaises(Exception):
+                self.rally_base._prepare_env()
+            self.assertEqual(mock_create_flavor.call_count, 2)
+            mock_set_flavor_specs.assert_called_once()
+            mock_add_router_if.assert_called()
+            mock_create_router.assert_called()
+            mock_create_subnet.assert_called()
+            mock_create_net.assert_called()
+            mock_create_img.assert_called()
+            mock_list_hyperv.assert_called()
 
     @mock.patch('functest.opnfv_tests.openstack.rally.rally.RallyBase.'
                 '_run_task')
@@ -388,12 +415,32 @@ class OSRallyTesting(unittest.TestCase):
         mock_run_task.assert_any_call('test1')
 
     def test_clean_up_default(self):
-        creator1 = mock.Mock()
-        creator2 = mock.Mock()
-        self.rally_base.creators = [creator1, creator2]
-        self.rally_base._clean_up()
-        self.assertTrue(creator1.clean.called)
-        self.assertTrue(creator2.clean.called)
+        with mock.patch.object(self.rally_base.cloud,
+                               'delete_flavor') as mock_delete_flavor, \
+            mock.patch.object(self.rally_base.cloud,
+                              'remove_router_interface') \
+            as mock_remove_router_if, \
+            mock.patch.object(self.rally_base.cloud,
+                              'delete_router') as mock_delete_router, \
+            mock.patch.object(self.rally_base.cloud,
+                              'delete_subnet') as mock_delete_subnet, \
+            mock.patch.object(self.rally_base.cloud,
+                              'delete_network') as mock_delete_net, \
+            mock.patch.object(self.rally_base.cloud,
+                              'delete_image') as mock_delete_img:
+            self.rally_base.flavor_alt = mock.Mock()
+            self.rally_base.flavor = mock.Mock()
+            self.rally_base.router = mock.Mock()
+            self.rally_base.subnet = mock.Mock()
+            self.rally_base.network = mock.Mock()
+            self.rally_base.image = mock.Mock()
+            self.rally_base._clean_up()
+            self.assertEqual(mock_delete_flavor.call_count, 2)
+            mock_remove_router_if.assert_called()
+            mock_delete_router.assert_called()
+            mock_delete_subnet.assert_called()
+            mock_delete_net.assert_called()
+            mock_delete_img.assert_called()
 
     @mock.patch('functest.opnfv_tests.openstack.tempest.conf_utils.'
                 'create_rally_deployment')
@@ -407,7 +454,8 @@ class OSRallyTesting(unittest.TestCase):
                 '_clean_up')
     def test_run_default(self, *args):
         self.assertEqual(self.rally_base.run(), testcase.TestCase.EX_OK)
-        map(lambda m: m.assert_called(), args)
+        for func in args:
+            func.assert_called()
 
     @mock.patch('functest.opnfv_tests.openstack.tempest.conf_utils.'
                 'create_rally_deployment', side_effect=Exception)
@@ -415,12 +463,12 @@ class OSRallyTesting(unittest.TestCase):
         self.assertEqual(self.rally_base.run(), testcase.TestCase.EX_RUN_ERROR)
         mock_create_rally_dep.assert_called()
 
-    @mock.patch('functest.opnfv_tests.openstack.rally.rally.RallyBase.'
-                '_prepare_env', side_effect=Exception)
     @mock.patch('functest.opnfv_tests.openstack.tempest.conf_utils.'
                 'create_rally_deployment', return_value=mock.Mock())
-    def test_run_exception_prepare_env(self, mock_create_rally_dep,
-                                       mock_prep_env):
+    @mock.patch('functest.opnfv_tests.openstack.rally.rally.RallyBase.'
+                '_prepare_env', side_effect=Exception)
+    def test_run_exception_prepare_env(self, mock_prep_env, *args):
+        # pylint: disable=unused-argument
         self.assertEqual(self.rally_base.run(), testcase.TestCase.EX_RUN_ERROR)
         mock_prep_env.assert_called()