Add suffixes in vnf keypair names
[functest.git] / functest / opnfv_tests / vnf / router / cloudify_vrouter.py
index 788a941..9a17268 100644 (file)
@@ -7,6 +7,8 @@
 # which accompanies this distribution, and is available at
 # http://www.apache.org/licenses/LICENSE-2.0
 
+# pylint: disable=missing-docstring
+
 """vrouter testcase implementation."""
 
 import logging
@@ -16,12 +18,12 @@ import time
 from cloudify_rest_client import CloudifyClient
 from cloudify_rest_client.executions import Execution
 from scp import SCPClient
-import yaml
 
 from functest.opnfv_tests.openstack.snaps import snaps_utils
 import functest.opnfv_tests.vnf.router.vrouter_base as vrouter_base
 from functest.opnfv_tests.vnf.router.utilvnf import Utilvnf
 from functest.utils.constants import CONST
+from functest.utils import functest_utils
 
 from git import Repo
 
@@ -50,6 +52,7 @@ __author__ = "Shuya Nakama <shuya.nakama@okinawaopenlabs.org>"
 
 
 class CloudifyVrouter(vrouter_base.VrouterOnBoardingBase):
+    # pylint: disable=too-many-instance-attributes
     """vrouter testcase deployed with Cloudify Orchestrator."""
 
     __logger = logging.getLogger(__name__)
@@ -76,35 +79,46 @@ class CloudifyVrouter(vrouter_base.VrouterOnBoardingBase):
 
         config_file = os.path.join(self.case_dir, self.config)
         self.orchestrator = dict(
-            requirements=get_config("orchestrator.requirements", config_file),
+            requirements=functest_utils.get_parameter_from_yaml(
+                "orchestrator.requirements", config_file),
         )
         self.details['orchestrator'] = dict(
-            name=get_config("orchestrator.name", config_file),
-            version=get_config("orchestrator.version", config_file),
+            name=functest_utils.get_parameter_from_yaml(
+                "orchestrator.name", config_file),
+            version=functest_utils.get_parameter_from_yaml(
+                "orchestrator.version", config_file),
             status='ERROR',
             result=''
         )
         self.__logger.debug("Orchestrator configuration %s", self.orchestrator)
         self.__logger.debug("name = %s", self.name)
         self.vnf = dict(
-            descriptor=get_config("vnf.descriptor", config_file),
-            inputs=get_config("vnf.inputs", config_file),
-            requirements=get_config("vnf.requirements", config_file)
+            descriptor=functest_utils.get_parameter_from_yaml(
+                "vnf.descriptor", config_file),
+            inputs=functest_utils.get_parameter_from_yaml(
+                "vnf.inputs", config_file),
+            requirements=functest_utils.get_parameter_from_yaml(
+                "vnf.requirements", config_file)
         )
         self.details['vnf'] = dict(
             descriptor_version=self.vnf['descriptor']['version'],
-            name=get_config("vnf.name", config_file),
-            version=get_config("vnf.version", config_file),
+            name=functest_utils.get_parameter_from_yaml(
+                "vnf.name", config_file),
+            version=functest_utils.get_parameter_from_yaml(
+                "vnf.version", config_file),
         )
         self.__logger.debug("VNF configuration: %s", self.vnf)
 
         self.util = Utilvnf()
 
         self.details['test_vnf'] = dict(
-            name=get_config("vnf_test_suite.name", config_file),
-            version=get_config("vnf_test_suite.version", config_file)
+            name=functest_utils.get_parameter_from_yaml(
+                "vnf_test_suite.name", config_file),
+            version=functest_utils.get_parameter_from_yaml(
+                "vnf_test_suite.version", config_file)
         )
-        self.images = get_config("tenant_images", config_file)
+        self.images = functest_utils.get_parameter_from_yaml(
+            "tenant_images", config_file)
         self.__logger.info("Images needed for vrouter: %s", self.images)
 
     def prepare(self):
@@ -112,10 +126,7 @@ class CloudifyVrouter(vrouter_base.VrouterOnBoardingBase):
 
         self.__logger.info("Additional pre-configuration steps")
 
-        self.util.set_credentials(self.snaps_creds.username,
-                                  self.snaps_creds.password,
-                                  self.snaps_creds.auth_url,
-                                  self.snaps_creds.project_name)
+        self.util.set_credentials(self.snaps_creds)
 
         # needs some images
         self.__logger.info("Upload some OS images if it doesn't exist")
@@ -124,14 +135,14 @@ class CloudifyVrouter(vrouter_base.VrouterOnBoardingBase):
             if image_file and image_name:
                 image_creator = OpenStackImage(
                     self.snaps_creds,
-                    ImageConfig(name=image_name,
-                                image_user='cloud',
-                                img_format='qcow2',
-                                image_file=image_file))
+                    ImageConfig(
+                        name=image_name, image_user='cloud',
+                        img_format='qcow2', image_file=image_file))
                 image_creator.create()
                 self.created_object.append(image_creator)
 
     def deploy_orchestrator(self):
+        # pylint: disable=too-many-locals,too-many-statements
         """
         Deploy Cloudify Manager.
         network, security group, fip, VM creation
@@ -141,17 +152,20 @@ class CloudifyVrouter(vrouter_base.VrouterOnBoardingBase):
         start_time = time.time()
         self.__logger.info("Creating keypair ...")
         kp_file = os.path.join(self.data_dir, "cloudify_vrouter.pem")
-        keypair_settings = KeypairConfig(name='cloudify_vrouter_kp',
-                                         private_filepath=kp_file)
+        keypair_settings = KeypairConfig(
+            name='cloudify_vrouter_kp-{}'.format(self.uuid),
+            private_filepath=kp_file)
         keypair_creator = OpenStackKeypair(self.snaps_creds, keypair_settings)
         keypair_creator.create()
         self.created_object.append(keypair_creator)
 
         self.__logger.info("Creating full network ...")
-        subnet_settings = SubnetConfig(name='cloudify_vrouter_subnet',
-                                       cidr='10.67.79.0/24')
-        network_settings = NetworkConfig(name='cloudify_vrouter_network',
-                                         subnet_settings=[subnet_settings])
+        subnet_settings = SubnetConfig(
+            name='cloudify_vrouter_subnet-{}'.format(self.uuid),
+            cidr='10.67.79.0/24')
+        network_settings = NetworkConfig(
+            name='cloudify_vrouter_network-{}'.format(self.uuid),
+            subnet_settings=[subnet_settings])
         network_creator = OpenStackNetwork(self.snaps_creds, network_settings)
         network_creator.create()
         self.created_object.append(network_creator)
@@ -159,7 +173,7 @@ class CloudifyVrouter(vrouter_base.VrouterOnBoardingBase):
         router_creator = OpenStackRouter(
             self.snaps_creds,
             RouterConfig(
-                name='cloudify_vrouter_router',
+                name='cloudify_vrouter_router-{}'.format(self.uuid),
                 external_gateway=ext_net_name,
                 internal_subnets=[subnet_settings.name]))
         router_creator.create()
@@ -169,20 +183,22 @@ class CloudifyVrouter(vrouter_base.VrouterOnBoardingBase):
         self.__logger.info("Creating security group for cloudify manager vm")
         sg_rules = list()
         sg_rules.append(
-            SecurityGroupRuleConfig(sec_grp_name="sg-cloudify-manager",
-                                    direction=Direction.ingress,
-                                    protocol=Protocol.tcp, port_range_min=1,
-                                    port_range_max=65535))
+            SecurityGroupRuleConfig(
+                sec_grp_name="sg-cloudify-manager-{}".format(self.uuid),
+                direction=Direction.ingress,
+                protocol=Protocol.tcp, port_range_min=1,
+                port_range_max=65535))
         sg_rules.append(
-            SecurityGroupRuleConfig(sec_grp_name="sg-cloudify-manager",
-                                    direction=Direction.ingress,
-                                    protocol=Protocol.udp, port_range_min=1,
-                                    port_range_max=65535))
+            SecurityGroupRuleConfig(
+                sec_grp_name="sg-cloudify-manager-{}".format(self.uuid),
+                direction=Direction.ingress,
+                protocol=Protocol.udp, port_range_min=1,
+                port_range_max=65535))
 
         security_group_creator = OpenStackSecurityGroup(
             self.snaps_creds,
             SecurityGroupConfig(
-                name="sg-cloudify-manager",
+                name="sg-cloudify-manager-{}".format(self.uuid),
                 rule_settings=sg_rules))
 
         security_group_creator.create()
@@ -204,24 +220,24 @@ class CloudifyVrouter(vrouter_base.VrouterOnBoardingBase):
             image_user='centos',
             exists=True)
 
-        port_settings = PortConfig(name='cloudify_manager_port',
-                                   network_name=network_settings.name)
+        port_settings = PortConfig(
+            name='cloudify_manager_port-{}'.format(self.uuid),
+            network_name=network_settings.name)
 
         manager_settings = VmInstanceConfig(
-            name='cloudify_manager',
+            name='cloudify_manager-{}'.format(self.uuid),
             flavor=flavor_settings.name,
             port_settings=[port_settings],
             security_group_names=[
                 security_group_creator.sec_grp_settings.name],
             floating_ip_settings=[FloatingIpConfig(
-                name='cloudify_manager_fip',
+                name='cloudify_manager_fip-{}'.format(self.uuid),
                 port_name=port_settings.name,
                 router_name=router_creator.router_settings.name)])
 
-        manager_creator = OpenStackVmInstance(self.snaps_creds,
-                                              manager_settings,
-                                              image_settings,
-                                              keypair_settings)
+        manager_creator = OpenStackVmInstance(
+            self.snaps_creds, manager_settings, image_settings,
+            keypair_settings)
 
         self.__logger.info("Creating cloudify manager VM")
         manager_creator.create()
@@ -231,15 +247,15 @@ class CloudifyVrouter(vrouter_base.VrouterOnBoardingBase):
             self.snaps_creds, 'identity')
 
         self.__logger.info("Set creds for cloudify manager")
-        cfy_creds = dict(keystone_username=self.tenant_name,
-                         keystone_password=self.tenant_name,
-                         keystone_tenant_name=self.tenant_name,
-                         keystone_url=public_auth_url)
+        cfy_creds = dict(
+            keystone_username=self.snaps_creds.username,
+            keystone_password=self.snaps_creds.password,
+            keystone_tenant_name=self.snaps_creds.project_name,
+            keystone_url=public_auth_url)
 
-        cfy_client = CloudifyClient(host=manager_creator.get_floating_ip().ip,
-                                    username='admin',
-                                    password='admin',
-                                    tenant='default_tenant')
+        cfy_client = CloudifyClient(
+            host=manager_creator.get_floating_ip().ip,
+            username='admin', password='admin', tenant='default_tenant')
 
         self.orchestrator['object'] = cfy_client
 
@@ -249,13 +265,14 @@ class CloudifyVrouter(vrouter_base.VrouterOnBoardingBase):
         cfy_status = None
         retry = 10
         while str(cfy_status) != 'running' and retry:
+            print cfy_client.manager.get_status()
             try:
                 cfy_status = cfy_client.manager.get_status()['status']
                 self.__logger.debug("The current manager status is %s",
                                     cfy_status)
             except Exception:  # pylint: disable=broad-except
-                self.__logger.warning("Cloudify Manager isn't " +
-                                      "up and running. Retrying ...")
+                self.__logger.exception(
+                    "Cloudify Manager isn't up and running. Retrying ...")
             retry = retry - 1
             time.sleep(30)
 
@@ -370,7 +387,8 @@ class CloudifyVrouter(vrouter_base.VrouterOnBoardingBase):
 
     def test_vnf(self):
         cfy_client = self.orchestrator['object']
-        credentials = {"username": self.snaps_creds.username,
+        credentials = {"snaps_creds": self.snaps_creds,
+                       "username": self.snaps_creds.username,
                        "password": self.snaps_creds.password,
                        "auth_url": self.snaps_creds.auth_url,
                        "tenant_name": self.snaps_creds.project_name}
@@ -410,7 +428,7 @@ class CloudifyVrouter(vrouter_base.VrouterOnBoardingBase):
                     try:
                         cfy_client.executions.cancel(execution['id'],
                                                      force=True)
-                    except:  # pylint: disable=broad-except
+                    except Exception:  # pylint: disable=broad-except
                         self.__logger.warn("Can't cancel the current exec")
 
             execution = cfy_client.executions.start(
@@ -421,51 +439,14 @@ class CloudifyVrouter(vrouter_base.VrouterOnBoardingBase):
             wait_for_execution(cfy_client, execution, self.__logger)
             cfy_client.deployments.delete(self.vnf['descriptor'].get('name'))
             cfy_client.blueprints.delete(self.vnf['descriptor'].get('name'))
-        except:  # pylint: disable=broad-except
+        except Exception:  # pylint: disable=broad-except
             self.__logger.warn("Some issue during the undeployment ..")
             self.__logger.warn("Tenant clean continue ..")
-
-        self.__logger.info('Remove the cloudify manager OS object ..')
-        for creator in reversed(self.created_object):
-            try:
-                creator.clean()
-            except Exception as exc:
-                self.logger.error('Unexpected error cleaning - %s', exc)
-
         super(CloudifyVrouter, self).clean()
 
-    def run(self, **kwargs):
-        """Execute CloudifyVrouter test case."""
-        return super(CloudifyVrouter, self).run(**kwargs)
-
     def get_vnf_info_list(self, target_vnf_name):
-        return self.util.get_vnf_info_list(self.cfy_manager_ip,
-                                           self.deployment_name,
-                                           target_vnf_name)
-
-
-# ----------------------------------------------------------
-#
-#               YAML UTILS
-#
-# -----------------------------------------------------------
-def get_config(parameter, file_path):
-    """
-    Get config parameter.
-    Returns the value of a given parameter in file.yaml
-    parameter must be given in string format with dots
-    Example: general.openstack.image_name
-    """
-    with open(file_path) as config_file:
-        file_yaml = yaml.safe_load(config_file)
-    config_file.close()
-    value = file_yaml
-    for element in parameter.split("."):
-        value = value.get(element)
-        if value is None:
-            raise ValueError("The parameter %s is not defined in"
-                             " reporting.yaml" % parameter)
-    return value
+        return self.util.get_vnf_info_list(
+            self.cfy_manager_ip, self.deployment_name, target_vnf_name)
 
 
 def wait_for_execution(client, execution, logger, timeout=7200, ):