Fix some pylint errors in onos package

[functest.git] / functest / opnfv_tests / sdn / onos / sfc / sfc_onos.py

diff --git a/functest/opnfv_tests/sdn/onos/sfc/sfc_onos.py b/functest/opnfv_tests/sdn/onos/sfc/sfc_onos.py
index 8ca32e9..4e93c13 100644 (file)
--- a/functest/opnfv_tests/sdn/onos/sfc/sfc_onos.py
+++ b/functest/opnfv_tests/sdn/onos/sfc/sfc_onos.py
@@ -1,4 +1,5 @@
-import os
+import logging
+import os
 import re
 import time
 import json
@@ -8,7 +9,7 @@ from multiprocessing import Process
 from multiprocessing import Queue
 from pexpect import pxssh
 
-import functest.utils.functest_logger as ft_logger
+from functest.utils.constants import CONST
 
 OK = 200
 CREATED = 201
@@ -16,12 +17,12 @@ ACCEPTED = 202
 NO_CONTENT = 204
 
 
-class SfcOnos:
+class SfcOnos(object):
     """Defines all the def function of SFC."""
 
     def __init__(self):
         """Initialization of variables."""
-        self.logger = ft_logger.Logger("sfc_fun").getLogger()
+        self.logger = logging.getLogger(__name__)
         self.osver = "v2.0"
         self.token_id = 0
         self.net_id = 0
@@ -99,6 +100,10 @@ class SfcOnos:
         self.ip_pool = 0
         self.vm_public_ip = []
         self.vm_public_id = []
+        self.cirros_username = CONST.__getattribute__(
+            'openstack_image_username')
+        self.cirros_password = CONST.__getattribute__(
+            'openstack_image_password')
         self.net_id1 = 0
         self.vm = []
         self.address = 0
@@ -112,7 +117,7 @@ class SfcOnos:
         data = ('{"auth": {"tenantName": "admin", "passwordCredentials":'
                 '{ "username": "admin", "password": "console"}}}')
         headers = {"Accept": "application/json"}
-        response = requests.post(url, headers=headers,  data=data)
+        response = requests.post(url, headers=headers, data=data)
         if (response.status_code == OK):
             json1_data = json.loads(response.content)
             self.logger.debug(response.status_code)
@@ -132,12 +137,12 @@ class SfcOnos:
         if self.admin_state_up != '':
             Dicdata['admin_state_up'] = self.admin_state_up
         Dicdata = {'network': Dicdata}
-        data = json.dumps(Dicdata,  indent=4)
+        data = json.dumps(Dicdata, indent=4)
         url = 'http://%s:9696/%s/networks' % (self.neutron_hostname,
                                               self.osver)
         headers = {"Accept": "application/json",
                    "X-Auth-Token": self.token_id}
-        response = requests.post(url, headers=headers,  data=data)
+        response = requests.post(url, headers=headers, data=data)
         if (response.status_code == CREATED):
             self.logger.debug(response.status_code)
             self.logger.debug(response.content)
@@ -167,7 +172,7 @@ class SfcOnos:
                                              self.osver)
         headers = {"Accept": "application/json",
                    "X-Auth-Token": self.token_id}
-        response = requests.post(url, headers=headers,  data=data)
+        response = requests.post(url, headers=headers, data=data)
 
         if (response.status_code == CREATED):
             self.logger.debug(response.status_code)
@@ -200,7 +205,7 @@ class SfcOnos:
                                                self.osver)
             headers = {"Accept": "application/json",
                        "X-Auth-Token": self.token_id}
-            response = requests.post(url, headers=headers,  data=data)
+            response = requests.post(url, headers=headers, data=data)
 
             if (response.status_code == CREATED):
                 self.logger.debug(response.status_code)
@@ -219,8 +224,9 @@ class SfcOnos:
         """Creation of Instance, using  firewall image."""
         url = ("http://%s:9292/v2/images?"
                "name=TestSfcVm" % (self.glance_hostname))
-        headers = {"Accept": "application/json", "Content-Type": "application/\
-                    octet-stream",  "X-Auth-Token": self.token_id}
+        headers = {"Accept": "application/json",
+                   "Content-Type": "application/octet-stream",
+                   "X-Auth-Token": self.token_id}
         response = requests.get(url, headers=headers)
         if (response.status_code == OK):
             self.logger.debug(response.status_code)
@@ -232,10 +238,8 @@ class SfcOnos:
         else:
             return(response.status_code)
 
-        url = ("http://%s:8774//v2.1/%s/ports/"
-               "%s/flavors?name=m1.tiny" % (self.nova_hostname,
-                                            self.tenant_id))
-
+        url = ("http://%s:8774/v2.1/%s/flavors?"
+               "name=m1.tiny" % (self.nova_hostname, self.tenant_id))
         headers = {"Accept": "application/json", "Content-Type":
                    "application/json", "X-Auth-Token": self.token_id}
         response = requests.get(url, headers=headers)
@@ -272,7 +276,7 @@ class SfcOnos:
                                                       self.tenant_id)
             headers = {"Accept": "application/json", "Content-Type":
                        "application/json", "X-Auth-Token": self.token_id}
-            response = requests.post(url, headers=headers,  data=data)
+            response = requests.post(url, headers=headers, data=data)
             if (response.status_code == ACCEPTED):
                 self.logger.debug(response.status_code)
                 self.logger.debug(response.content)
@@ -294,8 +298,8 @@ class SfcOnos:
         for y in range(0, 3):
             url = ("http://%s:8774/v2.1/servers/"
                    "detail?name=vm" + str(y)) % (self.neutron_hostname)
-            headers = {"Accept": "application/json",  "X-Auth-Token":
-                       self.token_id}
+            headers = {"Accept": "application/json",
+                       "X-Auth-Token": self.token_id}
             response = requests.get(url, headers=headers)
             if (response.status_code == OK):
                 self.logger.debug(response.status_code)
@@ -331,7 +335,7 @@ class SfcOnos:
                                                         self.osver)
             headers = {"Accept": "application/json", "X-Auth-Token":
                        self.token_id}
-            response = requests.post(url, headers=headers,  data=data)
+            response = requests.post(url, headers=headers, data=data)
             if (response.status_code == CREATED):
                 info = ("Creation of Port Pair PP" + str(p) +
                         " is successful")
@@ -344,7 +348,7 @@ class SfcOnos:
     def getPortPair(self):
         """Query the Portpair id value."""
         for p in range(0, 1):
-            url = ("http://%s:9696/%s/ports/"
+            url = ("http://%s:9696/%s/"
                    "sfc/port_pairs?name=PP1" % (self.neutron_hostname,
                                                 self.osver))
             headers = {"Accept": "application/json",
@@ -379,7 +383,7 @@ class SfcOnos:
                                              self.osver))
             headers = {"Accept": "application/json", "X-Auth-Token":
                        self.token_id}
-            response = requests.post(url, headers=headers,  data=data)
+            response = requests.post(url, headers=headers, data=data)
             if (response.status_code == CREATED):
                 info = ("Creation of Port Group PG" + str(p) +
                         "is successful")
@@ -430,7 +434,7 @@ class SfcOnos:
                                          self.osver))
         headers = {"Accept": "application/json",
                    "X-Auth-Token": self.token_id}
-        response = requests.post(url, headers=headers,  data=data)
+        response = requests.post(url, headers=headers, data=data)
         if (response.status_code == CREATED):
             json1_data = json.loads(response.content)
             self.flow_class_if = json1_data['flow_classifier']['id']
@@ -461,7 +465,7 @@ class SfcOnos:
         headers = {"Accept": "application/json",
                    "Content-Type": "application/json",
                    "X-Auth-Token": self.token_id}
-        response = requests.post(url, headers=headers,  data=data)
+        response = requests.post(url, headers=headers, data=data)
         if (response.status_code == CREATED):
             self.logger.debug("Creation of PORT CHAIN is successful")
             json1_data = json.loads(response.content)
@@ -475,7 +479,7 @@ class SfcOnos:
         time.sleep(5)
         response = requests.get('http://' + self.onos_hostname +
                                 ':8181/onos/v1/flows',
-                                auth=("karaf",  "karaf"))
+                                auth=("karaf", "karaf"))
         if (response.status_code == OK):
             self.logger.debug("Flow is successfully Queries")
             json1_data = json.loads(response.content)
@@ -504,7 +508,7 @@ class SfcOnos:
                                                   self.osver)
         headers = {"Accept": "application/json",
                    "X-Auth-Token": self.token_id}
-        response = requests.post(url, headers=headers,  data=data)
+        response = requests.post(url, headers=headers, data=data)
         if (response.status_code == CREATED):
             self.logger.debug(response.status_code)
             self.logger.debug(response.content)
@@ -547,7 +551,7 @@ class SfcOnos:
                                              self.router_id))
         headers = {"Accept": "application/json",
                    "X-Auth-Token": self.token_id}
-        response = requests.put(url, headers=headers,  data=data)
+        response = requests.put(url, headers=headers, data=data)
         if (response.status_code == OK):
             self.logger.debug(response.status_code)
             self.logger.debug(response.content)
@@ -569,7 +573,7 @@ class SfcOnos:
                                                 self.router_id)
         headers = {"Accept": "application/json",
                    "X-Auth-Token": self.token_id}
-        response = requests.put(url, headers=headers,  data=data)
+        response = requests.put(url, headers=headers, data=data)
         if (response.status_code == OK):
             self.logger.debug(response.status_code)
             self.logger.debug(response.content)
@@ -589,7 +593,7 @@ class SfcOnos:
                    "os-floating-ips" % (self.nova_hostname))
             headers = {"Accept": "application/json",
                        "X-Auth-Token": self.token_id}
-            response = requests.post(url, headers=headers,  data=data)
+            response = requests.post(url, headers=headers, data=data)
             if (response.status_code == OK):
                 self.logger.debug(response.status_code)
                 self.logger.debug(response.content)
@@ -613,7 +617,7 @@ class SfcOnos:
 
             headers = {"Accept": "application/json",
                        "X-Auth-Token": self.token_id}
-            response = requests.post(url, headers=headers,  data=data)
+            response = requests.post(url, headers=headers, data=data)
             if(response.status_code == ACCEPTED):
                 self.logger.debug(response.status_code)
                 self.logger.debug(response.content)
@@ -630,14 +634,12 @@ class SfcOnos:
 
             s = pxssh.pxssh()
             hostname = self.vm_public_ip[0]
-            username = "cirros"
-            password = "cubswin:)"
-            s.login(hostname,  username,  password)
+            s.login(hostname, self.cirros_username, self.cirros_password)
             s.sendline("ping -c 5 " + str(self.port_ip[2]))
             s.prompt()             # match the prompt
 
-            ping_re = re.search("transmitted.*received",  s.before).group()
-            x = re.split('\s+',  ping_re)
+            ping_re = re.search("transmitted.*received", s.before).group()
+            x = re.split('\s+', ping_re)
             if (x[1] >= "1"):
                 self.logger.info("Ping is Successfull")
             else:
@@ -646,9 +648,7 @@ class SfcOnos:
         def vm1(queue1):
             s = pxssh.pxssh()
             hostname = self.vm_public_ip[1]
-            username = "cirros"
-            password = "cubswin:)"
-            s.login(hostname,  username,  password)
+            s.login(hostname, self.cirros_username, self.cirros_password)
             s.sendline('sudo ./firewall')
             s.prompt()
             output_pack = s.before
@@ -679,7 +679,7 @@ class SfcOnos:
         if result0 == 0 and result1 == 0:
             time.sleep(300)
             queue1 = Queue()
-            p1 = Process(target=vm1,  args=(queue1, ))
+            p1 = Process(target=vm1, args=(queue1, ))
             p1.start()
             p2 = Process(target=vm0)
             p2.start()
@@ -706,7 +706,7 @@ class SfcOnos:
         """Check the PC SF Map Stats in the ONOS."""
         response = requests.get('http://' + self.onos_hostname +
                                 ':8181/onos/vtn/portChainSfMap/' +
-                                self.PC_id, auth=("karaf",  "karaf"))
+                                self.PC_id, auth=("karaf", "karaf"))
         if (response.status_code == OK):
             self.logger.info("portChainSfMap is successfully Queries")
             return(response.status_code)
@@ -764,7 +764,7 @@ class SfcOnos:
 
     def deletePortPair(self):
         """Deletion of Portpair."""
-        for p in range(1,  2):
+        for p in range(1, 2):
             url = ("http://%s:9696/%s/sfc/"
                    "port_pairs/%s" % (self.neutron_hostname,
                                       self.osver,
@@ -822,7 +822,7 @@ class SfcOnos:
                                 self.router_id))
         headers = {"Accept": "application/json",
                    "X-Auth-Token": self.token_id}
-        response = requests.put(url, headers=headers,  data=data)
+        response = requests.put(url, headers=headers, data=data)
         if (response.status_code == OK):
             self.logger.debug(response.status_code)
             self.logger.debug(response.content)
@@ -836,14 +836,14 @@ class SfcOnos:
                                                       self.router_id))
             headers = {"Accept": "application/json",
                        "X-Auth-Token": self.token_id}
-            response = requests.put(url, headers=headers,  data=data)
+            response = requests.put(url, headers=headers, data=data)
             if (response.status_code == OK):
                 url = ("http://%s:9696/%s/"
                        "routers/%s" % (self.neutron_hostname,
                                        self.osver,
                                        self.router_id))
-                headers = {"Accept": "application/json",  "X-Auth-Token":
-                           self.token_id}
+                headers = {"Accept": "application/json",
+                           "X-Auth-Token": self.token_id}
                 response = requests.delete(url, headers=headers)
                 if (response.status_code == NO_CONTENT):
                     self.logger.debug(response.status_code)