Added initial VLAN support with vdev devices
[samplevnf.git] / VNFs / DPPD-PROX / prox_port_cfg.c
index a71d0cc..2abf4d5 100644 (file)
@@ -1,5 +1,5 @@
 /*
-// Copyright (c) 2010-2017 Intel Corporation
+// Copyright (c) 2010-2020 Intel Corporation
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -31,6 +31,9 @@
 #endif
 #endif
 
+#include <sys/ioctl.h>
+#include <net/if.h>
+
 #include "prox_port_cfg.h"
 #include "prox_globals.h"
 #include "log.h"
@@ -41,6 +44,7 @@
 #include "prox_cksum.h"
 #include "stats_irq.h"
 #include "prox_compat.h"
+#include "rte_ethdev.h"
 
 struct prox_port_cfg prox_port_cfg[PROX_MAX_PORTS];
 rte_atomic32_t lsc;
@@ -103,10 +107,10 @@ void prox_pktmbuf_init(struct rte_mempool *mp, void *opaque_arg, void *_m, unsig
        struct rte_mbuf *mbuf = _m;
 
 #if RTE_VERSION >= RTE_VERSION_NUM(1,8,0,0)
-       mbuf->tx_offload = CALC_TX_OL(sizeof(struct ether_hdr), sizeof(struct ipv4_hdr));
+       mbuf->tx_offload = CALC_TX_OL(sizeof(prox_rte_ether_hdr), sizeof(prox_rte_ipv4_hdr));
 #else
-       mbuf->pkt.vlan_macip.f.l2_len = sizeof(struct ether_hdr);
-       mbuf->pkt.vlan_macip.f.l3_len = sizeof(struct ipv4_hdr);
+       mbuf->pkt.vlan_macip.f.l2_len = sizeof(prox_rte_ether_hdr);
+       mbuf->pkt.vlan_macip.f.l3_len = sizeof(prox_rte_ipv4_hdr);
 #endif
 
        rte_pktmbuf_init(mp, opaque_arg, mbuf, i);
@@ -160,15 +164,81 @@ void prox_pktmbuf_reinit(void *arg, void *start, __attribute__((unused)) void *e
         }\
 
 
+static void set_ip_address (char *devname, uint32_t *ip)
+{
+       struct ifreq ifreq;
+       struct sockaddr_in in_addr;
+       int fd, rc;
+
+       memset(&ifreq, 0, sizeof(struct ifreq));
+       memset(&in_addr, 0, sizeof(struct sockaddr_in));
+
+       in_addr.sin_family = AF_INET;
+       in_addr.sin_addr = *(struct in_addr *)ip;
+       fd = socket(in_addr.sin_family, SOCK_DGRAM, 0);
+
+       strncpy(ifreq.ifr_name, devname, IFNAMSIZ);
+       ifreq.ifr_addr = *(struct sockaddr *)&in_addr;
+       rc = ioctl(fd, SIOCSIFADDR, &ifreq);
+       PROX_PANIC(rc < 0, "Failed to set IP address %d on device %s: error = %d\n", *ip, devname, errno);
+       close(fd);
+}
+
 /* initialize rte devices and check the number of available ports */
 void init_rte_dev(int use_dummy_devices)
 {
        uint8_t nb_ports, port_id_max;
-       int port_id_last;
+       int port_id_last, rc = 0;
        struct rte_eth_dev_info dev_info;
        const struct rte_pci_device *pci_dev;
 
-       nb_ports = rte_eth_dev_count();
+       for (uint8_t port_id = 0; port_id < PROX_MAX_PORTS; ++port_id) {
+               if (!prox_port_cfg[port_id].active) {
+                       continue;
+               }
+               struct prox_port_cfg* port_cfg = &prox_port_cfg[port_id];
+               if (port_cfg->vdev[0]) {
+#if (RTE_VERSION > RTE_VERSION_NUM(17,5,0,1))
+                       char name[MAX_NAME_SIZE], tap[MAX_NAME_SIZE];
+                       snprintf(tap, MAX_NAME_SIZE, "net_tap%d", port_id);
+                       snprintf(name, MAX_NAME_SIZE, "iface=%s", port_cfg->vdev);
+                       rc = rte_vdev_init(tap, name);
+#else
+                       rc = eth_dev_null_create(tap, name, PROX_RTE_ETHER_MIN_LEN, 0);
+#endif
+                       PROX_PANIC(rc != 0, "Unable to create device %s %s\n", "net tap", port_cfg->vdev);
+                       int vdev_port_id = rte_eth_dev_count() - 1;
+                       PROX_PANIC(vdev_port_id >= PROX_MAX_PORTS, "Too many port defined %d >= %d\n", vdev_port_id, PROX_MAX_PORTS);
+                       plog_info("\tCreating device %s, port %d\n", port_cfg->vdev, vdev_port_id);
+                       prox_port_cfg[vdev_port_id].active = 1;
+                       prox_port_cfg[vdev_port_id].dpdk_mapping = port_id;
+                       prox_port_cfg[vdev_port_id].n_txq = 1;
+
+                       if (prox_port_cfg[port_id].vlan_tag) {
+                               char command[1024];
+                               snprintf(prox_port_cfg[vdev_port_id].name, MAX_NAME_SIZE, "%s_%d", port_cfg->vdev, prox_port_cfg[port_id].vlan_tag);
+                               sprintf(command, "ip link add link %s name %s type vlan id %d", port_cfg->vdev, prox_port_cfg[vdev_port_id].name, prox_port_cfg[port_id].vlan_tag);
+                               system(command);
+                               plog_info("Running %s\n", command);
+                               plog_info("Using vlan tag %d - added device %s\n", prox_port_cfg[port_id].vlan_tag, prox_port_cfg[vdev_port_id].name);
+                       } else
+                               strncpy(prox_port_cfg[vdev_port_id].name, port_cfg->vdev, MAX_NAME_SIZE);
+
+                       prox_port_cfg[port_id].dpdk_mapping = vdev_port_id;
+                       prox_port_cfg[vdev_port_id].ip = rte_be_to_cpu_32(prox_port_cfg[port_id].ip);
+                       prox_port_cfg[port_id].ip = 0;  // So only vdev has an IP associated
+                       prox_port_cfg[vdev_port_id].type = prox_port_cfg[port_id].type;
+                       if (prox_port_cfg[vdev_port_id].type == PROX_PORT_MAC_HW) {
+                               // If DPDK port MAC set to HW, then make sure the vdev has the same MAC as DPDK port
+                               prox_port_cfg[vdev_port_id].type = PROX_PORT_MAC_SET;
+                               rte_eth_macaddr_get(port_id, &prox_port_cfg[vdev_port_id].eth_addr);
+                               plog_info("\tDPDK port %d MAC address pre-configured to MAC from port %d: "MAC_BYTES_FMT"\n",
+                                       vdev_port_id, port_id, MAC_BYTES(prox_port_cfg[vdev_port_id].eth_addr.addr_bytes));
+                       } else
+                               memcpy(&prox_port_cfg[vdev_port_id].eth_addr, &prox_port_cfg[port_id].eth_addr, sizeof(prox_port_cfg[port_id].eth_addr));
+               }
+       }
+       nb_ports = prox_rte_eth_dev_count_avail();
        /* get available ports configuration */
        PROX_PANIC(use_dummy_devices && nb_ports, "Can't use dummy devices while there are also real ports\n");
 
@@ -180,9 +250,9 @@ void init_rte_dev(int use_dummy_devices)
                char port_name[32] = "0dummy_dev";
                for (uint32_t i = 0; i < nb_ports; ++i) {
 #if (RTE_VERSION > RTE_VERSION_NUM(17,5,0,1))
-                       rte_vdev_init(port_name, "size=ETHER_MIN_LEN,copy=0");
+                       rte_vdev_init(port_name, "size=64,copy=0");
 #else
-                       eth_dev_null_create(port_name, 0, ETHER_MIN_LEN, 0);
+                       eth_dev_null_create(port_name, 0, PROX_RTE_ETHER_MIN_LEN, 0);
 #endif
                        port_name[0]++;
                }
@@ -223,32 +293,39 @@ void init_rte_dev(int use_dummy_devices)
                port_cfg->max_rxq = dev_info.max_rx_queues;
                port_cfg->max_rx_pkt_len = dev_info.max_rx_pktlen;
                port_cfg->min_rx_bufsize = dev_info.min_rx_bufsize;
+               port_cfg->min_tx_desc = dev_info.tx_desc_lim.nb_min;
+               port_cfg->max_tx_desc = dev_info.tx_desc_lim.nb_max;
+               port_cfg->min_rx_desc = dev_info.rx_desc_lim.nb_min;
+               port_cfg->max_rx_desc = dev_info.rx_desc_lim.nb_max;
 
-#if RTE_VERSION < RTE_VERSION_NUM(18,5,0,0)
-               pci_dev = dev_info.pci_dev;
-#else
-               pci_dev = RTE_DEV_TO_PCI(dev_info.device);
-#endif
-               if (!pci_dev)
-                       continue;
-
-               snprintf(port_cfg->pci_addr, sizeof(port_cfg->pci_addr),
-                        "%04x:%02x:%02x.%1x", pci_dev->addr.domain, pci_dev->addr.bus, pci_dev->addr.devid, pci_dev->addr.function);
-               strncpy(port_cfg->driver_name, dev_info.driver_name, sizeof(port_cfg->driver_name));
+               prox_strncpy(port_cfg->driver_name, dev_info.driver_name, sizeof(port_cfg->driver_name));
                plog_info("\tPort %u : driver='%s' tx_queues=%d rx_queues=%d\n", port_id, !strcmp(port_cfg->driver_name, "")? "null" : port_cfg->driver_name, port_cfg->max_txq, port_cfg->max_rxq);
+               plog_info("\tPort %u : %d<=nb_tx_desc<=%d %d<=nb_rx_desc<=%d\n", port_id, port_cfg->min_tx_desc, port_cfg->max_tx_desc, port_cfg->min_rx_desc, port_cfg->max_rx_desc);
 
                if (strncmp(port_cfg->driver_name, "rte_", 4) == 0) {
-                       strncpy(port_cfg->short_name, prox_port_cfg[port_id].driver_name + 4, sizeof(port_cfg->short_name));
+                       prox_strncpy(port_cfg->short_name, prox_port_cfg[port_id].driver_name + 4, sizeof(port_cfg->short_name));
                } else if (strncmp(port_cfg->driver_name, "net_", 4) == 0) {
-                       strncpy(port_cfg->short_name, prox_port_cfg[port_id].driver_name + 4, sizeof(port_cfg->short_name));
+                       prox_strncpy(port_cfg->short_name, prox_port_cfg[port_id].driver_name + 4, sizeof(port_cfg->short_name));
                } else {
-                       strncpy(port_cfg->short_name, prox_port_cfg[port_id].driver_name, sizeof(port_cfg->short_name));
+                       prox_strncpy(port_cfg->short_name, prox_port_cfg[port_id].driver_name, sizeof(port_cfg->short_name));
                }
                char *ptr;
                if ((ptr = strstr(port_cfg->short_name, "_pmd")) != NULL) {
                        *ptr = '\x0';
                }
 
+#if RTE_VERSION < RTE_VERSION_NUM(18,5,0,0)
+               pci_dev = dev_info.pci_dev;
+#else
+               if (!dev_info.device)
+                       continue;
+               pci_dev = RTE_DEV_TO_PCI(dev_info.device);
+#endif
+               if (!pci_dev)
+                       continue;
+
+               snprintf(port_cfg->pci_addr, sizeof(port_cfg->pci_addr),
+                        "%04x:%02x:%02x.%1x", pci_dev->addr.domain, pci_dev->addr.bus, pci_dev->addr.devid, pci_dev->addr.function);
                /* Try to find the device's numa node */
                char buf[1024];
                snprintf(buf, sizeof(buf), "/sys/bus/pci/devices/%s/numa_node", port_cfg->pci_addr);
@@ -273,6 +350,13 @@ void init_rte_dev(int use_dummy_devices)
                        plog_info("\t\tDisabling UDP cksum on vmxnet3\n");
                        port_cfg->disabled_tx_offload |= DEV_TX_OFFLOAD_UDP_CKSUM;
                }
+               // Some OVS versions reports that they support UDP offload and no IPv4 offload, but fails when UDP offload is enabled
+               if ((!strcmp(port_cfg->short_name, "virtio")) &&
+                       ((port_cfg->dev_info.tx_offload_capa & DEV_TX_OFFLOAD_IPV4_CKSUM) == 0) &&
+                       (port_cfg->dev_info.tx_offload_capa & DEV_TX_OFFLOAD_UDP_CKSUM)) {
+                       plog_info("\t\tDisabling UDP cksum on virtio\n");
+                       port_cfg->disabled_tx_offload |= DEV_TX_OFFLOAD_UDP_CKSUM;
+               }
        }
 }
 
@@ -307,12 +391,9 @@ uint8_t init_rte_ring_dev(void)
        return nb_ring_dev;
 }
 
-static void init_port(struct prox_port_cfg *port_cfg)
+static void print_port_capa(struct prox_port_cfg *port_cfg)
 {
-       static char dummy_pool_name[] = "0_dummy";
-       struct rte_eth_link link;
        uint8_t port_id;
-       int ret;
 
        port_id = port_cfg - prox_port_cfg;
        plog_info("\t*** Initializing port %u ***\n", port_id);
@@ -322,54 +403,8 @@ static void init_port(struct prox_port_cfg *port_cfg)
 #if RTE_VERSION >= RTE_VERSION_NUM(16,4,0,0)
        plog_info("\t\tSupported speed mask = 0x%x\n", port_cfg->dev_info.speed_capa);
 #endif
-
-       PROX_PANIC(port_cfg->n_rxq == 0 && port_cfg->n_txq == 0,
-                  "\t\t port %u is enabled but no RX or TX queues have been configured", port_id);
-
-       if (port_cfg->n_rxq == 0) {
-               /* not receiving on this port */
-               plog_info("\t\tPort %u had no RX queues, setting to 1\n", port_id);
-               port_cfg->n_rxq = 1;
-               uint32_t mbuf_size = TX_MBUF_SIZE;
-               plog_info("\t\tAllocating dummy memory pool on socket %u with %u elements of size %u\n",
-                         port_cfg->socket, port_cfg->n_rxd, mbuf_size);
-               port_cfg->pool[0] = rte_mempool_create(dummy_pool_name, port_cfg->n_rxd, mbuf_size,
-                                                      0,
-                                                      sizeof(struct rte_pktmbuf_pool_private),
-                                                      rte_pktmbuf_pool_init, NULL,
-                                                      prox_pktmbuf_init, 0,
-                                                      port_cfg->socket, 0);
-               PROX_PANIC(port_cfg->pool[0] == NULL, "Failed to allocate dummy memory pool on socket %u with %u elements\n",
-                          port_cfg->socket, port_cfg->n_rxd);
-               dummy_pool_name[0]++;
-       } else {
-               // Most pmd should now support setting mtu
-               if (port_cfg->mtu + ETHER_HDR_LEN + ETHER_CRC_LEN > port_cfg->max_rx_pkt_len) {
-                       plog_info("\t\tMTU is too big for the port, reducing MTU from %d to %d\n", port_cfg->mtu, port_cfg->max_rx_pkt_len);
-                       port_cfg->mtu = port_cfg->max_rx_pkt_len;
-               }
-               plog_info("\t\tSetting MTU size to %u for port %u ...\n", port_cfg->mtu, port_id);
-               ret = rte_eth_dev_set_mtu(port_id, port_cfg->mtu);
-               if (ret)
-                       plog_err("\t\t\trte_eth_dev_set_mtu() failed on port %u: error %d\n", port_id, ret);
-
-               if (port_cfg->n_txq == 0) {
-                       /* not sending on this port */
-                       plog_info("\t\tPort %u had no TX queues, setting to 1\n", port_id);
-                       port_cfg->n_txq = 1;
-               }
-       }
-
-       if (port_cfg->n_rxq > 1)  {
-               // Enable RSS if multiple receive queues
-               port_cfg->port_conf.rxmode.mq_mode                      |= ETH_MQ_RX_RSS;
-               port_cfg->port_conf.rx_adv_conf.rss_conf.rss_key        = toeplitz_init_key;
-               port_cfg->port_conf.rx_adv_conf.rss_conf.rss_key_len    = TOEPLITZ_KEY_LEN;
-#if RTE_VERSION >= RTE_VERSION_NUM(2,0,0,0)
-               port_cfg->port_conf.rx_adv_conf.rss_conf.rss_hf         = ETH_RSS_IPV4|ETH_RSS_NONFRAG_IPV4_UDP;
-#else
-               port_cfg->port_conf.rx_adv_conf.rss_conf.rss_hf         = ETH_RSS_IPV4|ETH_RSS_NONF_IPV4_UDP;
-#endif
+       if (port_cfg->max_link_speed != UINT32_MAX) {
+               plog_info("\t\tHighest link speed capa = %d Mbps\n", port_cfg->max_link_speed);
        }
 
 #if RTE_VERSION >= RTE_VERSION_NUM(18,8,0,1)
@@ -398,8 +433,14 @@ static void init_port(struct prox_port_cfg *port_cfg)
                plog_info("VLAN EXTEND | ");
        if (port_cfg->dev_info.rx_offload_capa & DEV_RX_OFFLOAD_JUMBO_FRAME)
                plog_info("JUMBO FRAME | ");
+#if defined(DEV_RX_OFFLOAD_CRC_STRIP)
        if (port_cfg->dev_info.rx_offload_capa & DEV_RX_OFFLOAD_CRC_STRIP)
                plog_info("CRC STRIP | ");
+#endif
+#if defined(DEV_RX_OFFLOAD_KEEP_CRC)
+       if (port_cfg->dev_info.rx_offload_capa & DEV_RX_OFFLOAD_KEEP_CRC)
+               plog_info("KEEP CRC | ");
+#endif
        if (port_cfg->dev_info.rx_offload_capa & DEV_RX_OFFLOAD_SCATTER)
                plog_info("SCATTER | ");
        if (port_cfg->dev_info.rx_offload_capa & DEV_RX_OFFLOAD_TIMESTAMP)
@@ -455,11 +496,128 @@ static void init_port(struct prox_port_cfg *port_cfg)
        plog_info("\t\tdefault RX port conf: burst_size = %d, ring_size = %d, nb_queues = %d\n", port_cfg->dev_info.default_rxportconf.burst_size, port_cfg->dev_info.default_rxportconf.ring_size, port_cfg->dev_info.default_rxportconf.nb_queues);
        plog_info("\t\tdefault TX port conf: burst_size = %d, ring_size = %d, nb_queues = %d\n", port_cfg->dev_info.default_txportconf.burst_size, port_cfg->dev_info.default_txportconf.ring_size, port_cfg->dev_info.default_txportconf.nb_queues);
 #endif
+}
+
+static void get_max_link_speed(struct prox_port_cfg *port_cfg)
+{
+       port_cfg->max_link_speed = UINT32_MAX;
+
+#if RTE_VERSION >= RTE_VERSION_NUM(16,4,0,0)
+       // virtio and vmxnet3 reports fake max_link_speed
+       if (strcmp(port_cfg->short_name, "vmxnet3") && strcmp(port_cfg->short_name, "virtio")) {
+               // Get link_speed from highest capability from the port
+               // This will be used by gen and lat for extrapolation purposes
+               // The negotiated link_speed (as reported by rte_eth_link_get
+               // or rte_eth_link_get_nowait) might be reported too late
+               // and might result in wrong exrapolation, and hence should not be used
+               // for extrapolation purposes
+               if (port_cfg->dev_info.speed_capa & ETH_LINK_SPEED_100G)
+                       port_cfg->max_link_speed = ETH_SPEED_NUM_100G;
+               else if (port_cfg->dev_info.speed_capa & ETH_LINK_SPEED_56G)
+                       port_cfg->max_link_speed = ETH_SPEED_NUM_56G;
+               else if (port_cfg->dev_info.speed_capa & ETH_LINK_SPEED_50G)
+                       port_cfg->max_link_speed = ETH_SPEED_NUM_50G;
+               else if (port_cfg->dev_info.speed_capa & ETH_LINK_SPEED_40G)
+                       port_cfg->max_link_speed = ETH_SPEED_NUM_40G;
+               else if (port_cfg->dev_info.speed_capa & ETH_LINK_SPEED_25G)
+                       port_cfg->max_link_speed = ETH_SPEED_NUM_25G;
+               else if (port_cfg->dev_info.speed_capa & ETH_LINK_SPEED_20G)
+                       port_cfg->max_link_speed = ETH_SPEED_NUM_20G;
+               else if (port_cfg->dev_info.speed_capa & ETH_LINK_SPEED_10G)
+                       port_cfg->max_link_speed = ETH_SPEED_NUM_10G;
+               else if (port_cfg->dev_info.speed_capa & ETH_LINK_SPEED_5G)
+                       port_cfg->max_link_speed = ETH_SPEED_NUM_5G;
+               else if (port_cfg->dev_info.speed_capa & ETH_LINK_SPEED_2_5G)
+                       port_cfg->max_link_speed = ETH_SPEED_NUM_2_5G;
+               else if (port_cfg->dev_info.speed_capa & ETH_LINK_SPEED_1G)
+                       port_cfg->max_link_speed = ETH_SPEED_NUM_1G;
+               else if (port_cfg->dev_info.speed_capa & (ETH_LINK_SPEED_100M_HD | ETH_LINK_SPEED_100M))
+                       port_cfg->max_link_speed = ETH_SPEED_NUM_100M;
+               else if (port_cfg->dev_info.speed_capa & (ETH_LINK_SPEED_10M_HD | ETH_LINK_SPEED_10M))
+                       port_cfg->max_link_speed = ETH_SPEED_NUM_10M;
+
+       }
+#endif
+}
+
+static void init_port(struct prox_port_cfg *port_cfg)
+{
+       static char dummy_pool_name[] = "0_dummy";
+       struct rte_eth_link link;
+       uint8_t port_id;
+       int ret;
+
+       get_max_link_speed(port_cfg);
+       print_port_capa(port_cfg);
+       port_id = port_cfg - prox_port_cfg;
+       PROX_PANIC(port_cfg->n_rxq == 0 && port_cfg->n_txq == 0,
+                  "\t\t port %u is enabled but no RX or TX queues have been configured", port_id);
+
+       if (port_cfg->n_rxq == 0) {
+               /* not receiving on this port */
+               plog_info("\t\tPort %u had no RX queues, setting to 1\n", port_id);
+               port_cfg->n_rxq = 1;
+               uint32_t mbuf_size = TX_MBUF_SIZE;
+                if (mbuf_size < port_cfg->min_rx_bufsize + RTE_PKTMBUF_HEADROOM + sizeof(struct rte_mbuf))
+                        mbuf_size = port_cfg->min_rx_bufsize + RTE_PKTMBUF_HEADROOM + sizeof(struct rte_mbuf);
+
+               plog_info("\t\tAllocating dummy memory pool on socket %u with %u elements of size %u\n",
+                         port_cfg->socket, port_cfg->n_rxd, mbuf_size);
+               port_cfg->pool[0] = rte_mempool_create(dummy_pool_name, port_cfg->n_rxd, mbuf_size,
+                                                      0,
+                                                      sizeof(struct rte_pktmbuf_pool_private),
+                                                      rte_pktmbuf_pool_init, NULL,
+                                                      prox_pktmbuf_init, 0,
+                                                      port_cfg->socket, 0);
+               PROX_PANIC(port_cfg->pool[0] == NULL, "Failed to allocate dummy memory pool on socket %u with %u elements\n",
+                          port_cfg->socket, port_cfg->n_rxd);
+               dummy_pool_name[0]++;
+       } else {
+               // Most pmd should now support setting mtu
+               if (port_cfg->mtu + PROX_RTE_ETHER_HDR_LEN + PROX_RTE_ETHER_CRC_LEN > port_cfg->max_rx_pkt_len) {
+                       plog_info("\t\tMTU is too big for the port, reducing MTU from %d to %d\n", port_cfg->mtu, port_cfg->max_rx_pkt_len);
+                       port_cfg->mtu = port_cfg->max_rx_pkt_len;
+               }
+               plog_info("\t\tSetting MTU size to %u for port %u ...\n", port_cfg->mtu, port_id);
+               ret = rte_eth_dev_set_mtu(port_id, port_cfg->mtu);
+               if (ret)
+                       plog_err("\t\t\trte_eth_dev_set_mtu() failed on port %u: error %d\n", port_id, ret);
+
+               if (port_cfg->n_txq == 0) {
+                       /* not sending on this port */
+                       plog_info("\t\tPort %u had no TX queues, setting to 1\n", port_id);
+                       port_cfg->n_txq = 1;
+               }
+       }
+
+       if (port_cfg->n_rxq > 1)  {
+               // Enable RSS if multiple receive queues
+               port_cfg->port_conf.rxmode.mq_mode                      |= ETH_MQ_RX_RSS;
+               port_cfg->port_conf.rx_adv_conf.rss_conf.rss_key        = toeplitz_init_key;
+               port_cfg->port_conf.rx_adv_conf.rss_conf.rss_key_len    = TOEPLITZ_KEY_LEN;
+#if RTE_VERSION >= RTE_VERSION_NUM(2,0,0,0)
+               port_cfg->port_conf.rx_adv_conf.rss_conf.rss_hf         = ETH_RSS_IP|ETH_RSS_UDP;
+#else
+               port_cfg->port_conf.rx_adv_conf.rss_conf.rss_hf         = ETH_RSS_IPV4|ETH_RSS_NONF_IPV4_UDP;
+#endif
+       }
+
+       // Make sure that the requested RSS offload is supported by the PMD
+#if RTE_VERSION >= RTE_VERSION_NUM(2,0,0,0)
+       port_cfg->port_conf.rx_adv_conf.rss_conf.rss_hf &= port_cfg->dev_info.flow_type_rss_offloads;
+#endif
+       plog_info("\t\t Enabling RSS rss_hf = 0x%lx (requested 0x%llx, supported 0x%lx)\n", port_cfg->port_conf.rx_adv_conf.rss_conf.rss_hf, ETH_RSS_IP|ETH_RSS_UDP, port_cfg->dev_info.flow_type_rss_offloads);
 
        // rxmode such as hw src strip
 #if RTE_VERSION >= RTE_VERSION_NUM(18,8,0,1)
+#if defined (DEV_RX_OFFLOAD_CRC_STRIP)
        CONFIGURE_RX_OFFLOAD(DEV_RX_OFFLOAD_CRC_STRIP);
+#endif
+#if defined (DEV_RX_OFFLOAD_KEEP_CRC)
+       CONFIGURE_RX_OFFLOAD(DEV_RX_OFFLOAD_KEEP_CRC);
+#endif
        CONFIGURE_RX_OFFLOAD(DEV_RX_OFFLOAD_JUMBO_FRAME);
+       CONFIGURE_RX_OFFLOAD(DEV_RX_OFFLOAD_VLAN_STRIP);
 #else
        if (port_cfg->requested_rx_offload & DEV_RX_OFFLOAD_CRC_STRIP) {
                port_cfg->port_conf.rxmode.hw_strip_crc = 1;
@@ -473,6 +631,7 @@ static void init_port(struct prox_port_cfg *port_cfg)
 #if RTE_VERSION >= RTE_VERSION_NUM(18,8,0,1)
        CONFIGURE_TX_OFFLOAD(DEV_TX_OFFLOAD_IPV4_CKSUM);
        CONFIGURE_TX_OFFLOAD(DEV_TX_OFFLOAD_UDP_CKSUM);
+       CONFIGURE_TX_OFFLOAD(DEV_TX_OFFLOAD_VLAN_INSERT);
 #else
        if ((port_cfg->dev_info.tx_offload_capa & (DEV_TX_OFFLOAD_IPV4_CKSUM | DEV_TX_OFFLOAD_UDP_CKSUM)) == 0) {
                port_cfg->tx_conf.txq_flags |= ETH_TXQ_FLAGS_NOOFFLOADS;
@@ -486,19 +645,6 @@ static void init_port(struct prox_port_cfg *port_cfg)
        // Multi Segments
 #if RTE_VERSION >= RTE_VERSION_NUM(18,8,0,1)
        CONFIGURE_TX_OFFLOAD(DEV_TX_OFFLOAD_MULTI_SEGS);
-       //if (port_cfg->requested_tx_offload & DEV_TX_OFFLOAD_MULTI_SEGS) {
-               //if (port_cfg->dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MULTI_SEGS) {
-                       //port_cfg->port_conf.txmode.offloads |= DEV_TX_OFFLOAD_MULTI_SEGS;
-                       //plog_info("\t\tMULTI SEGS TX offloads enabled on port)\n");
-               //} else if (port_cfg->dev_info.tx_queue_offload_capa & DEV_TX_OFFLOAD_MULTI_SEGS) {
-                       //port_cfg->tx_conf.offloads |= DEV_TX_OFFLOAD_MULTI_SEGS;
-                       //plog_info("\t\tMULTI SEGS TX offloads enabled on queue)\n");
-               //} else {
-                       //port_cfg->requested_tx_offload &= ~DEV_TX_OFFLOAD_MULTI_SEGS;
-                       //plog_info("\t\tMULTI SEGS TX offloads disabled) as neither port or queue supports it\n");
-               //}
-       //} else
-               //plog_info("\t\tMULTI SEGS TX offloads disabled)\n");
 #else
        if (!strcmp(port_cfg->short_name, "vmxnet3")) {
                port_cfg->tx_conf.txq_flags |= ETH_TXQ_FLAGS_NOMULTSEGS;
@@ -547,12 +693,24 @@ static void init_port(struct prox_port_cfg *port_cfg)
                port_cfg->port_conf.intr_conf.lsc = port_cfg->lsc_val;
                plog_info("\t\tOverriding link state interrupt configuration to '%s'\n", port_cfg->lsc_val? "enabled" : "disabled");
        }
-       if (!strcmp(port_cfg->short_name, "vmxnet3")) {
-               if (port_cfg->n_txd < 512) {
-                       // Vmxnet3 driver requires minimum 512 tx descriptors
-                       plog_info("\t\tNumber of TX descriptors is set to 512 (minimum required for vmxnet3\n");
-                       port_cfg->n_txd = 512;
-               }
+       if (port_cfg->n_txd < port_cfg->min_tx_desc) {
+               plog_info("\t\tNumber of TX descriptors is set to %d (minimum required for %s\n", port_cfg->min_tx_desc, port_cfg->short_name);
+               port_cfg->n_txd = port_cfg->min_tx_desc;
+       }
+
+       if (port_cfg->n_rxd < port_cfg->min_rx_desc) {
+               plog_info("\t\tNumber of RX descriptors is set to %d (minimum required for %s\n", port_cfg->min_rx_desc, port_cfg->short_name);
+               port_cfg->n_rxd = port_cfg->min_rx_desc;
+       }
+
+       if (port_cfg->n_txd > port_cfg->max_tx_desc) {
+               plog_info("\t\tNumber of TX descriptors is set to %d (maximum required for %s\n", port_cfg->max_tx_desc, port_cfg->short_name);
+               port_cfg->n_txd = port_cfg->max_tx_desc;
+       }
+
+       if (port_cfg->n_rxd > port_cfg->max_rx_desc) {
+               plog_info("\t\tNumber of RX descriptors is set to %d (maximum required for %s\n", port_cfg->max_rx_desc, port_cfg->short_name);
+               port_cfg->n_rxd = port_cfg->max_rx_desc;
        }
 
        ret = rte_eth_dev_configure(port_id, port_cfg->n_rxq,
@@ -592,6 +750,9 @@ static void init_port(struct prox_port_cfg *port_cfg)
        PROX_PANIC(ret < 0, "\n\t\t\trte_eth_dev_start() failed on port %u: error %d\n", port_id, ret);
        plog_info(" done: ");
 
+       if (prox_port_cfg[port_id].ip) {
+               set_ip_address(prox_port_cfg[port_id].name, &prox_port_cfg[port_id].ip);
+       }
        /* Getting link status can be done without waiting if Link
           State Interrupt is enabled since in that case, if the link
           is recognized as being down, an interrupt will notify that
@@ -603,6 +764,7 @@ static void init_port(struct prox_port_cfg *port_cfg)
 
        port_cfg->link_up = link.link_status;
        port_cfg->link_speed = link.link_speed;
+
        if (link.link_status) {
                plog_info("Link Up - speed %'u Mbps - %s\n",
                          link.link_speed,
@@ -622,17 +784,31 @@ static void init_port(struct prox_port_cfg *port_cfg)
            strcmp(port_cfg->short_name, "i40e") &&
            strcmp(port_cfg->short_name, "i40e_vf") &&
            strcmp(port_cfg->short_name, "vmxnet3")) {
-               for (uint8_t i = 0; i < 16; ++i) {
+               for (uint8_t i = 0; i < port_cfg->n_rxq; ++i) {
                        ret = rte_eth_dev_set_rx_queue_stats_mapping(port_id, i, i);
                        if (ret) {
                                plog_info("\t\trte_eth_dev_set_rx_queue_stats_mapping() failed: error %d\n", ret);
                        }
+               }
+               for (uint8_t i = 0; i < port_cfg->n_txq; ++i) {
                        ret = rte_eth_dev_set_tx_queue_stats_mapping(port_id, i, i);
                        if (ret) {
                                plog_info("\t\trte_eth_dev_set_tx_queue_stats_mapping() failed: error %d\n", ret);
                        }
                }
        }
+       if (port_cfg->nb_mc_addr) {
+               rte_eth_allmulticast_enable(port_id);
+               if ((ret = rte_eth_dev_set_mc_addr_list(port_id, port_cfg->mc_addr, port_cfg->nb_mc_addr)) != 0) {
+                       plog_err("\t\trte_eth_dev_set_mc_addr_list returns %d on port %u\n", ret, port_id);
+                       port_cfg->nb_mc_addr = 0;
+                       rte_eth_allmulticast_disable(port_id);
+                       plog_info("\t\tport %u NOT in multicast mode as failed to add mcast address\n", port_id);
+               } else {
+                       plog_info("\t\trte_eth_dev_set_mc_addr_list(%d addr) on port %u\n", port_cfg->nb_mc_addr, port_id);
+                       plog_info("\t\tport %u in multicast mode\n", port_id);
+               }
+       }
 }
 
 void init_port_all(void)
@@ -662,6 +838,7 @@ void close_ports_atexit(void)
 void init_port_addr(void)
 {
        struct prox_port_cfg *port_cfg;
+       int rc;
 
        for (uint8_t port_id = 0; port_id < PROX_MAX_PORTS; ++port_id) {
                if (!prox_port_cfg[port_id].active) {
@@ -674,9 +851,12 @@ void init_port_addr(void)
                        rte_eth_macaddr_get(port_id, &port_cfg->eth_addr);
                        break;
                case PROX_PORT_MAC_RAND:
-                       eth_random_addr(port_cfg->eth_addr.addr_bytes);
+                       prox_rte_eth_random_addr(port_cfg->eth_addr.addr_bytes);
                        break;
                case PROX_PORT_MAC_SET:
+                       plog_info("Setting MAC to "MAC_BYTES_FMT"\n", MAC_BYTES(port_cfg->eth_addr.addr_bytes));
+                       if ((rc = rte_eth_dev_default_mac_addr_set(port_id, &port_cfg->eth_addr)) != 0)
+                               plog_warn("port %u: failed to set mac address. Error = %d\n", port_id, rc);
                        break;
                }
        }