Code Review
/
yardstick.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Merge "New reliability/availability testcase - IP datagram error rate and etc."
[yardstick.git]
/
yardstick
/
benchmark
/
scenarios
/
availability
/
operation
/
operation_general.py
diff --git
a/yardstick/benchmark/scenarios/availability/operation/operation_general.py
b/yardstick/benchmark/scenarios/availability/operation/operation_general.py
index
aa28472
..
42d70f4
100644
(file)
--- a/
yardstick/benchmark/scenarios/availability/operation/operation_general.py
+++ b/
yardstick/benchmark/scenarios/availability/operation/operation_general.py
@@
-6,8
+6,13
@@
# which accompanies this distribution, and is available at
# http://www.apache.org/licenses/LICENSE-2.0
##############################################################################
# which accompanies this distribution, and is available at
# http://www.apache.org/licenses/LICENSE-2.0
##############################################################################
+from __future__ import absolute_import
import logging
import logging
-from baseoperation import BaseOperation
+
+from yardstick.benchmark.scenarios.availability.operation.baseoperation \
+ import \
+ BaseOperation
+
import yardstick.ssh as ssh
from yardstick.benchmark.scenarios.availability.util import buildshellparams
import yardstick.ssh as ssh
from yardstick.benchmark.scenarios.availability.util import buildshellparams
@@
-19,7
+24,7
@@
class GeneralOperaion(BaseOperation):
__operation__type__ = "general-operation"
def setup(self):
__operation__type__ = "general-operation"
def setup(self):
- LOG.debug("config:%s context:%s"
% (self._config, self._context)
)
+ LOG.debug("config:%s context:%s"
, self._config, self._context
)
host = self._context.get(self._config['host'], None)
ip = host.get("ip", None)
user = host.get("user", "root")
host = self._context.get(self._config['host'], None)
ip = host.get("ip", None)
user = host.get("user", "root")
@@
-55,27
+60,31
@@
class GeneralOperaion(BaseOperation):
def run(self):
if "action_parameter" in self._config:
def run(self):
if "action_parameter" in self._config:
- exit_status, stdout, stderr = self.connection.execute(
- self.action_param,
- stdin=open(self.action_script, "r"))
+ with open(self.action_script, "r") as stdin_file:
+ exit_status, stdout, stderr = self.connection.execute(
+ self.action_param,
+ stdin=stdin_file)
else:
else:
- exit_status, stdout, stderr = self.connection.execute(
- "/bin/sh -s ",
- stdin=open(self.action_script, "r"))
+ with open(self.action_script, "r") as stdin_file:
+ exit_status, stdout, stderr = self.connection.execute(
+ "/bin/sh -s ",
+ stdin=stdin_file)
if exit_status == 0:
LOG.debug("success,the operation's output is: {0}".format(stdout))
else:
LOG.error(
if exit_status == 0:
LOG.debug("success,the operation's output is: {0}".format(stdout))
else:
LOG.error(
- "the operation's error, stdout:%s, stderr:%s"
%
-
(stdout, stderr)
)
+ "the operation's error, stdout:%s, stderr:%s"
,
+
stdout, stderr
)
def rollback(self):
if "rollback_parameter" in self._config:
def rollback(self):
if "rollback_parameter" in self._config:
- exit_status, stdout, stderr = self.connection.execute(
- self.rollback_param,
- stdin=open(self.rollback_script, "r"))
+ with open(self.rollback_script, "r") as stdin_file:
+ exit_status, stdout, stderr = self.connection.execute(
+ self.rollback_param,
+ stdin=stdin_file)
else:
else:
- exit_status, stdout, stderr = self.connection.execute(
- "/bin/sh -s ",
- stdin=open(self.rollback_script, "r"))
+ with open(self.rollback_script, "r") as stdin_file:
+ exit_status, stdout, stderr = self.connection.execute(
+ "/bin/sh -s ",
+ stdin=stdin_file)