Code Review
/
yardstick.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
use context manager for stdin files and use _put_file_shell
[yardstick.git]
/
yardstick
/
benchmark
/
scenarios
/
availability
/
attacker
/
attacker_general.py
diff --git
a/yardstick/benchmark/scenarios/availability/attacker/attacker_general.py
b/yardstick/benchmark/scenarios/availability/attacker/attacker_general.py
index
5e7716e
..
595067a
100644
(file)
--- a/
yardstick/benchmark/scenarios/availability/attacker/attacker_general.py
+++ b/
yardstick/benchmark/scenarios/availability/attacker/attacker_general.py
@@
-20,7
+20,7
@@
class GeneralAttacker(BaseAttacker):
__attacker_type__ = 'general-attacker'
def setup(self):
__attacker_type__ = 'general-attacker'
def setup(self):
- LOG.debug("config:%s context:%s"
% (self._config, self._context)
)
+ LOG.debug("config:%s context:%s"
, self._config, self._context
)
host = self._context.get(self._config['host'], None)
ip = host.get("ip", None)
user = host.get("user", "root")
host = self._context.get(self._config['host'], None)
ip = host.get("ip", None)
user = host.get("user", "root")
@@
-65,13
+65,15
@@
class GeneralAttacker(BaseAttacker):
if "action_parameter" in self._config:
LOG.debug("the shell command is: {0}".format(self.action_param))
if "action_parameter" in self._config:
LOG.debug("the shell command is: {0}".format(self.action_param))
- exit_status, stdout, stderr = self.connection.execute(
- self.action_param,
- stdin=open(self.inject_script, "r"))
+ with open(self.inject_script, "r") as stdin_file:
+ exit_status, stdout, stderr = self.connection.execute(
+ self.action_param,
+ stdin=stdin_file)
else:
else:
- exit_status, stdout, stderr = self.connection.execute(
- "/bin/bash -s ",
- stdin=open(self.inject_script, "r"))
+ with open(self.inject_script, "r") as stdin_file:
+ exit_status, stdout, stderr = self.connection.execute(
+ "/bin/bash -s ",
+ stdin=stdin_file)
LOG.debug("the inject_fault's exit status is: {0}".format(exit_status))
if exit_status == 0:
LOG.debug("the inject_fault's exit status is: {0}".format(exit_status))
if exit_status == 0:
@@
-79,16
+81,18
@@
class GeneralAttacker(BaseAttacker):
.format(stdout))
else:
LOG.error(
.format(stdout))
else:
LOG.error(
- "the inject_fault's error, stdout:%s, stderr:%s"
%
-
(stdout, stderr)
)
+ "the inject_fault's error, stdout:%s, stderr:%s"
,
+
stdout, stderr
)
def recover(self):
if "rollback_parameter" in self._config:
LOG.debug("the shell command is: {0}".format(self.rollback_param))
def recover(self):
if "rollback_parameter" in self._config:
LOG.debug("the shell command is: {0}".format(self.rollback_param))
- exit_status, stdout, stderr = self.connection.execute(
- self.rollback_param,
- stdin=open(self.recovery_script, "r"))
+ with open(self.recovery_script, "r") as stdin_file:
+ exit_status, stdout, stderr = self.connection.execute(
+ self.rollback_param,
+ stdin=stdin_file)
else:
else:
- exit_status, stdout, stderr = self.connection.execute(
- "/bin/bash -s ",
- stdin=open(self.recovery_script, "r"))
+ with open(self.recovery_script, "r") as stdin_file:
+ exit_status, stdout, stderr = self.connection.execute(
+ "/bin/bash -s ",
+ stdin=stdin_file)