VNFs/DPPD-PROX/prox_args.c

   1 /*
   2 // Copyright (c) 2010-2020 Intel Corporation
   3 //
   4 // Licensed under the Apache License, Version 2.0 (the "License");
   5 // you may not use this file except in compliance with the License.
   6 // You may obtain a copy of the License at
   7 //
   8 //     http://www.apache.org/licenses/LICENSE-2.0
   9 //
  10 // Unless required by applicable law or agreed to in writing, software
  11 // distributed under the License is distributed on an "AS IS" BASIS,
  12 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  13 // See the License for the specific language governing permissions and
  14 // limitations under the License.
  15 */
  16
  17 #include <unistd.h>
  18 #include <string.h>
  19
  20 #include <rte_sched.h>
  21 #include <rte_string_fns.h>
  22 #include <rte_version.h>
  23
  24 #include "prox_malloc.h"
  25 #include "version.h"
  26 #include "defines.h"
  27 #include "prox_args.h"
  28 #include "prox_assert.h"
  29 #include "prox_cfg.h"
  30 #include "cfgfile.h"
  31 #include "quit.h"
  32 #include "log.h"
  33 #include "parse_utils.h"
  34 #include "prox_port_cfg.h"
  35 #include "defaults.h"
  36 #include "prox_lua.h"
  37 #include "cqm.h"
  38 #include "defines.h"
  39 #include "prox_ipv6.h"
  40 #include "prox_compat.h"
  41 #include "ip_subnet.h"
  42
  43 #define MAX_RTE_ARGV 64
  44 #define MAX_ARG_LEN  256
  45
  46 struct cfg_depr {
  47         const char *opt;
  48         const char *info;
  49 };
  50
  51 /* Helper macro */
  52 #define STR_EQ(s1, s2)  (!strcmp((s1), (s2)))
  53
  54 /* configuration files support */
  55 static int get_rte_cfg(unsigned sindex, char *str, void *data);
  56 static int get_global_cfg(unsigned sindex, char *str, void *data);
  57 static int get_port_cfg(unsigned sindex, char *str, void *data);
  58 static int get_defaults_cfg(unsigned sindex, char *str, void *data);
  59 static int get_cache_set_cfg(unsigned sindex, char *str, void *data);
  60 static int get_var_cfg(unsigned sindex, char *str, void *data);
  61 static int get_lua_cfg(unsigned sindex, char *str, void *data);
  62 static int get_core_cfg(unsigned sindex, char *str, void *data);
  63
  64 static const char *cfg_file = DEFAULT_CONFIG_FILE;
  65 static struct rte_cfg    rte_cfg;
  66 struct prox_cache_set_cfg  prox_cache_set_cfg[PROX_MAX_CACHE_SET];
  67
  68 static char format_err_str[1024];
  69 static const char *err_str = "Unknown error";
  70
  71 static struct cfg_section eal_default_cfg = {
  72         .name   = "eal options",
  73         .parser = get_rte_cfg,
  74         .data   = &rte_cfg,
  75         .indexp[0]  = 0,
  76         .nbindex = 1,
  77         .error  = 0
  78 };
  79
  80 static struct cfg_section port_cfg = {
  81         .name   = "port #",
  82         .parser = get_port_cfg,
  83         .data   = &prox_port_cfg,
  84         .indexp[0]  = 0,
  85         .nbindex = 1,
  86         .error  = 0
  87 };
  88
  89 static struct cfg_section var_cfg = {
  90         .name   = "variables",
  91         .parser = get_var_cfg,
  92         .data   = 0,
  93         .indexp[0]  = 0,
  94         .nbindex = 1,
  95         .error  = 0
  96 };
  97
  98 static struct cfg_section cache_set_cfg = {
  99         .name   = "cache set #",
 100         .parser = get_cache_set_cfg,
 101         .data   = &prox_cache_set_cfg,
 102         .indexp[0]  = 0,
 103         .nbindex = 1,
 104         .error  = 0
 105 };
 106
 107 static struct cfg_section defaults_cfg = {
 108         .name   = "defaults",
 109         .parser = get_defaults_cfg,
 110         .data   = 0,
 111         .indexp[0]  = 0,
 112         .nbindex = 1,
 113         .error  = 0
 114 };
 115
 116 static struct cfg_section settings_cfg = {
 117         .name   = "global",
 118         .parser = get_global_cfg,
 119         .data   = &prox_cfg,
 120         .indexp[0]  = 0,
 121         .nbindex = 1,
 122         .error  = 0
 123 };
 124
 125 static struct cfg_section lua_cfg = {
 126         .name = "lua",
 127         .parser = get_lua_cfg,
 128         .raw_lines = 1,
 129         .indexp[0] = 0,
 130         .nbindex = 1,
 131         .error = 0,
 132 };
 133
 134 static struct cfg_section core_cfg = {
 135         .name   = "core #",
 136         .parser = get_core_cfg,
 137         .data   = lcore_cfg_init,
 138         .indexp[0]  = 0,
 139         .nbindex = 1,
 140         .error  = 0
 141 };
 142
 143 struct deferred_port {
 144         struct task_args *targ;
 145         char name[256];
 146         uint8_t is_rx_port;
 147 };
 148
 149 static struct deferred_port deferred_port[PROX_MAX_PORTS];
 150 static int n_deferred_ports = 0;
 151
 152 static void set_errf(const char *format, ...)
 153 {
 154         va_list ap;
 155         va_start(ap, format);
 156         vsnprintf(format_err_str, sizeof(format_err_str), format, ap);
 157         va_end(ap);
 158         err_str = format_err_str;
 159 }
 160
 161 /* [eal options] parser */
 162 static int get_rte_cfg(__attribute__((unused))unsigned sindex, char *str, void *data)
 163 {
 164         struct rte_cfg *pconfig = (struct rte_cfg *)data;
 165
 166         if (str == NULL || pconfig == NULL) {
 167                 return -1;
 168         }
 169
 170         char *pkey = get_cfg_key(str);
 171         if (pkey == NULL) {
 172                 set_errf("Missing key after option");
 173                 return -1;
 174         }
 175
 176         if (STR_EQ(str, "-m")) {
 177                 return parse_int(&pconfig->memory, pkey);
 178         }
 179         if (STR_EQ(str, "-n")) {
 180                 if (parse_int(&pconfig->force_nchannel, pkey)) {
 181                         return -1;
 182                 }
 183                 if (pconfig->force_nchannel == 0) {
 184                         set_errf("Invalid number of memory channels");
 185                         return -1;
 186                 }
 187                 return 0;
 188         }
 189         if (STR_EQ(str, "-r")) {
 190                 if (parse_int(&pconfig->force_nrank, pkey)) {
 191                         return -1;
 192                 }
 193                 if (pconfig->force_nrank == 0 || pconfig->force_nrank > 16) {
 194                         set_errf("Invalid number of memory ranks");
 195                         return -1;
 196                 }
 197                 return 0;
 198         }
 199         /* debug options */
 200         if (STR_EQ(str, "no-pci")) {
 201                 return parse_bool(&pconfig->no_pci, pkey);
 202         }
 203         if (STR_EQ(str, "no-hpet")) {
 204                 return parse_bool(&pconfig->no_hpet, pkey);
 205         }
 206         if (STR_EQ(str, "no-shconf")) {
 207                 return parse_bool(&pconfig->no_shconf, pkey);
 208         }
 209         if (STR_EQ(str, "no-huge")) {
 210                 return parse_bool(&pconfig->no_hugetlbfs, pkey);
 211         }
 212         if (STR_EQ(str, "no-output")) {
 213                 return parse_bool(&pconfig->no_output, pkey);
 214         }
 215
 216         if (STR_EQ(str, "huge-dir")) {
 217                 if (pconfig->hugedir) {
 218                         free(pconfig->hugedir);
 219                 }
 220                 pconfig->hugedir = strdup(pkey);
 221                 return 0;
 222         }
 223
 224         if (STR_EQ(str, "eal")) {
 225                 char eal[MAX_STR_LEN_PROC];
 226                 if (pconfig->eal) {
 227                         free(pconfig->eal);
 228                         pconfig->eal = NULL;
 229                 }
 230                 if (parse_str(eal, pkey, sizeof(eal)))
 231                         return -1;
 232                 pkey = eal;
 233                 strip_spaces(&pkey, 1);
 234                 if (*pkey)
 235                         pconfig->eal = strdup(pkey);
 236                 return 0;
 237         }
 238
 239         set_errf("Option '%s' is not known", str);
 240         return -1;
 241 }
 242
 243 struct cfg_depr global_cfg_depr[] = {
 244         {"virtualization", "This is now set automatically if needed"},
 245         {"qinq_tag", "This option is deprecated"},
 246         {"wait on quit", "This is now set automatically if needed"},
 247         {"version", ""}
 248 };
 249
 250 const char *get_cfg_dir(void)
 251 {
 252         static char dir[PATH_MAX];
 253         size_t end = strlen(cfg_file) - 1;
 254         while (end > 0 && cfg_file[end] != '/')
 255                 end--;
 256
 257         strncpy(dir, cfg_file, end);
 258         return dir;
 259 }
 260
 261 static int get_lua_cfg(__attribute__((unused)) unsigned sindex, __attribute__((unused)) char *str, __attribute__((unused)) void *data)
 262 {
 263         int status;
 264         char cwd[1024];
 265         if (NULL == getcwd(cwd, sizeof(cwd))) {
 266                 set_errf("Failed to get current directory while loading Lua file\n");
 267                 return -1;
 268         }
 269         status = chdir(get_cfg_dir());
 270         if (status) {
 271                 set_errf("Failed to change directory to '%s' while loading Lua file\n", get_cfg_dir());
 272                 return -1;
 273         }
 274
 275         struct lua_State *l = prox_lua();
 276
 277         char str_cpy[1024];
 278         prox_strncpy(str_cpy, str, sizeof(str_cpy));
 279         uint32_t len = strlen(str_cpy);
 280         str_cpy[len++] = '\n';
 281         str_cpy[len++] = 0;
 282
 283         status = luaL_loadstring(l, str_cpy);
 284         if (status) {
 285                 set_errf("Lua error: '%s'\n", lua_tostring(l, -1));
 286                 status = chdir(cwd);
 287                 return -1;
 288         }
 289
 290         status = lua_pcall(l, 0, LUA_MULTRET, 0);
 291         if (status) {
 292                 set_errf("Lua error: '%s'\n", lua_tostring(l, -1));
 293                 status = chdir(cwd);
 294                 return -1;
 295         }
 296
 297         status = chdir(cwd);
 298         if (status) {
 299                 set_errf("Failed to restore current directory to '%s' while loading Lua file\n", cwd);
 300                 return -1;
 301         }
 302
 303         return 0;
 304 }
 305
 306 /* [global] parser */
 307 static int get_global_cfg(__attribute__((unused))unsigned sindex, char *str, void *data)
 308 {
 309         struct prox_cfg *pset = (struct prox_cfg *)data;
 310
 311         if (str == NULL || pset == NULL) {
 312                 return -1;
 313         }
 314
 315         char *pkey = get_cfg_key(str);
 316         if (pkey == NULL) {
 317                 set_errf("Missing key after option");
 318                 return -1;
 319         }
 320
 321         for (uint32_t i = 0; i < RTE_DIM(global_cfg_depr); ++i) {
 322                 if (STR_EQ(str, global_cfg_depr[i].opt)) {
 323                         set_errf("Option '%s' is deprecated%s%s",
 324                                  global_cfg_depr[i].opt, strlen(global_cfg_depr[i].info)? ": ": "", global_cfg_depr[i].info);
 325                         return -1;
 326                 }
 327         }
 328
 329         if (STR_EQ(str, "name")) {
 330                 return parse_str(pset->name, pkey, sizeof(pset->name));
 331         }
 332
 333         if (STR_EQ(str, "start time")) {
 334                 return parse_int(&pset->start_time, pkey);
 335         }
 336
 337         if (STR_EQ(str, "duration time")) {
 338                 return parse_int(&pset->duration_time, pkey);
 339         }
 340
 341         if (STR_EQ(str, "shuffle")) {
 342                 return parse_flag(&pset->flags, DSF_SHUFFLE, pkey);
 343         }
 344         if (STR_EQ(str, "disable cmt")) {
 345                 return parse_flag(&pset->flags, DSF_DISABLE_CMT, pkey);
 346         }
 347         if (STR_EQ(str, "mp rings")) {
 348                 return parse_flag(&pset->flags, DSF_MP_RINGS, pkey);
 349         }
 350         if (STR_EQ(str, "enable bypass")) {
 351                 return parse_flag(&pset->flags, DSF_ENABLE_BYPASS, pkey);
 352         }
 353         if (STR_EQ(str, "poll timeout")) {
 354                 return parse_int(&pset->poll_timeout, pkey);
 355         }
 356         if (STR_EQ(str, "heartbeat timeout")) {
 357                 return parse_int(&pset->heartbeat_timeout, pkey);
 358         }
 359
 360         if (STR_EQ(str, "cpe table map")) {
 361                 /* The config defined ports through 0, 1, 2 ... which
 362                    need to be associated with ports. This is done
 363                    through defining it using "cpe table map=" */
 364                 return parse_port_name_list((uint32_t*)pset->cpe_table_ports, NULL, PROX_MAX_PORTS, pkey);
 365         }
 366
 367         if (STR_EQ(str, "pre cmd")) {
 368                 return system(pkey);
 369         }
 370
 371         if (STR_EQ(str, "unique mempool per socket")) {
 372                 return parse_flag(&pset->flags, UNIQUE_MEMPOOL_PER_SOCKET, pkey);
 373         }
 374
 375         if (STR_EQ(str, "log buffer size")) {
 376                 if (parse_kmg(&pset->logbuf_size, pkey)) {
 377                         return -1;
 378                 }
 379                 plog_info("Logging to buffer with size = %d\n", pset->logbuf_size);
 380                 return 0;
 381         }
 382
 383         set_errf("Option '%s' is not known", str);
 384         return -1;
 385 }
 386
 387 /* [variable] parser */
 388 static int get_var_cfg(__attribute__((unused)) unsigned sindex, char *str, __attribute__((unused)) void *data)
 389 {
 390         return add_var(str, get_cfg_key(str), 0);
 391 }
 392
 393 /* [defaults] parser */
 394 static int get_defaults_cfg(__attribute__((unused)) unsigned sindex, char *str, __attribute__((unused)) void *data)
 395 {
 396         uint32_t val;
 397         char *pkey;
 398
 399         pkey = get_cfg_key(str);
 400         if (pkey == NULL) {
 401                 set_errf("Missing key after option");
 402                 return -1;
 403         }
 404
 405         if (STR_EQ(str, "mempool size")) {
 406
 407                 if (parse_kmg(&val, pkey)) {
 408                         return -1;
 409                 }
 410
 411                 for (uint8_t lcore_id = 0; lcore_id < RTE_MAX_LCORE; ++lcore_id) {
 412                         struct lcore_cfg *cur_lcore_cfg_init = &lcore_cfg_init[lcore_id];
 413                         cur_lcore_cfg_init->id = lcore_id;
 414                         for (uint8_t task_id = 0; task_id < MAX_TASKS_PER_CORE; ++task_id) {
 415                                 struct task_args *targ = &cur_lcore_cfg_init->targs[task_id];
 416                                 targ->nb_mbuf = val;
 417                                 targ->id = task_id;
 418                         }
 419                 }
 420                 return 0;
 421         }
 422
 423         if (STR_EQ(str, "qinq tag")) {
 424                 for (uint8_t lcore_id = 0; lcore_id < RTE_MAX_LCORE; ++lcore_id) {
 425                         struct lcore_cfg *cur_lcore_cfg_init = &lcore_cfg_init[lcore_id];
 426                         cur_lcore_cfg_init->id = lcore_id;
 427                         for (uint8_t task_id = 0; task_id < MAX_TASKS_PER_CORE; ++task_id) {
 428                                 struct task_args *targ = &cur_lcore_cfg_init->targs[task_id];
 429                                 parse_int(&targ->qinq_tag, pkey);
 430                         }
 431                 }
 432                 return 0;
 433         }
 434         if (STR_EQ(str, "memcache size")) {
 435
 436                 if (parse_kmg(&val, pkey)) {
 437                         return -1;
 438                 }
 439
 440                 for (uint8_t lcore_id = 0; lcore_id < RTE_MAX_LCORE; ++lcore_id) {
 441                         struct lcore_cfg *cur_lcore_cfg_init = &lcore_cfg_init[lcore_id];
 442                         cur_lcore_cfg_init->id = lcore_id;
 443                         for (uint8_t task_id = 0; task_id < MAX_TASKS_PER_CORE; ++task_id) {
 444                                 struct task_args *targ = &cur_lcore_cfg_init->targs[task_id];
 445                                 targ->nb_cache_mbuf = val;
 446                         }
 447                 }
 448                 return 0;
 449         }
 450
 451         set_errf("Option '%s' is not known", str);
 452         return -1;
 453 }
 454
 455 /* [cache set] parser */
 456 static int get_cache_set_cfg(unsigned sindex, char *str, void *data)
 457 {
 458         struct prox_cache_set_cfg *cfg = (struct prox_cache_set_cfg *)data;
 459
 460         uint8_t cur_if = sindex & ~CFG_INDEXED;
 461
 462         if (cur_if >= PROX_MAX_CACHE_SET) {
 463                 set_errf("Cache set ID is too high (max allowed %d)", PROX_MAX_CACHE_SET - 1 );
 464                 return -1;
 465         }
 466
 467         cfg = &prox_cache_set_cfg[cur_if];
 468
 469         if (str == NULL || data == NULL) {
 470                 return -1;
 471         }
 472
 473         char *pkey = get_cfg_key(str);
 474
 475         if (pkey == NULL) {
 476                 set_errf("Missing key after option");
 477                 return -1;
 478         }
 479
 480         if (STR_EQ(str, "mask")) {
 481                 uint32_t val;
 482                 int err = parse_int(&val, pkey);
 483                 if (err) {
 484                         return -1;
 485                 }
 486                 cfg->mask = val;
 487                 cfg->socket_id = -1;
 488                 plog_info("\tCache set %d has mask %x\n", cur_if, cfg->mask);
 489                 return 0;
 490         }
 491         return 0;
 492 }
 493
 494 /* [port] parser */
 495 static int get_port_cfg(unsigned sindex, char *str, void *data)
 496 {
 497         struct prox_port_cfg *cfg = (struct prox_port_cfg *)data;
 498
 499         uint8_t cur_if = sindex & ~CFG_INDEXED;
 500
 501         if (cur_if >= PROX_MAX_PORTS) {
 502                 set_errf("Port ID is too high (max allowed %d)", PROX_MAX_PORTS - 1 );
 503                 return -1;
 504         }
 505
 506         cfg = &prox_port_cfg[cur_if];
 507
 508         if (str == NULL || data == NULL) {
 509                 return -1;
 510         }
 511
 512         char *pkey = get_cfg_key(str);
 513
 514         if (pkey == NULL) {
 515                 set_errf("Missing key after option");
 516                 return -1;
 517         }
 518
 519         if (STR_EQ(str, "mac")) {
 520                 if (STR_EQ(pkey, "hardware")) {
 521                         cfg->type = PROX_PORT_MAC_HW;
 522                 }
 523                 else if (STR_EQ(pkey, "random")) {
 524                         cfg->type = PROX_PORT_MAC_RAND;
 525                 }
 526                 else {
 527                         cfg->type = PROX_PORT_MAC_SET;
 528                         if (parse_mac(&cfg->eth_addr, pkey)) {
 529                                 return -1;
 530                         }
 531                 }
 532         }
 533         else if (STR_EQ(str, "name")) {
 534                 uint32_t val;
 535                 prox_strncpy(cfg->names[0], pkey, MAX_NAME_SIZE);
 536                 PROX_ASSERT(cur_if < PROX_MAX_PORTS);
 537                 return add_port_name(cur_if, pkey);
 538         }
 539         else if (STR_EQ(str, "rx desc")) {
 540                 return parse_int(&cfg->n_rxd, pkey);
 541         }
 542         else if (STR_EQ(str, "tx desc")) {
 543                 return parse_int(&cfg->n_txd, pkey);
 544         }
 545         else if (STR_EQ(str, "all_rx_queues")) {
 546                 uint32_t val;
 547                 if (parse_bool(&val, pkey)) {
 548                         return -1;
 549                 }
 550                 cfg->all_rx_queues = val;
 551         }
 552         else if (STR_EQ(str, "promiscuous")) {
 553                 uint32_t val;
 554                 if (parse_bool(&val, pkey)) {
 555                         return -1;
 556                 }
 557                 cfg->promiscuous = val;
 558         }
 559         else if (STR_EQ(str, "multicast")) {
 560                 uint32_t val;
 561                 if (cfg->nb_mc_addr >= NB_MCAST_ADDR) {
 562                         plog_err("too many multicast addresses\n");
 563                         return -1;
 564                 }
 565                 if (parse_mac(&cfg->mc_addr[cfg->nb_mc_addr], pkey)) {
 566                         return -1;
 567                 }
 568                 cfg->nb_mc_addr++ ;
 569         }
 570         else if (STR_EQ(str, "lsc")) {
 571                 cfg->lsc_set_explicitely = 1;
 572                 uint32_t val;
 573                 if (parse_bool(&val, pkey)) {
 574                         return -1;
 575                 }
 576                 cfg->lsc_val = val;
 577         }
 578         else if (STR_EQ(str, "local ipv4")) {
 579                 if (parse_ip_set(cfg->ip_addr, pkey, PROX_MAX_VLAN_TAGS) != 0) {
 580                         cfg->ip_addr[0].ip = 24;
 581                         return parse_ip(&cfg->ip_addr[0].ip, pkey);
 582                 }
 583                 return 0;
 584         }
 585         else if (STR_EQ(str, "virtual")) {
 586                 uint32_t val;
 587                 if (parse_bool(&val, pkey)) {
 588                         return -1;
 589                 }
 590                 cfg->virtual = val;
 591         }
 592         else if (STR_EQ(str, "vdev")) {
 593                 prox_strncpy(cfg->vdev, pkey, MAX_NAME_SIZE);
 594         }
 595 #if RTE_VERSION >= RTE_VERSION_NUM(18,8,0,1)
 596         else if (STR_EQ(str, "disable tx offload")) {
 597                 uint32_t val;
 598                 if (parse_int(&val, pkey)) {
 599                         return -1;
 600                 }
 601                 if (val)
 602                         cfg->disabled_tx_offload = val;
 603         }
 604 #endif
 605         else if (STR_EQ(str, "strip crc")) {
 606                 uint32_t val;
 607                 if (parse_bool(&val, pkey)) {
 608                         return -1;
 609                 }
 610 #if defined(DEV_RX_OFFLOAD_CRC_STRIP)
 611                 if (val)
 612                         cfg->requested_rx_offload |= DEV_RX_OFFLOAD_CRC_STRIP;
 613                 else
 614                         cfg->requested_rx_offload &= ~DEV_RX_OFFLOAD_CRC_STRIP;
 615 #else
 616 #if defined (DEV_RX_OFFLOAD_KEEP_CRC)
 617                 if (val)
 618                         cfg->requested_rx_offload &= ~DEV_RX_OFFLOAD_KEEP_CRC;
 619                 else
 620 #endif
 621                         cfg->requested_rx_offload |= DEV_RX_OFFLOAD_KEEP_CRC;
 622 #endif
 623
 624         }
 625         else if (STR_EQ(str, "vlan tag")) {
 626                 return parse_int_set(cfg->vlan_tags, pkey, sizeof(cfg->vlan_tags) / sizeof(cfg->vlan_tags[0]));
 627         }
 628         else if (STR_EQ(str, "vlan")) {
 629 #if RTE_VERSION >= RTE_VERSION_NUM(18,8,0,1)
 630                 uint32_t val;
 631                 if (parse_bool(&val, pkey)) {
 632                         return -1;
 633                 }
 634                 if (val) {
 635                         cfg->requested_rx_offload |= DEV_RX_OFFLOAD_VLAN_STRIP;
 636                         cfg->requested_tx_offload |= DEV_TX_OFFLOAD_VLAN_INSERT;
 637                 } else {
 638                         cfg->requested_rx_offload &= ~DEV_RX_OFFLOAD_VLAN_STRIP;
 639                         cfg->requested_tx_offload &= ~DEV_TX_OFFLOAD_VLAN_INSERT;
 640                 }
 641 #else
 642                 plog_warn("vlan option not supported : update DPDK at least to 18.08 to support this option\n");
 643 #endif
 644         }
 645         else if (STR_EQ(str, "mtu size")) {
 646                 uint32_t val;
 647                 if (parse_int(&val, pkey)) {
 648                         return -1;
 649                 }
 650                 if (val) {
 651                         cfg->mtu = val;
 652                         // A frame of 1526 bytes (1500 bytes mtu, 14 bytes hdr, 4 bytes crc and 8 bytes vlan)
 653                         // should not be considered as a jumbo frame. However rte_ethdev.c considers that
 654                         // the max_rx_pkt_len for a non jumbo frame is 1518
 655                         cfg->port_conf.rxmode.max_rx_pkt_len = cfg->mtu + PROX_RTE_ETHER_HDR_LEN + PROX_RTE_ETHER_CRC_LEN;
 656                         if (cfg->port_conf.rxmode.max_rx_pkt_len > PROX_RTE_ETHER_MAX_LEN) {
 657                                 cfg->requested_rx_offload |= DEV_RX_OFFLOAD_JUMBO_FRAME;
 658                         }
 659                 }
 660         }
 661
 662         else if (STR_EQ(str, "rss")) {
 663                 uint32_t val;
 664                 if (parse_bool(&val, pkey)) {
 665                         return -1;
 666                 }
 667                 if (val) {
 668                         cfg->port_conf.rxmode.mq_mode = ETH_MQ_RX_RSS;
 669                         cfg->port_conf.rx_adv_conf.rss_conf.rss_hf = ETH_RSS_IPV4;
 670                 }
 671         }
 672         else if (STR_EQ(str, "rx_ring")) {
 673                 parse_str(cfg->rx_ring, pkey, sizeof(cfg->rx_ring));
 674         }
 675         else if (STR_EQ(str, "tx_ring")) {
 676                 parse_str(cfg->tx_ring, pkey, sizeof(cfg->tx_ring));
 677         }
 678
 679         return 0;
 680 }
 681
 682 static enum police_action str_to_color(const char *str)
 683 {
 684         if (STR_EQ(str, "green"))
 685                 return ACT_GREEN;
 686         if (STR_EQ(str, "yellow"))
 687                 return ACT_YELLOW;
 688         if (STR_EQ(str, "red"))
 689                 return ACT_RED;
 690         if (STR_EQ(str, "drop"))
 691                 return ACT_DROP;
 692         return ACT_INVALID;
 693 }
 694
 695 struct cfg_depr task_cfg_depr[] = {
 696         {"sig", ""},
 697 };
 698
 699 struct cfg_depr core_cfg_depr[] = {
 700         {"do sig", ""},
 701         {"lat", ""},
 702         {"network side", ""},
 703 };
 704
 705 /* [core] parser */
 706 static int get_core_cfg(unsigned sindex, char *str, void *data)
 707 {
 708         char *pkey;
 709         struct lcore_cfg *lconf = (struct lcore_cfg *)data;
 710
 711         if (str == NULL || lconf == NULL || !(sindex & CFG_INDEXED)) {
 712                 return -1;
 713         }
 714
 715         pkey = get_cfg_key(str);
 716         if (pkey == NULL) {
 717                 set_errf("Missing key after option");
 718                 return -1;
 719         }
 720
 721         uint32_t ncore = sindex & ~CFG_INDEXED;
 722         if (ncore >= RTE_MAX_LCORE) {
 723                 set_errf("Core index too high (max allowed %d)", RTE_MAX_LCORE - 1);
 724                 return -1;
 725         }
 726
 727         lconf = &lconf[ncore];
 728
 729         for (uint32_t i = 0; i < RTE_DIM(core_cfg_depr); ++i) {
 730                 if (STR_EQ(str, core_cfg_depr[i].opt)) {
 731                         set_errf("Option '%s' is deprecated%s%s",
 732                                  core_cfg_depr[i].opt, strlen(core_cfg_depr[i].info)? ": ": "", core_cfg_depr[i].info);
 733                         return -1;
 734                 }
 735         }
 736
 737         char buff[128];
 738         lcore_to_socket_core_ht(ncore, buff, sizeof(buff));
 739         set_self_var(buff);
 740         if (STR_EQ(str, "task")) {
 741
 742                 uint32_t val;
 743                 if (parse_int(&val, pkey)) {
 744                         return -1;
 745                 }
 746                 if (val >= MAX_TASKS_PER_CORE) {
 747                         set_errf("Too many tasks for core (max allowed %d)", MAX_TASKS_PER_CORE - 1);
 748                         return -1;
 749                 }
 750                 if (val != lconf->n_tasks_all) {
 751                         set_errf("Task ID skipped or defined twice");
 752                         return -1;
 753                 }
 754
 755                 lconf->active_task = val;
 756
 757                 lconf->targs[lconf->active_task].task = lconf->active_task;
 758
 759                 if (lconf->n_tasks_all < lconf->active_task + 1) {
 760                         lconf->n_tasks_all = lconf->active_task + 1;
 761                 }
 762                 return 0;
 763         }
 764
 765         struct task_args *targ = &lconf->targs[lconf->active_task];
 766         if (STR_EQ(str, "tx ports from routing table")) {
 767                 uint32_t vals[PROX_MAX_PORTS];
 768                 uint32_t n_if;
 769                 if (!(targ->task_init->flag_features & TASK_FEATURE_ROUTING)) {
 770                         set_errf("tx port form route not supported mode %s",  targ->task_init->mode_str);
 771                         return -1;
 772                 }
 773
 774                 if (parse_port_name_list(vals, &n_if, PROX_MAX_PORTS, pkey)) {
 775                         return -1;
 776                 }
 777
 778                 for (uint8_t i = 0; i < n_if; ++i) {
 779                         targ->tx_port_queue[i].port = vals[i];
 780                         targ->nb_txports++;
 781                 }
 782                 targ->runtime_flags |= TASK_ROUTING;
 783                 return 0;
 784         }
 785         if (STR_EQ(str, "tx ports from cpe table")) {
 786                 uint32_t vals[PROX_MAX_PORTS];
 787                 int n_remap = -1;
 788                 uint32_t ret;
 789                 uint32_t val;
 790                 char* mapping_str = strstr(pkey, " remap=");
 791
 792                 if (mapping_str != NULL) {
 793                         *mapping_str = 0;
 794                         mapping_str += strlen(" remap=");
 795                         n_remap = parse_remap(targ->mapping, mapping_str);
 796                 }
 797
 798                 if (parse_port_name_list(vals, &ret, PROX_MAX_PORTS, pkey)) {
 799                         return -1;
 800                 }
 801
 802                 if (n_remap != -1 && ret != (uint32_t)n_remap) {
 803                         set_errf("Expected %d remap elements but had %d", n_remap, ret);
 804                         return -1;
 805                 }
 806
 807                 for (uint8_t i = 0; i < ret; ++i) {
 808                         targ->tx_port_queue[i].port = vals[i];
 809
 810                         /* default mapping this case is port0 -> port0 */
 811                         if (n_remap == -1) {
 812                                 targ->mapping[vals[i]] = i;
 813                         }
 814                 }
 815
 816                 targ->nb_txports = ret;
 817
 818                 return 0;
 819         }
 820         if (STR_EQ(str, "tx cores from routing table")) {
 821                 if (!(targ->task_init->flag_features & TASK_FEATURE_ROUTING)) {
 822                         set_errf("tx port form route not supported mode %s",  targ->task_init->mode_str);
 823                         return -1;
 824                 }
 825
 826                 struct core_task_set *cts = &targ->core_task_set[0];
 827
 828                 if (parse_task_set(cts, pkey))
 829                         return -1;
 830
 831                 if (cts->n_elems > MAX_WT_PER_LB) {
 832                         set_errf("Maximum worker threads allowed is %u but have %u", MAX_WT_PER_LB, cts->n_elems);
 833                         return -1;
 834                 }
 835
 836                 targ->nb_worker_threads = cts->n_elems;
 837                 targ->nb_txrings = cts->n_elems;
 838
 839                 if (targ->nb_txrings > MAX_RINGS_PER_TASK) {
 840                         set_errf("Maximum allowed TX rings is %u but have %u", MAX_RINGS_PER_TASK, targ->nb_txrings);
 841                         return -1;
 842                 }
 843
 844                 targ->runtime_flags |= TASK_ROUTING;
 845                 return 0;
 846         }
 847         if (STR_EQ(str, "tx cores from cpe table")) {
 848                 struct core_task_set *core_task_set =  &targ->core_task_set[0];
 849                 int ret, ret2;
 850                 char *mapping_str;
 851
 852                 mapping_str = strstr(pkey, " remap=");
 853                 if (mapping_str == NULL) {
 854                         set_errf("There is no default mapping for tx cores from cpe table. Please specify it through remap=");
 855                         return -1;
 856                 }
 857                 *mapping_str = 0;
 858                 mapping_str += strlen(" remap=");
 859                 ret = parse_remap(targ->mapping, mapping_str);
 860                 if (ret <= 0) {
 861                         return -1;
 862                 }
 863
 864                 struct core_task_set *cts = &targ->core_task_set[0];
 865
 866                 if (parse_task_set(cts, pkey))
 867                         return -1;
 868                 if (cts->n_elems > MAX_RINGS_PER_TASK) {
 869                         set_errf("Maximum cores to route to is %u\n", MAX_RINGS_PER_TASK);
 870                         return -1;
 871                 }
 872
 873                 targ->nb_txrings = cts->n_elems;
 874
 875                 if (ret != targ->nb_txrings) {
 876                         set_errf("Expecting same number of remaps as cores\n", str);
 877                         return -1;
 878                 }
 879                 return 0;
 880         }
 881
 882         if (STR_EQ(str, "delay ms")) {
 883                 if (targ->delay_us) {
 884                         set_errf("delay ms and delay us are mutually exclusive\n", str);
 885                         return -1;
 886                 }
 887                 uint32_t delay_ms;
 888                 int rc = parse_int(&delay_ms, pkey);
 889                 targ->delay_us = delay_ms * 1000;
 890                 return rc;
 891         }
 892         if (STR_EQ(str, "delay us")) {
 893                 if (targ->delay_us) {
 894                         set_errf("delay ms and delay us are mutually exclusive\n", str);
 895                         return -1;
 896                 }
 897                 return parse_int(&targ->delay_us, pkey);
 898         }
 899         if (STR_EQ(str, "random delay us")) {
 900                 return parse_int(&targ->random_delay_us, pkey);
 901         }
 902         if (STR_EQ(str, "cpe table timeout ms")) {
 903                 return parse_int(&targ->cpe_table_timeout_ms, pkey);
 904         }
 905         if (STR_EQ(str, "ctrl path polling frequency")) {
 906                 int rc = parse_int(&targ->ctrl_freq, pkey);
 907                 if (rc == 0) {
 908                         if (targ->ctrl_freq == 0) {
 909                                 set_errf("ctrl frequency must be non null.");
 910                                 return -1;
 911                         }
 912                 }
 913                 return rc;
 914         }
 915
 916         if (STR_EQ(str, "handle arp")) {
 917                 return parse_flag(&targ->runtime_flags, TASK_CTRL_HANDLE_ARP, pkey);
 918         }
 919         if (STR_EQ(str, "fast path handle arp")) {
 920                 return parse_flag(&targ->runtime_flags, TASK_FP_HANDLE_ARP, pkey);
 921         }
 922
 923         if (STR_EQ(str, "do not forward geneve")) {
 924                 return parse_flag(&targ->runtime_flags, TASK_DO_NOT_FWD_GENEVE, pkey);
 925         }
 926         /* Using tx port name, only a _single_ port can be assigned to a task. */
 927         if (STR_EQ(str, "tx port")) {
 928                 if (targ->nb_txports > 0) {
 929                         set_errf("Only one tx port can be defined per task. Use a LB task or routing instead.");
 930                         return -1;
 931                 }
 932
 933                 uint32_t n_if = 0;
 934                 uint32_t ports[PROX_MAX_PORTS];
 935
 936                 if(parse_port_name_list(ports, &n_if, PROX_MAX_PORTS, pkey)) {
 937                         // Port name not found, but could be a virtual device of a secondary process
 938                         // As DPDK not started yet, we can only check the config file to see whether we are a secondary process
 939                         if (rte_cfg.eal &&
 940                                         (strstr(rte_cfg.eal, "secondary") || strstr(rte_cfg.eal, "auto")) &&
 941                                         (n_deferred_ports < PROX_MAX_PORTS)) {
 942                                 prox_strncpy(deferred_port[n_deferred_ports].name, pkey, sizeof(deferred_port[n_deferred_ports].name));
 943                                 deferred_port[n_deferred_ports].is_rx_port = 0;
 944                                 deferred_port[n_deferred_ports++].targ = targ;
 945                                 return 0;
 946                         } else
 947                                 return -1;
 948                 }
 949
 950                 PROX_ASSERT(n_if-1 < PROX_MAX_PORTS);
 951
 952                 for (uint8_t i = 0; i < n_if; ++i) {
 953                         targ->tx_port_queue[i].port = ports[i];
 954                         targ->nb_txports++;
 955                 }
 956
 957                 if (n_if > 1) {
 958                         targ->nb_worker_threads = targ->nb_txports;
 959                 }
 960
 961                 return 0;
 962         }
 963         if (STR_EQ(str, "rx ring")) {
 964                 uint32_t val;
 965                 int err = parse_bool(&val, pkey);
 966                 if (!err && val && targ->rx_port_queue[0].port != OUT_DISCARD) {
 967                         set_errf("Can't read both from internal ring and external port from the same task. Use multiple tasks instead.");
 968                         return -1;
 969                 }
 970
 971                 return parse_flag(&targ->flags, TASK_ARG_RX_RING, pkey);
 972         }
 973         if (STR_EQ(str, "private")) {
 974                 return parse_bool(&targ->use_src, pkey);
 975         }
 976         if (STR_EQ(str, "use src ip")) {
 977                 return parse_bool(&targ->use_src, pkey);
 978         }
 979         if (STR_EQ(str, "nat table")) {
 980                 return parse_str(targ->nat_table, pkey, sizeof(targ->nat_table));
 981         }
 982         if (STR_EQ(str, "rules")) {
 983                 return parse_str(targ->rules, pkey, sizeof(targ->rules));
 984         }
 985         if (STR_EQ(str, "route table")) {
 986                 return parse_str(targ->route_table, pkey, sizeof(targ->route_table));
 987         }
 988         if (STR_EQ(str, "dscp")) {
 989                 return parse_str(targ->dscp, pkey, sizeof(targ->dscp));
 990         }
 991         if (STR_EQ(str, "tun_bindings")) {
 992                 return parse_str(targ->tun_bindings, pkey, sizeof(targ->tun_bindings));
 993         }
 994         if (STR_EQ(str, "cpe table")) {
 995                 return parse_str(targ->cpe_table_name, pkey, sizeof(targ->cpe_table_name));
 996         }
 997         if (STR_EQ(str, "user table")) {
 998                 return parse_str(targ->user_table, pkey, sizeof(targ->user_table));
 999         }
1000         if (STR_EQ(str, "streams")) {
1001                 return parse_str(targ->streams, pkey, sizeof(targ->streams));
1002         }
1003         if (STR_EQ(str, "Unsollicited NA")) {
1004                 return parse_flag(&targ->flags, TASK_ARG_SEND_NA_AT_STARTUP, pkey);
1005         }
1006         if (STR_EQ(str, "local lpm")) {
1007                 return parse_flag(&targ->flags, TASK_ARG_LOCAL_LPM, pkey);
1008         }
1009         if (STR_EQ(str, "drop")) {
1010                 return parse_flag(&targ->flags, TASK_ARG_DROP, pkey);
1011         }
1012         if (STR_EQ(str, "loop")) {
1013                 parse_flag(&targ->loop, 1, pkey);
1014                 return parse_flag(&targ->loop, 1, pkey);
1015         }
1016         if (STR_EQ(str, "qinq")) {
1017                 return parse_flag(&targ->flags, TASK_ARG_QINQ_ACL, pkey);
1018         }
1019         if (STR_EQ(str, "bps")) {
1020                 return parse_u64(&targ->rate_bps, pkey);
1021         }
1022         if (STR_EQ(str, "random")) {
1023                 return parse_str(targ->rand_str[targ->n_rand_str++], pkey, sizeof(targ->rand_str[0]));
1024         }
1025         if (STR_EQ(str, "range")) {
1026                 int rc = parse_range(&targ->range[targ->n_ranges].min, &targ->range[targ->n_ranges].max, pkey);
1027                 targ->n_ranges++;
1028                 return rc;
1029         }
1030         if (STR_EQ(str, "range_offset")) {
1031                 if (targ->n_ranges == 0) {
1032                         set_errf("No range defined previously (use range=...)");
1033                         return -1;
1034                 }
1035                 return parse_int(&targ->range[targ->n_ranges - 1].offset, pkey);
1036         }
1037         if (STR_EQ(str, "rand_offset")) {
1038                 if (targ->n_rand_str == 0) {
1039                         set_errf("No random defined previously (use random=...)");
1040                         return -1;
1041                 }
1042
1043                 return parse_int(&targ->rand_offset[targ->n_rand_str - 1], pkey);
1044         }
1045         if (STR_EQ(str, "keep src mac")) {
1046                 return parse_flag(&targ->flags, DSF_KEEP_SRC_MAC, pkey);
1047         }
1048         if (STR_EQ(str, "pcap file")) {
1049                 return parse_str(targ->pcap_file, pkey, sizeof(targ->pcap_file));
1050         }
1051         if (STR_EQ(str, "imix")) {
1052                 char pkey2[MAX_CFG_STRING_LEN], *ptr;
1053                 if (parse_str(pkey2, pkey, sizeof(pkey2)) != 0) {
1054                         set_errf("Error while parsing imix, too long\n");
1055                         return -1;
1056                 }
1057                 const size_t pkey_len = strlen(pkey2);
1058                 targ->imix_nb_pkts = 0;
1059                 ptr = pkey2;
1060                 while (targ->imix_nb_pkts < MAX_IMIX_PKTS) {
1061                         if (parse_int(&targ->imix_pkt_sizes[targ->imix_nb_pkts], ptr) != 0)
1062                                 break;
1063                         targ->imix_nb_pkts++;
1064                         if ((ptr = strchr(ptr, ',')) == NULL)
1065                                 break;
1066                         ptr++;
1067                         if (targ->imix_nb_pkts == MAX_IMIX_PKTS) {
1068                                 set_errf("Too many packet sizes specified");
1069                                 return -1;
1070                         }
1071                 }
1072                 plog_info("%d IMIX packets:", targ->imix_nb_pkts);
1073                 for (size_t i = 0; i < targ->imix_nb_pkts; ++i) {
1074                         plog_info("%d ", targ->imix_pkt_sizes[i]);
1075                 }
1076                 plog_info("\n");
1077                 return 0;
1078         }
1079         if (STR_EQ(str, "pkt inline")) {
1080                 char pkey2[MAX_CFG_STRING_LEN];
1081                 if (parse_str(pkey2, pkey, sizeof(pkey2)) != 0) {
1082                         set_errf("Error while parsing pkt line, too long\n");
1083                         return -1;
1084                 }
1085
1086                 const size_t pkey_len = strlen(pkey2);
1087                 targ->pkt_size = 0;
1088
1089                 for (size_t i = 0; i < pkey_len; ++i) {
1090                         if (pkey2[i] == ' ')
1091                                 continue;
1092
1093                         if (i + 1 == pkey_len) {
1094                                 set_errf("Incomplete byte at character %z", i);
1095                                 return -1;
1096                         }
1097
1098                         uint8_t byte = 0;
1099
1100                         if (pkey2[i] >= '0' && pkey2[i] <= '9') {
1101                                 byte = (pkey2[i] - '0') << 4;
1102                         }
1103                         else if (pkey2[i] >= 'a' && pkey2[i] <= 'f') {
1104                                 byte = (pkey2[i] - 'a' + 10) << 4;
1105                         }
1106                         else if (pkey2[i] >= 'A' && pkey2[i] <= 'F') {
1107                                 byte = (pkey2[i] - 'A' + 10) << 4;
1108                         }
1109                         else {
1110                                 set_errf("Invalid character in pkt inline at byte %d (%c)", i, pkey2[i]);
1111                                 return -1;
1112                         }
1113
1114                         if (pkey2[i + 1] >= '0' && pkey2[i + 1] <= '9') {
1115                                 byte |= (pkey2[i + 1] - '0');
1116                         }
1117                         else if (pkey2[i + 1] >= 'a' && pkey2[i + 1] <= 'f') {
1118                                 byte |= (pkey2[i + 1] - 'a' + 10);
1119                         }
1120                         else if (pkey2[i + 1] >= 'A' && pkey2[i + 1] <= 'F') {
1121                                 byte |= (pkey2[i + 1] - 'A' + 10);
1122                         }
1123                         else {
1124                                 set_errf("Invalid character in pkt inline at byte %d (%c)", i, pkey2[i + 1]);
1125                                 return -1;
1126                         }
1127                         if (targ->pkt_size == sizeof(targ->pkt_inline)) {
1128                                 set_errf("Inline packet definition can't be longer than %u", sizeof(targ->pkt_inline));
1129                                 return -1;
1130                         }
1131
1132                         targ->pkt_inline[targ->pkt_size++] = byte;
1133                         i += 1;
1134                 }
1135
1136                 return 0;
1137         }
1138         if (STR_EQ(str, "accuracy limit nsec")) {
1139                 return parse_int(&targ->accuracy_limit_nsec, pkey);
1140         }
1141         if (STR_EQ(str, "latency bucket size")) {
1142                 return parse_int(&targ->bucket_size, pkey);
1143         }
1144         if (STR_EQ(str, "latency buffer size")) {
1145                 return parse_int(&targ->latency_buffer_size, pkey);
1146         }
1147         if (STR_EQ(str, "accuracy pos")) {
1148                 return parse_int(&targ->accur_pos, pkey);
1149         }
1150         if (STR_EQ(str, "signature")) {
1151                 return parse_int(&targ->sig, pkey);
1152         }
1153         if (STR_EQ(str, "signature pos")) {
1154                 return parse_int(&targ->sig_pos, pkey);
1155         }
1156         if (STR_EQ(str, "lat pos")) {
1157                 targ->lat_enabled = 1;
1158                 return parse_int(&targ->lat_pos, pkey);
1159         }
1160         if (STR_EQ(str, "packet id pos")) {
1161                 return parse_int(&targ->packet_id_pos, pkey);
1162         }
1163         if (STR_EQ(str, "probability")) { // old - use "probability no drop" instead
1164                 float probability;
1165                 int rc = parse_float(&probability, pkey);
1166                 if (probability == 0) {
1167                         set_errf("Probability must be != 0\n");
1168                         return -1;
1169                 } else if (probability > 100.0) {
1170                         set_errf("Probability must be < 100\n");
1171                         return -1;
1172                 }
1173                 targ->probability_no_drop = probability * 10000;
1174                 return rc;
1175         }
1176         if (STR_EQ(str, "proba no drop")) {
1177                 float probability;
1178                 int rc = parse_float(&probability, pkey);
1179                 if (probability == 0) {
1180                         set_errf("probability no drop must be != 0\n");
1181                         return -1;
1182                 } else if (probability > 100.0) {
1183                         set_errf("Probability must be < 100\n");
1184                         return -1;
1185                 }
1186                 targ->probability_no_drop = probability * 10000;
1187                 return rc;
1188         }
1189         if (STR_EQ(str, "proba delay")) {
1190                 float probability;
1191                 int rc = parse_float(&probability, pkey);
1192                 if (probability > 100.0) {
1193                         set_errf("Probability must be < 100\n");
1194                         return -1;
1195                 }
1196                 targ->probability_delay = probability * 10000;
1197                 return rc;
1198         }
1199 #if RTE_VERSION >= RTE_VERSION_NUM(19,11,0,0)
1200         if (STR_EQ(str, "proba duplicate")) {
1201                 float probability;
1202                 int rc = parse_float(&probability, pkey);
1203                 if (probability > 100.0) {
1204                         set_errf("probability duplicate must be < 100\n");
1205                         return -1;
1206                 }
1207                 targ->probability_duplicate = probability * 10000;
1208                 return rc;
1209         }
1210 #endif
1211         if (STR_EQ(str, "concur conn")) {
1212                 return parse_int(&targ->n_concur_conn, pkey);
1213         }
1214         if (STR_EQ(str, "max setup rate")) {
1215                 return parse_int(&targ->max_setup_rate, pkey);
1216         }
1217         if (STR_EQ(str, "pkt size")) {
1218                 return parse_int(&targ->pkt_size, pkey);
1219         }
1220         if (STR_EQ(str, "min bulk size")) {
1221                 return parse_int(&targ->min_bulk_size, pkey);
1222         }
1223         if (STR_EQ(str, "max bulk size")) {
1224                 return parse_int(&targ->max_bulk_size, pkey);
1225         }
1226         if (STR_EQ(str, "rx port")) {
1227                 if (targ->flags & TASK_ARG_RX_RING) {
1228                         set_errf("Can't read both from internal ring and external port from the same task. Use multiple tasks instead.");
1229                         return -1;
1230                 }
1231                 uint32_t vals[PROX_MAX_PORTS];
1232                 uint32_t n_if;
1233
1234                 if (parse_port_name_list(vals, &n_if, PROX_MAX_PORTS, pkey)) {
1235                         // Port name not found, but could be a virtual device of a secondary process
1236                         // As DPDK not started yet, we can only check the config file to see whether we are a secondary process
1237                         if (rte_cfg.eal &&
1238                                         (strstr(rte_cfg.eal, "secondary") || strstr(rte_cfg.eal, "auto")) &&
1239                                         (n_deferred_ports < PROX_MAX_PORTS)) {
1240                                 prox_strncpy(deferred_port[n_deferred_ports].name, pkey, sizeof(deferred_port[n_deferred_ports].name));
1241                                 deferred_port[n_deferred_ports].is_rx_port = 1;
1242                                 deferred_port[n_deferred_ports++].targ = targ;
1243                                 return 0;
1244                         } else
1245                                 return -1;
1246                 }
1247
1248                 for (uint8_t i = 0; i < n_if; ++i) {
1249                         PROX_ASSERT(vals[i] < PROX_MAX_PORTS);
1250                         targ->rx_port_queue[i].port = vals[i];
1251                         targ->nb_rxports++;
1252                 }
1253                 return 0;
1254         }
1255
1256         if (STR_EQ(str, "mode")) {
1257                 /* Check deprecated task modes */
1258                 char mode[255];
1259                 int ret = parse_str(mode, pkey, sizeof(mode));
1260                 if (ret)
1261                         return ret;
1262
1263                 for (uint32_t i = 0; i < RTE_DIM(task_cfg_depr); ++i) {
1264                         if (STR_EQ(mode, task_cfg_depr[i].opt)) {
1265                                 set_errf("Task mode '%s' is deprecated%s%s",
1266                                          task_cfg_depr[i].opt, strlen(task_cfg_depr[i].info)? ": ": "", task_cfg_depr[i].info);
1267                                 return -1;
1268                         }
1269                 }
1270
1271                 /* master is a special mode that is always needed (cannot be turned off) */
1272                 if (STR_EQ(mode, "master")) {
1273                         prox_cfg.master = ncore;
1274                         targ->mode = MASTER;
1275                         if (lconf->n_tasks_all > 1 || targ->task != 0) {
1276                                 set_errf("Master core can only have one task\n");
1277                                 return -1;
1278                         }
1279                         // Initialize number of tasks to 1 for master, even if no task specified
1280                         lconf->n_tasks_all = 1;
1281                         lconf->active_task = 0;
1282                         lconf->targs[lconf->active_task].task = 0;
1283                         struct task_init* task_init = to_task_init(mode, "");
1284                         if (task_init) {
1285                                 targ->mode = task_init->mode;
1286                         }
1287                         targ->task_init = task_init;
1288                         return 0;
1289                 }
1290
1291                 struct task_init* task_init = to_task_init(mode, "");
1292                 if (task_init) {
1293                         targ->mode = task_init->mode;
1294                 }
1295                 else {
1296                         set_errf("Task mode '%s' is invalid", mode);
1297                         tasks_list();
1298                         return -1;
1299                 }
1300                 targ->task_init = task_init;
1301                 return 0;
1302         }
1303         if (STR_EQ(str, "users")) {
1304                 return parse_int(&targ->n_flows, pkey);
1305         }
1306
1307         if (STR_EQ(str, "mark")) {
1308                 return parse_flag(&targ->runtime_flags, TASK_MARK, pkey);
1309         }
1310
1311         if (STR_EQ(str, "mark green")) {
1312                 return parse_int(&targ->marking[0], pkey);
1313         }
1314
1315         if (STR_EQ(str, "mark yellow")) {
1316                 return parse_int(&targ->marking[1], pkey);
1317         }
1318
1319         if (STR_EQ(str, "mark red")) {
1320                 return parse_int(&targ->marking[2], pkey);
1321         }
1322
1323         if (STR_EQ(str, "tx cores")) {
1324                 uint8_t dest_task = 0;
1325                 /* if user did not specify, dest_port is left at default (first type) */
1326                 uint8_t dest_proto = 0;
1327                 uint8_t ctrl = CTRL_TYPE_DP;
1328                 char *task_str = strstr(pkey, "proto=");
1329                 if (task_str) {
1330                         task_str += strlen("proto=");
1331
1332                         if (STR_EQ(task_str, "ipv4")) {
1333                                 dest_proto = IPV4;
1334                         }
1335                         else if (STR_EQ(task_str, "arp")) {
1336                                 dest_proto = ARP;
1337                         }
1338                         else if (STR_EQ(task_str, "ipv6")) {
1339                                 dest_proto = IPV6;
1340                         }
1341                         else {
1342                                 set_errf("proto needs to be either ipv4, arp or ipv6");
1343                                 return -1;
1344                         }
1345
1346                 }
1347
1348                 task_str = strstr(pkey, "task=");
1349
1350                 if (task_str) {
1351                         --task_str;
1352                         *task_str = 0;
1353                         task_str++;
1354                         task_str += strlen("task=");
1355                         char *task_str_end = strstr(task_str, " ");
1356                         if (task_str_end) {
1357                                 *task_str_end = 0;
1358                         }
1359                         if (0 == strlen(task_str)) {
1360                                 set_errf("Invalid task= syntax");
1361                                 return -1;
1362                         }
1363
1364                         switch (task_str[strlen(task_str) - 1]) {
1365                         case 'p':
1366                                 ctrl = CTRL_TYPE_PKT;
1367                                 break;
1368                         case 'm':
1369                                 ctrl = CTRL_TYPE_MSG;
1370                                 break;
1371                         case '\n':
1372                         case 0:
1373                                 break;
1374                         default:
1375                                 if (task_str[strlen(task_str) -1] < '0' ||
1376                                     task_str[strlen(task_str) -1] > '9') {
1377                                         set_errf("Unknown ring type %c.\n",
1378                                                  task_str[strlen(task_str) - 1]);
1379                                         return -1;
1380                                 }
1381                         }
1382
1383                         dest_task = atoi(task_str);
1384                         if (dest_task >= MAX_TASKS_PER_CORE) {
1385                                 set_errf("Destination task too high (max allowed %d)", MAX_TASKS_PER_CORE - 1);
1386                                 return -1;
1387                         }
1388                 }
1389                 else {
1390                         dest_task = 0;
1391                 }
1392
1393                 struct core_task_set *cts = &targ->core_task_set[dest_proto];
1394
1395                 if (parse_task_set(cts, pkey))
1396                         return -1;
1397
1398                 if (cts->n_elems > MAX_WT_PER_LB) {
1399                         set_errf("Too many worker threads (max allowed %d)", MAX_WT_PER_LB - 1);
1400                         return -1;
1401                 }
1402
1403                 targ->nb_worker_threads = cts->n_elems;
1404                 targ->nb_txrings += cts->n_elems;
1405
1406                 return 0;
1407         }
1408         if (STR_EQ(str, "tx crc")) {
1409                 return parse_flag(&targ->runtime_flags, TASK_TX_CRC, pkey);
1410         }
1411         if (STR_EQ(str, "ring size")) {
1412                 return parse_int(&targ->ring_size, pkey);
1413         }
1414         if (STR_EQ(str, "mempool size")) {
1415                 return parse_kmg(&targ->nb_mbuf, pkey);
1416         }
1417
1418         else if (STR_EQ(str, "mbuf size")) {
1419                 return parse_int(&targ->mbuf_size, pkey);
1420         }
1421         if (STR_EQ(str, "memcache size")) {
1422                 return parse_kmg(&targ->nb_cache_mbuf, pkey);
1423         }
1424
1425         if (STR_EQ(str, "byte offset")) {
1426                 return parse_int(&targ->byte_offset, pkey);
1427         }
1428
1429         if (STR_EQ(str, "realtime scheduling")) {
1430                 return parse_flag(&lconf->flags, LCONF_FLAG_SCHED_RR, pkey);
1431         }
1432         if (STR_EQ(str, "name")) {
1433                 return parse_str(lconf->name, pkey, sizeof(lconf->name));
1434         }
1435         /* MPLS configuration */
1436         if (STR_EQ(str, "untag mpls")) {
1437                 return parse_flag(&targ->runtime_flags, TASK_MPLS_TAGGING, pkey);
1438         }
1439
1440         if (STR_EQ(str, "add mpls")) {
1441                 return parse_flag(&targ->runtime_flags, TASK_MPLS_TAGGING, pkey);
1442         }
1443
1444         if (STR_EQ(str, "ether type")) {
1445                 return parse_int(&targ->etype, pkey);
1446         }
1447
1448         if (STR_EQ(str, "cache set")) {
1449                 return parse_int(&lconf->cache_set, pkey);
1450         }
1451
1452         if (STR_EQ(str, "sub mode")) {
1453                 const char* mode_str = targ->task_init->mode_str;
1454                 const char *sub_mode_str = pkey;
1455
1456                 targ->task_init = to_task_init(mode_str, sub_mode_str);
1457                 if (!targ->task_init) {
1458                         if ((strcmp(sub_mode_str, "l3") != 0) && (strcmp(sub_mode_str, "ndp") != 0)) {
1459                                 set_errf("sub mode %s not supported for mode %s", sub_mode_str, mode_str);
1460                                 return -1;
1461                         }
1462                         targ->task_init = to_task_init(mode_str, "");
1463                         if (!targ->task_init) {
1464                                 set_errf("sub mode %s not supported for mode %s", sub_mode_str, mode_str);
1465                                 return -1;
1466                         }
1467                 }
1468                 if (strcmp(sub_mode_str, "l3") == 0) {
1469                         prox_cfg.flags |= DSF_L3_ENABLED;
1470                         targ->flags |= TASK_ARG_L3;
1471                         strcpy(targ->sub_mode_str, "l3");
1472                 } else if (strcmp(sub_mode_str, "ndp") == 0) {
1473                         prox_cfg.flags |= DSF_NDP_ENABLED;
1474                         targ->flags |= TASK_ARG_NDP;
1475                         strcpy(targ->sub_mode_str, "ndp");
1476                 } else {
1477                         strcpy(targ->sub_mode_str, targ->task_init->sub_mode_str);
1478                 }
1479                 return 0;
1480         }
1481
1482         if (STR_EQ(str, "mempool name")) {
1483                 return parse_str(targ->pool_name, pkey, sizeof(targ->pool_name));
1484         }
1485         if (STR_EQ(str, "dpi engine")) {
1486                 return parse_str(targ->dpi_engine_path, pkey, sizeof(targ->dpi_engine_path));
1487         }
1488         if (STR_EQ(str, "dpi engine arg")) {
1489                 return parse_str(targ->dpi_engine_args[targ->n_dpi_engine_args++], pkey,
1490                                  sizeof(targ->dpi_engine_args[0]));
1491         }
1492         if (STR_EQ(str, "dst mac")) { /* destination MAC address to be used for packets */
1493                 if (parse_mac(&targ->edaddr, pkey)) {
1494                         if (STR_EQ(pkey, "no")) {
1495                                 targ->flags |= TASK_ARG_DO_NOT_SET_DST_MAC;
1496                                 return 0;
1497                         }
1498                         if (STR_EQ(pkey, "packet") == 0)
1499                                 return -1;
1500                         else
1501                                 return 0;
1502                 }
1503                 targ->flags |= TASK_ARG_DST_MAC_SET;
1504                 return 0;
1505         }
1506         if (STR_EQ(str, "src mac")) {
1507                 if (parse_mac(&targ->esaddr, pkey)) {
1508                         if (STR_EQ(pkey, "no")) {
1509                                 targ->flags |= TASK_ARG_DO_NOT_SET_SRC_MAC;
1510                                 return 0;
1511                         }
1512                         else if (STR_EQ(pkey, "packet"))
1513                                 return 0;
1514                         else if (STR_EQ(pkey, "hw")) {
1515                                 targ->flags |= TASK_ARG_HW_SRC_MAC;
1516                                 return 0;
1517                         } else {
1518                                 return -1;
1519                         }
1520                 }
1521                 targ->flags |= TASK_ARG_SRC_MAC_SET;
1522                 return 0;
1523         }
1524         if (STR_EQ(str, "igmp ipv4")) { /* IGMP Group */
1525                 return parse_ip(&targ->igmp_address, pkey);
1526         }
1527         if (STR_EQ(str, "gateway ipv4")) { /* Gateway IP address used when generating */
1528                 if ((targ->flags & TASK_ARG_L3) == 0)
1529                         plog_warn("gateway ipv4 configured but L3 sub mode not enabled\n");
1530                 if (targ->local_ipv4)
1531                         targ->local_prefix = 32;
1532                 return parse_ip(&targ->gateway_ipv4, pkey);
1533         }
1534         if (STR_EQ(str, "ipv6 router")) { /* we simulate an IPV6 router */
1535                 int rc = parse_flag(&targ->ipv6_router, 1, pkey);
1536                 if (!rc && targ->ipv6_router) {
1537                         plog_info("\tipv6 router configured => NDP enabled\n");
1538                         prox_cfg.flags |= DSF_NDP_ENABLED;
1539                         targ->flags |= TASK_ARG_NDP;
1540                         strcpy(targ->sub_mode_str, "ndp");
1541                 }
1542                 return 0;
1543         }
1544         if (STR_EQ(str, "gateway ipv6")) { /* Gateway IP address used when generating */
1545                 if ((targ->flags & TASK_ARG_NDP) == 0)
1546                         plog_warn("gateway ipv6 configured but NDP sub mode not enabled\n");
1547                 return parse_ip6(&targ->gateway_ipv6, pkey);
1548         }
1549         if (STR_EQ(str, "local ipv4")) { /* source IP address to be used for packets */
1550                 struct ip4_subnet cidr;
1551                 if (parse_ip4_and_prefix(&cidr, pkey) != 0) {
1552                         if (targ->gateway_ipv4)
1553                                 targ->local_prefix = 32;
1554                         else
1555                                 targ->local_prefix = 0;
1556                         return parse_ip(&targ->local_ipv4, pkey);
1557                 } else {
1558                         targ->local_ipv4 = cidr.ip;
1559                         targ->local_prefix = cidr.prefix;
1560                         return 0;
1561                 }
1562         }
1563         if (STR_EQ(str, "remote ipv4")) { /* source IP address to be used for packets */
1564                 return parse_ip(&targ->remote_ipv4, pkey);
1565         }
1566         if (STR_EQ(str, "global ipv6")) {
1567                 if (parse_ip6(&targ->global_ipv6, pkey) == 0) {
1568                         plog_info("\tglobal ipv6 configured => NDP enabled\n");
1569                         targ->flags |= TASK_ARG_NDP;
1570                         prox_cfg.flags |= DSF_NDP_ENABLED;
1571                         strcpy(targ->sub_mode_str, "ndp");
1572                 } else {
1573                         plog_err("Unable to parse content of local ipv6: %s\n", pkey);
1574                         return -1;
1575                 }
1576                 return 0;
1577         }
1578         if (STR_EQ(str, "local ipv6")) { /* source IPv6 address to be used for packets */
1579                 if (parse_ip6(&targ->local_ipv6, pkey) == 0) {
1580                         plog_info("\tlocal ipv6 configured => NDP enabled\n");
1581                         targ->flags |= TASK_ARG_NDP;
1582                         prox_cfg.flags |= DSF_NDP_ENABLED;
1583                         strcpy(targ->sub_mode_str, "ndp");
1584                 } else {
1585                         plog_err("Unable to parse content of local ipv6: %s\n", pkey);
1586                         return -1;
1587                 }
1588                 return 0;
1589         }
1590         if (STR_EQ(str, "router prefix")) {
1591                 if (parse_ip6(&targ->router_prefix, pkey) == 0) {
1592                         plog_info("\trouter prefix set to "IPv6_BYTES_FMT" (%s)\n", IPv6_BYTES(targ->router_prefix.bytes), IP6_Canonical(&targ->router_prefix));
1593                 } else {
1594                         plog_err("Unable to parse content of router prefix: %s\n", pkey);
1595                         return -1;
1596                 }
1597                 return 0;
1598         }
1599         if (STR_EQ(str, "arp timeout"))
1600                 return parse_int(&targ->reachable_timeout, pkey);
1601         if (STR_EQ(str, "arp update time"))
1602                 return parse_int(&targ->arp_ndp_retransmit_timeout, pkey);
1603         if (STR_EQ(str, "number of packets"))
1604                 return parse_int(&targ->n_pkts, pkey);
1605         if (STR_EQ(str, "store size"))
1606                 return parse_int(&targ->store_max, pkey);
1607         if (STR_EQ(str, "pipes")) {
1608                 uint32_t val;
1609                 int err = parse_int(&val, pkey);
1610                 if (err)
1611                         return -1;
1612                 if (!val || !rte_is_power_of_2(val)) {
1613                         set_errf("Number of pipes has to be power of 2 and not zero");
1614                         return -1;
1615                 }
1616
1617                 targ->qos_conf.port_params.n_pipes_per_subport = val;
1618                 return 0;
1619         }
1620         if (STR_EQ(str, "queue size")) {
1621                 uint32_t val;
1622                 int err = parse_int(&val, pkey);
1623                 if (err) {
1624                         return -1;
1625                 }
1626 #if RTE_VERSION > RTE_VERSION_NUM(19,11,0,0)
1627                 targ->qos_conf.subport_params[0].qsize[0] = val;
1628                 targ->qos_conf.subport_params[0].qsize[1] = val;
1629                 targ->qos_conf.subport_params[0].qsize[2] = val;
1630                 targ->qos_conf.subport_params[0].qsize[3] = val;
1631 #else
1632                 targ->qos_conf.port_params.qsize[0] = val;
1633                 targ->qos_conf.port_params.qsize[1] = val;
1634                 targ->qos_conf.port_params.qsize[2] = val;
1635                 targ->qos_conf.port_params.qsize[3] = val;
1636 #endif
1637                 return 0;
1638         }
1639         if (STR_EQ(str, "subport tb rate")) {
1640 #if RTE_VERSION >= RTE_VERSION_NUM(20,11,0,0)
1641                 return parse_u64(&targ->qos_conf.port_params.subport_profiles->tb_rate, pkey);
1642 #else
1643 #if RTE_VERSION > RTE_VERSION_NUM(19,11,0,0)
1644                 return parse_u64(&targ->qos_conf.subport_params[0].tb_rate, pkey);
1645 #else
1646                 return parse_int(&targ->qos_conf.subport_params[0].tb_rate, pkey);
1647 #endif
1648 #endif
1649         }
1650         if (STR_EQ(str, "subport tb size")) {
1651 #if RTE_VERSION >= RTE_VERSION_NUM(20,11,0,0)
1652                 return parse_u64(&targ->qos_conf.port_params.subport_profiles->tb_size, pkey);
1653 #else
1654 #if RTE_VERSION > RTE_VERSION_NUM(19,11,0,0)
1655                 return parse_u64(&targ->qos_conf.subport_params[0].tb_size, pkey);
1656 #else
1657                 return parse_int(&targ->qos_conf.subport_params[0].tb_size, pkey);
1658 #endif
1659 #endif
1660         }
1661         if (STR_EQ(str, "subport tc 0 rate")) {
1662 #if RTE_VERSION >= RTE_VERSION_NUM(20,11,0,0)
1663                 return parse_u64(&targ->qos_conf.port_params.subport_profiles->tc_rate[0], pkey);
1664 #else
1665 #if RTE_VERSION > RTE_VERSION_NUM(19,11,0,0)
1666                 return parse_u64(&targ->qos_conf.subport_params[0].tc_rate[0], pkey);
1667 #else
1668                 return parse_int(&targ->qos_conf.subport_params[0].tc_rate[0], pkey);
1669 #endif
1670 #endif
1671         }
1672         if (STR_EQ(str, "subport tc 1 rate")) {
1673 #if RTE_VERSION >= RTE_VERSION_NUM(20,11,0,0)
1674                 return parse_u64(&targ->qos_conf.port_params.subport_profiles->tc_rate[1], pkey);
1675 #else
1676 #if RTE_VERSION > RTE_VERSION_NUM(19,11,0,0)
1677                 return parse_u64(&targ->qos_conf.subport_params[0].tc_rate[1], pkey);
1678 #else
1679                 return parse_int(&targ->qos_conf.subport_params[0].tc_rate[1], pkey);
1680 #endif
1681 #endif
1682         }
1683         if (STR_EQ(str, "subport tc 2 rate")) {
1684 #if RTE_VERSION >= RTE_VERSION_NUM(20,11,0,0)
1685                 return parse_u64(&targ->qos_conf.port_params.subport_profiles->tc_rate[2], pkey);
1686 #else
1687 #if RTE_VERSION > RTE_VERSION_NUM(19,11,0,0)
1688                 return parse_u64(&targ->qos_conf.subport_params[0].tc_rate[2], pkey);
1689 #else
1690                 return parse_int(&targ->qos_conf.subport_params[0].tc_rate[2], pkey);
1691 #endif
1692 #endif
1693         }
1694         if (STR_EQ(str, "subport tc 3 rate")) {
1695 #if RTE_VERSION >= RTE_VERSION_NUM(20,11,0,0)
1696                 return parse_u64(&targ->qos_conf.port_params.subport_profiles->tc_rate[3], pkey);
1697 #else
1698 #if RTE_VERSION > RTE_VERSION_NUM(19,11,0,0)
1699                 return parse_u64(&targ->qos_conf.subport_params[0].tc_rate[3], pkey);
1700 #else
1701                 return parse_int(&targ->qos_conf.subport_params[0].tc_rate[3], pkey);
1702 #endif
1703 #endif
1704         }
1705
1706         if (STR_EQ(str, "subport tc rate")) {
1707                 uint32_t val;
1708                 int err = parse_int(&val, pkey);
1709                 if (err) {
1710                         return -1;
1711                 }
1712
1713 #if RTE_VERSION >= RTE_VERSION_NUM(20,11,0,0)
1714                 targ->qos_conf.port_params.subport_profiles->tc_rate[0] = val;
1715                 targ->qos_conf.port_params.subport_profiles->tc_rate[1] = val;
1716                 targ->qos_conf.port_params.subport_profiles->tc_rate[2] = val;
1717                 targ->qos_conf.port_params.subport_profiles->tc_rate[3] = val;
1718 #else
1719                 targ->qos_conf.subport_params[0].tc_rate[0] = val;
1720                 targ->qos_conf.subport_params[0].tc_rate[1] = val;
1721                 targ->qos_conf.subport_params[0].tc_rate[2] = val;
1722                 targ->qos_conf.subport_params[0].tc_rate[3] = val;
1723 #endif
1724
1725                 return 0;
1726         }
1727         if (STR_EQ(str, "subport tc period")) {
1728 #if RTE_VERSION >= RTE_VERSION_NUM(20,11,0,0)
1729                 return parse_u64(&targ->qos_conf.port_params.subport_profiles->tc_period, pkey);
1730 #else
1731 #if RTE_VERSION > RTE_VERSION_NUM(19,11,0,0)
1732                 return parse_u64(&targ->qos_conf.subport_params[0].tc_period, pkey);
1733 #else
1734                 return parse_int(&targ->qos_conf.subport_params[0].tc_period, pkey);
1735 #endif
1736 #endif
1737         }
1738         if (STR_EQ(str, "pipe tb rate")) {
1739 #if RTE_VERSION > RTE_VERSION_NUM(19,11,0,0)
1740                 return parse_u64(&targ->qos_conf.pipe_params[0].tb_rate, pkey);
1741 #else
1742                 return parse_int(&targ->qos_conf.pipe_params[0].tb_rate, pkey);
1743 #endif
1744         }
1745         if (STR_EQ(str, "pipe tb size")) {
1746 #if RTE_VERSION > RTE_VERSION_NUM(19,11,0,0)
1747                 return parse_u64(&targ->qos_conf.pipe_params[0].tb_size, pkey);
1748 #else
1749                 return parse_int(&targ->qos_conf.pipe_params[0].tb_size, pkey);
1750 #endif
1751         }
1752         if (STR_EQ(str, "pipe tc rate")) {
1753                 uint32_t val;
1754                 int err = parse_int(&val, pkey);
1755                 if (err) {
1756                         return -1;
1757                 }
1758
1759                 targ->qos_conf.pipe_params[0].tc_rate[0] = val;
1760                 targ->qos_conf.pipe_params[0].tc_rate[1] = val;
1761                 targ->qos_conf.pipe_params[0].tc_rate[2] = val;
1762                 targ->qos_conf.pipe_params[0].tc_rate[3] = val;
1763                 return 0;
1764         }
1765         if (STR_EQ(str, "pipe tc 0 rate")) {
1766 #if RTE_VERSION > RTE_VERSION_NUM(19,11,0,0)
1767                 return parse_u64(&targ->qos_conf.pipe_params[0].tc_rate[0], pkey);
1768 #else
1769                 return parse_int(&targ->qos_conf.pipe_params[0].tc_rate[0], pkey);
1770 #endif
1771         }
1772         if (STR_EQ(str, "pipe tc 1 rate")) {
1773 #if RTE_VERSION > RTE_VERSION_NUM(19,11,0,0)
1774                 return parse_u64(&targ->qos_conf.pipe_params[0].tc_rate[1], pkey);
1775 #else
1776                 return parse_int(&targ->qos_conf.pipe_params[0].tc_rate[1], pkey);
1777 #endif
1778         }
1779         if (STR_EQ(str, "pipe tc 2 rate")) {
1780 #if RTE_VERSION > RTE_VERSION_NUM(19,11,0,0)
1781                 return parse_u64(&targ->qos_conf.pipe_params[0].tc_rate[2], pkey);
1782 #else
1783                 return parse_int(&targ->qos_conf.pipe_params[0].tc_rate[2], pkey);
1784 #endif
1785         }
1786         if (STR_EQ(str, "pipe tc 3 rate")) {
1787 #if RTE_VERSION > RTE_VERSION_NUM(19,11,0,0)
1788                 return parse_u64(&targ->qos_conf.pipe_params[0].tc_rate[3], pkey);
1789 #else
1790                 return parse_int(&targ->qos_conf.pipe_params[0].tc_rate[3], pkey);
1791 #endif
1792         }
1793         if (STR_EQ(str, "pipe tc period")) {
1794 #if RTE_VERSION > RTE_VERSION_NUM(19,11,0,0)
1795                 return parse_u64(&targ->qos_conf.pipe_params[0].tc_period, pkey);
1796 #else
1797                 return parse_int(&targ->qos_conf.pipe_params[0].tc_period, pkey);
1798 #endif
1799         }
1800         if (STR_EQ(str, "police action")) {
1801                 char *in = strstr(pkey, " io=");
1802                 if (in == NULL) {
1803                         set_errf("Need to specify io colors using io=in_color,out_color\n");
1804                         return -1;
1805                 }
1806                 *in = 0;
1807                 in += strlen(" io=");
1808
1809                 char *out = strstr(in, ",");
1810                 if (out == NULL) {
1811                         set_errf("Output color not specified\n");
1812                 }
1813                 *out = 0;
1814                 out++;
1815
1816                 enum police_action in_color = str_to_color(in);
1817                 enum police_action out_color = str_to_color(out);
1818
1819                 if (in_color == ACT_INVALID) {
1820                         set_errf("Invalid input color %s. Expected green, yellow or red", in);
1821                         return -1;
1822                 }
1823                 if (out_color == ACT_INVALID) {
1824                         set_errf("Invalid output color %s. Expected green, yellow or red", out);
1825                         return -1;
1826                 }
1827                 enum police_action action = str_to_color(pkey);
1828                 if (action == ACT_INVALID) {
1829                         set_errf("Error action %s. Expected green, yellow, red or drop", pkey);
1830                         return -1;
1831                 }
1832                 targ->police_act[in_color][out_color] = action;
1833
1834                 return 0;
1835         }
1836         if (STR_EQ(str, "qinq tag")) {
1837                 return parse_int(&targ->qinq_tag, pkey);
1838         }
1839         if (STR_EQ(str, "cir")) {
1840                 return parse_int(&targ->cir, pkey);
1841         }
1842         if (STR_EQ(str, "cbs")) {
1843                 return parse_int(&targ->cbs, pkey);
1844         }
1845         if (STR_EQ(str, "pir")) {
1846                 return parse_int(&targ->pir, pkey);
1847         }
1848         if (STR_EQ(str, "pbs")) {
1849                 return parse_int(&targ->pbs, pkey);
1850         }
1851         if (STR_EQ(str, "ebs")) {
1852                 return parse_int(&targ->ebs, pkey);
1853         }
1854         uint32_t queue_id = 0;
1855         if (sscanf(str, "queue %d weight", &queue_id) == 1) {
1856                 uint32_t val;
1857                 int err = parse_int(&val, pkey);
1858                 if (err) {
1859                         return -1;
1860                 }
1861                 if (queue_id >= RTE_SCHED_BE_QUEUES_PER_PIPE) {
1862                         set_errf("queue_id must be < %d", RTE_SCHED_BE_QUEUES_PER_PIPE);
1863                         return -1;
1864                 }
1865                 targ->qos_conf.pipe_params[0].wrr_weights[queue_id] = val;
1866                 return 0;
1867         }
1868         if (STR_EQ(str, "classify")) {
1869                 if (!(targ->task_init->flag_features & TASK_FEATURE_CLASSIFY)) {
1870                         set_errf("Classify is not supported in '%s' mode", targ->task_init->mode_str);
1871                         return -1;
1872                 }
1873
1874                 return parse_flag(&targ->runtime_flags, TASK_CLASSIFY, pkey);
1875         }
1876         if (STR_EQ(str, "flow table size")) {
1877                 return parse_int(&targ->flow_table_size, pkey);
1878         }
1879 #ifdef GRE_TP
1880         if (STR_EQ(str, "tbf rate")) {
1881                 return parse_int(&targ->tb_rate, pkey);
1882         }
1883         if (STR_EQ(str, "tbf size")) {
1884                 return parse_int(&targ->tb_size, pkey);
1885         }
1886 #endif
1887         if (STR_EQ(str, "max rules")) {
1888                 return parse_int(&targ->n_max_rules, pkey);
1889         }
1890
1891         if (STR_EQ(str, "tunnel hop limit")) {
1892                 uint32_t val;
1893                 int err = parse_int(&val, pkey);
1894                 if (err) {
1895                         return -1;
1896                 }
1897                 targ->tunnel_hop_limit = val;
1898                 return 0;
1899         }
1900
1901         if (STR_EQ(str, "lookup port mask")) {
1902                 uint32_t val;
1903                 int err = parse_int(&val, pkey);
1904                 if (err) {
1905                         return -1;
1906                 }
1907                 targ->lookup_port_mask = val;
1908                 return 0;
1909         }
1910
1911         if (STR_EQ(str, "irq debug")) {
1912                 parse_int(&targ->irq_debug, pkey);
1913                 return 0;
1914         }
1915
1916         if (STR_EQ(str, "multiplier")) {
1917                 parse_int(&targ->multiplier, pkey);
1918                 return 0;
1919         }
1920
1921         if (STR_EQ(str, "mirror size")) {
1922                 parse_int(&targ->mirror_size, pkey);
1923                 return 0;
1924         }
1925
1926         set_errf("Option '%s' is not known", str);
1927         /* fail on unknown keys */
1928         return -1;
1929 }
1930
1931 static int str_is_number(const char *in)
1932 {
1933         int dot_once = 0;
1934
1935         for (size_t i = 0; i < strlen(in); ++i) {
1936                 if (!dot_once && in[i] == '.') {
1937                         dot_once = 1;
1938                         continue;
1939                 }
1940
1941                 if (in[i] < '0' || in[i] > '9')
1942                         return 0;
1943         }
1944
1945         return 1;
1946 }
1947
1948 /* command line parameters parsing procedure */
1949 int prox_parse_args(int argc, char **argv)
1950 {
1951         int i, opt, ret;
1952         char *tmp, *tmp2;
1953         char tmp3[64];
1954
1955         /* Default settings */
1956         prox_cfg.flags |= DSF_AUTOSTART | DSF_WAIT_ON_QUIT;
1957         prox_cfg.ui = PROX_UI_CURSES;
1958
1959         plog_info("\tCommand line:");
1960         for (i = 0; i < argc; ++i) {
1961                 plog_info(" %s", argv[i]);
1962         }
1963         plog_info("\n");
1964
1965         while ((opt = getopt(argc, argv, "f:dnzpo:tkuar:emsiw:l:v:q:")) != EOF) {
1966                 switch (opt) {
1967                 case 'f':
1968                         /* path to config file */
1969                         cfg_file = optarg;
1970                         size_t offset = 0;
1971                         for (size_t i = 0; i < strlen(cfg_file); ++i) {
1972                                 if (cfg_file[i] == '/') {
1973                                         offset = i + 1;
1974                                 }
1975                         }
1976
1977                         prox_strncpy(prox_cfg.name, cfg_file + offset, MAX_NAME_SIZE);
1978                         break;
1979                 case 'v':
1980                         plog_set_lvl(atoi(optarg));
1981                         break;
1982                 case 'l':
1983                         prox_cfg.log_name_pid = 0;
1984                         prox_strncpy(prox_cfg.log_name, optarg, MAX_NAME_SIZE);
1985                         break;
1986                 case 'p':
1987                         prox_cfg.log_name_pid = 1;
1988                         break;
1989                 case 'k':
1990                         prox_cfg.use_stats_logger = 1;
1991                         break;
1992                 case 'd':
1993                         prox_cfg.flags |= DSF_DAEMON;
1994                         prox_cfg.ui = PROX_UI_NONE;
1995                         break;
1996                 case 'z':
1997                         prox_cfg.flags |= DSF_USE_DUMMY_CPU_TOPO;
1998                         prox_cfg.flags |= DSF_CHECK_INIT;
1999                         break;
2000                 case 'n':
2001                         prox_cfg.flags |= DSF_USE_DUMMY_DEVICES;
2002                         break;
2003                 case 'r':
2004                         if (!str_is_number(optarg) || strlen(optarg) > 11)
2005                                 return -1;
2006                         prox_strncpy(prox_cfg.update_interval_str, optarg, sizeof(prox_cfg.update_interval_str));
2007                         break;
2008                 case 'o':
2009                         if (prox_cfg.flags & DSF_DAEMON)
2010                                 break;
2011
2012                         if (!strcmp(optarg, "curses")) {
2013                                 prox_cfg.ui = PROX_UI_CURSES;
2014                         }
2015                         else if (!strcmp(optarg, "cli")) {
2016                                 prox_cfg.ui = PROX_UI_CLI;
2017                         }
2018                         else if (!strcmp(optarg, "none")) {
2019                                 prox_cfg.ui = PROX_UI_NONE;
2020                         }
2021                         else {
2022                                 plog_err("Invalid local UI '%s', local UI can be 'curses', 'cli' or 'none'.", optarg);
2023                                 return -1;
2024                         }
2025                         break;
2026                 case 'q':
2027                         if (luaL_loadstring(prox_lua(), optarg)) {
2028                                 set_errf("Lua error: '%s'\n", lua_tostring(prox_lua(), -1));
2029                                 return -1;
2030                         }
2031
2032                         if (lua_pcall(prox_lua(), 0, LUA_MULTRET, 0)) {
2033                                 set_errf("Lua error: '%s'\n", lua_tostring(prox_lua(), -1));
2034                                 return -1;
2035                         }
2036
2037                         break;
2038                 case 'a':
2039                         /* autostart all cores */
2040                         prox_cfg.flags |= DSF_AUTOSTART;
2041                         break;
2042                 case 'e':
2043                         /* don't autostart */
2044                         prox_cfg.flags &= ~DSF_AUTOSTART;
2045                         break;
2046                 case 't':
2047                         prox_cfg.flags |= DSF_LISTEN_TCP;
2048                         break;
2049                 case 'u':
2050                         prox_cfg.flags |= DSF_LISTEN_UDS;
2051                         break;
2052                 case 'm':
2053                         /* list supported task modes and exit */
2054                         prox_cfg.flags |= DSF_LIST_TASK_MODES;
2055                         break;
2056                 case 's':
2057                         /* check configuration file syntax and exit */
2058                         prox_cfg.flags |= DSF_CHECK_SYNTAX;
2059                         break;
2060                 case 'i':
2061                         /* check initialization sequence and exit */
2062                         prox_cfg.flags |= DSF_CHECK_INIT;
2063                         break;
2064                 case 'w':
2065                         tmp = optarg;
2066                         tmp2 = 0;
2067                         if (strlen(tmp) >= 3 &&
2068                             (tmp2 = strchr(tmp, '='))) {
2069                                 *tmp2 = 0;
2070                                 tmp3[0] = '$';
2071                                 prox_strncpy(tmp3 + 1, tmp, 63);
2072                                 plog_info("\tAdding variable: %s = %s\n", tmp3, tmp2 + 1);
2073                                 ret = add_var(tmp3, tmp2 + 1, 1);
2074                                 if (ret == -2) {
2075                                         plog_err("\tFailed to add variable, too many variables defines\n");
2076                                         return -1;
2077                                 }
2078                                 else if(ret == -3) {
2079                                         plog_err("\tFailed to add variable, already defined\n");
2080                                         return -1;
2081                                 }
2082                                 break;
2083                         }
2084                         /* fall-through */
2085                 default:
2086                         plog_err("\tUnknown option\n");
2087                         return -1;
2088                 }
2089         }
2090
2091         /* reset getopt lib for DPDK */
2092         optind = 0;
2093
2094         return 0;
2095 }
2096
2097 static int check_cfg(void)
2098 {
2099         /* Sanity check */
2100 #define RETURN_IF(cond, err)                    \
2101         if (cond) {                             \
2102                 plog_err(err);                  \
2103                 return -1;                      \
2104         };
2105
2106         RETURN_IF(rte_cfg.force_nchannel == 0, "\tError: number of memory channels not specified in [eal options] section\n");
2107         RETURN_IF(prox_cfg.master >= RTE_MAX_LCORE, "\tError: No master core specified (one core needs to have mode=master)\n");
2108
2109 #undef RETURN_IF
2110
2111         return 0;
2112 }
2113
2114 static int calc_tot_rxrings(void)
2115 {
2116         struct lcore_cfg *slconf, *dlconf;
2117         struct task_args *starg, *dtarg;
2118         uint32_t dlcore_id;
2119         uint8_t dtask_id;
2120         struct core_task ct;
2121
2122         dlconf = NULL;
2123         while (core_targ_next_early(&dlconf, &dtarg, 1) == 0) {
2124                 dtarg->tot_rxrings = 0;
2125         }
2126
2127         slconf = NULL;
2128         while (core_targ_next_early(&slconf, &starg, 1) == 0) {
2129                 for (uint8_t idx = 0; idx < MAX_PROTOCOLS; ++idx) {
2130                         for (uint8_t ring_idx = 0; ring_idx < starg->core_task_set[idx].n_elems; ++ring_idx) {
2131                                 ct = starg->core_task_set[idx].core_task[ring_idx];
2132                                 if (!prox_core_active(ct.core, 0)) {
2133                                         set_errf("Core %u is disabled but Core %u task %u is sending to it\n",
2134                                                  ct.core, slconf->id, starg->id);
2135                                         return -1;
2136                                 }
2137
2138                                 dlconf = &lcore_cfg_init[ct.core];
2139
2140                                 if (ct.task >= dlconf->n_tasks_all) {
2141                                         set_errf("Core %u task %u not enabled\n", ct.core, ct.task);
2142                                         return -1;
2143                                 }
2144
2145                                 dtarg = &dlconf->targs[ct.task];
2146
2147                                 /* Control rings are not relevant at this point. */
2148                                 if (ct.type)
2149                                         continue;
2150
2151                                 if (!(dtarg->flags & TASK_ARG_RX_RING)) {
2152                                         set_errf("Core %u task %u is not expecting to receive through a ring\n",
2153                                                  ct.core, ct.task);
2154                                         return -1;
2155                                 }
2156
2157                                 dtarg->tot_rxrings++;
2158                                 if (dtarg->tot_rxrings > MAX_RINGS_PER_TASK) {
2159                                         set_errf("Core %u task %u is receiving from too many tasks",
2160                                                  ct.core, ct.task);
2161                                         return -1;
2162                                 }
2163                         }
2164                 }
2165         }
2166
2167         return 0;
2168 }
2169
2170 static void prox_set_core_mask(void)
2171 {
2172         struct lcore_cfg *lconf;
2173
2174         prox_core_clr();
2175         for (uint8_t lcore_id = 0; lcore_id < RTE_MAX_LCORE; ++lcore_id) {
2176                 lconf = &lcore_cfg_init[lcore_id];
2177                 if (lconf->n_tasks_all > 0 && lconf->targs[0].mode != MASTER) {
2178                         prox_core_set_active(lcore_id);
2179                 }
2180         }
2181 }
2182
2183 static int is_using_no_drop(void)
2184 {
2185         uint32_t lcore_id;
2186         struct lcore_cfg *lconf;
2187         struct task_args *targs;
2188
2189         lcore_id = -1;
2190         while(prox_core_next(&lcore_id, 1) == 0) {
2191                 lconf = &lcore_cfg_init[lcore_id];
2192                 for (uint8_t task_id = 0; task_id < lconf->n_tasks_all; ++task_id) {
2193                         targs = &lconf->targs[task_id];
2194                         if (!(targs->flags & TASK_ARG_DROP))
2195                                 return 1;
2196                 }
2197         }
2198         return 0;
2199 }
2200
2201 int prox_read_config_file(void)
2202 {
2203         set_global_defaults(&prox_cfg);
2204         set_task_defaults(&prox_cfg, lcore_cfg_init);
2205         set_port_defaults();
2206         plog_info("=== Parsing configuration file '%s' ===\n", cfg_file);
2207         struct cfg_file *pcfg = cfg_open(cfg_file);
2208         if (pcfg == NULL) {
2209                 return -1;
2210         }
2211
2212         struct cfg_section* config_sections[] = {
2213                 &lua_cfg          ,
2214                 &var_cfg          ,
2215                 &eal_default_cfg  ,
2216                 &cache_set_cfg    ,
2217                 &port_cfg         ,
2218                 &defaults_cfg     ,
2219                 &settings_cfg     ,
2220                 &core_cfg         ,
2221                 NULL
2222         };
2223
2224         for (struct cfg_section** section = config_sections; *section != NULL; ++section) {
2225                 const char* name = (*section)->name;
2226                 size_t len = strlen(name);
2227                 plog_info("\t*** Reading [%s] section%s ***\n", name, name[len - 1] == '#'? "s": "");
2228                 cfg_parse(pcfg, *section);
2229
2230                 if ((*section)->error) {
2231                         plog_err("At line %u, section [%s], entry %u: '%s'\n\t%s\n"
2232                                  , pcfg->err_line, pcfg->err_section, pcfg->err_entry + 1, pcfg->cur_line,
2233                                  strlen(get_parse_err())? get_parse_err() : err_str);
2234                         cfg_close(pcfg); /* cannot close before printing error, print uses internal buffer */
2235                         return -1;
2236                 }
2237         }
2238
2239         cfg_close(pcfg);
2240
2241         prox_set_core_mask();
2242
2243         if (is_using_no_drop()) {
2244                 prox_cfg.flags &= ~DSF_WAIT_ON_QUIT;
2245         }
2246
2247         if (calc_tot_rxrings()) {
2248                 plog_err("Error in configuration: %s\n", err_str);
2249                 return -1;
2250         }
2251
2252         return check_cfg();
2253 }
2254
2255 static void failed_rte_eal_init(__attribute__((unused))const char *prog_name)
2256 {
2257         plog_err("\tError in rte_eal_init()\n");
2258 }
2259
2260 int prox_setup_rte(const char *prog_name)
2261 {
2262         char *rte_argv[MAX_RTE_ARGV];
2263         char  rte_arg[MAX_RTE_ARGV][MAX_ARG_LEN];
2264         char tmp[PROX_CM_STR_LEN];
2265         /* create mask of used cores */
2266         plog_info("=== Setting up RTE EAL ===\n");
2267
2268         if (prox_cfg.flags & DSF_USE_DUMMY_CPU_TOPO) {
2269                 plog_info("Using dummy cpu topology\n");
2270                 snprintf(tmp, sizeof(tmp), "0x1");
2271         } else {
2272                 prox_core_to_hex(tmp, sizeof(tmp), 0);
2273                 plog_info("\tWorker threads core mask is %s\n", tmp);
2274                 prox_core_to_hex(tmp, sizeof(tmp), 1);
2275                 plog_info("\tWith master core index %u, full core mask is %s\n", prox_cfg.master, tmp);
2276         }
2277
2278         /* fake command line parameters for rte_eal_init() */
2279         int argc = 0;
2280         rte_argv[argc] = strdup(prog_name);
2281         sprintf(rte_arg[++argc], "-c%s", tmp);
2282         rte_argv[argc] = rte_arg[argc];
2283 #if RTE_VERSION >= RTE_VERSION_NUM(1,8,0,0)
2284         if (prox_cfg.flags & DSF_USE_DUMMY_CPU_TOPO)
2285                 sprintf(rte_arg[++argc], "--master-lcore=%u", 0);
2286         else
2287                 sprintf(rte_arg[++argc], "--master-lcore=%u", prox_cfg.master);
2288         rte_argv[argc] = rte_arg[argc];
2289 #else
2290         /* For old DPDK versions, the master core had to be the first
2291            core. */
2292         uint32_t first_core = -1;
2293
2294         if (prox_core_next(&first_core, 1) == -1) {
2295                 plog_err("Can't core ID of first core in use\n");
2296                 return -1;
2297         }
2298         if (first_core != prox_cfg.master) {
2299                 plog_err("The master core needs to be the first core (master core = %u, first core = %u).\n", first_core, prox_cfg.master);
2300                 return -1;
2301         }
2302 #endif
2303
2304         if (rte_cfg.memory) {
2305                 sprintf(rte_arg[++argc], "-m%u", rte_cfg.memory);
2306                 rte_argv[argc] = rte_arg[argc];
2307         }
2308
2309         if (rte_cfg.force_nchannel) {
2310                 sprintf(rte_arg[++argc], "-n%u", rte_cfg.force_nchannel);
2311                 rte_argv[argc] = rte_arg[argc];
2312         }
2313
2314         if (rte_cfg.force_nrank) {
2315                 sprintf(rte_arg[++argc], "-r%u", rte_cfg.force_nrank);
2316                 rte_argv[argc] = rte_arg[argc];
2317         }
2318
2319         if (rte_cfg.no_hugetlbfs) {
2320                 strcpy(rte_arg[++argc], "--no-huge");
2321                 rte_argv[argc] = rte_arg[argc];
2322         }
2323
2324         if (rte_cfg.no_pci) {
2325                 strcpy(rte_arg[++argc], "--no-pci");
2326                 rte_argv[argc] = rte_arg[argc];
2327         }
2328
2329         if (rte_cfg.no_hpet) {
2330                 strcpy(rte_arg[++argc], "--no-hpet");
2331                 rte_argv[argc] = rte_arg[argc];
2332         }
2333
2334         if (rte_cfg.no_shconf) {
2335                 strcpy(rte_arg[++argc], "--no-shconf");
2336                 rte_argv[argc] = rte_arg[argc];
2337         }
2338
2339         if (rte_cfg.eal != NULL) {
2340                 char *ptr = rte_cfg.eal;
2341                 char *ptr2;
2342                 while (ptr != NULL) {
2343                         while (isspace(*ptr))
2344                                 ptr++;
2345                         ptr2 = ptr;
2346                         ptr = strchr(ptr, ' ');
2347                         if (ptr) {
2348                                 *ptr++ = '\0';
2349                         }
2350                         prox_strncpy(rte_arg[++argc], ptr2, MAX_ARG_LEN);
2351                         rte_argv[argc] = rte_arg[argc];
2352                 }
2353         }
2354
2355         if (rte_cfg.hugedir != NULL) {
2356                 strcpy(rte_arg[++argc], "--huge-dir");
2357                 rte_argv[argc] = rte_arg[argc];
2358                 rte_argv[++argc] = rte_cfg.hugedir;
2359         }
2360
2361         if (rte_cfg.no_output) {
2362                 rte_log_set_global_level(0);
2363         }
2364         /* init EAL */
2365         plog_info("\tEAL command line:");
2366         if (argc >= MAX_RTE_ARGV) {
2367                 plog_err("too many arguments for EAL\n");
2368                 return -1;
2369         }
2370
2371         for (int h = 0; h <= argc; ++h) {
2372                 plog_info(" %s", rte_argv[h]);
2373         }
2374         plog_info("\n");
2375
2376         rte_set_application_usage_hook(failed_rte_eal_init);
2377         if (rte_eal_init(++argc, rte_argv) < 0) {
2378                 plog_err("\tError in rte_eal_init()\n");
2379                 return -1;
2380         }
2381         plog_info("\tEAL Initialized\n");
2382
2383         if (prox_cfg.flags & DSF_USE_DUMMY_CPU_TOPO)
2384                 return 0;
2385
2386         /* check if all active cores are in enabled in DPDK */
2387         for (uint32_t lcore_id = 0; lcore_id < RTE_MAX_LCORE; ++lcore_id) {
2388                 if (lcore_id == prox_cfg.master) {
2389                         if (!rte_lcore_is_enabled(lcore_id))
2390                                 return -1;
2391                 }
2392                 else if (rte_lcore_is_enabled(lcore_id) != prox_core_active(lcore_id, 0)) {
2393                         plog_err("\tFailed to enable lcore %u\n", lcore_id);
2394                         return -1;
2395                 }
2396                 else if (lcore_cfg_init[lcore_id].n_tasks_all != 0 && !rte_lcore_is_enabled(lcore_id)) {
2397                         plog_err("\tFailed to enable lcore %u\n", lcore_id);
2398                         return -1;
2399                 }
2400         }
2401         uint16_t port_id;
2402         for (int i = 0; i < n_deferred_ports; i++) {
2403                 if (prox_rte_eth_dev_get_port_by_name(deferred_port[i].name, &port_id) != 0) {
2404                         plog_err("Did not find port name %s used while reading %s\n", deferred_port[i].name, deferred_port[i].is_rx_port ? "rx port" : "tx_port");
2405                         return -1;
2406                 }
2407                 plog_info("\tport %s is port id %d\n", deferred_port[i].name, port_id);
2408                 if (deferred_port[i].is_rx_port) {
2409                         deferred_port[i].targ->rx_port_queue[0].port = port_id;
2410                         deferred_port[i].targ->nb_rxports = 1;
2411                 } else {
2412                         deferred_port[i].targ->tx_port_queue[0].port = port_id;
2413                         deferred_port[i].targ->nb_txports = 1;
2414                 }
2415         }
2416         return 0;
2417 }