Increase default mbuf size and code simplification/cleanup
[samplevnf.git] / VNFs / DPPD-PROX / prox_args.c
1 /*
2 // Copyright (c) 2010-2017 Intel Corporation
3 //
4 // Licensed under the Apache License, Version 2.0 (the "License");
5 // you may not use this file except in compliance with the License.
6 // You may obtain a copy of the License at
7 //
8 //     http://www.apache.org/licenses/LICENSE-2.0
9 //
10 // Unless required by applicable law or agreed to in writing, software
11 // distributed under the License is distributed on an "AS IS" BASIS,
12 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 // See the License for the specific language governing permissions and
14 // limitations under the License.
15 */
16
17 #include <unistd.h>
18 #include <string.h>
19
20 #include <rte_sched.h>
21 #include <rte_string_fns.h>
22 #include <rte_version.h>
23
24 #include "prox_malloc.h"
25 #include "version.h"
26 #include "defines.h"
27 #include "prox_args.h"
28 #include "prox_assert.h"
29 #include "prox_cfg.h"
30 #include "cfgfile.h"
31 #include "quit.h"
32 #include "log.h"
33 #include "parse_utils.h"
34 #include "prox_port_cfg.h"
35 #include "defaults.h"
36 #include "prox_lua.h"
37 #include "cqm.h"
38 #include "prox_compat.h"
39
40 #define MAX_RTE_ARGV 64
41 #define MAX_ARG_LEN  64
42
43 struct cfg_depr {
44         const char *opt;
45         const char *info;
46 };
47
48 /* Helper macro */
49 #define STR_EQ(s1, s2)  (!strcmp((s1), (s2)))
50
51 /* configuration files support */
52 static int get_rte_cfg(unsigned sindex, char *str, void *data);
53 static int get_global_cfg(unsigned sindex, char *str, void *data);
54 static int get_port_cfg(unsigned sindex, char *str, void *data);
55 static int get_defaults_cfg(unsigned sindex, char *str, void *data);
56 static int get_cache_set_cfg(unsigned sindex, char *str, void *data);
57 static int get_var_cfg(unsigned sindex, char *str, void *data);
58 static int get_lua_cfg(unsigned sindex, char *str, void *data);
59 static int get_core_cfg(unsigned sindex, char *str, void *data);
60
61 static const char *cfg_file = DEFAULT_CONFIG_FILE;
62 static struct rte_cfg    rte_cfg;
63 struct prox_cache_set_cfg  prox_cache_set_cfg[PROX_MAX_CACHE_SET];
64
65 static char format_err_str[1024];
66 static const char *err_str = "Unknown error";
67
68 static struct cfg_section eal_default_cfg = {
69         .name   = "eal options",
70         .parser = get_rte_cfg,
71         .data   = &rte_cfg,
72         .indexp[0]  = 0,
73         .nbindex = 1,
74         .error  = 0
75 };
76
77 static struct cfg_section port_cfg = {
78         .name   = "port #",
79         .parser = get_port_cfg,
80         .data   = &prox_port_cfg,
81         .indexp[0]  = 0,
82         .nbindex = 1,
83         .error  = 0
84 };
85
86 static struct cfg_section var_cfg = {
87         .name   = "variables",
88         .parser = get_var_cfg,
89         .data   = 0,
90         .indexp[0]  = 0,
91         .nbindex = 1,
92         .error  = 0
93 };
94
95 static struct cfg_section cache_set_cfg = {
96         .name   = "cache set #",
97         .parser = get_cache_set_cfg,
98         .data   = &prox_cache_set_cfg,
99         .indexp[0]  = 0,
100         .nbindex = 1,
101         .error  = 0
102 };
103
104 static struct cfg_section defaults_cfg = {
105         .name   = "defaults",
106         .parser = get_defaults_cfg,
107         .data   = 0,
108         .indexp[0]  = 0,
109         .nbindex = 1,
110         .error  = 0
111 };
112
113 static struct cfg_section settings_cfg = {
114         .name   = "global",
115         .parser = get_global_cfg,
116         .data   = &prox_cfg,
117         .indexp[0]  = 0,
118         .nbindex = 1,
119         .error  = 0
120 };
121
122 static struct cfg_section lua_cfg = {
123         .name = "lua",
124         .parser = get_lua_cfg,
125         .raw_lines = 1,
126         .indexp[0] = 0,
127         .nbindex = 1,
128         .error = 0,
129 };
130
131 static struct cfg_section core_cfg = {
132         .name   = "core #",
133         .parser = get_core_cfg,
134         .data   = lcore_cfg_init,
135         .indexp[0]  = 0,
136         .nbindex = 1,
137         .error  = 0
138 };
139
140 static void set_errf(const char *format, ...)
141 {
142         va_list ap;
143         va_start(ap, format);
144         vsnprintf(format_err_str, sizeof(format_err_str), format, ap);
145         va_end(ap);
146         err_str = format_err_str;
147 }
148
149 /* [eal options] parser */
150 static int get_rte_cfg(__attribute__((unused))unsigned sindex, char *str, void *data)
151 {
152         struct rte_cfg *pconfig = (struct rte_cfg *)data;
153
154         if (str == NULL || pconfig == NULL) {
155                 return -1;
156         }
157
158         char *pkey = get_cfg_key(str);
159         if (pkey == NULL) {
160                 set_errf("Missing key after option");
161                 return -1;
162         }
163
164         if (STR_EQ(str, "-m")) {
165                 return parse_int(&pconfig->memory, pkey);
166         }
167         if (STR_EQ(str, "-n")) {
168                 if (parse_int(&pconfig->force_nchannel, pkey)) {
169                         return -1;
170                 }
171                 if (pconfig->force_nchannel == 0) {
172                         set_errf("Invalid number of memory channels");
173                         return -1;
174                 }
175                 return 0;
176         }
177         if (STR_EQ(str, "-r")) {
178                 if (parse_int(&pconfig->force_nrank, pkey)) {
179                         return -1;
180                 }
181                 if (pconfig->force_nrank == 0 || pconfig->force_nrank > 16) {
182                         set_errf("Invalid number of memory ranks");
183                         return -1;
184                 }
185                 return 0;
186         }
187         /* debug options */
188         if (STR_EQ(str, "no-pci")) {
189                 return parse_bool(&pconfig->no_pci, pkey);
190         }
191         if (STR_EQ(str, "no-hpet")) {
192                 return parse_bool(&pconfig->no_hpet, pkey);
193         }
194         if (STR_EQ(str, "no-shconf")) {
195                 return parse_bool(&pconfig->no_shconf, pkey);
196         }
197         if (STR_EQ(str, "no-huge")) {
198                 return parse_bool(&pconfig->no_hugetlbfs, pkey);
199         }
200         if (STR_EQ(str, "no-output")) {
201                 return parse_bool(&pconfig->no_output, pkey);
202         }
203
204         if (STR_EQ(str, "huge-dir")) {
205                 if (pconfig->hugedir) {
206                         free(pconfig->hugedir);
207                 }
208                 pconfig->hugedir = strdup(pkey);
209                 return 0;
210         }
211
212         if (STR_EQ(str, "eal")) {
213                 char eal[MAX_STR_LEN_PROC];
214                 if (pconfig->eal) {
215                         free(pconfig->eal);
216                         pconfig->eal = NULL;
217                 }
218                 if (parse_str(eal, pkey, sizeof(eal)))
219                         return -1;
220                 pkey = eal;
221                 strip_spaces(&pkey, 1);
222                 if (*pkey)
223                         pconfig->eal = strdup(pkey);
224                 return 0;
225         }
226
227         set_errf("Option '%s' is not known", str);
228         return -1;
229 }
230
231 struct cfg_depr global_cfg_depr[] = {
232         {"virtualization", "This is now set automatically if needed"},
233         {"qinq_tag", "This option is deprecated"},
234         {"wait on quit", "This is now set automatically if needed"},
235         {"version", ""}
236 };
237
238 const char *get_cfg_dir(void)
239 {
240         static char dir[PATH_MAX];
241         size_t end = strlen(cfg_file) - 1;
242         while (end > 0 && cfg_file[end] != '/')
243                 end--;
244
245         strncpy(dir, cfg_file, end);
246         return dir;
247 }
248
249 static int get_lua_cfg(__attribute__((unused)) unsigned sindex, __attribute__((unused)) char *str, __attribute__((unused)) void *data)
250 {
251         int status;
252         char cwd[1024];
253         if (NULL == getcwd(cwd, sizeof(cwd))) {
254                 set_errf("Failed to get current directory while loading Lua file\n");
255                 return -1;
256         }
257         status = chdir(get_cfg_dir());
258         if (status) {
259                 set_errf("Failed to change directory to '%s' while loading Lua file\n", get_cfg_dir());
260                 return -1;
261         }
262
263         struct lua_State *l = prox_lua();
264
265         char str_cpy[1024];
266         strncpy(str_cpy, str, sizeof(str_cpy));
267         uint32_t len = strlen(str_cpy);
268         str_cpy[len++] = '\n';
269         str_cpy[len++] = 0;
270
271         status = luaL_loadstring(l, str_cpy);
272         if (status) {
273                 set_errf("Lua error: '%s'\n", lua_tostring(l, -1));
274                 status = chdir(cwd);
275                 return -1;
276         }
277
278         status = lua_pcall(l, 0, LUA_MULTRET, 0);
279         if (status) {
280                 set_errf("Lua error: '%s'\n", lua_tostring(l, -1));
281                 status = chdir(cwd);
282                 return -1;
283         }
284
285         status = chdir(cwd);
286         if (status) {
287                 set_errf("Failed to restore current directory to '%s' while loading Lua file\n", cwd);
288                 return -1;
289         }
290
291         return 0;
292 }
293
294 /* [global] parser */
295 static int get_global_cfg(__attribute__((unused))unsigned sindex, char *str, void *data)
296 {
297         struct prox_cfg *pset = (struct prox_cfg *)data;
298
299         if (str == NULL || pset == NULL) {
300                 return -1;
301         }
302
303         char *pkey = get_cfg_key(str);
304         if (pkey == NULL) {
305                 set_errf("Missing key after option");
306                 return -1;
307         }
308
309         for (uint32_t i = 0; i < RTE_DIM(global_cfg_depr); ++i) {
310                 if (STR_EQ(str, global_cfg_depr[i].opt)) {
311                         set_errf("Option '%s' is deprecated%s%s",
312                                  global_cfg_depr[i].opt, strlen(global_cfg_depr[i].info)? ": ": "", global_cfg_depr[i].info);
313                         return -1;
314                 }
315         }
316
317         if (STR_EQ(str, "name")) {
318                 return parse_str(pset->name, pkey, sizeof(pset->name));
319         }
320
321         if (STR_EQ(str, "start time")) {
322                 return parse_int(&pset->start_time, pkey);
323         }
324
325         if (STR_EQ(str, "duration time")) {
326                 return parse_int(&pset->duration_time, pkey);
327         }
328
329         if (STR_EQ(str, "shuffle")) {
330                 return parse_flag(&pset->flags, DSF_SHUFFLE, pkey);
331         }
332         if (STR_EQ(str, "disable cmt")) {
333                 return parse_flag(&pset->flags, DSF_DISABLE_CMT, pkey);
334         }
335         if (STR_EQ(str, "mp rings")) {
336                 return parse_flag(&pset->flags, DSF_MP_RINGS, pkey);
337         }
338         if (STR_EQ(str, "enable bypass")) {
339                 return parse_flag(&pset->flags, DSF_ENABLE_BYPASS, pkey);
340         }
341
342         if (STR_EQ(str, "cpe table map")) {
343                 /* The config defined ports through 0, 1, 2 ... which
344                    need to be associated with ports. This is done
345                    through defining it using "cpe table map=" */
346                 return parse_port_name_list((uint32_t*)pset->cpe_table_ports, NULL, PROX_MAX_PORTS, pkey);
347         }
348
349         if (STR_EQ(str, "pre cmd")) {
350                 return system(pkey);
351         }
352
353         if (STR_EQ(str, "unique mempool per socket")) {
354                 return parse_flag(&pset->flags, UNIQUE_MEMPOOL_PER_SOCKET, pkey);
355         }
356
357         if (STR_EQ(str, "log buffer size")) {
358                 if (parse_kmg(&pset->logbuf_size, pkey)) {
359                         return -1;
360                 }
361                 plog_info("Logging to buffer with size = %d\n", pset->logbuf_size);
362                 return 0;
363         }
364
365         set_errf("Option '%s' is not known", str);
366         return -1;
367 }
368
369 /* [variable] parser */
370 static int get_var_cfg(__attribute__((unused)) unsigned sindex, char *str, __attribute__((unused)) void *data)
371 {
372         return add_var(str, get_cfg_key(str), 0);
373 }
374
375 /* [defaults] parser */
376 static int get_defaults_cfg(__attribute__((unused)) unsigned sindex, char *str, __attribute__((unused)) void *data)
377 {
378         uint32_t val;
379         char *pkey;
380
381         pkey = get_cfg_key(str);
382         if (pkey == NULL) {
383                 set_errf("Missing key after option");
384                 return -1;
385         }
386
387         if (STR_EQ(str, "mempool size")) {
388
389                 if (parse_kmg(&val, pkey)) {
390                         return -1;
391                 }
392
393                 for (uint8_t lcore_id = 0; lcore_id < RTE_MAX_LCORE; ++lcore_id) {
394                         struct lcore_cfg *cur_lcore_cfg_init = &lcore_cfg_init[lcore_id];
395                         cur_lcore_cfg_init->id = lcore_id;
396                         for (uint8_t task_id = 0; task_id < MAX_TASKS_PER_CORE; ++task_id) {
397                                 struct task_args *targ = &cur_lcore_cfg_init->targs[task_id];
398                                 targ->nb_mbuf = val;
399                                 targ->id = task_id;
400                         }
401                 }
402                 return 0;
403         }
404
405         if (STR_EQ(str, "qinq tag")) {
406                 for (uint8_t lcore_id = 0; lcore_id < RTE_MAX_LCORE; ++lcore_id) {
407                         struct lcore_cfg *cur_lcore_cfg_init = &lcore_cfg_init[lcore_id];
408                         cur_lcore_cfg_init->id = lcore_id;
409                         for (uint8_t task_id = 0; task_id < MAX_TASKS_PER_CORE; ++task_id) {
410                                 struct task_args *targ = &cur_lcore_cfg_init->targs[task_id];
411                                 parse_int(&targ->qinq_tag, pkey);
412                         }
413                 }
414                 return 0;
415         }
416         if (STR_EQ(str, "memcache size")) {
417
418                 if (parse_kmg(&val, pkey)) {
419                         return -1;
420                 }
421
422                 for (uint8_t lcore_id = 0; lcore_id < RTE_MAX_LCORE; ++lcore_id) {
423                         struct lcore_cfg *cur_lcore_cfg_init = &lcore_cfg_init[lcore_id];
424                         cur_lcore_cfg_init->id = lcore_id;
425                         for (uint8_t task_id = 0; task_id < MAX_TASKS_PER_CORE; ++task_id) {
426                                 struct task_args *targ = &cur_lcore_cfg_init->targs[task_id];
427                                 targ->nb_cache_mbuf = val;
428                         }
429                 }
430                 return 0;
431         }
432
433         set_errf("Option '%s' is not known", str);
434         return -1;
435 }
436
437 /* [cache set] parser */
438 static int get_cache_set_cfg(unsigned sindex, char *str, void *data)
439 {
440         struct prox_cache_set_cfg *cfg = (struct prox_cache_set_cfg *)data;
441
442         uint8_t cur_if = sindex & ~CFG_INDEXED;
443
444         if (cur_if >= PROX_MAX_CACHE_SET) {
445                 set_errf("Cache set ID is too high (max allowed %d)", PROX_MAX_CACHE_SET - 1 );
446                 return -1;
447         }
448
449         cfg = &prox_cache_set_cfg[cur_if];
450
451         if (str == NULL || data == NULL) {
452                 return -1;
453         }
454
455         char *pkey = get_cfg_key(str);
456
457         if (pkey == NULL) {
458                 set_errf("Missing key after option");
459                 return -1;
460         }
461
462         if (STR_EQ(str, "mask")) {
463                 uint32_t val;
464                 int err = parse_int(&val, pkey);
465                 if (err) {
466                         return -1;
467                 }
468                 cfg->mask = val;
469                 cfg->socket_id = -1;
470                 plog_info("\tCache set %d has mask %x\n", cur_if, cfg->mask);
471                 return 0;
472         }
473         return 0;
474 }
475
476 /* [port] parser */
477 static int get_port_cfg(unsigned sindex, char *str, void *data)
478 {
479         struct prox_port_cfg *cfg = (struct prox_port_cfg *)data;
480
481         uint8_t cur_if = sindex & ~CFG_INDEXED;
482
483         if (cur_if >= PROX_MAX_PORTS) {
484                 set_errf("Port ID is too high (max allowed %d)", PROX_MAX_PORTS - 1 );
485                 return -1;
486         }
487
488         cfg = &prox_port_cfg[cur_if];
489
490         if (str == NULL || data == NULL) {
491                 return -1;
492         }
493
494         char *pkey = get_cfg_key(str);
495
496         if (pkey == NULL) {
497                 set_errf("Missing key after option");
498                 return -1;
499         }
500
501         if (STR_EQ(str, "mac")) {
502                 if (STR_EQ(pkey, "hardware")) {
503                         cfg->type = PROX_PORT_MAC_HW;
504                 }
505                 else if (STR_EQ(pkey, "random")) {
506                         cfg->type = PROX_PORT_MAC_RAND;
507                 }
508                 else {
509                         cfg->type = PROX_PORT_MAC_SET;
510                         if (parse_mac(&cfg->eth_addr, pkey)) {
511                                 return -1;
512                         }
513                 }
514         }
515         else if (STR_EQ(str, "name")) {
516                 uint32_t val;
517                 strncpy(cfg->name, pkey, MAX_NAME_SIZE);
518                 PROX_ASSERT(cur_if < PROX_MAX_PORTS);
519                 return add_port_name(cur_if, pkey);
520         }
521         else if (STR_EQ(str, "rx desc")) {
522                 return parse_int(&cfg->n_rxd, pkey);
523         }
524         else if (STR_EQ(str, "tx desc")) {
525                 return parse_int(&cfg->n_txd, pkey);
526         }
527         else if (STR_EQ(str, "promiscuous")) {
528                 uint32_t val;
529                 if (parse_bool(&val, pkey)) {
530                         return -1;
531                 }
532                 cfg->promiscuous = val;
533         }
534         else if (STR_EQ(str, "lsc")) {
535                 cfg->lsc_set_explicitely = 1;
536                 uint32_t val;
537                 if (parse_bool(&val, pkey)) {
538                         return -1;
539                 }
540                 cfg->lsc_val = val;
541         }
542         else if (STR_EQ(str, "strip crc")) {
543                 uint32_t val;
544                 if (parse_bool(&val, pkey)) {
545                         return -1;
546                 }
547                 cfg->port_conf.rxmode.hw_strip_crc = val;
548         }
549         else if (STR_EQ(str, "mtu size")) {
550                 uint32_t val;
551                 if (parse_int(&val, pkey)) {
552                         return -1;
553                 }
554                 if (val) {
555                         cfg->mtu = val;
556                         // A frame of 1526 bytes (1500 bytes mtu, 14 bytes hdr, 4 bytes crc and 8 bytes vlan)
557                         // should not be considered as a jumbo frame. However rte_ethdev.c considers that
558                         // the max_rx_pkt_len for a non jumbo frame is 1518
559                         cfg->port_conf.rxmode.max_rx_pkt_len = cfg->mtu + ETHER_HDR_LEN + ETHER_CRC_LEN;
560                         if (cfg->port_conf.rxmode.max_rx_pkt_len > ETHER_MAX_LEN) {
561                                 cfg->port_conf.rxmode.jumbo_frame = 1;
562                         }
563                 }
564         }
565
566         else if (STR_EQ(str, "rss")) {
567                 uint32_t val;
568                 if (parse_bool(&val, pkey)) {
569                         return -1;
570                 }
571                 if (val) {
572                         cfg->port_conf.rxmode.mq_mode = ETH_MQ_RX_RSS;
573                         cfg->port_conf.rx_adv_conf.rss_conf.rss_hf = ETH_RSS_IPV4;
574                 }
575         }
576         else if (STR_EQ(str, "rx_ring")) {
577                 parse_str(cfg->rx_ring, pkey, sizeof(cfg->rx_ring));
578         }
579         else if (STR_EQ(str, "tx_ring")) {
580                 parse_str(cfg->tx_ring, pkey, sizeof(cfg->tx_ring));
581         }
582
583         return 0;
584 }
585
586 static enum police_action str_to_color(const char *str)
587 {
588         if (STR_EQ(str, "green"))
589                 return ACT_GREEN;
590         if (STR_EQ(str, "yellow"))
591                 return ACT_YELLOW;
592         if (STR_EQ(str, "red"))
593                 return ACT_RED;
594         if (STR_EQ(str, "drop"))
595                 return ACT_DROP;
596         return ACT_INVALID;
597 }
598
599 struct cfg_depr task_cfg_depr[] = {
600         {"sig", ""},
601 };
602
603 struct cfg_depr core_cfg_depr[] = {
604         {"do sig", ""},
605         {"lat", ""},
606         {"network side", ""},
607 };
608
609 /* [core] parser */
610 static int get_core_cfg(unsigned sindex, char *str, void *data)
611 {
612         char *pkey;
613         struct lcore_cfg *lconf = (struct lcore_cfg *)data;
614
615         if (str == NULL || lconf == NULL || !(sindex & CFG_INDEXED)) {
616                 return -1;
617         }
618
619         pkey = get_cfg_key(str);
620         if (pkey == NULL) {
621                 set_errf("Missing key after option");
622                 return -1;
623         }
624
625         uint32_t ncore = sindex & ~CFG_INDEXED;
626         if (ncore >= RTE_MAX_LCORE) {
627                 set_errf("Core index too high (max allowed %d)", RTE_MAX_LCORE - 1);
628                 return -1;
629         }
630
631         lconf = &lconf[ncore];
632
633         for (uint32_t i = 0; i < RTE_DIM(core_cfg_depr); ++i) {
634                 if (STR_EQ(str, core_cfg_depr[i].opt)) {
635                         set_errf("Option '%s' is deprecated%s%s",
636                                  core_cfg_depr[i].opt, strlen(core_cfg_depr[i].info)? ": ": "", core_cfg_depr[i].info);
637                         return -1;
638                 }
639         }
640
641         char buff[128];
642         lcore_to_socket_core_ht(ncore, buff, sizeof(buff));
643         set_self_var(buff);
644         if (STR_EQ(str, "task")) {
645
646                 uint32_t val;
647                 if (parse_int(&val, pkey)) {
648                         return -1;
649                 }
650                 if (val >= MAX_TASKS_PER_CORE) {
651                         set_errf("Too many tasks for core (max allowed %d)", MAX_TASKS_PER_CORE - 1);
652                         return -1;
653                 }
654                 if (val != lconf->n_tasks_all) {
655                         set_errf("Task ID skipped or defined twice");
656                         return -1;
657                 }
658
659                 lconf->active_task = val;
660
661                 lconf->targs[lconf->active_task].task = lconf->active_task;
662
663                 if (lconf->n_tasks_all < lconf->active_task + 1) {
664                         lconf->n_tasks_all = lconf->active_task + 1;
665                 }
666                 return 0;
667         }
668
669         struct task_args *targ = &lconf->targs[lconf->active_task];
670         if (STR_EQ(str, "tx ports from routing table")) {
671                 uint32_t vals[PROX_MAX_PORTS];
672                 uint32_t n_if;
673                 if (!(targ->task_init->flag_features & TASK_FEATURE_ROUTING)) {
674                         set_errf("tx port form route not supported mode %s",  targ->task_init->mode_str);
675                         return -1;
676                 }
677
678                 if (parse_port_name_list(vals, &n_if, PROX_MAX_PORTS, pkey)) {
679                         return -1;
680                 }
681
682                 for (uint8_t i = 0; i < n_if; ++i) {
683                         targ->tx_port_queue[i].port = vals[i];
684                         targ->nb_txports++;
685                 }
686                 targ->runtime_flags |= TASK_ROUTING;
687                 return 0;
688         }
689         if (STR_EQ(str, "tx ports from cpe table")) {
690                 uint32_t vals[PROX_MAX_PORTS];
691                 int n_remap = -1;
692                 uint32_t ret;
693                 uint32_t val;
694                 char* mapping_str = strstr(pkey, " remap=");
695
696                 if (mapping_str != NULL) {
697                         *mapping_str = 0;
698                         mapping_str += strlen(" remap=");
699                         n_remap = parse_remap(targ->mapping, mapping_str);
700                 }
701
702                 if (parse_port_name_list(vals, &ret, PROX_MAX_PORTS, pkey)) {
703                         return -1;
704                 }
705
706                 if (n_remap != -1 && ret != (uint32_t)n_remap) {
707                         set_errf("Expected %d remap elements but had %d", n_remap, ret);
708                         return -1;
709                 }
710
711                 for (uint8_t i = 0; i < ret; ++i) {
712                         targ->tx_port_queue[i].port = vals[i];
713
714                         /* default mapping this case is port0 -> port0 */
715                         if (n_remap == -1) {
716                                 targ->mapping[vals[i]] = i;
717                         }
718                 }
719
720                 targ->nb_txports = ret;
721
722                 return 0;
723         }
724         if (STR_EQ(str, "tx cores from routing table")) {
725                 if (!(targ->task_init->flag_features & TASK_FEATURE_ROUTING)) {
726                         set_errf("tx port form route not supported mode %s",  targ->task_init->mode_str);
727                         return -1;
728                 }
729
730                 struct core_task_set *cts = &targ->core_task_set[0];
731
732                 if (parse_task_set(cts, pkey))
733                         return -1;
734
735                 if (cts->n_elems > MAX_WT_PER_LB) {
736                         set_errf("Maximum worker threads allowed is %u but have %u", MAX_WT_PER_LB, cts->n_elems);
737                         return -1;
738                 }
739
740                 targ->nb_worker_threads = cts->n_elems;
741                 targ->nb_txrings = cts->n_elems;
742
743                 if (targ->nb_txrings > MAX_RINGS_PER_TASK) {
744                         set_errf("Maximum allowed TX rings is %u but have %u", MAX_RINGS_PER_TASK, targ->nb_txrings);
745                         return -1;
746                 }
747
748                 targ->runtime_flags |= TASK_ROUTING;
749                 return 0;
750         }
751         if (STR_EQ(str, "tx cores from cpe table")) {
752                 struct core_task_set *core_task_set =  &targ->core_task_set[0];
753                 int ret, ret2;
754                 char *mapping_str;
755
756                 mapping_str = strstr(pkey, " remap=");
757                 if (mapping_str == NULL) {
758                         set_errf("There is no default mapping for tx cores from cpe table. Please specify it through remap=");
759                         return -1;
760                 }
761                 *mapping_str = 0;
762                 mapping_str += strlen(" remap=");
763                 ret = parse_remap(targ->mapping, mapping_str);
764                 if (ret <= 0) {
765                         return -1;
766                 }
767
768                 struct core_task_set *cts = &targ->core_task_set[0];
769
770                 if (parse_task_set(cts, pkey))
771                         return -1;
772                 if (cts->n_elems > MAX_RINGS_PER_TASK) {
773                         set_errf("Maximum cores to route to is %u\n", MAX_RINGS_PER_TASK);
774                         return -1;
775                 }
776
777                 targ->nb_txrings = cts->n_elems;
778
779                 if (ret != targ->nb_txrings) {
780                         set_errf("Expecting same number of remaps as cores\n", str);
781                         return -1;
782                 }
783                 return 0;
784         }
785
786         if (STR_EQ(str, "delay ms")) {
787                 if (targ->delay_us) {
788                         set_errf("delay ms and delay us are mutually exclusive\n", str);
789                         return -1;
790                 }
791                 uint32_t delay_ms;
792                 int rc = parse_int(&delay_ms, pkey);
793                 targ->delay_us = delay_ms * 1000;
794                 return rc;
795         }
796         if (STR_EQ(str, "delay us")) {
797                 if (targ->delay_us) {
798                         set_errf("delay ms and delay us are mutually exclusive\n", str);
799                         return -1;
800                 }
801                 return parse_int(&targ->delay_us, pkey);
802         }
803         if (STR_EQ(str, "random delay us")) {
804                 return parse_int(&targ->random_delay_us, pkey);
805         }
806         if (STR_EQ(str, "cpe table timeout ms")) {
807                 return parse_int(&targ->cpe_table_timeout_ms, pkey);
808         }
809         if (STR_EQ(str, "ctrl path polling frequency")) {
810                 int rc = parse_int(&targ->ctrl_freq, pkey);
811                 if (rc == 0) {
812                         if (targ->ctrl_freq == 0) {
813                                 set_errf("ctrl frequency must be non null.");
814                                 return -1;
815                         }
816                 }
817                 return rc;
818         }
819
820         if (STR_EQ(str, "handle arp")) {
821                 return parse_flag(&targ->runtime_flags, TASK_CTRL_HANDLE_ARP, pkey);
822         }
823         if (STR_EQ(str, "fast path handle arp")) {
824                 return parse_flag(&targ->runtime_flags, TASK_FP_HANDLE_ARP, pkey);
825         }
826         if (STR_EQ(str, "multiple arp")) {
827                 return parse_flag(&targ->flags, TASK_MULTIPLE_MAC, pkey);
828         }
829
830         /* Using tx port name, only a _single_ port can be assigned to a task. */
831         if (STR_EQ(str, "tx port")) {
832                 if (targ->nb_txports > 0) {
833                         set_errf("Only one tx port can be defined per task. Use a LB task or routing instead.");
834                         return -1;
835                 }
836
837                 uint32_t n_if = 0;
838                 uint32_t ports[PROX_MAX_PORTS];
839
840                 if(parse_port_name_list(ports, &n_if, PROX_MAX_PORTS, pkey)) {
841                         return -1;
842                 }
843
844                 PROX_ASSERT(n_if-1 < PROX_MAX_PORTS);
845
846                 for (uint8_t i = 0; i < n_if; ++i) {
847                         targ->tx_port_queue[i].port = ports[i];
848                         targ->nb_txports++;
849                 }
850
851                 if (n_if > 1) {
852                         targ->nb_worker_threads = targ->nb_txports;
853                 }
854
855                 return 0;
856         }
857         if (STR_EQ(str, "rx ring")) {
858                 uint32_t val;
859                 int err = parse_bool(&val, pkey);
860                 if (!err && val && targ->rx_port_queue[0].port != OUT_DISCARD) {
861                         set_errf("Can't read both from internal ring and external port from the same task. Use multiple tasks instead.");
862                         return -1;
863                 }
864
865                 return parse_flag(&targ->flags, TASK_ARG_RX_RING, pkey);
866         }
867         if (STR_EQ(str, "private")) {
868                 return parse_bool(&targ->use_src, pkey);
869         }
870         if (STR_EQ(str, "use src ip")) {
871                 return parse_bool(&targ->use_src, pkey);
872         }
873         if (STR_EQ(str, "nat table")) {
874                 return parse_str(targ->nat_table, pkey, sizeof(targ->nat_table));
875         }
876         if (STR_EQ(str, "rules")) {
877                 return parse_str(targ->rules, pkey, sizeof(targ->rules));
878         }
879         if (STR_EQ(str, "route table")) {
880                 return parse_str(targ->route_table, pkey, sizeof(targ->route_table));
881         }
882         if (STR_EQ(str, "dscp")) {
883                 return parse_str(targ->dscp, pkey, sizeof(targ->dscp));
884         }
885         if (STR_EQ(str, "tun_bindings")) {
886                 return parse_str(targ->tun_bindings, pkey, sizeof(targ->tun_bindings));
887         }
888         if (STR_EQ(str, "cpe table")) {
889                 return parse_str(targ->cpe_table_name, pkey, sizeof(targ->cpe_table_name));
890         }
891         if (STR_EQ(str, "user table")) {
892                 return parse_str(targ->user_table, pkey, sizeof(targ->user_table));
893         }
894         if (STR_EQ(str, "streams")) {
895                 return parse_str(targ->streams, pkey, sizeof(targ->streams));
896         }
897         if (STR_EQ(str, "local lpm")) {
898                 return parse_flag(&targ->flags, TASK_ARG_LOCAL_LPM, pkey);
899         }
900         if (STR_EQ(str, "drop")) {
901                 return parse_flag(&targ->flags, TASK_ARG_DROP, pkey);
902         }
903         if (STR_EQ(str, "loop")) {
904                 parse_flag(&targ->loop, 1, pkey);
905                 return parse_flag(&targ->loop, 1, pkey);
906         }
907         if (STR_EQ(str, "qinq")) {
908                 return parse_flag(&targ->flags, TASK_ARG_QINQ_ACL, pkey);
909         }
910         if (STR_EQ(str, "bps")) {
911                 return parse_u64(&targ->rate_bps, pkey);
912         }
913         if (STR_EQ(str, "random")) {
914                 return parse_str(targ->rand_str[targ->n_rand_str++], pkey, sizeof(targ->rand_str[0]));
915         }
916         if (STR_EQ(str, "rand_offset")) {
917                 if (targ->n_rand_str == 0) {
918                         set_errf("No random defined previously (use random=...)");
919                         return -1;
920                 }
921
922                 return parse_int(&targ->rand_offset[targ->n_rand_str - 1], pkey);
923         }
924         if (STR_EQ(str, "keep src mac")) {
925                 return parse_flag(&targ->flags, DSF_KEEP_SRC_MAC, pkey);
926         }
927         if (STR_EQ(str, "pcap file")) {
928                 return parse_str(targ->pcap_file, pkey, sizeof(targ->pcap_file));
929         }
930         if (STR_EQ(str, "pkt inline")) {
931                 char pkey2[MAX_CFG_STRING_LEN];
932                 if (parse_str(pkey2, pkey, sizeof(pkey2)) != 0) {
933                         set_errf("Error while parsing pkt line, too long\n");
934                         return -1;
935                 }
936
937                 const size_t pkey_len = strlen(pkey2);
938                 targ->pkt_size = 0;
939
940                 for (size_t i = 0; i < pkey_len; ++i) {
941                         if (pkey2[i] == ' ')
942                                 continue;
943
944                         if (i + 1 == pkey_len) {
945                                 set_errf("Incomplete byte at character %z", i);
946                                 return -1;
947                         }
948
949                         uint8_t byte = 0;
950
951                         if (pkey2[i] >= '0' && pkey2[i] <= '9') {
952                                 byte = (pkey2[i] - '0') << 4;
953                         }
954                         else if (pkey2[i] >= 'a' && pkey2[i] <= 'f') {
955                                 byte = (pkey2[i] - 'a' + 10) << 4;
956                         }
957                         else if (pkey2[i] >= 'A' && pkey2[i] <= 'F') {
958                                 byte = (pkey2[i] - 'A' + 10) << 4;
959                         }
960                         else {
961                                 set_errf("Invalid character in pkt inline at byte %d (%c)", i, pkey2[i]);
962                                 return -1;
963                         }
964
965                         if (pkey2[i + 1] >= '0' && pkey2[i + 1] <= '9') {
966                                 byte |= (pkey2[i + 1] - '0');
967                         }
968                         else if (pkey2[i + 1] >= 'a' && pkey2[i + 1] <= 'f') {
969                                 byte |= (pkey2[i + 1] - 'a' + 10);
970                         }
971                         else if (pkey2[i + 1] >= 'A' && pkey2[i + 1] <= 'F') {
972                                 byte |= (pkey2[i + 1] - 'A' + 10);
973                         }
974                         else {
975                                 set_errf("Invalid character in pkt inline at byte %d (%c)", i, pkey2[i + 1]);
976                                 return -1;
977                         }
978                         if (targ->pkt_size == sizeof(targ->pkt_inline)) {
979                                 set_errf("Inline packet definition can't be longer than %u", sizeof(targ->pkt_inline));
980                                 return -1;
981                         }
982
983                         targ->pkt_inline[targ->pkt_size++] = byte;
984                         i += 1;
985                 }
986
987                 return 0;
988         }
989         if (STR_EQ(str, "accuracy limit nsec")) {
990                 return parse_int(&targ->accuracy_limit_nsec, pkey);
991         }
992         if (STR_EQ(str, "latency bucket size")) {
993                 return parse_int(&targ->bucket_size, pkey);
994         }
995         if (STR_EQ(str, "latency buffer size")) {
996                 return parse_int(&targ->latency_buffer_size, pkey);
997         }
998         if (STR_EQ(str, "accuracy pos")) {
999                 return parse_int(&targ->accur_pos, pkey);
1000         }
1001         if (STR_EQ(str, "signature")) {
1002                 return parse_int(&targ->sig, pkey);
1003         }
1004         if (STR_EQ(str, "signature pos")) {
1005                 return parse_int(&targ->sig_pos, pkey);
1006         }
1007         if (STR_EQ(str, "lat pos")) {
1008                 targ->lat_enabled = 1;
1009                 return parse_int(&targ->lat_pos, pkey);
1010         }
1011         if (STR_EQ(str, "packet id pos")) {
1012                 return parse_int(&targ->packet_id_pos, pkey);
1013         }
1014         if (STR_EQ(str, "probability")) {
1015                 float probability;
1016                 int rc = parse_float(&probability, pkey);
1017                 if (probability == 0) {
1018                         set_errf("Probability must be != 0\n");
1019                         return -1;
1020                 } else if (probability > 100.0) {
1021                         set_errf("Probability must be < 100\n");
1022                         return -1;
1023                 }
1024                 targ->probability = probability * 10000;
1025                 return rc;
1026         }
1027         if (STR_EQ(str, "concur conn")) {
1028                 return parse_int(&targ->n_concur_conn, pkey);
1029         }
1030         if (STR_EQ(str, "max setup rate")) {
1031                 return parse_int(&targ->max_setup_rate, pkey);
1032         }
1033         if (STR_EQ(str, "pkt size")) {
1034                 return parse_int(&targ->pkt_size, pkey);
1035         }
1036         if (STR_EQ(str, "min bulk size")) {
1037                 return parse_int(&targ->min_bulk_size, pkey);
1038         }
1039         if (STR_EQ(str, "max bulk size")) {
1040                 return parse_int(&targ->max_bulk_size, pkey);
1041         }
1042         if (STR_EQ(str, "rx port")) {
1043                 if (targ->flags & TASK_ARG_RX_RING) {
1044                         set_errf("Can't read both from internal ring and external port from the same task. Use multiple tasks instead.");
1045                         return -1;
1046                 }
1047                 uint32_t vals[PROX_MAX_PORTS];
1048                 uint32_t n_if;
1049
1050                 if (parse_port_name_list(vals, &n_if, PROX_MAX_PORTS, pkey)) {
1051                         return -1;
1052                 }
1053
1054                 for (uint8_t i = 0; i < n_if; ++i) {
1055                         PROX_ASSERT(vals[i] < PROX_MAX_PORTS);
1056                         targ->rx_port_queue[i].port = vals[i];
1057                         targ->nb_rxports++;
1058                 }
1059                 return 0;
1060         }
1061
1062         if (STR_EQ(str, "mode")) {
1063                 /* Check deprecated task modes */
1064                 char mode[255];
1065                 int ret = parse_str(mode, pkey, sizeof(mode));
1066                 if (ret)
1067                         return ret;
1068
1069                 for (uint32_t i = 0; i < RTE_DIM(task_cfg_depr); ++i) {
1070                         if (STR_EQ(mode, task_cfg_depr[i].opt)) {
1071                                 set_errf("Task mode '%s' is deprecated%s%s",
1072                                          task_cfg_depr[i].opt, strlen(task_cfg_depr[i].info)? ": ": "", task_cfg_depr[i].info);
1073                                 return -1;
1074                         }
1075                 }
1076
1077                 /* master is a special mode that is always needed (cannot be turned off) */
1078                 if (STR_EQ(mode, "master")) {
1079                         prox_cfg.master = ncore;
1080                         targ->mode = MASTER;
1081                         if (lconf->n_tasks_all > 1 || targ->task != 0) {
1082                                 set_errf("Master core can only have one task\n");
1083                                 return -1;
1084                         }
1085                         // Initialize number of tasks to 1 for master, even if no task specified
1086                         lconf->n_tasks_all = 1;
1087                         lconf->active_task = 0;
1088                         lconf->targs[lconf->active_task].task = 0;
1089                         struct task_init* task_init = to_task_init(mode, "");
1090                         if (task_init) {
1091                                 targ->mode = task_init->mode;
1092                         }
1093                         targ->task_init = task_init;
1094                         return 0;
1095                 }
1096
1097                 struct task_init* task_init = to_task_init(mode, "");
1098                 if (task_init) {
1099                         targ->mode = task_init->mode;
1100                 }
1101                 else {
1102                         set_errf("Task mode '%s' is invalid", mode);
1103                         tasks_list();
1104                         return -1;
1105                 }
1106                 targ->task_init = task_init;
1107                 return 0;
1108         }
1109         if (STR_EQ(str, "users")) {
1110                 return parse_int(&targ->n_flows, pkey);
1111         }
1112
1113         if (STR_EQ(str, "mark")) {
1114                 return parse_flag(&targ->runtime_flags, TASK_MARK, pkey);
1115         }
1116
1117         if (STR_EQ(str, "mark green")) {
1118                 return parse_int(&targ->marking[0], pkey);
1119         }
1120
1121         if (STR_EQ(str, "mark yellow")) {
1122                 return parse_int(&targ->marking[1], pkey);
1123         }
1124
1125         if (STR_EQ(str, "mark red")) {
1126                 return parse_int(&targ->marking[2], pkey);
1127         }
1128
1129         if (STR_EQ(str, "tx cores")) {
1130                 uint8_t dest_task = 0;
1131                 /* if user did not specify, dest_port is left at default (first type) */
1132                 uint8_t dest_proto = 0;
1133                 uint8_t ctrl = CTRL_TYPE_DP;
1134                 char *task_str = strstr(pkey, "proto=");
1135                 if (task_str) {
1136                         task_str += strlen("proto=");
1137
1138                         if (STR_EQ(task_str, "ipv4")) {
1139                                 dest_proto = IPV4;
1140                         }
1141                         else if (STR_EQ(task_str, "arp")) {
1142                                 dest_proto = ARP;
1143                         }
1144                         else if (STR_EQ(task_str, "ipv6")) {
1145                                 dest_proto = IPV6;
1146                         }
1147                         else {
1148                                 set_errf("proto needs to be either ipv4, arp or ipv6");
1149                                 return -1;
1150                         }
1151
1152                 }
1153
1154                 task_str = strstr(pkey, "task=");
1155
1156                 if (task_str) {
1157                         --task_str;
1158                         *task_str = 0;
1159                         task_str++;
1160                         task_str += strlen("task=");
1161                         char *task_str_end = strstr(task_str, " ");
1162                         if (task_str_end) {
1163                                 *task_str_end = 0;
1164                         }
1165                         if (0 == strlen(task_str)) {
1166                                 set_errf("Invalid task= syntax");
1167                                 return -1;
1168                         }
1169
1170                         switch (task_str[strlen(task_str) - 1]) {
1171                         case 'p':
1172                                 ctrl = CTRL_TYPE_PKT;
1173                                 break;
1174                         case 'm':
1175                                 ctrl = CTRL_TYPE_MSG;
1176                                 break;
1177                         case '\n':
1178                         case 0:
1179                                 break;
1180                         default:
1181                                 if (task_str[strlen(task_str) -1] < '0' ||
1182                                     task_str[strlen(task_str) -1] > '9') {
1183                                         set_errf("Unknown ring type %c.\n",
1184                                                  task_str[strlen(task_str) - 1]);
1185                                         return -1;
1186                                 }
1187                         }
1188
1189                         dest_task = atoi(task_str);
1190                         if (dest_task >= MAX_TASKS_PER_CORE) {
1191                                 set_errf("Destination task too high (max allowed %d)", MAX_TASKS_PER_CORE - 1);
1192                                 return -1;
1193                         }
1194                 }
1195                 else {
1196                         dest_task = 0;
1197                 }
1198
1199                 struct core_task_set *cts = &targ->core_task_set[dest_proto];
1200
1201                 if (parse_task_set(cts, pkey))
1202                         return -1;
1203
1204                 if (cts->n_elems > MAX_WT_PER_LB) {
1205                         set_errf("Too many worker threads (max allowed %d)", MAX_WT_PER_LB - 1);
1206                         return -1;
1207                 }
1208
1209                 targ->nb_worker_threads = cts->n_elems;
1210                 targ->nb_txrings += cts->n_elems;
1211
1212                 return 0;
1213         }
1214         if (STR_EQ(str, "tx crc")) {
1215                 return parse_flag(&targ->runtime_flags, TASK_TX_CRC, pkey);
1216         }
1217         if (STR_EQ(str, "ring size")) {
1218                 return parse_int(&targ->ring_size, pkey);
1219         }
1220         if (STR_EQ(str, "mempool size")) {
1221                 return parse_kmg(&targ->nb_mbuf, pkey);
1222         }
1223
1224         else if (STR_EQ(str, "mbuf size")) {
1225                 return parse_int(&targ->mbuf_size, pkey);
1226         }
1227         if (STR_EQ(str, "memcache size")) {
1228                 return parse_kmg(&targ->nb_cache_mbuf, pkey);
1229         }
1230
1231         if (STR_EQ(str, "byte offset")) {
1232                 return parse_int(&targ->byte_offset, pkey);
1233         }
1234
1235         if (STR_EQ(str, "name")) {
1236                 return parse_str(lconf->name, pkey, sizeof(lconf->name));
1237         }
1238         /* MPLS configuration */
1239         if (STR_EQ(str, "untag mpls")) {
1240                 return parse_flag(&targ->runtime_flags, TASK_MPLS_TAGGING, pkey);
1241         }
1242
1243         if (STR_EQ(str, "add mpls")) {
1244                 return parse_flag(&targ->runtime_flags, TASK_MPLS_TAGGING, pkey);
1245         }
1246
1247         if (STR_EQ(str, "ether type")) {
1248                 return parse_int(&targ->etype, pkey);
1249         }
1250
1251         if (STR_EQ(str, "cache set")) {
1252                 return parse_int(&lconf->cache_set, pkey);
1253         }
1254
1255         if (STR_EQ(str, "sub mode")) {
1256                 const char* mode_str = targ->task_init->mode_str;
1257                 const char *sub_mode_str = pkey;
1258
1259                 targ->task_init = to_task_init(mode_str, sub_mode_str);
1260                 if (!targ->task_init) {
1261                         if (strcmp(sub_mode_str, "l3") != 0) {
1262                                 set_errf("sub mode %s not supported for mode %s", sub_mode_str, mode_str);
1263                                 return -1;
1264                         }
1265                         targ->task_init = to_task_init(mode_str, "");
1266                         if (!targ->task_init) {
1267                                 set_errf("sub mode %s not supported for mode %s", sub_mode_str, mode_str);
1268                                 return -1;
1269                         }
1270                 }
1271                 if (strcmp(sub_mode_str, "l3") == 0) {
1272                         prox_cfg.flags |= DSF_CTRL_PLANE_ENABLED;
1273                         targ->flags |= TASK_ARG_L3;
1274                         strcpy(targ->sub_mode_str, "l3");
1275                 } else {
1276                         strcpy(targ->sub_mode_str, targ->task_init->sub_mode_str);
1277                 }
1278                 return 0;
1279         }
1280
1281         if (STR_EQ(str, "mempool name")) {
1282                 return parse_str(targ->pool_name, pkey, sizeof(targ->pool_name));
1283         }
1284         if (STR_EQ(str, "dpi engine")) {
1285                 return parse_str(targ->dpi_engine_path, pkey, sizeof(targ->dpi_engine_path));
1286         }
1287         if (STR_EQ(str, "dpi engine arg")) {
1288                 return parse_str(targ->dpi_engine_args[targ->n_dpi_engine_args++], pkey,
1289                                  sizeof(targ->dpi_engine_args[0]));
1290         }
1291         if (STR_EQ(str, "dst mac")) { /* destination MAC address to be used for packets */
1292                 if (parse_mac(&targ->edaddr, pkey)) {
1293                         if (STR_EQ(pkey, "no")) {
1294                                 targ->flags |= TASK_ARG_DO_NOT_SET_DST_MAC;
1295                                 return 0;
1296                         }
1297                         if (STR_EQ(pkey, "packet") == 0)
1298                                 return -1;
1299                         else
1300                                 return 0;
1301                 }
1302                 targ->flags |= TASK_ARG_DST_MAC_SET;
1303                 return 0;
1304         }
1305         if (STR_EQ(str, "src mac")) {
1306                 if (parse_mac(&targ->esaddr, pkey)) {
1307                         if (STR_EQ(pkey, "no")) {
1308                                 targ->flags |= TASK_ARG_DO_NOT_SET_SRC_MAC;
1309                                 return 0;
1310                         }
1311                         else if (STR_EQ(pkey, "packet"))
1312                                 return 0;
1313                         else if (STR_EQ(pkey, "hw")) {
1314                                 targ->flags |= TASK_ARG_HW_SRC_MAC;
1315                                 return 0;
1316                         } else {
1317                                 return -1;
1318                         }
1319                 }
1320                 targ->flags |= TASK_ARG_SRC_MAC_SET;
1321                 return 0;
1322         }
1323         if (STR_EQ(str, "gateway ipv4")) { /* Gateway IP address used when generating */
1324                 return parse_ip(&targ->gateway_ipv4, pkey);
1325         }
1326         if (STR_EQ(str, "local ipv4")) { /* source IP address to be used for packets */
1327                 return parse_ip(&targ->local_ipv4, pkey);
1328         }
1329         if (STR_EQ(str, "remote ipv4")) { /* source IP address to be used for packets */
1330                 return parse_ip(&targ->remote_ipv4, pkey);
1331         }
1332         if (STR_EQ(str, "local ipv6")) { /* source IPv6 address to be used for packets */
1333                 return parse_ip6(&targ->local_ipv6, pkey);
1334         }
1335         if (STR_EQ(str, "number of packets"))
1336                 return parse_int(&targ->n_pkts, pkey);
1337         if (STR_EQ(str, "pipes")) {
1338                 uint32_t val;
1339                 int err = parse_int(&val, pkey);
1340                 if (err)
1341                         return -1;
1342                 if (!val || !rte_is_power_of_2(val)) {
1343                         set_errf("Number of pipes has to be power of 2 and not zero");
1344                         return -1;
1345                 }
1346
1347                 targ->qos_conf.port_params.n_pipes_per_subport = val;
1348                 return 0;
1349         }
1350         if (STR_EQ(str, "queue size")) {
1351                 uint32_t val;
1352                 int err = parse_int(&val, pkey);
1353                 if (err) {
1354                         return -1;
1355                 }
1356
1357                 targ->qos_conf.port_params.qsize[0] = val;
1358                 targ->qos_conf.port_params.qsize[1] = val;
1359                 targ->qos_conf.port_params.qsize[2] = val;
1360                 targ->qos_conf.port_params.qsize[3] = val;
1361                 return 0;
1362         }
1363         if (STR_EQ(str, "subport tb rate")) {
1364                 return parse_int(&targ->qos_conf.subport_params[0].tb_rate, pkey);
1365         }
1366         if (STR_EQ(str, "subport tb size")) {
1367                 return parse_int(&targ->qos_conf.subport_params[0].tb_size, pkey);
1368         }
1369         if (STR_EQ(str, "subport tc 0 rate")) {
1370                 return parse_int(&targ->qos_conf.subport_params[0].tc_rate[0], pkey);
1371         }
1372         if (STR_EQ(str, "subport tc 1 rate")) {
1373                 return parse_int(&targ->qos_conf.subport_params[0].tc_rate[1], pkey);
1374         }
1375         if (STR_EQ(str, "subport tc 2 rate")) {
1376                 return parse_int(&targ->qos_conf.subport_params[0].tc_rate[2], pkey);
1377         }
1378         if (STR_EQ(str, "subport tc 3 rate")) {
1379                 return parse_int(&targ->qos_conf.subport_params[0].tc_rate[3], pkey);
1380         }
1381
1382         if (STR_EQ(str, "subport tc rate")) {
1383                 uint32_t val;
1384                 int err = parse_int(&val, pkey);
1385                 if (err) {
1386                         return -1;
1387                 }
1388
1389                 targ->qos_conf.subport_params[0].tc_rate[0] = val;
1390                 targ->qos_conf.subport_params[0].tc_rate[1] = val;
1391                 targ->qos_conf.subport_params[0].tc_rate[2] = val;
1392                 targ->qos_conf.subport_params[0].tc_rate[3] = val;
1393
1394                 return 0;
1395         }
1396         if (STR_EQ(str, "subport tc period")) {
1397                 return parse_int(&targ->qos_conf.subport_params[0].tc_period, pkey);
1398         }
1399         if (STR_EQ(str, "pipe tb rate")) {
1400                 return parse_int(&targ->qos_conf.pipe_params[0].tb_rate, pkey);
1401         }
1402         if (STR_EQ(str, "pipe tb size")) {
1403                 return parse_int(&targ->qos_conf.pipe_params[0].tb_size, pkey);
1404         }
1405         if (STR_EQ(str, "pipe tc rate")) {
1406                 uint32_t val;
1407                 int err = parse_int(&val, pkey);
1408                 if (err) {
1409                         return -1;
1410                 }
1411
1412                 targ->qos_conf.pipe_params[0].tc_rate[0] = val;
1413                 targ->qos_conf.pipe_params[0].tc_rate[1] = val;
1414                 targ->qos_conf.pipe_params[0].tc_rate[2] = val;
1415                 targ->qos_conf.pipe_params[0].tc_rate[3] = val;
1416                 return 0;
1417         }
1418         if (STR_EQ(str, "pipe tc 0 rate")) {
1419                 return parse_int(&targ->qos_conf.pipe_params[0].tc_rate[0], pkey);
1420         }
1421         if (STR_EQ(str, "pipe tc 1 rate")) {
1422                 return parse_int(&targ->qos_conf.pipe_params[0].tc_rate[1], pkey);
1423         }
1424         if (STR_EQ(str, "pipe tc 2 rate")) {
1425                 return parse_int(&targ->qos_conf.pipe_params[0].tc_rate[2], pkey);
1426         }
1427         if (STR_EQ(str, "pipe tc 3 rate")) {
1428                 return parse_int(&targ->qos_conf.pipe_params[0].tc_rate[3], pkey);
1429         }
1430         if (STR_EQ(str, "pipe tc period")) {
1431                 return parse_int(&targ->qos_conf.pipe_params[0].tc_period, pkey);
1432         }
1433         if (STR_EQ(str, "police action")) {
1434                 char *in = strstr(pkey, " io=");
1435                 if (in == NULL) {
1436                         set_errf("Need to specify io colors using io=in_color,out_color\n");
1437                         return -1;
1438                 }
1439                 *in = 0;
1440                 in += strlen(" io=");
1441
1442                 char *out = strstr(in, ",");
1443                 if (out == NULL) {
1444                         set_errf("Output color not specified\n");
1445                 }
1446                 *out = 0;
1447                 out++;
1448
1449                 enum police_action in_color = str_to_color(in);
1450                 enum police_action out_color = str_to_color(out);
1451
1452                 if (in_color == ACT_INVALID) {
1453                         set_errf("Invalid input color %s. Expected green, yellow or red", in);
1454                         return -1;
1455                 }
1456                 if (out_color == ACT_INVALID) {
1457                         set_errf("Invalid output color %s. Expected green, yellow or red", out);
1458                         return -1;
1459                 }
1460                 enum police_action action = str_to_color(pkey);
1461                 if (action == ACT_INVALID) {
1462                         set_errf("Error action %s. Expected green, yellow, red or drop", pkey);
1463                         return -1;
1464                 }
1465                 targ->police_act[in_color][out_color] = action;
1466
1467                 return 0;
1468         }
1469         if (STR_EQ(str, "qinq tag")) {
1470                 return parse_int(&targ->qinq_tag, pkey);
1471         }
1472         if (STR_EQ(str, "cir")) {
1473                 return parse_int(&targ->cir, pkey);
1474         }
1475         if (STR_EQ(str, "cbs")) {
1476                 return parse_int(&targ->cbs, pkey);
1477         }
1478         if (STR_EQ(str, "pir")) {
1479                 return parse_int(&targ->pir, pkey);
1480         }
1481         if (STR_EQ(str, "pbs")) {
1482                 return parse_int(&targ->pbs, pkey);
1483         }
1484         if (STR_EQ(str, "ebs")) {
1485                 return parse_int(&targ->ebs, pkey);
1486         }
1487         uint32_t queue_id = 0;
1488         if (sscanf(str, "queue %d weight", &queue_id) == 1) {
1489                 uint32_t val;
1490                 int err = parse_int(&val, pkey);
1491                 if (err) {
1492                         return -1;
1493                 }
1494                 targ->qos_conf.pipe_params[0].wrr_weights[queue_id] = val;
1495                 return 0;
1496         }
1497         if (STR_EQ(str, "classify")) {
1498                 if (!(targ->task_init->flag_features & TASK_FEATURE_CLASSIFY)) {
1499                         set_errf("Classify is not supported in '%s' mode", targ->task_init->mode_str);
1500                         return -1;
1501                 }
1502
1503                 return parse_flag(&targ->runtime_flags, TASK_CLASSIFY, pkey);
1504         }
1505         if (STR_EQ(str, "flow table size")) {
1506                 return parse_int(&targ->flow_table_size, pkey);
1507         }
1508 #ifdef GRE_TP
1509         if (STR_EQ(str, "tbf rate")) {
1510                 return parse_int(&targ->tb_rate, pkey);
1511         }
1512         if (STR_EQ(str, "tbf size")) {
1513                 return parse_int(&targ->tb_size, pkey);
1514         }
1515 #endif
1516         if (STR_EQ(str, "max rules")) {
1517                 return parse_int(&targ->n_max_rules, pkey);
1518         }
1519
1520         if (STR_EQ(str, "tunnel hop limit")) {
1521                 uint32_t val;
1522                 int err = parse_int(&val, pkey);
1523                 if (err) {
1524                         return -1;
1525                 }
1526                 targ->tunnel_hop_limit = val;
1527                 return 0;
1528         }
1529
1530         if (STR_EQ(str, "lookup port mask")) {
1531                 uint32_t val;
1532                 int err = parse_int(&val, pkey);
1533                 if (err) {
1534                         return -1;
1535                 }
1536                 targ->lookup_port_mask = val;
1537                 return 0;
1538         }
1539
1540         if (STR_EQ(str, "irq debug")) {
1541                 parse_int(&targ->irq_debug, pkey);
1542                 return 0;
1543         }
1544
1545         set_errf("Option '%s' is not known", str);
1546         /* fail on unknown keys */
1547         return -1;
1548 }
1549
1550 static int str_is_number(const char *in)
1551 {
1552         int dot_once = 0;
1553
1554         for (size_t i = 0; i < strlen(in); ++i) {
1555                 if (!dot_once && in[i] == '.') {
1556                         dot_once = 1;
1557                         continue;
1558                 }
1559
1560                 if (in[i] < '0' || in[i] > '9')
1561                         return 0;
1562         }
1563
1564         return 1;
1565 }
1566
1567 /* command line parameters parsing procedure */
1568 int prox_parse_args(int argc, char **argv)
1569 {
1570         int i, opt, ret;
1571         char *tmp, *tmp2;
1572         char tmp3[64];
1573
1574         /* Default settings */
1575         prox_cfg.flags |= DSF_AUTOSTART | DSF_WAIT_ON_QUIT;
1576         prox_cfg.ui = PROX_UI_CURSES;
1577
1578         plog_info("\tCommand line:");
1579         for (i = 0; i < argc; ++i) {
1580                 plog_info(" %s", argv[i]);
1581         }
1582         plog_info("\n");
1583
1584         while ((opt = getopt(argc, argv, "f:dnzpo:tkuar:emsiw:l:v:q:")) != EOF) {
1585                 switch (opt) {
1586                 case 'f':
1587                         /* path to config file */
1588                         cfg_file = optarg;
1589                         size_t offset = 0;
1590                         for (size_t i = 0; i < strlen(cfg_file); ++i) {
1591                                 if (cfg_file[i] == '/') {
1592                                         offset = i + 1;
1593                                 }
1594                         }
1595
1596                         strncpy(prox_cfg.name, cfg_file + offset, MAX_NAME_SIZE);
1597                         break;
1598                 case 'v':
1599                         plog_set_lvl(atoi(optarg));
1600                         break;
1601                 case 'l':
1602                         prox_cfg.log_name_pid = 0;
1603                         strncpy(prox_cfg.log_name, optarg, MAX_NAME_SIZE);
1604                         break;
1605                 case 'p':
1606                         prox_cfg.log_name_pid = 1;
1607                         break;
1608                 case 'k':
1609                         prox_cfg.use_stats_logger = 1;
1610                         break;
1611                 case 'd':
1612                         prox_cfg.flags |= DSF_DAEMON;
1613                         prox_cfg.ui = PROX_UI_NONE;
1614                         break;
1615                 case 'z':
1616                         prox_cfg.flags |= DSF_USE_DUMMY_CPU_TOPO;
1617                         prox_cfg.flags |= DSF_CHECK_INIT;
1618                         break;
1619                 case 'n':
1620                         prox_cfg.flags |= DSF_USE_DUMMY_DEVICES;
1621                         break;
1622                 case 'r':
1623                         if (!str_is_number(optarg) || strlen(optarg) > 11)
1624                                 return -1;
1625                         strncpy(prox_cfg.update_interval_str, optarg, sizeof(prox_cfg.update_interval_str));
1626                         break;
1627                 case 'o':
1628                         if (prox_cfg.flags & DSF_DAEMON)
1629                                 break;
1630
1631                         if (!strcmp(optarg, "curses")) {
1632                                 prox_cfg.ui = PROX_UI_CURSES;
1633                         }
1634                         else if (!strcmp(optarg, "cli")) {
1635                                 prox_cfg.ui = PROX_UI_CLI;
1636                         }
1637                         else if (!strcmp(optarg, "none")) {
1638                                 prox_cfg.ui = PROX_UI_NONE;
1639                         }
1640                         else {
1641                                 plog_err("Invalid local UI '%s', local UI can be 'curses', 'cli' or 'none'.", optarg);
1642                                 return -1;
1643                         }
1644                         break;
1645                 case 'q':
1646                         if (luaL_loadstring(prox_lua(), optarg)) {
1647                                 set_errf("Lua error: '%s'\n", lua_tostring(prox_lua(), -1));
1648                                 return -1;
1649                         }
1650
1651                         if (lua_pcall(prox_lua(), 0, LUA_MULTRET, 0)) {
1652                                 set_errf("Lua error: '%s'\n", lua_tostring(prox_lua(), -1));
1653                                 return -1;
1654                         }
1655
1656                         break;
1657                 case 'a':
1658                         /* autostart all cores */
1659                         prox_cfg.flags |= DSF_AUTOSTART;
1660                         break;
1661                 case 'e':
1662                         /* don't autostart */
1663                         prox_cfg.flags &= ~DSF_AUTOSTART;
1664                         break;
1665                 case 't':
1666                         prox_cfg.flags |= DSF_LISTEN_TCP;
1667                         break;
1668                 case 'u':
1669                         prox_cfg.flags |= DSF_LISTEN_UDS;
1670                         break;
1671                 case 'm':
1672                         /* list supported task modes and exit */
1673                         prox_cfg.flags |= DSF_LIST_TASK_MODES;
1674                         break;
1675                 case 's':
1676                         /* check configuration file syntax and exit */
1677                         prox_cfg.flags |= DSF_CHECK_SYNTAX;
1678                         break;
1679                 case 'i':
1680                         /* check initialization sequence and exit */
1681                         prox_cfg.flags |= DSF_CHECK_INIT;
1682                         break;
1683                 case 'w':
1684                         tmp = optarg;
1685                         tmp2 = 0;
1686                         if (strlen(tmp) >= 3 &&
1687                             (tmp2 = strchr(tmp, '='))) {
1688                                 *tmp2 = 0;
1689                                 tmp3[0] = '$';
1690                                 strncpy(tmp3 + 1, tmp, 63);
1691                                 plog_info("\tAdding variable: %s = %s\n", tmp3, tmp2 + 1);
1692                                 ret = add_var(tmp3, tmp2 + 1, 1);
1693                                 if (ret == -2) {
1694                                         plog_err("\tFailed to add variable, too many variables defines\n");
1695                                         return -1;
1696                                 }
1697                                 else if(ret == -3) {
1698                                         plog_err("\tFailed to add variable, already defined\n");
1699                                         return -1;
1700                                 }
1701                                 break;
1702                         }
1703                         /* fall-through */
1704                 default:
1705                         plog_err("\tUnknown option\n");
1706                         return -1;
1707                 }
1708         }
1709
1710         /* reset getopt lib for DPDK */
1711         optind = 0;
1712
1713         return 0;
1714 }
1715
1716 static int check_cfg(void)
1717 {
1718         /* Sanity check */
1719 #define RETURN_IF(cond, err)                    \
1720         if (cond) {                             \
1721                 plog_err(err);                  \
1722                 return -1;                      \
1723         };
1724
1725         RETURN_IF(rte_cfg.force_nchannel == 0, "\tError: number of memory channels not specified in [eal options] section\n");
1726         RETURN_IF(prox_cfg.master >= RTE_MAX_LCORE, "\tError: No master core specified (one core needs to have mode=master)\n");
1727
1728 #undef RETURN_IF
1729
1730         return 0;
1731 }
1732
1733 static int calc_tot_rxrings(void)
1734 {
1735         struct lcore_cfg *slconf, *dlconf;
1736         struct task_args *starg, *dtarg;
1737         uint32_t dlcore_id;
1738         uint8_t dtask_id;
1739         struct core_task ct;
1740
1741         dlconf = NULL;
1742         while (core_targ_next_early(&dlconf, &dtarg, 1) == 0) {
1743                 dtarg->tot_rxrings = 0;
1744         }
1745
1746         slconf = NULL;
1747         while (core_targ_next_early(&slconf, &starg, 1) == 0) {
1748                 for (uint8_t idx = 0; idx < MAX_PROTOCOLS; ++idx) {
1749                         for (uint8_t ring_idx = 0; ring_idx < starg->core_task_set[idx].n_elems; ++ring_idx) {
1750                                 ct = starg->core_task_set[idx].core_task[ring_idx];
1751                                 if (!prox_core_active(ct.core, 0)) {
1752                                         set_errf("Core %u is disabled but Core %u task %u is sending to it\n",
1753                                                  ct.core, slconf->id, starg->id);
1754                                         return -1;
1755                                 }
1756
1757                                 dlconf = &lcore_cfg_init[ct.core];
1758
1759                                 if (ct.task >= dlconf->n_tasks_all) {
1760                                         set_errf("Core %u task %u not enabled\n", ct.core, ct.task);
1761                                         return -1;
1762                                 }
1763
1764                                 dtarg = &dlconf->targs[ct.task];
1765
1766                                 /* Control rings are not relevant at this point. */
1767                                 if (ct.type)
1768                                         continue;
1769
1770                                 if (!(dtarg->flags & TASK_ARG_RX_RING)) {
1771                                         set_errf("Core %u task %u is not expecting to receive through a ring\n",
1772                                                  ct.core, ct.task);
1773                                         return -1;
1774                                 }
1775
1776                                 dtarg->tot_rxrings++;
1777                                 if (dtarg->tot_rxrings > MAX_RINGS_PER_TASK) {
1778                                         set_errf("Core %u task %u is receiving from too many tasks",
1779                                                  ct.core, ct.task);
1780                                         return -1;
1781                                 }
1782                         }
1783                 }
1784         }
1785
1786         return 0;
1787 }
1788
1789 static void prox_set_core_mask(void)
1790 {
1791         struct lcore_cfg *lconf;
1792
1793         prox_core_clr();
1794         for (uint8_t lcore_id = 0; lcore_id < RTE_MAX_LCORE; ++lcore_id) {
1795                 lconf = &lcore_cfg_init[lcore_id];
1796                 if (lconf->n_tasks_all > 0 && lconf->targs[0].mode != MASTER) {
1797                         prox_core_set_active(lcore_id);
1798                 }
1799         }
1800 }
1801
1802 static int is_using_no_drop(void)
1803 {
1804         uint32_t lcore_id;
1805         struct lcore_cfg *lconf;
1806         struct task_args *targs;
1807
1808         lcore_id = -1;
1809         while(prox_core_next(&lcore_id, 1) == 0) {
1810                 lconf = &lcore_cfg_init[lcore_id];
1811                 for (uint8_t task_id = 0; task_id < lconf->n_tasks_all; ++task_id) {
1812                         targs = &lconf->targs[task_id];
1813                         if (!(targs->flags & TASK_ARG_DROP))
1814                                 return 1;
1815                 }
1816         }
1817         return 0;
1818 }
1819
1820 int prox_read_config_file(void)
1821 {
1822         set_global_defaults(&prox_cfg);
1823         set_task_defaults(&prox_cfg, lcore_cfg_init);
1824         set_port_defaults();
1825         plog_info("=== Parsing configuration file '%s' ===\n", cfg_file);
1826         struct cfg_file *pcfg = cfg_open(cfg_file);
1827         if (pcfg == NULL) {
1828                 return -1;
1829         }
1830
1831         struct cfg_section* config_sections[] = {
1832                 &lua_cfg          ,
1833                 &var_cfg          ,
1834                 &eal_default_cfg  ,
1835                 &cache_set_cfg    ,
1836                 &port_cfg         ,
1837                 &defaults_cfg     ,
1838                 &settings_cfg     ,
1839                 &core_cfg         ,
1840                 NULL
1841         };
1842
1843         for (struct cfg_section** section = config_sections; *section != NULL; ++section) {
1844                 const char* name = (*section)->name;
1845                 size_t len = strlen(name);
1846                 plog_info("\t*** Reading [%s] section%s ***\n", name, name[len - 1] == '#'? "s": "");
1847                 cfg_parse(pcfg, *section);
1848
1849                 if ((*section)->error) {
1850                         plog_err("At line %u, section [%s], entry %u: '%s'\n\t%s\n"
1851                                  , pcfg->err_line, pcfg->err_section, pcfg->err_entry + 1, pcfg->cur_line,
1852                                  strlen(get_parse_err())? get_parse_err() : err_str);
1853                         cfg_close(pcfg); /* cannot close before printing error, print uses internal buffer */
1854                         return -1;
1855                 }
1856         }
1857
1858         cfg_close(pcfg);
1859
1860         prox_set_core_mask();
1861
1862         if (is_using_no_drop()) {
1863                 prox_cfg.flags &= ~DSF_WAIT_ON_QUIT;
1864         }
1865
1866         if (calc_tot_rxrings()) {
1867                 plog_err("Error in configuration: %s\n", err_str);
1868                 return -1;
1869         }
1870
1871         return check_cfg();
1872 }
1873
1874 static void failed_rte_eal_init(__attribute__((unused))const char *prog_name)
1875 {
1876         plog_err("\tError in rte_eal_init()\n");
1877 }
1878
1879 int prox_setup_rte(const char *prog_name)
1880 {
1881         char *rte_argv[MAX_RTE_ARGV];
1882         char  rte_arg[MAX_RTE_ARGV][MAX_ARG_LEN];
1883         char tmp[PROX_CM_STR_LEN];
1884         /* create mask of used cores */
1885         plog_info("=== Setting up RTE EAL ===\n");
1886
1887         if (prox_cfg.flags & DSF_USE_DUMMY_CPU_TOPO) {
1888                 plog_info("Using dummy cpu topology\n");
1889                 snprintf(tmp, sizeof(tmp), "0x1");
1890         } else {
1891                 prox_core_to_hex(tmp, sizeof(tmp), 0);
1892                 plog_info("\tWorker threads core mask is %s\n", tmp);
1893                 prox_core_to_hex(tmp, sizeof(tmp), 1);
1894                 plog_info("\tWith master core index %u, full core mask is %s\n", prox_cfg.master, tmp);
1895         }
1896
1897         /* fake command line parameters for rte_eal_init() */
1898         int argc = 0;
1899         rte_argv[argc] = strdup(prog_name);
1900         sprintf(rte_arg[++argc], "-c%s", tmp);
1901         rte_argv[argc] = rte_arg[argc];
1902 #if RTE_VERSION >= RTE_VERSION_NUM(1,8,0,0)
1903         if (prox_cfg.flags & DSF_USE_DUMMY_CPU_TOPO)
1904                 sprintf(rte_arg[++argc], "--master-lcore=%u", 0);
1905         else
1906                 sprintf(rte_arg[++argc], "--master-lcore=%u", prox_cfg.master);
1907         rte_argv[argc] = rte_arg[argc];
1908 #else
1909         /* For old DPDK versions, the master core had to be the first
1910            core. */
1911         uint32_t first_core = -1;
1912
1913         if (prox_core_next(&first_core, 1) == -1) {
1914                 plog_err("Can't core ID of first core in use\n");
1915                 return -1;
1916         }
1917         if (first_core != prox_cfg.master) {
1918                 plog_err("The master core needs to be the first core (master core = %u, first core = %u).\n", first_core, prox_cfg.master);
1919                 return -1;
1920         }
1921 #endif
1922
1923         if (rte_cfg.memory) {
1924                 sprintf(rte_arg[++argc], "-m%u", rte_cfg.memory);
1925                 rte_argv[argc] = rte_arg[argc];
1926         }
1927
1928         if (rte_cfg.force_nchannel) {
1929                 sprintf(rte_arg[++argc], "-n%u", rte_cfg.force_nchannel);
1930                 rte_argv[argc] = rte_arg[argc];
1931         }
1932
1933         if (rte_cfg.force_nrank) {
1934                 sprintf(rte_arg[++argc], "-r%u", rte_cfg.force_nrank);
1935                 rte_argv[argc] = rte_arg[argc];
1936         }
1937
1938         if (rte_cfg.no_hugetlbfs) {
1939                 strcpy(rte_arg[++argc], "--no-huge");
1940                 rte_argv[argc] = rte_arg[argc];
1941         }
1942
1943         if (rte_cfg.no_pci) {
1944                 strcpy(rte_arg[++argc], "--no-pci");
1945                 rte_argv[argc] = rte_arg[argc];
1946         }
1947
1948         if (rte_cfg.no_hpet) {
1949                 strcpy(rte_arg[++argc], "--no-hpet");
1950                 rte_argv[argc] = rte_arg[argc];
1951         }
1952
1953         if (rte_cfg.no_shconf) {
1954                 strcpy(rte_arg[++argc], "--no-shconf");
1955                 rte_argv[argc] = rte_arg[argc];
1956         }
1957
1958         if (rte_cfg.eal != NULL) {
1959                 char *ptr = rte_cfg.eal;
1960                 char *ptr2;
1961                 while (ptr != NULL) {
1962                         while (isspace(*ptr))
1963                                 ptr++;
1964                         ptr2 = ptr;
1965                         ptr = strchr(ptr, ' ');
1966                         if (ptr) {
1967                                 *ptr++ = '\0';
1968                         }
1969                         strcpy(rte_arg[++argc], ptr2);
1970                         rte_argv[argc] = rte_arg[argc];
1971                 }
1972         }
1973
1974         if (rte_cfg.hugedir != NULL) {
1975                 strcpy(rte_arg[++argc], "--huge-dir");
1976                 rte_argv[argc] = rte_arg[argc];
1977                 rte_argv[++argc] = rte_cfg.hugedir;
1978         }
1979
1980         if (rte_cfg.no_output) {
1981                 rte_log_set_global_level(0);
1982         }
1983         /* init EAL */
1984         plog_info("\tEAL command line:");
1985         if (argc >= MAX_RTE_ARGV) {
1986                 plog_err("too many arguments for EAL\n");
1987                 return -1;
1988         }
1989
1990         for (int h = 0; h <= argc; ++h) {
1991                 plog_info(" %s", rte_argv[h]);
1992         }
1993         plog_info("\n");
1994
1995         rte_set_application_usage_hook(failed_rte_eal_init);
1996         if (rte_eal_init(++argc, rte_argv) < 0) {
1997                 plog_err("\tError in rte_eal_init()\n");
1998                 return -1;
1999         }
2000         plog_info("\tEAL Initialized\n");
2001
2002         if (prox_cfg.flags & DSF_USE_DUMMY_CPU_TOPO)
2003                 return 0;
2004
2005         /* check if all active cores are in enabled in DPDK */
2006         for (uint32_t lcore_id = 0; lcore_id < RTE_MAX_LCORE; ++lcore_id) {
2007                 if (lcore_id == prox_cfg.master) {
2008                         if (!rte_lcore_is_enabled(lcore_id))
2009                                 return -1;
2010                 }
2011                 else if (rte_lcore_is_enabled(lcore_id) != prox_core_active(lcore_id, 0)) {
2012                         plog_err("\tFailed to enable lcore %u\n", lcore_id);
2013                         return -1;
2014                 }
2015                 else if (lcore_cfg_init[lcore_id].n_tasks_all != 0 && !rte_lcore_is_enabled(lcore_id)) {
2016                         plog_err("\tFailed to enable lcore %u\n", lcore_id);
2017                         return -1;
2018                 }
2019         }
2020         return 0;
2021 }